summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-02-18Resolves: tdf#97953 spinbuttons are not suitable for reuse as up/down arrowsCaolán McNamara
Change-Id: Ibcd7bd4099210a26513caac6e3b16a88a4c8abad
2016-02-18StyleSettingsOptions Only NONE, Mono and NoMnemonics are in useCaolán McNamara
ditch the rest Change-Id: I3383023958f528d9d0d6ba715356d8d6a6aecd5a
2016-02-18StyleSettingsOptions::SpinArrow is not set by anyoneCaolán McNamara
Tragically this means the loss of a OS/2 comment Change-Id: Ia3f7b0a840e6b73cf4fae5f98dd4cf97d4e7b87c
2016-02-18StyleSettingsOptions::SpinUpDown is not set by anyoneCaolán McNamara
Change-Id: I26d5189b6a20844bac2a671a30def1b01aa786a8
2016-02-18refactor ImplDrawSpinButtonCaolán McNamara
there is (supposed to be anyway) no logic change here, just unwind the overly complex flow Change-Id: I9c96f41b0480a60c486b476f383d856b464cd62d
2016-02-18move from boost::signal to typed LinkCaolán McNamara
it doesn't really gain us much to have a handful of boost::signal use in a sea of Links This also fixes a regression in commit 051b29e1025253f35f87a04e297760aa8b40611f Author: Luboš Luňák <l.lunak@collabora.com> Date: Sun Sep 14 15:45:02 2014 +0200 convert Edit autocomplete Hdl to boost signals2 where the conversion was... - if ( maAutocompleteHdl.IsSet() ) + if ( autocompleteSignal.empty() ) instead of the correct + if ( !autocompleteSignal.empty() ) Change-Id: I27270d94c782485c0a7e929bc4980af4527fe82b
2016-02-18Resolves: tdf#97904 opengl stuff isn't implemented for gtk3Caolán McNamara
Change-Id: I1abbceebadf320f28955f54058b2d0ebfc79b9bc
2016-02-18tdf#96091 Correct ascend and descend values for OTC font.Mark Hung
CffSubsetterContext::emitAsType1() calculate ascend and descend when emitting PDF font descriptor based on bounding box values. However, values can come directly from hhea or OS2 table are better for OTC font. The order that determines which ascend and descend values are used in PrintFontManager::analyzeTrueTypeFile() is changed in order to make winAscend/winDescend and bounding box based values the last choice. Change-Id: I421f6af6a4bee01d23ccf3e8e65c8f6ad80922b6 Reviewed-on: https://gerrit.libreoffice.org/21444 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-18WaE: not necessary to pass this argument, it defaults to the same valueTor Lillqvist
[loplugin:defaultparams] I strongly dislike default parameters. And confusing boolean parameters. Here what I really would prefer would be to have two separate functions, InvalidateUpperSpin() and InvalidateLowerSpin() (or something like that), neither taking any parameter at all. Change-Id: I42c92339481cf576397822c318db1449a576a06a
2016-02-18Resolves: rhbz#1285356 force swing not to use gtk2 if gtk3 is loadedCaolán McNamara
Change-Id: I6347bf4c25ce649073afdfe4225182ab2dc84af1 Reviewed-on: https://gerrit.libreoffice.org/22433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-02-17tdf#95618 - opengl - mend control regions and caching for tab headers.Michael Meeks
Some tab headers in some themes unhelpfully enlarge the control region in some states - so query the region size in advance. Sadly the control region querying is something of a train-wreck too - so only use that for CTRL_TAB_ITEMs for now. Also fix Rectangle constructor ordering. Change-Id: I5e66ec541193f5b66a656dd45d5fba67a771e132
2016-02-17tdf#97922 - Mend nonsensical spin invalidation to improve rendering.Michael Meeks
Change-Id: Ief3d95b0b03e8062115785461b3834a03f9fb52b
2016-02-17tdf#97922 - Mend nonsensical spin invalidation to improve rendering.Michael Meeks
Change-Id: I3a398c47c69cc292a681ebe2414d844c224f3e3e
2016-02-17tdf#97922 - get control area right for spinbuttons.Michael Meeks
Also avoid caching both spin-buttons and some other complex types. The cache key needs to be able to include more state. Change-Id: I8eff6b1c5c51d27afb796cae66b45390433138b4
2016-02-17Missing semicolonStephan Bergmann
Change-Id: If7e643ed3238074a3e6394834b17b8c96e8decac
2016-02-17gtk3: use native GtkPopover for calc formula prompt, etcCaolán McNamara
Change-Id: I9aa7e977228780b6273daa03be5e872342414437
2016-02-17use consistent #define checks for the Windows platformNoel Grandin
stage 2 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro In this stage we focus on replacing usage of the WIN macro Change-Id: Ie8a4a63198a6de96bd158ecd707dadafb9c8ea84 Reviewed-on: https://gerrit.libreoffice.org/22393 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-02-17ForceReposition is unusedCaolán McNamara
Change-Id: Ic9c37aef877e81f0c569ae8fe89bbdc41dd09419
2016-02-16gtk3+wayland: play video via gtksink gstreamer elementCaolán McNamara
Change-Id: Ib371fa06eda73962cbe94739e69a68b46c26e4bf
2016-02-16use std shared_ptr for sharing ImpBitmapsCaolán McNamara
Change-Id: I1a0360096964f6402bd3631f2b3f34bf9595ebc6 Reviewed-on: https://gerrit.libreoffice.org/22394 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-02-16Related: tdf#97739 fix gtk3 spinbuttons for recent control region changesCaolán McNamara
Change-Id: Ia745cbe808395c4c9ec6a3c72612814a4834bbcb
2016-02-16use consistent #define checks for the Windows platformNoel Grandin
stage 1 of replacing usage of various checks for the windows platform with the compiler-defined '_WIN32' macro Change-Id: Iece73abdee530937e0737190b1aa97a46cd3075f Reviewed-on: https://gerrit.libreoffice.org/22390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-02-16Work around CPPUNIT_ASSERT_EQUAL shortcomingsStephan Bergmann
Change-Id: I377c6b6817a432d1e9d740c7d43233f5b98cd2f6
2016-02-16Silence loplugin:staticmethodsNoel Grandin
Change-Id: I112dec3253c6eb41dd18bd5cdbcc5a488e4d268c
2016-02-16this "else" looks uselessDavid Tardon
Change-Id: I370973066604fc04201431a67d3752cc63a60e6d
2016-02-16vcl: assign nullptr after deletingHenry Castro
In the preinit stage, the VCL initialization is done by the parent process and when the lo_startmain thread de-initialize the VCL, some services are disposed early, and it causes segmentation violation. So it is ensured that pointers to service objetcs is set nullptr after deleting. Change-Id: I65ecfc2d2694a981ec2986988efabdfd28d0cce4
2016-02-15loplugin:nullptrTor Lillqvist
Change-Id: I8dafbf99638fd24828327ce4493bfbbf1b9d2c6d
2016-02-15loplugin:simplifyboolTor Lillqvist
conditional expression of the form '!A ? B : true' (with A of type 'bool' and B of type 'bool') can literally be simplified as 'A || B'. Change-Id: I46bee836425bf1c76def23e30dca9ddd9e791b42
2016-02-15vcl: add isInitVCL, to not initialize twiceHenry Castro
In the preinit stage, the VCL is initialized in the parent process and when the lo_startmain thread is started, the thread initialize VCL again. It is not necessary to initialize twice. Change-Id: I819cf0125afe7760c3f4d91c420d36a3a383902c
2016-02-15Unit test for opengl blocklist parsing and evaluatingTomaž Vajngerl
Parsing unit test checks that the xml values are parsed correctly and that the DriverInfo structure is populated with the expected values. Evaluate unit test checks that blacklisting / whitelisting logic blocks OS/vendor/driver/device as expected. Change-Id: Ib1b0926606f0835207c324193bbe19ba83f86bdc Reviewed-on: https://gerrit.libreoffice.org/22371 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-02-15implement wayland handle passing for gstreamerCaolán McNamara
Change-Id: I3b0effe35ad7b37ff7ab3de2a3b78b6312779139
2016-02-15rename X11WindowProvider to a NativeWindowHandle providerCaolán McNamara
sort of thing and genericize it Change-Id: I27e1e47f2b371e5269db079cfc1262d056105f80
2016-02-15tdf#97739 - ensure we have a valid rectangle for spin-button controls.Michael Meeks
Otherwise OpenGL can't render, cache and diff these; so we loose them. Change-Id: Iac4f3ee0fc68154f708a881d5e0255fc9f8df62d
2016-02-15tdf#97665 Let's hope that over activation isn't really neededMaxim Monastirsky
- MenuBarManager::Activate has a check for duplicate activation, which makes the second activation attempt fail. Removing this check or deactivating after each activation will likely affect performance even more, but on the other hand should solve lp#1296715, which was the main reason of the over activation in the first place. So let's activate only one menu at a time, and do full activation only on the initial update. - Unfortunately the HUD activation callback doesn't work, so we still have to keep active status listener for all menu items. (Which is BTW against the recommendation in XPopupMenuController::updatePopupMenu IDL doc. Fortunately the performance problem hardly noticeable on modern hw.) Change-Id: I96affa72412f3f38160fdca4b6efd20ca68d059f Reviewed-on: https://gerrit.libreoffice.org/22369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-02-15Package_opengl_blacklist is Windows-specificTor Lillqvist
Change-Id: Ida79aa0d5a519a2c124d20a1cd908411d01799de
2016-02-15Tidy up graphite layout code after fixing line ending diacriticsMartin Hosken
Change-Id: I1efafbd64539ac6d71de0be41ecaa71533143590 Reviewed-on: https://gerrit.libreoffice.org/22362 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2016-02-14WaE: unreachable codeCaolán McNamara
Change-Id: I700168b0484e86caa8df4a579ef51bcd40b6f66f
2016-02-14tdf#85761 vcl: JPEG export does not save PPI values correctlyChris Sherlock
JPEG values are currently hardcoded to 96PPI when we export JPEGs. The Graphic class doesn't have an easy way to get the PPI, but this can actually be calculated from the pref size and pref map mode (no idea why it is called "Pref"). Interestingly, you need to get a multiplier to work this out, relative to units of 100th mm. The EPS filter code had a function that does exactly this, but it's entirely based on MapMode units so it was really implemented in the wrong class IMO. I have thus moved it out of PSWriter and into MapMode. This also fixes tdf#65695, which was partially fixed, but had the JPEG PPI hardcoded to 96dpi. Also fixes tdf#97481. Change-Id: Iedb674141dd4e22fcbfb7be357dc777f732aa3aa Reviewed-on: https://gerrit.libreoffice.org/22339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-02-14coverity#1352217 Logically dead codeCaolán McNamara
Change-Id: Ia4ca58ca67936a558b3157daae6a663ef81a81bf
2016-02-13Fix graphite line final diacriticsMartin Hosken
Change-Id: If5175fd489e835dbf9d37a45fd266c6ce44eae1a Reviewed-on: https://gerrit.libreoffice.org/22280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2016-02-12gtk3: only available since 3.12.0Caolán McNamara
Change-Id: I23a9907fa0ec3258afdb69285f31b6ce5a3521a0
2016-02-12nothing needs GetClipRegionType or uses SAL_OBJECT_CLIP_INCLUDERECTS nowCaolán McNamara
Change-Id: Ie43eb3b2c449891fef1031e7df3f381cecb4b4f9
2016-02-12op is always SAL_OBJECT_CLIP_INCLUDERECTSCaolán McNamara
Change-Id: I4d350aa5d791febde3fea824e3e7b4ab6b6c06e8
2016-02-12this GetClipRegionType is always SAL_OBJECT_CLIP_INCLUDERECTSCaolán McNamara
Change-Id: I0dc1ac4748dc81e16cf1d68e5f1bd8eb407bb9cf
2016-02-12SAL_OBJECT_CLIP_ABSOLUTE is never usedCaolán McNamara
Change-Id: I090f9854589a26b8de78fcda1093ea0c19625c79
2016-02-12SAL_OBJECT_CLIP_EXCLUDERECTS is never usedCaolán McNamara
Change-Id: I60b267e84df2ca0e540fc3218faa9a3fc4c9c55d
2016-02-12nClipRegionType is always SAL_OBJECT_CLIP_INCLUDERECTSCaolán McNamara
Change-Id: Iba054bc064c664f8499219db002749072435e32c
2016-02-12split the gtk2 and gtk2 gtkobjectsCaolán McNamara
Change-Id: I32084232c44a12e9641010b51e75710abc827695
2016-02-12tdf#95857 Sort out German plurals ...danielt998
Made a start in removing the incorrect 'Infos' German plural Change-Id: Ie989351a7473fc35b563e63ce6a4fb229093af60 Reviewed-on: https://gerrit.libreoffice.org/22301 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-13vcl: include vcl headers via triangular brackets instead of quotesChris Sherlock
Change-Id: I311f7db622ce341527fe12a92b516f800b602f92