summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-09-17bmp failure not detected as such because of svg fallback testCaolán McNamara
I thought it was suspicious that everything was a pass Change-Id: I10b98cc19d2e23bd5d518113785aeca3a0ea346a Reviewed-on: https://gerrit.libreoffice.org/18662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17make CalcMaskShift a verifiable operationCaolán McNamara
and check it on untrusted data Change-Id: I7c97a27d70f91b9686adf9dcb8b68c5aa25c2b4c Reviewed-on: https://gerrit.libreoffice.org/18637 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-17convert Link<> to typedNoel Grandin
Change-Id: I3d35a0bb75b6989dd13371543d1bdf3ef5f47641
2015-09-17Fix Graphite windows build staticMartin Hosken
Change-Id: I6feb3805e79f7cae4a8df7efa665fd97c56411c2 Reviewed-on: https://gerrit.libreoffice.org/18654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2015-09-16tdf#94281 - don't mix legacy and VCL OpenGLContext's.Michael Meeks
Each has rather different assumptions about how life should be. Change-Id: I85fffc77d14f3a5335a077fcb541a2b31c372043
2015-09-16don't crash with unknown out color spaceCaolán McNamara
Change-Id: Ib066ff1fad686d611a86510e768b1109ef7a5e75
2015-09-16pointer->referenceCaolán McNamara
Change-Id: I9d76750d907968d54d5ab99304080a75452c0420
2015-09-16Add debugging helpers to binary shader loading.Michael Meeks
Change-Id: I32b8d8ce0fbf824120c8afd288b728314cd74142 Reviewed-on: https://gerrit.libreoffice.org/18620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-16opengl: check framebuffer completenessTomaž Vajngerl
Change-Id: Idd80b7390694038ab0913edab0e496593beb0e15
2015-09-16opengl: support reading back 1-bit masks from textureTomaž Vajngerl
Change-Id: Ibe8d9140f7a54016f2cd684198856ac27d880aa3
2015-09-16tdf#93666: use x,y coords when reading texture part + don't bindTomaž Vajngerl
Fixes shrinking shapes with gradients when the VirtualDev is reused to create a alpha mask (and the texture is reused and reading back from just one part of the texture which uses glReadPixels code-path). Binding texture is not necessary when we use and bind it to the framebuffer. Change-Id: Ie3994f749e1a2c17d4d3df44710b7453d7a4f45f
2015-09-16opengl: optimize search for a free slot in texture atlasTomaž Vajngerl
Change-Id: Ic853457871b914f9c1beb2f648bf7d9d18dce957
2015-09-16opengl: this doesn't really do anything as data is null anywayTomaž Vajngerl
Change-Id: Iacd75beecc14023173a9aa52a30298bbfe787d61
2015-09-16GL paint-flushing guard re-work.Michael Meeks
Unfortunately, since we can have 2x SalGraphics' on a OutputDevice, and one of these can be a printer - things got very confused around which context to glFlush. This de-tangles the various reference-counts. Change-Id: I1062be0b02a91fc9009deaa3ec29c5dbb227df20 Reviewed-on: https://gerrit.libreoffice.org/18604 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-16tdf#94213 - cleanup associated GL contexts properly when DCs released.Michael Meeks
Change-Id: I6b9fb899777d8e460999ac3ff038a1302e434bb5 Reviewed-on: https://gerrit.libreoffice.org/18605 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-16Blind fix for --enable-tdeStephan Bergmann
Change-Id: I6e60bf537ffc91210862ba77ffefa933e90ed84f
2015-09-16convert Link<> to typedNoel Grandin
Change-Id: I8275f9a100e5ed93f44596fe428a39e902c12dfc
2015-09-16clean up VclEventListeners and VclEventListeners2Noel Grandin
Move them inside the vcl module. there is no need to expose their implementation. Make the VclEventListeners2 implementation similar to the VclEventListeners implemenation - I can't see the benefit of this extra complication with invalidated iterators, given the very small number of listeners typically on such a list. Change-Id: I040ddd24b10d2109af13ee25b5181703af17a109
2015-09-16convert Link<> to typedNoel Grandin
Change-Id: If6334d32abbec379acbb9def98fdf6cb5144238b
2015-09-16convert Link<> to typedNoel Grandin
Change-Id: I628de57f87b4ba20a797d345bdf71cf10cf148fc
2015-09-16tdf#94252 - avoid switching contexts un-necessarily to reduce flicker.Michael Meeks
Change-Id: Id4ac387174fa03c5886a990d89fd53a4f18db11c
2015-09-16tdf#94213 - release offscreen texture properly on re-size.Michael Meeks
We need to ensure that we use an initialized context, and that (when we re-parent) we DeInit and so reset the previous OpenGLContext. Make UseContext more paranoid as well for good measure. Change-Id: Ia45334222045e5d2f48da47560fab8511223a9a5 Reviewed-on: https://gerrit.libreoffice.org/18601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-15tdf#94213 - calc re-size flicker turns out to be the status bar.Michael Meeks
Using vdev's associated with old contexts, is un-necessary and a recipe for context switching & hence flicker. Change-Id: I37ed967a7816e5ca0240908ab4793ce1e68570ee Reviewed-on: https://gerrit.libreoffice.org/18602 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-15loplugin:cstylecastStephan Bergmann
Change-Id: Ib87c2d84bc954e768a9a5165f528936aafa94887
2015-09-15WaE: loplugin:cstylecastTor Lillqvist
Change-Id: I08c31a7e097464da5df4fcda6637f442d147230f
2015-09-15tdf#93814: Added support for caching shader program binaries.Marco Cecchetti
Change-Id: I21c844b47282f6b3eec443933a86421a074e24df Reviewed-on: https://gerrit.libreoffice.org/18555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2015-09-15convert Link<> to typedNoel Grandin
Change-Id: I5c4021c9cb3fdeace7f7d99d580dc7fe2f7c354a
2015-09-15remove Link<> field that is never Call()'edNoel Grandin
Change-Id: I416734c7c42709438e3bdcdb8922ce4ec576c95a
2015-09-15[API CHANGE] XFilePicker2/3 changes for multiselectionJulien Nabet
In order to use GetSelectedFiles (in XFilePicker2) instead of GetFiles (in XFilePicker), here are some api changes before: XFilePicker3 inherits from XFilePicker XFilePicker2 is not a published interface after: XFilePicker3 inherits from XFilePicker2 XFilePicker2 is a published interface + adapt Uno Implementations Change-Id: If44afaa7236f08bc2b814f91eda5bfad333dd799 Reviewed-on: https://gerrit.libreoffice.org/17068 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-14tdf#94213 - defer glFlushing until we've re-rendered after a re-size.Michael Meeks
Avoids a rather horrible flickering problem in GL mode. Change-Id: Id205f28de209dc2e4fb6d6fa48b86ee5bd38835d
2015-09-14convert Link<> to typedNoel Grandin
Change-Id: I1c501671d72edd5b998e80c7fa1e91dbeb507af8
2015-09-14ImplCallEventListeners and FireVclEvent can take referencesNoel Grandin
Change-Id: Ibfb5ae40edd0db1f6b99bd5178d4d871ede37d7d
2015-09-14list->vectorNoel Grandin
since we are copying these before iterating over them, we don't need the iterator guarantees of std::list Change-Id: I9cb2048e1527f37104c3077e69b5f3b827f08c7b
2015-09-14loplugin:implicitboolconversionStephan Bergmann
Change-Id: Ib9f2b44c16e43841d560ac18ff82efd54888b9d7
2015-09-14Refactor graphite integration and update graphiteMartin Hosken
Change-Id: I09db7262c2a6180a078620ba086dd7a4c132bd82 Reviewed-on: https://gerrit.libreoffice.org/18459 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2015-09-13cppcheck: noExplicitConstructorCaolán McNamara
Change-Id: I39194062ba68c4cb1ccc9b93c629f005ccd02497
2015-09-13boost->stdCaolán McNamara
Change-Id: I9b4f884c6313a53fea543ea6f93175205351ad14 Reviewed-on: https://gerrit.libreoffice.org/18517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-12GetCommandLineParamCount() returns sal_uInt16Matteo Casalin
Change-Id: Ie85f3a44034ffcfe08493256bc65e49b63a28013
2015-09-12This parameter type should be sal_Int32, for consistencyMatteo Casalin
Change-Id: I3fe7761d1ec88183853b240f7205bf98cfa5e965
2015-09-11getFiles refactoring: kde partJulien Nabet
1) kdecommandthread part before: getFiles retrieves all files with: First element = path only of the files other elements = file names (without path) after: Add getSelectedFiles which retrieves all files with their url getFiles uses getSelectedFiles and truncates to 1 entry if more than 1 entry 2) kdefilepicker part before: getFiles case retrieves all files with names including path after: add getSelectedFiles case which retrieves all files with names including path change getFiles to retrieve only the first file (with path) See http://nabble.documentfoundation.org/Dev-f1639786.html for discussion Change-Id: I73cf00e7c03a1f2379f4628b5d7f12418029cca1 Reviewed-on: https://gerrit.libreoffice.org/17064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-09-11vcl: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I4499569f73b04cc7444787d51bf804c090a5c951 Reviewed-on: https://gerrit.libreoffice.org/18478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-11tdf#93480: Don't send an EMPTY Invalidate() on .uno:DefaultBullet.Jan Holesovsky
When there was no modification to the document, and .uno:DefaultBullet was sent, we have got an invalidtion of the entire document. It seems that Invalidate() was not supposed to be called in the Validate() call, and instead, we should rely on what the Validate() invalidates :-) Change-Id: Ia65df90e4ff34078b59c1b2eb1ce1faac790b40d
2015-09-11coverity#1323754 we apparently can survive std::abort for a whileCaolán McNamara
so try and suppress this warning Change-Id: I096352af0116f1ba0911cc201eb884267095a797
2015-09-11windows opengl: make sure mpLastContext is indeed the current contextMiklos Vajna
There were two problems here: 1) The OpenGLContext ctor registered the instance on the list of contexts, but platform-specific call (e.g. wglMakeCurrent()) was only made later. Add a registerAsCurrent() member function that helps ensuring that the last item in the context list is indeed the current context. 2) OpenGLContext::prepareForYield() is called without the solar mutex being locked, but it still assumes that the last context in the context list is the thread's current context, which may not be true. The result is that during JunitTest_sd_unoapi, we end up in a situation like: debug:4640:5240: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA65F8 debug:4640:7944: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 000D0003, pSVData->maGDIData.mpLastContext is 00FA6C70 debug:4640:5240: OpenGLContext::prepareForYield: start, wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA6C70 I.e. one thread registers as current, an other registers as current, too (while the other thread has the solar mutex), then once the original thread wants to release the solar mutex, the real current context and the last item in the context list won't match, so the assert at the end of prepareForYield() will fail. Fix this by releasing the GL context in WinSalInstance::DestroyFrame(). With this, JunitTest_sd_unoapi passes on Windows with GL enabled. Change-Id: Icfb9c65c871586b5df69b5a2ab3aa91843dfc799 Reviewed-on: https://gerrit.libreoffice.org/18473 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-09-11convert Link<> to typedNoel Grandin
Change-Id: I70d7c7ae4fc68d2f36a00d7c1b6eba71f63872d7
2015-09-11convert Link<> to typedNoel Grandin
and remove unused maChildEventListeners Change-Id: I845a9af608c3429cf9ccb0e8041f24f423839513
2015-09-11convert Link<> to typedNoel Grandin
Change-Id: I8f64b8f8e1e8ac7ce1475fc5132acb7171237a32
2015-09-10coverity#1323752 Logically dead codeCaolán McNamara
Change-Id: Ic7b0e9c6a1e4e1ce37d49358828a660fdfc63a1d
2015-09-10coverity#1323759 Uninitialized pointer fieldCaolán McNamara
Change-Id: I9fca8838beb1c2f6db8a9f1c9b6fe77f247b847c
2015-09-10coverity#1323760 Uninitialized scalar fieldCaolán McNamara
Change-Id: I933b208283629e7940f3d5928bae9f94a485f54c