summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-08-25coverity#1416668 Uncaught exceptionCaolán McNamara
Change-Id: Ibc2be8fe44295a8ea08105549448609e00262740 Reviewed-on: https://gerrit.libreoffice.org/41560 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-08-25Drop gratuitous initial :: from comphelper::ProfileZoneTor Lillqvist
Change-Id: Iae7d86b857d0563d9ed9d9b4187e009554698412
2017-08-25Allow non-modal Dialogs during FileImport/LoadArmin Le Grand
When opening a file that triggers Dialogs (e.g. cannot read/repair/FileType) the Frame from which it was initialized gets blocked. This irritates quite some people. Changed this to a non-modal Dialog so that the user can continue to work with all opened docs, open new ones, close and print/PDF/export these. Change-Id: I048d3de3369527cec20d26396b87439254764b8a Reviewed-on: https://gerrit.libreoffice.org/41534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-25loplugin:unusedmethodsNoel Grandin
Change-Id: Iaaf9092ec4d6189492906648b84494d087fed81f Reviewed-on: https://gerrit.libreoffice.org/41539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24vcl: fix double-free of ErrorInfoMichael Stahl
The only value that ErrorHandler::GetErrorString() adds over ErrorStringFactory::CreateString() is that it will delete the pInfo a 2nd time, because the ErrorInfo::GetErrorInfo() returns the same object twice. This may fix it, but it's generally hard to tell what this brain damaged error handling code will do. (regression from 1167df7df59e37fddef0c40c4d27cb2e82e10922) Change-Id: I22f446bee669cae8c5288bcc2f1e1d0299f5b384
2017-08-24vcl PDF export: remove no longer direct NSS dependencyMiklos Vajna
The relevant code has been moved to svl. Change-Id: Id2b77c797745af21d3d5f954357a02d54fb67908 Reviewed-on: https://gerrit.libreoffice.org/41498 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-08-24Consistently use OUString in test::DirectoriesStephan Bergmann
Change-Id: Ia5fd8af34ee9d2f37e4450ab241f6bb9a06445b2 Reviewed-on: https://gerrit.libreoffice.org/41466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-08-24remove unused error code in vclNoel Grandin
ever since commit 920d4463f6e59b815852c173e2974ffc7b4bb284 Date: Thu Jun 23 13:13:28 2016 +0200 loplugin:singlevalfields in vcl(part1) Change-Id: I3691d03dadff10585a119ca8db8aa193b5a01702 Reviewed-on: https://gerrit.libreoffice.org/41492 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-24unnecessary condition:rGraphic.IsDummyContext()ccsheller
when bDummyContext is true at pre code,and call the rGraphic.SetDummyContext( false ). so this is unnecessary condition at follow code. Change-Id: I69da58485fd7b81c9111e188d47b98fe8065fc47 Reviewed-on: https://gerrit.libreoffice.org/41489 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-23Android: Enable HAVE_FEATURE_NSS and package the NSS libraries with apkGautam Prajapati
This commit enables HAVE_FEATURE_NSS for Android and fixes the svl/ vcl/ and xmlsecurity/ module to use NSS. xmlsecurity/ wasn't built for Android previously, this commit enables building xmlsecurity/ for Android and disables the support of gpgme in the same module(Only for Android). It also enables the linking of NSS shared libraries with liblo-native-code.so and adds a rule to package them along with the apk. Change-Id: I7d0341688ac979ae92e9145c37dd107670417fe1 Reviewed-on: https://gerrit.libreoffice.org/41308 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-08-23convert message box style bits to scoped enumNoel Grandin
and fix harmless bug in ImpSVGDialog::ImpSVGDialog, which there since commit 6456f1d81090dd5fe44455c09ae3ede7ec6ac38a Date: Fri Feb 4 14:52:54 2011 +0100 ka102: added/removed files for SVG import and module cleanup Change-Id: I66b2ec2b029431ab453e54e962863e4ed7d78962 Reviewed-on: https://gerrit.libreoffice.org/41412 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22OSX fix updates during resizeJan-Marek Glogowski
While resizing MacOS suspends the NSDefaultRunLoopMode. So in this caae we can't post to the system event loop, but must use timers to restart ourself. Since the timer itself is scheduled on the NSEventTrackingRunLoopMode it' also triggers on resize events. There is still some minor glitch: when resizing too fast some part of LibreOffice isn't painted, while the left mouse button is down. Since there isn't any layouting triggered by the mouse up, there has to be an other inconsistency. Change-Id: I3ccba78bd23ec8526f21e7b93b027f3d3279f901
2017-08-22unnecessary conditionccsheller
truth table pContext bDummyContext !pContext || bDummyContext pContext && !bDummyContext T T T F T F F T F T T F F F T F Change-Id: I52e4647cb081eae265b3cc31e60a1ac6b0a5337d Reviewed-on: https://gerrit.libreoffice.org/41418 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-22Abort on critical Scheduler problemsJan-Marek Glogowski
We don't have the possibility to continue processing tasks without the scheduler lock. Same situation, if a task throws an exception. In both cases we just abort() instead of using assertions. Change-Id: I4d52a6ef0526a1e46b64f9f3a6e0cc1a718618cc
2017-08-22SVP always drain the wakeup pipeJan-Marek Glogowski
When we have a lot of idle tasks and generate new tasks, the wakeup pipe fills and is never drained, so OSL_ENSURE in Wakeup() starts to fail. This simply drains the pipe on every run, which processed an event. Change-Id: I7b6366b2649133b63138dc77fe51508404132890
2017-08-22The scheduler timer starts without SolarMutexJan-Marek Glogowski
The backend is resposible to correctly start the timer. Otherwise you can't start new Tasks without the SolarMutex. Change-Id: I4e066fceb513d0de90b58854baf3e45f2b8ff25b
2017-08-21Fix typoAndrea Gelmini
Change-Id: Ife6c317187915ba8df0351b7b96d481345343df6 Reviewed-on: https://gerrit.libreoffice.org/41404 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-21WB_FLATSPLITDRAW is deadNoel Grandin
since commit 2235846149e89dd9fe83cd4fbaf32908983aa571 Date: Tue Nov 23 18:50:48 2010 +0100 vcl117: reduce duplication of enums Change-Id: Ib9c8015934bc794df4b96cd35f5f93b23f372f70 Reviewed-on: https://gerrit.libreoffice.org/41386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_FORCETABCYCLE is deadNoel Grandin
since commit 7ced337e1f0e1fae81ff7f196e59e558b729bdde Date: Tue Jun 18 16:59:27 2013 +0200 startcenter: GSOC Use Widget Layout for the Start Center Change-Id: I406059568f15500a21a1b41d3a4b8e12b2adb5cf Reviewed-on: https://gerrit.libreoffice.org/41385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21emfplus: Corrected ReadWindowMetafileArmin Le Grand
There are two places which do hand over not a complete SvStream staring at pos zero, but pass a seek position indirectly in that stream. Thus this needs to be used. There is one usage in sc that copies the data to a MemStream to avoid that, so this hints that this 'trap/feature' was not known to everyone using it Change-Id: I94139b86c8bdd82879124c574bc3014e02d9ab5f Reviewed-on: https://gerrit.libreoffice.org/41399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2017-08-21fix bogus always-true assertsMichael Stahl
Most of these were converted from OSL_ASSERT Change-Id: Ia95a758cdebf72ee80d00866644d92e6bb915071
2017-08-21WB_CBLINESTYLE is deadNoel Grandin
since commit 51e6fc0c9e401162036913a943708b7cca1b2598 Date: Wed Oct 1 13:31:44 2008 +0000 CWS-TOOLING: integrate CWS vcl92 Change-Id: I31e39286d207ab7be91411b5644578762ec0d0d1 Reviewed-on: https://gerrit.libreoffice.org/41383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21WB_FAST/WB_TOPLEFTVISIBLE are deadNoel Grandin
since commit 2235846149e89dd9fe83cd4fbaf32908983aa571 Date: Tue Nov 23 18:50:48 2010 +0100 vcl117: reduce duplication of enums Change-Id: Ic34a09ae79c5226e4f07230ac8ec5f528210d988 Reviewed-on: https://gerrit.libreoffice.org/41384 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-21trivial WaE when pdfium is disabledCaolán McNamara
Change-Id: I43a5061c9549a0aff217407ebd3cc5baf68ac60d Reviewed-on: https://gerrit.libreoffice.org/41334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-19Fix typoAndrea Gelmini
Change-Id: Ia4c3ac4fd264d490dd3a91402897560ebd3006be Reviewed-on: https://gerrit.libreoffice.org/41314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-19convert WB_SLIDERSET to a bool fieldNoel Grandin
Change-Id: I8a3767e162a14069937d52f5eb57ae5cd7f3fa7b Reviewed-on: https://gerrit.libreoffice.org/41302 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-19convert extended WinBits to scoped enumNoel Grandin
Change-Id: If35f4fcda2415c858ba8f963e9f471c87169bc99 Reviewed-on: https://gerrit.libreoffice.org/41301 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18vcl: DockingManager owns ImplDockingWindowWrappersTakeshi Abe
so simplify code with std::unique_ptr. Change-Id: Ieec470e0a5f52c0d652d169c1ced6ca7307f062f Reviewed-on: https://gerrit.libreoffice.org/41217 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18loplugin:implicitboolconversion (clang-cl)Stephan Bergmann
...after 2bb282656a19a399a101dbeadf157d10d4d5e4f4 "SalFrame Handle* methods can return bool" Change-Id: I15659eafc27e8402aeb407418e656d546c554f06
2017-08-18loplugin:oncevar (clang-cl)Stephan Bergmann
Change-Id: I118da42ad7a42e4d081fd9901e230a0318a77f73
2017-08-18loplugin:unnecessaryparenNoel Grandin
look for statements like return (function()); Change-Id: I906cf2183489f87225b99b987caca67e39b26cc3 Reviewed-on: https://gerrit.libreoffice.org/41260 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-18Fix typosAndrea Gelmini
Change-Id: If13c1408a3e597c6f9b21d209722ef6bc87c0c94 Reviewed-on: https://gerrit.libreoffice.org/41270 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-17Fix typosAndrea Gelmini
Change-Id: Iaa9c0aea3ea1a239e378bd714ba335f91bb1faf3 Reviewed-on: https://gerrit.libreoffice.org/41194 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-08-17remove unnecessary use of OUString::getStrNoel Grandin
Change-Id: I3d13e1c0bb6aa4a7aacc463198747c1368ebc9b4 Reviewed-on: https://gerrit.libreoffice.org/38114 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from integer constants on the RHS of expressionsNoel Grandin
Change-Id: I899a8126c9d971601fea6c77eca165718aea0ac5 Reviewed-on: https://gerrit.libreoffice.org/41237 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17Clean up uses of OUString::fromUtf8 around string literalsStephan Bergmann
Change-Id: I9a2990e49c95a01ce505f13408be8c19db1cf5d1
2017-08-17Remove an odd attempt at ASCII graphicsTor Lillqvist
Change-Id: I5acb745bae01a60995376d33347a39edc12d4118
2017-08-17Put comment back next to code it pertains toStephan Bergmann
31ad2d7af585e8f35a645482a92bdc37a66e64ca "vcl: remove unnecessary included headers" had broken 598d8194b0ea1a64e0ebba28a86c128bafa57c7c "Visible function type RTTI for Clang -fsanitize=function" Change-Id: I16e4bb0bdded85f9a6edbd235a53c3a9bbdb7214
2017-08-17remove UL/L suffixes from integer constants in initialiser/call expressionsNoel Grandin
Change-Id: Iae081567c4fa5b88edbd12cf2fbafd2b8f31b300 Reviewed-on: https://gerrit.libreoffice.org/41214 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-17remove UL/L suffixes from shift-by-constant expressionsNoel Grandin
Change-Id: Ia470f643e3eefeccc14183133603db260460bd53 Reviewed-on: https://gerrit.libreoffice.org/41212 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-16SalFrame Handle* methods can return boolNoel Grandin
Change-Id: Ia28463e1c83aa496e8c389d1614f9b8a78100994 Reviewed-on: https://gerrit.libreoffice.org/41209 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-15tdf#111337 - Introduce alternative workflows at the special characters dialogAkshay Deep
Change-Id: I6a8fe2476adc5c4379c76dfaef090d1b5cd81ea0 Reviewed-on: https://gerrit.libreoffice.org/41170 Reviewed-by: Heiko Tietze <tietze.heiko@googlemail.com> Tested-by: Heiko Tietze <tietze.heiko@googlemail.com>
2017-08-15loplugin:redundantcast, find more functional castsNoel Grandin
In the enum types that caused the problem look like this when I dump then: EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' SubstTemplateTypeParmType 0xdb61200 'enum SvxFrameDirection' sugar |-TemplateTypeParmType 0xd7518f0 'EnumT' dependent depth 0 index 0 | `-TemplateTypeParm 0xd7518a8 'EnumT' `-EnumType 0xdb45770 'enum SvxFrameDirection' `-Enum 0xdb456d8 'SvxFrameDirection' Change-Id: Id8fedabe43b7a27df61a2320a9acbf54d2dc7882 Reviewed-on: https://gerrit.libreoffice.org/41169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-14Fix typosAndrea Gelmini
Change-Id: Ic95ec7c8a36ef5d19eac93b7eed8a7de2ec8904f Reviewed-on: https://gerrit.libreoffice.org/41153 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-14Creating a button for the hamburger menuGökhan Gurbetoğlu
Things done in this commit: - Created a hamburger menu button on the right. - Moved the opening menu to match the new hamburger button. - Added 1 pixel at the end of shortcut toolbox so no overlapping with the tabs would occur. Change-Id: I3d05eec72e260575563e4d016945af0777541cfb Reviewed-on: https://gerrit.libreoffice.org/38450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-08-13tdf#110988 Middle click does not paste primary selectionNoel Grandin
regression from commit 65b7b6322b662785bf032e66c76abc36c9a2bb0e "loplugin:unusedenumconstants read-only constants in vcl" Change-Id: I262dd4c9cd1dc6eca82521f5fd9fbfc952fb7745 Reviewed-on: https://gerrit.libreoffice.org/41111 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-13Related tdf#101467: fix a leak with pSalMask (vcl/bitmapex)Julien Nabet
+ initialize pSalBmp+pSalMask to nullptr Change-Id: I320e9cf98ef8224e98303bec1e58f59dc5b1ad4e Reviewed-on: https://gerrit.libreoffice.org/41097 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-12OSL_FAIL->SAL_WARN + display errcode (vcl/errinf)Julien Nabet
Change-Id: I59afb67fb160319e73adf2e5874e6f1825a3879d Reviewed-on: https://gerrit.libreoffice.org/41089 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-08-11vcl: use default copy-ctor for TextAttribJochen Nitschke
Type of TextAttrib (mnWhich) never changes, const it up. Derived classes can use implicit default copy-ctor. No need to explicitly delete default-ctor if there is a user provided ctor. And no need to define a default override dtor here either. Change-Id: I7a0d1896f659801319dc5fa74844df94c5888a7b Reviewed-on: https://gerrit.libreoffice.org/41022 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-08-11vcl: remove dead TextAttribHyperLinkJochen Nitschke
couldn't even find a proper ctor beside copy-ctor since commit e19c00ed76f5d46c3b88d2721b9ac84fcaaed97c Date: Wed Jul 13 13:30:48 2011 +0200 callcatcher: remove unused TextAttrib stuff Change-Id: Ia7f0bd1dcc725beb8cc53bb82372a4cce3ec68b0 Reviewed-on: https://gerrit.libreoffice.org/41012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-24 04:14:27 +0000