summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-07-22GSoC notebookbar: file menuSzymon Kłos
+ added icon to the notebookbar, after click the file menu will appear Change-Id: I30e1ed7e2c4a194e150c7196652904fd4e5c9e8e Reviewed-on: https://gerrit.libreoffice.org/27347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-21These fixes aren't needed after all.Caolán McNamara
The root problem was instead fixed by... commit 144e73f50c49333f61c6f27b882be9dbc232ceb4 Author: Noel Grandin <noel@peralex.com> Date: Tue Dec 22 09:05:32 2015 +0200 fix Link::operator< so that it is consistent with operator== Revert "Related: rhbz#1343766 a11y queries during dispose trigger listbox crashes" This reverts commit c615943bda57eadfa73c14a7314938aabe0bd16f. Revert "Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes" This reverts commit f120abb446bf3f5230ed06a3b148654dde36bb94.
2016-07-21memset hammer for -Werror=missing-field-initializersCaolán McNamara
Change-Id: I025bc48edad9fd0275f264a71e13dacd4c5bcc96
2016-07-21Resolves: tdf#100558 last 'section' of date field not incrementedCaolán McNamara
presumably a regression from... commit 3cad6c806e5247ce20b78eb688551aa5d872b934 Author: Chr. Rossmanith <ChrRossmanith@gmx.de> Date: Fri Mar 1 21:47:10 2013 +0100 Replace (Xub)String with OUString in vcl(field) where UniString::Search returned a max short on not-found while OUString::indexOf returns a -1 Change-Id: Ia3ef80dd318375ccdb3bdcee9bed7b70bf67cae1
2016-07-21gtk3-a11y: our eventbox is inside a grid nowCaolán McNamara
Change-Id: Icb49d6274b09fb426ab6c0f9f67b7c71c4ef9a31
2016-07-21Resolves: tdf#101011 atk needs a value for accessible-table-column-headerCaolán McNamara
This presumably became a problem after... commit 76c549eb01dcb7b5bf28a271ce00e386f3d388ba Author: Steve Yin <steve_y@apache.org> Date: Fri Nov 29 13:03:27 2013 +0000 Integrate branch of IAccessible2 added a TABLE_COLUMN_HEADER_CHANGED usage which triggered it. Change-Id: If54b7a39a170566cf7def3548ba385fa5d99bb1c
2016-07-20vcl: don't use the faster cairo code path when using OpenGLTomaž Vajngerl
Change-Id: Ia5f2fbf8765db4828338df4eb1f6d7405004e738
2016-07-20Resolves: tdf#100903 Calc hangs when preediting Japanese with GTK pluginTakeshi Abe
... + Mozc. This issue shares a common root with tdf#56937. Change-Id: Ic5720c19f22f7e6b047e1251b34f90d04ce7eee7 Reviewed-on: https://gerrit.libreoffice.org/27305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-19Revert "hack for now"Caolán McNamara
This reverts commit f5792667cafef77cc4c142f4261f8b64280bc0fe. it turns out it was the use of an intermediate GtkGrid which made a11y work a little differently under gtk3. Clearly not intended to be pushed. Change-Id: I6931163e07ea413acdd45ba1353f357d317fdfbd
2016-07-19hack for nowCaolán McNamara
Change-Id: I62673e60ac8785c74fc4f97ad76bcb02c7e28941
2016-07-19use CAIRO_FILL_RULE_EVEN_ODD by defaultCaolán McNamara
as seen in tdf#100909 with gtk3 backend Change-Id: I67a270a96df980489cd2cb37461b3bf88de4df03
2016-07-19clang-tidy performance-unnecessary-value-param in vclStephan Bergmann
Change-Id: I0b53c4bf5b4619cde357cf4eb432b153b1f7e6b5
2016-07-18Resolves: tdf#100731 include palette in checksumCaolán McNamara
Change-Id: I084d840b9fa078ebea3ff1471d8c8bc88171abc7
2016-07-18vcl: This seems a missing returnTakeshi Abe
Change-Id: I99c3be904e9ee2ad8f76d09d1d8998a6898fb81e Reviewed-on: https://gerrit.libreoffice.org/27283 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-07-18GSoC notebookbar: don't show empty space for hidden tabsSzymon Kłos
Change-Id: Ia00f64c1cb5d990e852cc297b6b7bd76df4b1b05 Reviewed-on: https://gerrit.libreoffice.org/27191 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-18add tagging to ThreadTasks so we don't need more one poolNoel Grandin
If more than one place in the code submits tasks to the shared pool, then waitTillDone() becomes unreliable. Add a tagging mechanism, so different callsites can wait on different sets of tasks. Also try to protect our worker threads against exceptions from the thread tasks code. Change-Id: Idde664ab50008d31a2dd73910bb22f50e62ae22f Reviewed-on: https://gerrit.libreoffice.org/27042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-17uitest: recognize function keys in keycodesMarkus Mohrhard
Change-Id: I0246b21d88aa43e36728c556b22372a8c04299fe
2016-07-17uitest: add 2 more properties for listboxesMarkus Mohrhard
Change-Id: Id8fb7973f868c12f920051ef3719ed0ff0712828
2016-07-15loplugin:nullptrStephan Bergmann
Change-Id: I35e2ee930d29cc8547a0fcf39d199727d7815748
2016-07-15new loplugin unnecessary overrideNoel Grandin
Change-Id: I88d3e33823d68745b98625050a8a274f9ef04bcb Reviewed-on: https://gerrit.libreoffice.org/27135 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-14vcl headless: ignore visibility in GetClientSize()Miklos Vajna
This fixes the missing-invalidation problem outlined in commit 22023b104cd1e024aecc28a6161bea519a584407 (vcl lok: fix missing paints due to zero-sized windows, 2016-07-12) also in Writer, not only in Impress. Starting text edit, doing a change, and ending text edit now results in the expected invalidations. Ignoring visibility seems to be a better fix for the missing paints. This way the headless case doesn't hit the corner cases of 0x0-sized windows. Also, the gtk vclplug's GetClientSize() only returns 0x0 in case the underlying window is disposed or it's minimized, but it does hand out the size before Show() is called, so now the headless backend is in sync with that. Change-Id: I78698cbfce954c8c593d279ab057a87cfbe87260 Reviewed-on: https://gerrit.libreoffice.org/27224 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-13Related: rhbz#1343766 a11y queries during dispose trigger listbox crashesCaolán McNamara
though not able to reproduce, I have an in-house complaint similar to commit f120abb446bf3f5230ed06a3b148654dde36bb94 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 8 11:35:15 2016 +0100 Resolves: rhbz#1343766 a11y queries during dispose trigger combobox crashes except with a listbox in the bt Change-Id: Id31561e009a1f0ec9272a0e7216296e4017e5688
2016-07-13Remove __cplusplus-checks from apparently-C++-only filesStephan Bergmann
Change-Id: I87e9ce45cf945e75e8140a9d4608da8abcddada6 Reviewed-on: https://gerrit.libreoffice.org/27187 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-07-13Make TooltipLabel default to PopupLabelSamuel Mehrbrodt
Because we often have similiar tooltip and menu names. Change-Id: I0ab66269b0b1f2985f23cf92289b3da69b6ddfd3 Reviewed-on: https://gerrit.libreoffice.org/27186 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-07-13no need to create temporary OUString for comparisonNoel Grandin
Change-Id: I0a321e8ffbe379588a288084ec2e74e1a8c296b2 Reviewed-on: https://gerrit.libreoffice.org/27171 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-13vcl lok: fix missing paints due to zero-sized windowsMiklos Vajna
How to reproduce the problem: open an Impress presentation in gtktiledviewer, create two views. Start editing the text of a shape in one view -> nothing happens in the other view. There is no invalidation in the other view, as sdr::contact::ViewContact::AddViewObjectContact() is not called for either of the views. Editing with a single view only worked as when clicking into the shape, the ViewObjectContact is created. On the desktop, those ViewObjectContacts are created on the first paint of the slide, but in the LOK case the vcl::Window instances had a 0x0 size, so an invalidation didn't result in a paint -> no ViewObjectContact was created -> no LOK invalidation was sent. No testcase, as I didn't manage to write code that actually triggers the failure under cppunit with the fix reverted. Change-Id: If29fcea4258a45f3d6d9aab284445756609fa13c Reviewed-on: https://gerrit.libreoffice.org/27159 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-12Related: rhbz#1351369 gtk3 clipboards have to live to end once createdCaolán McNamara
like the other platforms do Change-Id: I31340254573d13dc808d1e3038e3a36ae97f6c22
2016-07-12tdf#100600 sfx2 classification: never replace the control with labelMiklos Vajna
Thanks to Caolán McNamara for pointing out where is the condition of the replacement in VCL. Change-Id: I7e1ef4a016a37b25e084c4c6467a42ca557069a4 Reviewed-on: https://gerrit.libreoffice.org/27133 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-12new loplugin fragiledestructorNoel Grandin
fix up a small number of places that it finds Change-Id: Iedc91e141edfb28f727454f698cd2155a7fd5bf4 Reviewed-on: https://gerrit.libreoffice.org/26566 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-11loplugin:nullptr: Better heuristic to determine code shared between C and C++Stephan Bergmann
Change-Id: I51e1c5fa4639e51fac90f92adf3d87d12960d589
2016-07-11Resolves: tdf#95729 move 'alt' accel enable/disable down to systemwindowCaolán McNamara
from dialog and send the 'alt' to the active floating window, if there is one, before trying the menubar. so popups like the calc autofilter one can display their accelerators when alt is pressed Change-Id: I52e45b72885b1b0a7362cecc30e41d218a48a58d
2016-07-11Resolves: tdf#100463 tolerence in contour editor doesn't workCaolán McNamara
probably since commit f51f03a46102333bac6a7fe06bc8538492f413a5 Author: Stephan Bergmann <sbergman@redhat.com> Date: Wed Mar 5 12:24:14 2014 +0100 Do not needlessly truncate MinMax argument before comparison with bounds Change-Id: I5c92f0af3e05ad68ed88fa860b36e8426e160bf9
2016-07-11opencl: OpenCLZone, detect CL device change and disable CL on crashTomaž Vajngerl
Guard OpenCL calls with OpenCLZone, so if a OpenCL call crashes we detect this and disable OpenCL so next time the user doesn't encounter the crash at the same calculation because he has a broken OpenCL drivers. Similar has been implemented for OpenGL with good results. Additionaly we persistently remember a known good OpenCL device ID and driver version so we can match this and perform calculation tests when they change. This is to ensure that the selected OpenCL device performs as we expect. In this commit the calculation tests aren't included yet. Remove complex static initializer in opencl wrapper library. Change-Id: I1a8b81ee31298731efcf63dc6a476955afc035e9 Reviewed-on: https://gerrit.libreoffice.org/27064 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2016-07-11Modify ImpGraphic class, GraphicReader context to use unique ptrMark Page
Change-Id: I51c3995f4a6e940a5235524eb94dd356b27ae8d7 Reviewed-on: https://gerrit.libreoffice.org/26955 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-07-10so the global Application GetAutoMnemonic is always true, simplifyCaolán McNamara
Change-Id: I6c23273bd02841f72b489535f8a546e561df94e8
2016-07-10ditch the application per-language IsAutoMnemonicEnabled settingCaolán McNamara
Change-Id: I9734ada09edb6544a332893a7c5d31730b0d081d
2016-07-10ditch the multiply dialog width * X where X is based on language thingCaolán McNamara
Which should be unnecessary since the vcl layout work and optimal size widgets, and its a small and arbitary set of languages for which its set. Change-Id: Ifa397218510ade251f795cdd9360d6bdccb115b7
2016-07-10ditch the font/screen-scaling thingCaolán McNamara
its of limited utility wrt the vcl layout work and optimal size widgets, and its confuses people looking for hidpi settings Change-Id: I37d21b480446f9fe2845b3a2d9fd59cdeddf1a93
2016-07-10making a disabled image from a 1 bit depth icon gives index assertsCaolán McNamara
cause the disabled color cannot be mapped to the 2 entries in the palette, so use 8bit dests if the src is 1bit regression from commit 507d0ded64db51a8826d07c507f612a6c02c3869 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Dec 1 12:18:57 2015 +0000 keep disable image at same depth as original seen when clicking on the image loaded from tdf#100632 Change-Id: Ic69bccfa0fc86707b4fd9e757d8374d80e4b0071
2016-07-09uitest: throw an exception instead of crashing when we can't find childMarkus Mohrhard
Change-Id: I0527a1d207a87b7ba8d2e65cb866fe3ea1f25af6
2016-07-08Resolves: tdf#100452 class Date full (BCE,CE) proleptic Gregorian calendarEike Rathke
... implementing signed years with year 0 gap. Date(31,12,-1) last day BCE Date(1,1,1) first day CE New class Date member functions: * AddYears(sal_Int16) to be used instead of aDate.SetYear(aDate.GetYear()+sal_Int16) to handle year 0 gap. * convenience GetNextYear() to be used insted of GetYear()+1 * convenience GetPrevYear() to be used insted of GetYear()-1 * AddMonths(sal_Int32) * operator=(const css::util::Date&) New class DateTime member functions: * operator=(const css::util::DateTime&) Made some conversion ctors explicit, specifically Date(sal_Int32) Adapted hopefully all places that used a sal_uInt16 year to use sal_Int16 where appropriate. Eliminated some quirks in date handling found on the fly. Added era handling to i18npool icu calendar setting interface, which missing was responsible for 0001-01-01 entered in Calc being set as -0001-01-01, hence subtracting one day resulted in -0002-12-31. Change-Id: I77b39fba9599ebd5067d7864f6c9ebe01f6f578f Reviewed-on: https://gerrit.libreoffice.org/27049 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-07-08DialogControlFlags::Mod1Tab is never setCaolán McNamara
Change-Id: If681e1f296934c7e20934b0e000a3288f989ed35
2016-07-08ScrollFlags::NoErase is never setCaolán McNamara
Change-Id: I0cd0140b26100c6cd6d91ad060526310ef2ba7f6
2016-07-08ScrollFlags::NoInvalidate is never setCaolán McNamara
Change-Id: I7646b9572429540704a6f84734f647c10540825d
2016-07-08ScrollFlags::NoWindowInvalidate never setCaolán McNamara
Change-Id: Ib1f0f85fc6c1b68fcebdf94635536a9bdba06d93
2016-07-08PosSizeFlags::Dropdown is never setCaolán McNamara
Change-Id: I22d43822a54ec80b01b889cb4ab32073fdd2a3d0
2016-07-08loplugin:redundantcast: redundant static_casts in vclStephan Bergmann
Change-Id: Ib543e45d8eb1d54ef5c27769c601379fe615b23d
2016-07-08Resolves: rhbz#1352965 gtk3 infinite clipboard recursion with clipit installedCaolán McNamara
Change-Id: Ib67afaf532b8409e05fffbf1b8312d664460567d
2016-07-08if mpCurrentProgram and pProgram are NULL this crashesMarkus Mohrhard
See http://crashreport.libreoffice.org/stats/signature/OpenGLProgram::Reuse%28%29 Change-Id: I2d1c9d9faff05d0d57a2c217a9ee594b1c22b61d Reviewed-on: https://gerrit.libreoffice.org/27043 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-07-08GSoC notebookbar: container with prioritySzymon Kłos
+ extended vcl builder to parse priority + IPrioritable interface for controls with priorities + added IPrioritable as a base for VclContainer + Added PriorityHBox - box which shows controls if we have enough space PriorityHBox listen vcl events from SystemWindow to detect Resize Change-Id: I74ac1a80e7d0a061f5e7a8584dbb2abf956053c7 Reviewed-on: https://gerrit.libreoffice.org/26983 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>