summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-01-30extend menu builder to handle radio and check entriesCaolán McNamara
Change-Id: Iadbf01f42cb83b2595a49f2e5ba286bcba24281e
2017-01-30I don't see why we hide 'select all' if there is no insert symbol dialogCaolán McNamara
Change-Id: I928c94e104009e880c46100bdb57926f1a006877
2017-01-30convert edit menu to .ui formatCaolán McNamara
Change-Id: I658242745aba910c42a9bddf648dc88f53db6313
2017-01-30vcl: fix MetaTextLine reading, version 2 contains overlineTomaž Vajngerl
Reading MetaTextLine version 2 was reading to meUnderline (twice) and never read to meOverline. This is not consistent with Write where in version 2 we write the content of meOverline. Change-Id: If7911add5845ec3a01365d4ad8b8afaa6b2723dd Reviewed-on: https://gerrit.libreoffice.org/33687 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-30expand SVM test (Mask, TextRect, TextLine) and mtfxmldumpTomaž Vajngerl
Change-Id: I13e0882ac7093d6d3ab46914316f303e1ab01b93 Reviewed-on: https://gerrit.libreoffice.org/33686 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-30support accelerator modifiers in menu builderCaolán McNamara
Change-Id: I39c4260ecec288be61f4f2c42c5b7c72babdb7a8
2017-01-30Resolves: rhbz#1417480 stray bare XWarpPointer call in gtk3 codeCaolán McNamara
which blows up under wayland naturally can get here from tools->options->mouse positioning->"dialog center" table->insert table Change-Id: Id81b06a63cc3a2a1073d236e2f36dc65e533e598
2017-01-30tdf#104693: screenshot: fix mirrored mac screenshotsThorsten Behrens
Change-Id: Ie13689d7e15bf8dee6f21e6f5e7d75c9e53e931b Reviewed-on: https://gerrit.libreoffice.org/32543 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-01-28loplugin:stringconstantJochen Nitschke
Change-Id: I4e2e0aba2930d7c4ee60567d1d65e0e773a470bf Reviewed-on: https://gerrit.libreoffice.org/33650 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-28loplugin:stringconstant check for unnecessary OUString constructor..Noel Grandin
..calls when creating exceptions Change-Id: I3bc58a5aa4dc6f0508ecb88b3a843b96b8c7ebfe Reviewed-on: https://gerrit.libreoffice.org/33617 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-27add eps fuzzerCaolán McNamara
Change-Id: I7455a01076fc7c5fd16bbb90914ac93c236b2a3b
2017-01-27coverity#1371303 Missing move assignment operatorCaolán McNamara
Change-Id: I0dec3e192f3da895398a8b011c0e7275aab59d73
2017-01-27everything ImplClear clears is managed by their dtors anywayCaolán McNamara
Change-Id: Icafd4a4915d2fb3159b50409e5fc443c58d43d57
2017-01-27Animation dtor will be called anyway, so drop ClearCaolán McNamara
Change-Id: Ifa5a1cf6d782af0bb73ceff10f5a2a2daa4457d4
2017-01-27everything reset by ImplClear is going to be overwritten anywayCaolán McNamara
Change-Id: I94de8723a43d177fdf2caf0d8d3e529200d2e718
2017-01-27we copy the flag for the context in the ctor, but not the contextCaolán McNamara
which is worrying, copy the other missing maSwapInfo too which should be safe to do. in the assignment operator, we don't copy any of those three fields at all, which is inconsistent save and restore the context and context flags on the piece where we overwrite ourself via *this = tempobj Change-Id: I06a7d491f95dcb113a3c705ceeb41f576ab0a514
2017-01-27remove weirdness of ImpGraphic assignment operatorCaolán McNamara
seems to me that this hackery is to avoid the swapfile getting pulled out from underneath it during swapin Change-Id: I6b58d7e31731db8edc4026460beabc667204dcae Reviewed-on: https://gerrit.libreoffice.org/33620 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-27DisableGlyphInjection does nothingKhaled Hosny
Change-Id: Ie97eac46fde075bd74c7adb583b8be979f3af829
2017-01-27move these into the member init listCaolán McNamara
Change-Id: I94a1ea4cb81e2b7383c3e7c56314d08eea754434
2017-01-27-Werror=int-in-bool-context (GCC 7)Stephan Bergmann
Change-Id: Ide131a586d0d282993dfbf53a783f02d48860647
2017-01-27ImplClear sets mbSwapOut false, so mbSwapOut is actually always false hereCaolán McNamara
i.e. failure to swap in does not mean that mbSwapOut is true afterwards, and mpSwapFile is discarded. It means the whole thing is thrown away. Change-Id: I73704866d77078c73d053047a7d2ef6499a3e69d
2017-01-27Remove dynamic exception specifications from some TDE-only codeStephan Bergmann
Change-Id: I55cfacfd66ed31c8ec209d8deed7746ce917f8ba
2017-01-27loplugin:unnecessaryoverrideStephan Bergmann
Change-Id: I5bed51a3c03e2d55b9b7508d854cd486a35ea90e
2017-01-27reformat member initializationCaolán McNamara
Change-Id: I6c86da271d01d63ad426d3ac99068a6ad9663705
2017-01-27Related: tdf#105514 recursive fallback GetOpenGLContextCaolán McNamara
Change-Id: Icb8f3751806ef9c1c7c92cd8b7cc7c28595eca22 Reviewed-on: https://gerrit.libreoffice.org/33580 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-27loplugin: unnecessary destructor vbahelper..vclNoel Grandin
Change-Id: I6b7800d4a456391251168f7923a1ec7a5ca9efc9 Reviewed-on: https://gerrit.libreoffice.org/33577 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-25Resolves: tdf#94457 our EmfPlusSetPageTransform is malformedCaolán McNamara
we write a single short, resulting in a record of 0x000C in length MS-EMFPLUS spec has EmfPlusSetPageTransform as 0x0010 in length because we're not writing the 4 byte PageScale value. the previous pageunit unit we are writing is of value 1, which is UnitTypeDisplay, the same spec says... "The unit of measure for page space coordinates, from the UnitType enumeration. This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld" and footnotes that with... "Windows never writes those values to the PageUnit field, but they are accepted with undefined results." Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048 Reviewed-on: https://gerrit.libreoffice.org/33548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25ofz: xpm parser is too slowCaolán McNamara
and keeps timing out on documents, this takes my example pathological case from a callgrind cost of 40875 to 1292 million, and as a side effect rhbz#1051121-xpm now look right Change-Id: I840705007acf329579f270c390328f80190c19e7 Reviewed-on: https://gerrit.libreoffice.org/33532 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-25return earlyCaolán McNamara
Change-Id: Ia8504fdbc952b1e116bdca135a063d4d98be92be Reviewed-on: https://gerrit.libreoffice.org/33531 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25appears to be a missing break hereCaolán McNamara
Change-Id: Ifb04133b1946303879bf860003749996512bec91 Reviewed-on: https://gerrit.libreoffice.org/33530 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25Resolves: tdf#104598 make bright theme shadow the same as it always wasCaolán McNamara
The shadow color was originally set via StyleSettings::Set3DColors taking the background color as the input, and doing DecreaseLuminance(64) on it to make the shadow color So, continue to follow that mode if the "dark shadow" is darker than the foreground, and IncreaseLuminance the equal amount the other direction for dark themes. This way under a dark theme the problem of impossible to see rulers of tdf#90214 is still fixed, while the bright theme colors are the same as they always were, which avoid the wearing-on-the-nerves "regression" problem. Change-Id: I33133ff180ecadce3a14ee45bd33db73c56c0225
2017-01-25ofz#463 unable to mmapCaolán McNamara
Change-Id: I509faeda019f42bbe7cdc5fc249f2ea2076bb702 Reviewed-on: https://gerrit.libreoffice.org/33519 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25Fix typo in comments: relativ -> relativeTakeshi Abe
Change-Id: I58833e503e93b8057f92710c5828bba6cecd4e09 Reviewed-on: https://gerrit.libreoffice.org/33488 Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp> Tested-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-01-24add psd fuzzerCaolán McNamara
Change-Id: I8969e9f5020a6c1957b7f326e5dcca52915ddd4f
2017-01-24can use memcmp here, for hopefully a little import boostCaolán McNamara
Change-Id: I5084eff570a66cc2596b400cbb83d1eb24889f0b
2017-01-24return earlyCaolán McNamara
Change-Id: Ic95f968bcd7acdde170a1128a512f03f77e334cf
2017-01-24loplugin:useuniqueptrStephan Bergmann
Change-Id: I502ebf4024cd9b0ee61d58d6b6a8e342c7ceac08
2017-01-24coverity#1399552 Unintended sign extensionCaolán McNamara
and coverity#1399551 Unintended sign extension Change-Id: Iedf7edf35f8b7985860fc254597776fbc1f561f5
2017-01-23drop one of the Image ctorsCaolán McNamara
Change-Id: I51178fa30418136d4e5d266715d450f1c967167c Reviewed-on: https://gerrit.libreoffice.org/33475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-23Change all Idle* LINKs to be Timer*Jan-Marek Glogowski
Seem UBSAN doesn't like my forced reinterpret_cast to set the Idles Link in the Timer class. Now there are two possible solution: 1. convert all (DECL|IMPL).*_LINK call sites to use a Timer* or 2. split the inheritance of Idle from Timer again to maintain different Link<>s and move all common code into a TimerBase. While the 1st is more correct, the 2nd has a better indicator for Idles. This implements the first solution. And while at it, this also converts all call sites of SetTimeoutHdl and SetIdleHdl to SetInvokeHandler and gets rid of some local Link objects, which are just passed to the SetInvokeHandler call. It also introduces ClearInvokeHandler() and replaces the respective call sites of SetInvokeHandler( Link<Timer *, void>() ). Change-Id: I40c4167b1493997b7f136add4dad2f4ff5504b69
2017-01-22coverity#1399045 Untrusted value as argumentCaolán McNamara
Change-Id: Icac88c7b439036434cbf2352ac50e954139db4ce
2017-01-22wrong streamCaolán McNamara
Change-Id: I4e890ab80ed4ddb24b0fd41dae12264c99fb1477
2017-01-22return early on not goodCaolán McNamara
Change-Id: I4aca6cb1c3dae652595b93ff7507db713a668d5f
2017-01-22move loop variables to loopsCaolán McNamara
Change-Id: I914206bad88fb3c405a335c2926fb51e39b7857e
2017-01-21coverity#1399156 split ImplCreateSwapInfo and ImplClearGraphicsCaolán McNamara
Change-Id: Iab449967c70a55c03c3e6b95de8e7d973cb68089
2017-01-21coverity#1399017 Unchecked return valueCaolán McNamara
Change-Id: I67a8b8b5f63d3a44dc1df5c848da5797a6c20646
2017-01-21move GetXGraphic to its only userCaolán McNamara
Change-Id: I72ec4a7e72ca3355a97f987fab70b3e3a8e45168
2017-01-21This does not seem to be neededKhaled Hosny
Change-Id: I3f9a447478062ad4cfbf7bfadfd3fe73523de847