summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-03-17Resolves: tdf#98726 sneaky transparent clearlooks-phenix scrollbarsCaolán McNamara
Change-Id: Idc05d7b6c2b42086eafa9ad8ab8e63116d6f676c
2016-03-17too many configurations, too many platforms variantsCaolán McNamara
Change-Id: I10a284b7c27b145b003ff01a77dc5c0d51f418ad
2016-03-17Add a humble wishTor Lillqvist
Change-Id: Ie94f991acebda4e9074dba46d7bd65b433e0ce9b
2016-03-17loplugin:constantparam in toolsNoel Grandin
Change-Id: I3774661799c074561c694515baba42a375d0a077 Reviewed-on: https://gerrit.libreoffice.org/23301 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16WaE: loplugin:nullptrCaolán McNamara
Change-Id: I279d0021e7cdfd7e2d73ec6542e9ba27f300606c
2016-03-16tdf#97319: Give up on caching non-BMP glyphsTor Lillqvist
I can't figure out why successive non-BMP glyphs in the bugdoc get drawn on top of each others. So bail out... Change-Id: I9c6241916347ec31d616e5cbf00bf3b1869edba2
2016-03-16tdf#98607 - fix drag and drop regression.Michael Meeks
regressed in: f2f1f52d8b84ac088496a4964d799bb84007fc45 Added belt and braces fix. Thanks to Maxim for the bisect. Change-Id: I5b263870d76f44ef8833b27f0d8d391210216459 Reviewed-on: https://gerrit.libreoffice.org/23307 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-16attempt to address reported loplugin:vclwidgets warningCaolán McNamara
Change-Id: I6ccefa2d5d1c57cf9f1c4041d14c92d03ded1333
2016-03-16loplugin:constantparam in unotools/Noel Grandin
Change-Id: I016cf96af3a93c8f2114657a7e59599f68446ddc Reviewed-on: https://gerrit.libreoffice.org/23296 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16vcl: fix loplugin:defaultparamsMiklos Vajna
Change-Id: Ic947d1a4a341a778c88d1225b1a2ea66df697084
2016-03-16coverity#1355505 Uninitialized scalar fieldCaolán McNamara
Change-Id: I95d76b6c06d194b762ecd0534c51314744eb42ae
2016-03-16match types for legibilityCaolán McNamara
Change-Id: Ifd84a9a9dc54772a56d3bf0e345782f7f77562bd
2016-03-16Related: tdf#98637 make this a tractable problemCaolán McNamara
This is just too hard, it would all be much easier if the ActionGroup existed right from the start of the entire process. So smuggle in to the ctor the toplevel frame that the menubar will be inserted into so we can use its ActionGroup from the start. That would suggest that we could then just keep the hierarchy in sync as it is created rather than finding opportune moments to update /generate it. Change-Id: I550f94a994210423ab9cea1986e643056cb5bd29 Reviewed-on: https://gerrit.libreoffice.org/23287 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-16loplugin:constantparams in vcl/Noel Grandin
also some improvements to the plugin Change-Id: I0e3a519d70756e577fcb1bd47dd66864b5b4c871 Reviewed-on: https://gerrit.libreoffice.org/23289 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-03-16loplugin:implicitboolconversionTor Lillqvist
Change-Id: I9edc0d2e478f83e39e93e70e6c05c77b0125aad0
2016-03-15fix windows buildChristian Lohmaier
34a7b51ea482d4487d4fb8e61cde18aa1ff9b8ff (for 5-1) auto → size_t made 32bit happy, but win64bit still failed with: error C2784: ´_Ty std::min(std::initializer_list<_Elem>,_Pr)´ : could not deduce template argument for ´std::initializer_list<_Elem>´ from ´__int64´ Change-Id: Ib44840f692f1bcdea90decfe443c6eb72806002a
2016-03-15Resolves: tdf#98636Caolán McNamara
On changing a menu item from a non-submenu to a submenu then update the newly created menu as if it was the first full update of the entire menu hierarchy. On changing a menu item from a submenu to a non-submenu its evidentially not sufficient to unset the G_LO_MENU_ATTRIBUTE_SUBMENU_ACTION attribute so remove the submenu-item and add a new non-submenu item to force its new type Change-Id: I2030d9198d6849643a5991ddfffc1cc3425ba72e
2016-03-15vcl: improve opengl glyph cache debugging.Michael Meeks
Show cutting rectangles, base-lines, and count box widths. Change-Id: Ic6a08c4c029d6b576ea55479bbf6293accae6f15 Reviewed-on: https://gerrit.libreoffice.org/23251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-15tdf#98600 and tdf#98622 fix metafile parsingNoel Grandin
regression from commit db17d3c1 "new loplugin: memoryvar" Change-Id: I8b11871cadcf50649533680be51c767d6bb98350
2016-03-15tdf#97319: Handle surrogate pairs in glyph caching for SimpleWinLayoutTor Lillqvist
(For UniscribeLayout we use glyph indices.) Change-Id: Id1907cb766b9285d32e484049bec1b99159c5768
2016-03-15s/SEP/SMPTor Lillqvist
See https://bugs.documentfoundation.org/show_bug.cgi?id=97319#c8 . Change-Id: I66f5ea5ddd2a98de1d6445f3c6a91f1943dd7ca4
2016-03-15We use strlen() on these char arrays so better terminate them with 0Tor Lillqvist
Avoids an assertion failure for me. Change-Id: I811a3702baf76465acc580bc0e05db8a3c7f5364
2016-03-15remove unnecessary parentheses in case labelsNoel Grandin
Change-Id: I987bf68c767709080c67c8b183c036a4109c6caa
2016-03-15loplugin:constantparamNoel Grandin
Change-Id: I270e068b3c83e966e741b0a072fecce9d92d53f5
2016-03-14Bin a few pointless static const integersTor Lillqvist
Change-Id: I59f2547523129155b9d17699cc985fe0bd78f7e6
2016-03-14Bin leftover #if 0 snippetTor Lillqvist
Change-Id: I848a5dca6d18c3df57f563bb137efaed2e000461
2016-03-14fix memory leak in headless backendMarkus Mohrhard
Change-Id: I90282c86b45845fc35b23b275301be24a2f18a4d Reviewed-on: https://gerrit.libreoffice.org/23248 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-14tdf#95845 Use CommandInfoProvider to receive UNO command labelsSusobhan Ghosh
Added GetCommandPropertyFromModule to CommandInfoProvider. Removed GetCommandText. Change-Id: Ie987984b6465d540029196df371c0c0467999a59 Reviewed-on: https://gerrit.libreoffice.org/22918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-03-14Resolves: tdf#98638 sometimes menu grab doesn't takeCaolán McNamara
due to older timestamp vs earlier grab. Which suggests we should probably use GDK_CURRENT_TIME everywhere or (probably better) use gtk_get_current_event_time everywhere Change-Id: Ie04ab254b9fea423143cc9a129d2eecb683ed300
2016-03-14remove some unused Java codeNoel Grandin
found by UCDetector Change-Id: Ic0295a24b26e206eb53eda2da540755477df86df
2016-03-14tdf#95616 - fix flickering issueMarco Cecchetti
Change-Id: I0d5bfdf44dde2cd06c193f34e81c6ce71291bba1 Reviewed-on: https://gerrit.libreoffice.org/23238 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-03-14Fix what seems to have been off-by-one errors in glyph bounds calculationTor Lillqvist
For some reason the error had a visible impact (as far as I an see, anyway) only for Graphite fonts. The bottommost pixels were cut off. (Also leftmost, but that was not so easily visible.) <tools/gen.hxx> Rectangle type, I love you. Change-Id: I6f7438ec21d2bc1b9bef31cd70e649856f7ec7d5
2016-03-14tdf#97171: Use DirectWrite for OpenGL glyph cachingTim Eves
This is a squash of several separate intermediate commits, the most relevant log messages of which are repeated here: Refactor some previously private methods into public ones and reimplement parts of D2DWriteTextOutRenderer to user them. Also apply them to rendering the OpenGL glyph atlas, in an effort to workaround some bugs in legacy Windows text rendering APIs. I assume we want to initialise the rectangle with zero left/right/top/bottom and not using the default constructor, which sets the right and bottom coordinates to the magic value -32767. That made the 'bound' rectangle end up with rather amusing boundaries, like left=-32766, top=-16, right=-32576, bottom=6. Try calculating a chunks ascent & height from the inkboxes rather than using the font metrics which might not alway be correct when glyphs inkboxes are tall than the ascent or lower than the descent. Mark the mnAscent in the chunk bitmap debug output. Fix several miscalulations in positioning glyph to be rendered into that atlas. Fix vertical alignment problems. Inkboxes are returned with all co-ordinates relative to the glyphs not the fonts ascent. Therefor bounds.Top() is not the vertical overhang but the -ve height of the inkbox above the baseline. This fixes the calulation of the per Chunk ascent. Fix horizontal occsional alingment issues in OpenGL cached glyphs. The left edge of the src location rectangle for the first glyph in a cache chunk would set to extraspace and not zero, but all other rectangles in the chunk would be set from the aEnds array. This produced a bug where only certain letters would be mispositioned, proportional to the fonts point size. Rename OpenGLGlyphChunk::mnAscent to mnBaselineOffset to reflect curr use. Changed at Tor's stuggestion to better describe to it's use as it's value would be per chunk and based on the maximum ink box bounds of the glyphs in the chunk, rather than having anything to do with the font's real ascent value.
2016-03-14GetEnglishSearchFontName is what is supposed to use hereDouglas Mencken
Change-Id: I210359c28b5e66b64627cb49cdf388ee35015a92
2016-03-13coverity#1355505 Uninitialized pointer fieldCaolán McNamara
Change-Id: I95259c8a572529f47ef4fddf59f9ca29d078b6f4
2016-03-13add assert preventing memory leakMarkus Mohrhard
Change-Id: I0c659bf4fab2319f06df09dd11a768a295e95722
2016-03-13fix strange memory leak in VclBuilderMarkus Mohrhard
Change-Id: Iba34c25b19a94a8d4c147f8ccaef95f34183414b
2016-03-12vcl graph: stop abusing a pointer for a boolNorbert Thiebaud
Change-Id: I816fe3a52c03fa5a3fd372492985783f9f6ff91c Reviewed-on: https://gerrit.libreoffice.org/23181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-03-12Resolves: tdf#92067 with duplicate menu entries track which to activateCaolán McNamara
rather than just stick 2/3/4 at the end embed that this is a dup as the prefix and strip that off at dispatch time and pass the dup index around as a counter to how many dup candidates to dismiss to find the desired one. Change-Id: I81d97090a7e9b8c2995a3b27934f3ee5636d05fe
2016-03-12Typo: documet->documentJulien Nabet
Change-Id: I7ec134282af33386cab001ed076fb8fa90d33608
2016-03-11Passing a string to a std::ostringstream ctor is trickyTor Lillqvist
For it to do what one typically wants, also std::ios_base::ate is needed. Change-Id: If520c98cbd4d3913b644c2137623c2b7e9c5c708
2016-03-11gtk3: various bits means different things againCaolán McNamara
Change-Id: Iafa1e65fb0cc096513cdfe12a09fb0ef4c4d2db0
2016-03-11tdf#97966: Remove 'static' keywordsWastack
Change-Id: Id70f9e55fb4ad7d3a501399b055208ea10369c82 Reviewed-on: https://gerrit.libreoffice.org/23131 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack
Change-Id: I67e6076d65b90fb386ab439c5716820a6322af38 Reviewed-on: https://gerrit.libreoffice.org/23130 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-11tdf#97966: Remove 'static' keywordsWastack
Change-Id: I0a3f17d43917d05734980329231ef6e7cadfd58a Reviewed-on: https://gerrit.libreoffice.org/23129 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2016-03-10Avoid reserved identifier, remove unnecessary typedefStephan Bergmann
Change-Id: I2dfce92ef98ca18ac0fe2c415240216228b4ee0a
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: I554fde45000114dd19f117d93ef5c7a780231594
2016-03-10Avoid reserved identifierStephan Bergmann
Change-Id: Ie62bbf64a9cdb74725fd48a8f8dcc1ab76d97219
2016-03-10Remove unnecessary typedef (that introduced a reserved identifier)Stephan Bergmann
Change-Id: I6c0aaac10b2244271f3cdf45f4eceb6d685b213c
2016-03-10Avoid reserved identifiersStephan Bergmann
Change-Id: I751e75e0b63e95cc92be7b61a77ed21eeb52bc1f