summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2013-11-04Resolves: fdo#70588 MultiLineEdits don't need WB_WORDBREAK setCaolán McNamara
and inherits from Edit which reuses that same bit for password Change-Id: Ice27caecfd82e2dd7b000474f37b601fd4628766
2013-11-04remove redundant calls to OUString constructor in if expressionNoel Grandin
Convert code like: if( aStr == OUString("xxxx") ) to this: if( aStr == "xxxx" ) Change-Id: I8d201f048477731eff590fb988259ef0935c080c
2013-11-04remove redundant calls to OUString constructorNoel Grandin
Change code like this: aStr = OUString("xxxx"); into this: aStr = "xxxx"; Change-Id: I31cb92e21658d57bb9e14b65c179536eae8096f6
2013-11-04Convert code that calls OUString::getStr()[] to use the [] operatorNoel Grandin
This also means that this code now gets bounds checked in debug builds. Change-Id: Id777f85eaee6a737bbcb84625e6e110abe0e0f27
2013-11-03fdo#70885: disable app menu under UnityIvan Timofeev
Change-Id: I90ca2f5dd8d2678dff74ae5599e640c9a69aee33
2013-11-02Fix invalid string accessMarcos Paulo de Souza
Change-Id: Ic83af0549a88b8debfdf945853fa42e1d28e5869
2013-11-01Better approach for fdo#40077: Characters cropped in GTK-ComboboxSamuel Mehrbrodt
Now using gtk_widget_size_request() to get the native size. I reverted the earlier change (border_width etc. ignored) Change-Id: I0d89a2df5186bd27cbb77c8b0f2cc7b1fb247005 Reviewed-on: https://gerrit.libreoffice.org/6478 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-01remove nonsense FOLD commentsThomas Arnhold
Conflicts: vcl/inc/sft.hxx Change-Id: I1b744f14b6524e4d5913775427280e68c4ee07fc Reviewed-on: https://gerrit.libreoffice.org/6491 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-11-01TypoTor Lillqvist
Change-Id: I31cd13e6b11b73166e7a7f351c5eb3ea8038a4fc
2013-11-01Maybe Dialog::Execute() is one good place to call touch_ui_dialog_modal()Tor Lillqvist
Change-Id: I5f1b9fd266d7920a947d3dfb6bcd584e3cc30b53
2013-11-01Bin pointless Android ifdefsTor Lillqvist
It did not do anything. How to handle dialog attempts from random places in the code on non-desktop needs to be re-done properly. Change-Id: I854a12faba3f98c61f637b465789976493326d43
2013-11-01Bin dead codeTor Lillqvist
Change-Id: I7c3ae0afd6740df326a5c74826e7f204e9df2219
2013-11-01Cosmetics and style cleanupsTor Lillqvist
Change-Id: I45b072e5d6a216f0b82f7a0b3a4554ef4cc3570f
2013-11-01The "source size" of a VCL bitmap is not used for anythingTor Lillqvist
Thorsten thought it might have been used for to the handling of the "Original Size" functionality originally. That seems slightly broken currently in some use cases, and this change doesn't make it any worse. (To see the brokenness, play with resizing an image, reloading the document, and using "Original Size". With the right sequence of actions, LO seems to think that the "original size" is very small (1x1 pixel perhaps).) Change-Id: I4e0852d2b367def5bc40baf95aac273d59731eec
2013-10-31vcl: fix braceThomas Arnhold
Change-Id: Ib41c9521a8b8e5b8ebc170f9b7e45379a51f1bd5
2013-10-31Windows: SHARDAPPIDINFO since 0x0600Thomas Arnhold
This requires at least Windows 7 / Windows Server 2008. Otherwise it won't compile under WinXP. http://msdn.microsoft.com/en-us/library/windows/desktop/dd391556 Change-Id: I984e8bc1e9dc80a9c8bf236be9af3cffabcabd05
2013-10-31Better warnings when CheckContext() failsTor Lillqvist
Change-Id: I94627e5b4efda92ac80a618e5aa4b0b33340f4ef
2013-10-31Convert indexOf->startsWith and lastIndexOf->endsWithNoel Grandin
This is both an optimisation and a cleanup. This converts code like aStr.indexOf("XX") == 0 to aStr.startsWith("XX") and converts code like aStr.lastIndexOf("XXX") == aStr.getLength() - 3 to aStr.endsWith("XXX") Note that in general aStr.lastIndexOf("X") == aStr.getLength() - 1 converts to aStr.isEmpty() || aStr.endsWith("X") so I used the surrounding context to determine if aStr could be empty when modifying the code. Change-Id: I22cb8ca7c2a4d0288b001f72adb27fd63af87669
2013-10-30Windows: Drop obsolete stuffThomas Arnhold
This is pre Windows 2000. Drop it. Change-Id: I3599a0d2ff7cb967c534eaa0cd4f070817fe3240
2013-10-30windows: remove WINVER checkThomas Arnhold
This check is no longer necessary as we require at least Windows XP, which is 0x0501. It was implemented for ImmGetProperty(). Came in with 011bcd1ea1e8ce10f6b9946d8d44d05a59387b8c Change-Id: If94d6e99e7f474d931546326bd6c96f2cfa4cfcd
2013-10-30fdo#70968: Incorrect rendering of Devanagari short 'i' vowelKhaled Hosny
It seems that some Indic fonts assign 'mark' glyph class to combining spacing marks (spacing not non spacing) so my reliance on the glyph class to set the IS_DIACRITIC flags broke those fonts. This is a bandaid to get around the issue, plus some long rant! (at this rate, I'll be writing "The VCL haters handbook" pretty soon). Change-Id: I3ff892acf746d50182573f94e7e8c3c6f9464ae0
2013-10-30SimplifyKhaled Hosny
Change-Id: I30ab912b96fffa181b5cf062ecdf80faec615ec3
2013-10-30avoid build breakage on lame pseudo-OS that cannot unlink open fileMichael Stahl
Delivery of image theme zip can fail when a unit test runs concurrently and has the zip file opened on WNT. Horrible hack to have vcl depend on the image themes should prevent that. Change-Id: I4b65dbb6cae8738d52153eba3397b17e94cdc7c9
2013-10-29Resolves: rhbz#1021915 force menubar menus to be up/down onlyCaolán McNamara
If a menu won't fit in the desired location the default mode is to place it somewhere it will fit. e.g. above, left, right. For some cases, e.g. menubars, it's desirable to limit the options to above/below and force the menu to scroll if it won't fit Change-Id: I1998a842d25752389ec9032e54673408d1ed6cb5
2013-10-29fdo#40077 Characters cropped in GTK-based ComboBoxSamuel Mehrbrodt
Change-Id: I589ddfee1f69f5e8ba74dcc6abf9afb97cdf367d Reviewed-on: https://gerrit.libreoffice.org/6444 Reviewed-by: Adolfo Jayme Barrientos <fito@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-29TypoTor Lillqvist
Change-Id: I564659c8b05f08d497b778144a04464ba8f9ddd6
2013-10-29Add a SAL_WARN_IF to get more verbose information when CheckYieldMutex() failsTor Lillqvist
Change-Id: Ia9b9e43a25c1d86e3f8c6d9a29d54dd94625bb0d
2013-10-29VCL: I18NStatus::setStatusText shouldn't depend on aStr[len] == 0Arnaud Versini
Change-Id: Ifa0770eb24df4ae4c7c058b980545a9094bbdf50 Reviewed-on: https://gerrit.libreoffice.org/6461 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2013-10-28gbuild: set Package default target to INSTDIRMichael Stahl
Change-Id: I2bc45e4ba63f5faaee7389bcd9d7b3f563503186
2013-10-28fixincludeguards.sh: vclThomas Arnhold
Change-Id: I3858c2152267474afab8e5a72b9f5da0ac623012
2013-10-28Add some (commented out) SAL_DEBUG() callsTor Lillqvist
2013-10-28Shortcut when the SvpSalFrame already has the "focus"Tor Lillqvist
2013-10-26fix warnings in gtksalframeTomaž Vajngerl
g_simple_action_group_add_entries was deprecated in GLib 2.38 Change-Id: I727e8aeeecd66b8f071d43ff56d9dc94cda1b9e0
2013-10-26Seems that <vcl/cvtsvm.hxx> is private to VCL, so move it thereTor Lillqvist
Change-Id: I3fd1ac8aaea2e79efcd9e2d4b12347a387d0d28b
2013-10-25Remove unused fileTor Lillqvist
Change-Id: I78023074a31cf1cc3703a8fbeeb7f6a44a5c70d3
2013-10-24Bin unused #definesTor Lillqvist
Change-Id: I5a6eb741c0669d2f1e5bfbe302066be863ec0249
2013-10-24fixed build breaker MongolianEike Rathke
Change-Id: I5100d44ceea79c4b47d2dd5bda5066c5003313a1
2013-10-24added/checked/aligned MS-LangIDs and mappings from new MS-LCID.pdfEike Rathke
... found at http://msdn.microsoft.com/library/cc233965.aspx (the 5th or 6th place I'm aware of where MS defines LCIDs, all different ...) * a bunch of new definitions up to Windows 8.1 * lots of cross-checks done with SIL, Ethnologue, ... Change-Id: Ifae8e676558c6712fe752856acca600d05d0a63f
2013-10-23clean up places accessing the NULL at the of an OUStringNoel Grandin
There were only a couple of real bugs fixed, but we're a little bit safer now. This also fixes the assert and the comment in OUString::operator[] about this. Change-Id: Ibe16b5794e0ba7ecd345fa0801586d25b015974c
2013-10-23convert code to use OUString::endsWithNoel Grandin
Convert places that call aStr[aStr.getLength()-1] == 'x' to use the shorter form aStr.endsWith("x") Change-Id: I1b3a19c0e89b8989cdbeed440f95fc76f9a4b6b6
2013-10-23More work on selection handling in iOSTor Lillqvist
Got the selection start and end handle dragging working... The trick was not to call SwWrtShell::SetCursor(), but SwCrsrShell::SetCrsr(). Sounds easy but took a lot of guessing and experimentation to figure out. Anyway, now it does what I had expected it to do a few das ago already. There are glitches, especially in corner cases like if you move the start handle past the end handle or vice versa. more Change-Id: Id6c1d99a4052531789bccf0d48165cfb41b89cfe 9b94c0dd55b04a7b6b3c40654562a9c51fa9b450
2013-10-22vcl: convert some BOOL to sal_uInt8Michael Stahl
Change-Id: Ib0d90de832bc8006eaa62b55abb416e2d19b4782
2013-10-22ImplCalcSize etc can be constCaolán McNamara
Change-Id: Idd1e33b6da8be9575e74701735f0dbc742849c07
2013-10-22Bin comments that claim to say why some header is includedTor Lillqvist
They are practically always useless, often misleading or obsolete. Change-Id: I2d32182a31349c9fb3b982498fd22d93e84c0c0c
2013-10-22vcl: mark more Image constructors as "explicit"Michael Stahl
Change-Id: If59d7c75c89a102a573738d15d8593cb8ac5c486
2013-10-22bah, Len->!isEmptyCaolán McNamara
Change-Id: Icc09ef129d39575e02de4eaf1e371e3de8758eb3
2013-10-22aqua String remnantsCaolán McNamara
Change-Id: Ic574acda26775848918dc42ce3bce43c731ae267
2013-10-22some sneaky strings in vcl/winCaolán McNamara
Change-Id: I489b0088302016fb403fed090be9de9d6c213350
2013-10-22sneaky macosx StringsCaolán McNamara
Change-Id: I4baa3c144c357d3622c1d6b6a32435e52059d897
2013-10-22Resolves: fdo#38838 remove UniStringCaolán McNamara
hammer silver nails into coffin and bury in concrete Change-Id: I3fda2ff47738bb33793adab97faba2d439ac9a28