summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-12-08add mathtype fuzzerCaolán McNamara
Change-Id: I14a1f496dfc94bf678112d67f63a2c0101013472 Reviewed-on: https://gerrit.libreoffice.org/45815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07Fix typoAndrea Gelmini
Change-Id: I6c2a81ec4f60d09819112952a4384b8096ea414f Reviewed-on: https://gerrit.libreoffice.org/46004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-07fix fuzzer buildCaolán McNamara
Change-Id: Ibd2d1700c3bb69c6339110088ba531f95071ebd3 Reviewed-on: https://gerrit.libreoffice.org/46042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07gpg4libre: add KDE4 fpicker gpg crypt chechboxThorsten Behrens
Change-Id: Iba8fb0e0ac732f36cd1d880884bde1121e6b1eab
2017-12-07gpg4libre: add gtk fpicker gpg crypt chechboxThorsten Behrens
Change-Id: I27b494530a2b61eb37c4a9f7c3e1f9845f045e66
2017-12-07lokdialog: sc: Prevent assert when invoking autopopup filter dialogPranav Kant
We set the notifier in sc, so don't try to set it again in vcl. Change-Id: Ic7ab3d0030532a4e8630aa7e9266d32057373a65
2017-12-07incomplete type GraphicCaolán McNamara
Change-Id: I471d43be4b34f3bdb3db5b5ff316ff0a414c8996
2017-12-07loplugin:constparamsNoel Grandin
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06tdf#114262 Respect text+image toolbar styleMaxim Monastirsky
Regression of 67c9d054517fc3b5cbc203c330eedef4b50f0e57 ("fdo#84938: replace TIB_ constants with enum"). Change-Id: Ib90473a80fd491f4a136b4e76864c107a9240990 Reviewed-on: https://gerrit.libreoffice.org/45920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-06lokdialog: Show/Hide floating window on StateChangedType::VisiblePranav Kant
In the earlier approach, other state change events like SetText are emitted which ends up in "else if !IsVisible()" block and tries to close the floating window before it's even registered. Interestingly, this is not the case every time. Anyhow, better safe than sorry. Guard the floating window 'created', 'close' callbacks in a StateChangeType::Visible event. Change-Id: Ib997e11fd4a0f50b8911e9891918112e8ff8ef85
2017-12-06Document SAL_RTL_ENABLED env varSamuel Mehrbrodt
Change-Id: I6242f6028daaa0eb4d14134658e2eb50fd8f8275 Reviewed-on: https://gerrit.libreoffice.org/45932 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-06lokdialog: Window* -> VclPtr<Window>, and a small simplification.Jan Holesovsky
Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195 Reviewed-on: https://gerrit.libreoffice.org/45900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-06loplugin:salcallStephan Bergmann
Change-Id: I5c21f95f763f1491cc68087ecec0909493fd7f63
2017-12-06loplugin:redundantcastStephan Bergmann
Change-Id: I7e73878f263be57d91a1db2fc3d65d411bd49228 Reviewed-on: https://gerrit.libreoffice.org/45912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06tdf#108302: keep the font unrotated if @font isn't available.Mark Hung
We will create the font in ExTextOutRenderer for glyphs that are expected to be sideway in vertical writing, so we can reset the font escapement and orientation if @font ( windows notation of fonts for CJK vertical writing. ) isn't available. That will keep the font consistent with @fonts for those glyphs expected to be upright in vertical writing. Note that it is necessary to change text alignment of DC when such font is used. Change-Id: I1a4a6e8aa232119dd136beeb6c19505d7980a534 Reviewed-on: https://gerrit.libreoffice.org/45609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2017-12-05drop opencl and clew for fuzzingCaolán McNamara
Change-Id: I6b438e32b1be1ee8fbd72d296e3824b8bb473e8e Reviewed-on: https://gerrit.libreoffice.org/45878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05Revert "require at least gtk3 3.20.0 to build and run gtk3 bits"Caolán McNamara
Linux-deb-x86_64_56-lhm-ubuntu-trusty is at 3.18, not defunct Linux-Ubuntu-x86_64_54-TDE This reverts commit 75e828cad5e652f111278b103b72b9a9a344b689. Change-Id: I8939e4bb1876186f5ed75b3ad4c2626e37e4c81c
2017-12-05lokdialog: Make the badstatic loplugin happy.Jan Holesovsky
Change-Id: Ic19bbd2a3533e4e600d8856e55c4e8d06f0ad752 Reviewed-on: https://gerrit.libreoffice.org/45500 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-05require at least gtk3 3.20.0 to build and run gtk3 bitsCaolán McNamara
Change-Id: I2caf8c32d47ce195a3b714e50256d8425a5a117e Reviewed-on: https://gerrit.libreoffice.org/45735 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-05loplugin:salcall fix non-virtual methodsNoel Grandin
first, since those are safer to change than virtual methods Change-Id: Ie3b624019d75ee2b793cee33b3c5f64e994e8bfe Reviewed-on: https://gerrit.libreoffice.org/45798 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-04add html to fftesterCaolán McNamara
Change-Id: I85c2ce10ff6142d04310f834b16b2ded474e7a34 Reviewed-on: https://gerrit.libreoffice.org/45814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-04lokdialog: Merge dialog & dialog child mouse event APIs into onePranav Kant
Change-Id: I91aaa6a58f33dd2d817e02533de96e0c8191f2ca
2017-12-04lokdialog: Simplify; make the LOK dialog API more genericPranav Kant
Merge the dialog floating window callbacks and function calls into one. Unique window ids across vcl::Window is enough to distinguish between them. Floating windows don't have a LOK notifier as they are created in the vcl itself (so we can't access them from sfx2). Use the parent LOK notifier in that case (which would be a dialog). This API should also help in autopopup filter tunneling later. Change-Id: I63a2c97ffdd84695dc967e14c793089a7c50b41b
2017-12-04lokdialog: Kill some code; use already existing method to paintPranav Kant
This is not require now in the new approach where the dialog is already created by the time paint request call for dialog happens. Layouting is already complete by that time. Change-Id: I610b050a268e61e8d4036aa7eb5766cf0c8b37e0
2017-12-04add mml fuzzerCaolán McNamara
Change-Id: If508e804da7ec945deb1034a797d3a11a7a2ca00 Reviewed-on: https://gerrit.libreoffice.org/45684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-04new loplugin salcall: remove unnecessary SAL_CALLNoel Grandin
In this first commit, I use the plugin to verify the consistency of our SAL_CALL annotations. The point being to make the next commit more mechanical in nature, purely using the rewriter. There are various chunks of unix-only code that have never had to be compiled by MSVC, hence the inconsistencies. In bridges, I had to inline some typedefs to make the verification code happy, since it cannot see into typedefs. Change-Id: Iec6e274bed857febf7295cfcf5e9f21fe4a34da0 Reviewed-on: https://gerrit.libreoffice.org/45502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-03Use for-range loops in print2 (vcl/gdi)Julien Nabet
Change-Id: I13920afc28ac5bf4643aa545efe88488b8502e5d Reviewed-on: https://gerrit.libreoffice.org/45746 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-03require at least gtk3 3.18.0 to build and run gtk3 bitsCaolán McNamara
Change-Id: I02efb169ba1d0756d2d9c4b77c3c2b58e48c4a82 Reviewed-on: https://gerrit.libreoffice.org/45727 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-03Add mathtype to fftesterCaolán McNamara
Change-Id: If082fc85d943c5b2537800456dcebbce3cb10791 Reviewed-on: https://gerrit.libreoffice.org/45730 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02require at least gtk3 3.16.0 to build and run gtk3 bitsCaolán McNamara
Change-Id: I38cd6bcd9ed01695be4345add9d7c0a43a921d04 Reviewed-on: https://gerrit.libreoffice.org/45721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02require at least gtk3 3.14.0 to build gtk3 bitsCaolán McNamara
Change-Id: Ide498b03f21e2c3b8fb47c565079af26ead1d762 Reviewed-on: https://gerrit.libreoffice.org/45712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02require at least gtk3 3.12.0 to build gtk3 bitsCaolán McNamara
Change-Id: I608fa4075eadd0b3ed038c26aba5d9383a99b314 Reviewed-on: https://gerrit.libreoffice.org/45669 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-02require at least gtk3 3.10.0 to build gtk vclplugCaolán McNamara
Change-Id: I4ca34184237d05b999c92648494c306a1f1371cd Reviewed-on: https://gerrit.libreoffice.org/45668 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01we already don't run with < 3.14Caolán McNamara
Change-Id: I07adad73285bfd8550cc29ff0145cfc971cc7c71 Reviewed-on: https://gerrit.libreoffice.org/45671 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01we already don't run gtk3 if < 3.14Caolán McNamara
Change-Id: I6bc3cacb12fef6dd607f6c38612c270ecf845221 Reviewed-on: https://gerrit.libreoffice.org/45664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01Revert "tdf#114025 - avoid deadlock between x11 clipboard and ...Michael Stahl
... the lock dialog." SolarMutexReleaser hack can be avoided with the rtl_Instance fix from commit fa9c083c6071a0a4dc812f3c34731f347ddbabf7. This reverts commit b0e37303df56472fdc7782b977326c2391fdab07. Change-Id: Ib90cdec1420807afbadfd526a1ddb68d58db79c1 Reviewed-on: https://gerrit.libreoffice.org/45624 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-01add pptx fuzzerCaolán McNamara
Change-Id: I50495496914929f9279a455d1acbffab833bf3f5 Reviewed-on: https://gerrit.libreoffice.org/45482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-01loplugin:unusedfieldsNoel Grandin
The mnRequestedLength fields in formula/ were introduced in commit 6ef6dd0122b8e44d8547ec31f40def42173e4e41 Author: Kohei Yoshida <kohei.yoshida@collabora.com> Date: Wed Feb 26 14:32:57 2014 -0500 Store the length of originally requested array size prior to trimming. but then partially removed in commit d7f1f91b194da1cb96e66268ce7ef38602aa5754 Author: Noel Grandin <noel@peralex.com> Date: Mon Mar 3 13:29:43 2014 +0200 remove unused code in formula/vectortoken Change-Id: Ic56b6e42682131ee45df7838867145f980f3d601 Reviewed-on: https://gerrit.libreoffice.org/45571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-30add mml support to fftesterCaolán McNamara
Change-Id: Ie0c3dd5eddb274cf04b335af6fdcb32b3445d02c
2017-11-30silence various coverity warningsCaolán McNamara
Change-Id: I9ac4c179c30efa9d5950aa2106639d3781dd0308 Reviewed-on: https://gerrit.libreoffice.org/45583 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30loplugin:unnecessaryparen: signed numeric literalsStephan Bergmann
Change-Id: I75c8224452ca9c3711a2ccaca9ecf549fa59cb64 Reviewed-on: https://gerrit.libreoffice.org/45549 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30add xlsx fuzzerCaolán McNamara
Change-Id: Icce1317dc3ccfb598ce07ee61eddd873f1f98222 Reviewed-on: https://gerrit.libreoffice.org/45481 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-30Silence -Werror=pragmas with some GCCStephan Bergmann
...version "gcc (Ubuntu 6.3.0-12ubuntu2) 6.3.0 20170406" which reportedly supports C++17 but doesn't know -Wregister Change-Id: If8fd6f3c23ac26386fbc3ccd2df68d61d68ea793 Reviewed-on: https://gerrit.libreoffice.org/45509 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-30loplugin:unusedenumconstantsNoel Grandin
Change-Id: Iebcd8688ec807aa61989b4622ea0d3eca5c4c671 Reviewed-on: https://gerrit.libreoffice.org/45478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-29Resolves: tdf#114117 draw page shadow mangledCaolán McNamara
when cairo had to stretch the 1 pixel dimension to fit the area. When its this 1 pixel case set the same settings we use for the stipple effect to get the expected interpolation Change-Id: I42d87d6d01ebdb44083351a9632860f5f0a3bf63 Reviewed-on: https://gerrit.libreoffice.org/45511 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29add pptx support to fftesterCaolán McNamara
Change-Id: I517fa449ec75d8817cc3e03d0d90ab4c289a7c0f Reviewed-on: https://gerrit.libreoffice.org/45477 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-29lokdialog: new callback size_changed with new size of the dialogPranav Kant
Change-Id: Ibb864cb588ae7db92381c5578701d3ce09185f34
2017-11-29lokdialog: Emit callback when title is changedPranav Kant
The plan is to remove the getDialogInfo from LOK API but one more step before doing that is to find out why the dialog size in 'created' dialog callback is less than what the actual dialog after painting is. Change-Id: I5176e175cbf7ed81c1465feeeea053c9a024fbd9