summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-11-27with RTL UI the LTR scrollbar in 'gen' calc is rendered incorrectlyCaolán McNamara
this is noticable since... commit 4deadc3c78949c18bb886eb1f66caa8f3cd7a2df Date: Fri Sep 25 13:30:11 2020 +0200 disentangle AA and B2D use in VCL drawing but is probably a problem since around... commit b5f081e1ac14f60497f62a27be86b07b0baa42f7 Date: Thu Aug 30 23:41:36 2018 +0200 Support RTL layout in VCL using Matrices Change-Id: I6bcad30982ee1eaee96bc6721d73e1e545f0d86a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106761 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-27WinSalFrame::mnWidth/Height should presumably be of type LONGStephan Bergmann
...as they are only ever set to LO-/HIWORD values cast to a signed integer type Change-Id: I82f9a80bab7c3b7e3ee5545725efd0d88601b8c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106755 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27DWRITE_GLYPH_METRICS members are of INT32 and UINT32 typesStephan Bergmann
Change-Id: Ie09e0150bf73efd552e3a3b455ffc395d6b6370c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106754 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27RECT members are of type LONGStephan Bergmann
Change-Id: I8c0ad0878903c729be7149f81f5844a4baea7883 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106753 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27LOGFONTW::lfHeight is of type LONGStephan Bergmann
Change-Id: Iec7e8e84b8a6ee9e4ddbbbf5708bf9040418bbb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106752 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27DocumentPropertiesW returns LONGStephan Bergmann
Change-Id: I1ee167ef1bca530be9399dd081d7d25bd4155794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106750 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27loplugin:toolslong (Library_vclplug_win)Stephan Bergmann
Change-Id: I1e8c02a4fdb42a7bbc25764ceaf96972f175130a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106751 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27GetLastError returns DWORDStephan Bergmann
Change-Id: I4e886d1d5f94f8a25591c41e9f03300cfba641dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106729 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27Windows InterlockedIncrement/Decrement use LONGStephan Bergmann
Change-Id: Ib3e8e89332399eba443d9ff291f694cfceb95af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106726 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-27jsdialog: dump dialog titleSzymon Kłos
Change-Id: Id4c9f336039f8a0b8d1d43fdff4852f32e2c7ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106707 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27jsdialog: remember dialog instance & handle closeSzymon Kłos
Change-Id: I1b10d12edfa7ffca1061f50b5219baae1ac3caeb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106706 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27jsdialog: drag and drop support for TreeViewSzymon Kłos
Change-Id: I67e2eb986b48591b7f758bbb5c1d72b6a322d4d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106705 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-27silence warnings about negative widths under RTLCaolán McNamara
I don't see any visual problems, but there are these annoying warnings Change-Id: Ifc8830503cdc57084272a973b09927069caabada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-27tdf#127294 add ToD Previewsandreas kainz
Change-Id: Icd049b0ae313e4c3095975a98f8765372fa22abf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106719 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-26with SAL_RTL_ENABLED=1 calc tabbar arrows are rendered reversedCaolán McNamara
in... commit 6a54960f6b38a7d549ed33419cf55f4e718cf7b9 Date: Fri Jul 17 17:04:27 2020 +0100 tdf#134085 DrawTransformedBitmap in wrong place for RTL The return of mirror wasn't used, so no effort at a rtl mirror was made anyway. I confidently claimed that "we don't want to mirror polygons", and we definitely don't want to mirror images which was the immediately obvious problem there. It was also the case that the highlight polygons drawn there were missing entirely and the changes improved matters and put those polygons at the correct position. But it does seem that we *do* want to mirror polygons. Since... commit 4deadc3c78949c18bb886eb1f66caa8f3cd7a2df Date: Fri Sep 25 13:30:11 2020 +0200 disentangle AA and B2D use in VCL drawing this path has become more used and makes it obvious that the triangles in the tabbar buttons are reversed since the second commit. Change-Id: Id709b2abff04c609a3c644530bcdb60c83a82942 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106702 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26tdf#138486 Artifacts in some impress templatesNoel Grandin
fields need to be signed regression from commit 548d77d0c06f7088dd3eb408797aa1fc1d7eb277 Author: Noel <noelgrandin@gmail.com> Date: Fri Nov 13 10:23:36 2020 +0200 tools::Long->sal_uInt16 in ImpErrorQuad Change-Id: Ia2a70d55d9af2ea3712ace3394c0de3931bee95c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106709 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-26jsdialog: implemented Expander widgetSzymon Kłos
Change-Id: Ib0aee0e01c662a4d6a9231d9a1a951c9fa68eff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106693 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26keep toolitem ids uniqueCaolán McNamara
which is a problem when we swap item ids under SAL_RTL_ENABLED=1 in sidebars Change-Id: Ib949f7836893b2f06b748fc3a2546788555782ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106662 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26Move SalInstanceExpander decl to header fileSzymon Kłos
Change-Id: I5399f5aca07dd27dfc668cad66cf347936bbba7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106664 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26add a way to invalidate the InterimItemWindow child contentsCaolán McNamara
Change-Id: Id7bbf6443f25eee7745123f127cd9d6424a684b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26factor out as a standalone "ButtonPressRepeater" classCaolán McNamara
Change-Id: Id89d5655c2428cecdaf9faa224133302c6448a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-26Fix "single print jobs" function in print dlgSamuel Mehrbrodt
Did not work at all Change-Id: I388ce579691a1e7ad2eff8420c2f8b6b3e939ef0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106665 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-26jsdialog: dump VclExpander typeSzymon Kłos
Change-Id: Ie40632ab8ce53e0b1f9277dce3d46032a508edce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106663 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26jsdialog: signal when treeview element is toggledSzymon Kłos
Change-Id: If69eac02db386fd94420aff5a8b082281e913c15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106658 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26jsdialog: cleanup when destroying builderSzymon Kłos
Change-Id: I38bf65eb96b560970fb03eafaea89446e89a2896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106591 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26jsdialog: prevent from crashSzymon Kłos
Change-Id: If17738b7f58037929e29def75736434c33649b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106590 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-26pdfium: replace PDFiumSignature::getPointer() with typed gettersMiklos Vajna
Once reason and time has getters, no need to expose the underlying PDFium type. Change-Id: I8f6b152fddf38e76ad7c3b1897fcb2026129820f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106631 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-26Add 'SinglePrintJobs' to PrintOptionsSamuel Mehrbrodt
So that this option can be set via UNO API Change-Id: I0b69162661a4327d59aaed82d5eff98cb50d852c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106593 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-26WMF export: just write the source data as is for from-WMF graphicsMiklos Vajna
This was already working on master since commit 5868745db74ae930edb0058490076d82aaeafbe9 (emfplus: make VectorFormats Emf/Wmf/Svg work, 2017-06-12), but a matching testcase was missing. Change-Id: I7661cd5e66d13b1750f16c0c423c4b69420577a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106607 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-25jsdialog: execute checkbox actionSzymon Kłos
Change-Id: Ib19997f600404cc9555acbfaf87acac32f8aa5fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106562 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25jsdialog: export placeholder text for edit fieldsSzymon Kłos
Change-Id: I6031025a72cc72e8bc3834c256479ec1a07971b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106561 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25jsdialog: implement TreeViewSzymon Kłos
Change-Id: I7c1cc683e8c5d5bdc00c1e3d3d0a2c85846bbda0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106560 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25-Wc++11-narrowing (clang-cl)Stephan Bergmann
MSVC seems not to mind, but a Windows 64-bit build with clang-cl fails with "error: non-constant-expression cannot be narrowed from type 'tools::Long' (aka 'long long') to 'LONG' (aka 'long') in initializer list". But adding explicit casts would have the downside of preventing tools like -fsanitize=implict-conversion (if we ever use that on Windows) from detecting truncation, so introduce o3tl::narrowing. Change-Id: Ia33a9ae4d8134b5ad0c8b7cf6812fbdd625ca89e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106577 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25Use sal_Int64 to printf tools::Long valuesStephan Bergmann
(The "%l" format specifiers had now caused -Werror,-Wformat with clang-cl for a Windows 64-bit build.) Change-Id: I86b9617310f7348d72172cc7a29f0976c7030dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106576 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-25tdf#138425 vcl/gtk activate main menu in UpdateFullThomas Viehmann
VCL GTK (in contrast to X11 and apparently Windows) pre-activates popup menus in GtkSalMenu::UpdateFull by calling GtkSalMenu::ActivateAllSubmenus. Before this patch, this, called on the main menu, would not activate the main menu itself (which does get activated in X11 eventually). This patch changes the logic to also activate the main menu. This patch deals only with gtk3. A followup patch would do the analogous change in the VCL Qt5 plugin in Qt5Menu::DoFullMenuUpdate. I haven't discovered yet where this type of functionality is currently tested, so sadly I don't have an idea how to test this and so didn't include a test case. Change-Id: I6cd9929acfd3b3af731bbc62d649d643044ca692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106454 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-25pdfium: add sig getters: ByteRange, DocMDPPermission, Contents and SubFilterMiklos Vajna
Change-Id: Ieab577de92898568e27a879af1ca1bda170a307d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106554 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-25Move SalInstanceTreeView decl to header fileSzymon Kłos
Change-Id: Ie49f4113332de5c4fa825f93dde46bb408187fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106536 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25jsdialog: dump treelistviewSzymon Kłos
Change-Id: Id6152a1b96a92a8ee863e1426d458b9f81605065 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106535 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-25tdf#138326 impress template thumbnails are blurredNoel Grandin
regression from commit 548d77d0c06f7088dd3eb408797aa1fc1d7eb277 Author: Noel <noelgrandin@gmail.com> Date: Fri Nov 13 10:23:36 2020 +0200 tools::Long->sal_uInt16 in ImpErrorQuad Change-Id: I29403afcb7d88dee27f1565793ffbd7ad4c53a17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106545 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-24jsdialog: use separate content and notificator windowsSzymon Kłos
Change-Id: I42208dd69bc790d136637253d7f1ae39a6306820 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106503 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24lok: Log save errors and avoid infinite loopSzymon Kłos
Don't create synchronous dialogs on errors which were causing infinite loops. Just send error for logging purposes. Change-Id: I88e57ae34502a6f82e44051033c91ca41c1a7b8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104579 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Ashod Nakashian <ash@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106418 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-11-24add set_buildable_name to enable distinguishing different instancesCaolán McNamara
of widgets loaded from the same .ui snippet in the same dialog so ui-testing can identify the right one Change-Id: I2ecc7fd60ab891ae9f94971a3035585d4500f694 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106500 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-24Remove unused parameter (flagged now by loplugin:stringview)Stephan Bergmann
Change-Id: I78e2b60945f256de5e7455373a2ecff72f9eaae7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106484 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-24Remove unused ScrollBarBox from tabpageSamuel Mehrbrodt
This displays an empty rectangle at the upper left of the tabpage. Change-Id: I8424a3f8ec4896814b135aa2c86012f0b33ee1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106480 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-11-24loplugin:stringviewparam extend to comparison operatorsNoel
which means that some call sites have to change to use unicode string literals i.e. u"foo" instead of "foo" Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23Fix typoAndrea Gelmini
Change-Id: If4a6264729432cee6fc27765ad0f35e9bc4f0f43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106417 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-23tdf#137662 ignore focus in dropdown if dropdown is hiddenCaolán McNamara
Change-Id: I0263fb832f31c6926ac63cab79ce8fd0b9548581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-23Fix typosAndrea Gelmini
Change-Id: I6ee795694959f1750a3c84421e632d00ad805b3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-23pdf: test reexporting a PDF with complex resourcesTomaž Vajngerl
This tests the copying of complex resource when we reexport a document which contains PDF graphic obects (and thus contains the original PDF data in "Form" XObjects). Change-Id: I680eb4702a7de7d48b67bd8cb8aa39e5195d876c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105812 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-11-23pdf: Improve dict and array format when copying with PDFObjectCopierTomaž Vajngerl
Change-Id: I4fcc4d912d4ce9d7800782b69811f877b85d9857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105811 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-21 09:22:09 +0000