summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-04-15move ImpNodeCache into Octree.cxx and clean-upTomaž Vajngerl
ImpNodeCache is specific to Octree so it's best that it lives near the source. Change-Id: I35e937343312b0ab18ed1a4dcaa067ea01a0191f Reviewed-on: https://gerrit.libreoffice.org/70736 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-14Octree: more clean-up, avoid memset, prefix member varsTomaž Vajngerl
Change-Id: I79ec1d0176f523d16c53220de9b0a0d9819729ea Reviewed-on: https://gerrit.libreoffice.org/70729 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-14vcl: add a basic Octree testTomaž Vajngerl
Change-Id: I4f142586ceedb8f51610139db914845892f65d2c Reviewed-on: https://gerrit.libreoffice.org/70728 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-14put Octree classes out of formatting blacklistTomaž Vajngerl
Need to do this so it is at least somewhat formatted sanely before refactoring to the data structures. Change-Id: I136a539a190c2f53aa05cc9a26872a5606f81888 Reviewed-on: https://gerrit.libreoffice.org/70727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-14move octree to bitmap folder, and *octree headers to inc/bitmapTomaž Vajngerl
Octree is a tree, that's used for color quantization, so it's better to move it there. Headers are also moved to bitmap subfolder so it's better organized. Change-Id: I2b84a5469c1479cf0a060ba8eb46591dabab2883 Reviewed-on: https://gerrit.libreoffice.org/70726 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-14tdf#120703 PVS: Silence V522 warningsMike Kaganski
V522 There might be dereferencing of a potential null pointer. Change-Id: Ie4bc74a734a6d5a73838a27e0d80cc8e51595839 Reviewed-on: https://gerrit.libreoffice.org/70730 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-13BitmapScaleSuper: rename the func. names to reflect what they doTomaž Vajngerl
Functions that scaled down had "2" at the end of the name so we could distinguish them from the scale up functions. This was hard to tell them apart, so rename the functions to reflect what they do. Change-Id: I9d88b86312e80b111439f1022212de07e53485d5 Reviewed-on: https://gerrit.libreoffice.org/70696 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-13BitmapScaleSuper: generalize 24bit scalingTomaž Vajngerl
Until now we had RGB and BGR version. Because we never change the byte order when scaling and the scanline type, we can generalize the two funcions into one, where we only need to be careful that we don't change the order of color components. The same is done already for 4 variants of 32-bit bitmap, where we really only need 1 function for all 4 variants, using the same principle. Change-Id: I0f6d6b0c06a45e53bcd048e2ae009a471bf90a06 Reviewed-on: https://gerrit.libreoffice.org/70695 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-13BitmapScaleSuper: make it easy to change the percisionTomaž Vajngerl
Most calculations work with integers for speed, which sacrifices some bits of an integer type for decimal values (fixed-point precision). In this case we used 7 bits for decimal values. This change makes the precision easily adjustable. In addition the actual type of bilinar weights, which was until now the type long (that hasn't a standardized bit length), but is now changed to sal_Int32 (so we know exactly how much bits we can use) and can be changed to sal_Int64 in the future if necessary by just adjusting the typedef. Change-Id: I8d41751c20e14cd1b9b64b055ff66bd1ca7c9f1d Reviewed-on: https://gerrit.libreoffice.org/70694 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-13tdf#97822 vcl opengl gtk2: fix missing list node widgetMiklos Vajna
OpenGL just sets GtkSalGraphics::bNeedPixmapPaint to true, and the problem is specific to that flag (can be also enabled via SAL_GTK_USE_PIXMAPPAINT=1). Most other widgets are painted correctly in the GL case as they pass around a drawable explicitly; do the same for ControlType::ListNode as well in the GL case. The non-GL case still needs to go via the pixmap render macros to have correct position, leave that unchanged. Change-Id: Ia82a6772e357b434d706e58664be3a8427e91669 Reviewed-on: https://gerrit.libreoffice.org/70669 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-13use more std::make_uniqueNoel Grandin
Change-Id: I7d85cbc9105c5e0c4a8d9a69c4ac9d6dfc07eabd Reviewed-on: https://gerrit.libreoffice.org/70663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-13tdf#124543 add functs. to scale 32bit bitmaps to BitmapScaleSuperTomaž Vajngerl
We still miss the support in other function however. Change-Id: Ie87b588a9f8826242f4cff9d6671c98f3407f0e3 Reviewed-on: https://gerrit.libreoffice.org/70679 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-13Improve multi-threaded scaling in BitmapScaleSuperFilterTomaž Vajngerl
The old approach was to calculate the number of stripes of the bitmap per thread and later create the exact number tasks (ScaleTask) as there are threads, where each task would process stripes it had been given. This is needlesly complicated as the job of a thread pool is to properly delegate the tasks between threads. This was now changed so that we create one stripe per ScaleTask and let the threadpool delegate the tasks to its threads (that are available). It also wanted to be clever and use the main thread to do the work also, but it had a major flaw. The threadpool started to process the tasks only when "waitUntilDone" method was called, but the code first processed its slices and then called the threadpool method to start processing. Because of this the performance of scaling wasn't as good as it could be. This behaviour was now changed so that the main thread isn't involved in processing. It just creates the task, runs the threadpool and waits until the tasks are finished. Change-Id: I1e8c733bdbced8867d0a7f1190f0421a0cc3e067 Reviewed-on: https://gerrit.libreoffice.org/70668 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-12Resolves: tdf#124698 bubble down parent for modal dialogCaolán McNamara
Change-Id: If03c6ff8043bb39f2efdf4cde19d8277886bf36f Reviewed-on: https://gerrit.libreoffice.org/70658 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12prefer vector::data to &vector[0]Caolán McNamara
probably missed loads more Change-Id: I53c9fe188055ef925fed54500e64b837cd56a1e7 Reviewed-on: https://gerrit.libreoffice.org/70676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12loplugin:unusedmethodsNoel Grandin
Change-Id: Ie90e53583484ee4f378ec92634adf3be7cd9ecbb Reviewed-on: https://gerrit.libreoffice.org/70650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-12internally resize image instead of scaling bitmaps outsideTomaž Vajngerl
When we want a different size Image, we can now set that as a parameter at construction of the Image. Previously we needed to create an Image, forcefully take the bitmap out, resize the bitmap and create a new Image out of that. Doing it internally gives us the benefit to have a more control over the scaling process, especially when dealing with HiDPI images. Change-Id: I104118f4d863d519cc7aad1a17ca0289c01ed9ff Reviewed-on: https://gerrit.libreoffice.org/70617 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-12downgrade warning to infoCaolán McNamara
Change-Id: I2d0725b3ba5f8d68c6757235a8372894903a5769 Reviewed-on: https://gerrit.libreoffice.org/70606 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-12drop warning we're going to do nothing aboutCaolán McNamara
Change-Id: I44cc4b3c4f1af21e0d7a2a0914a5e84a6f4453d7 Reviewed-on: https://gerrit.libreoffice.org/70605 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScDbNameDlgCaolán McNamara
Change-Id: I676909cbb4067ce69d5327403dd25cc80c4cbc4b Reviewed-on: https://gerrit.libreoffice.org/70593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-11weld ScNameDlgCaolán McNamara
Change-Id: I7a00dd386a1cb52e046d0f57c77fe3fdf8252bb7 Reviewed-on: https://gerrit.libreoffice.org/70548 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-10fix build failure, use explicit $(SRCDIR)Caolán McNamara
presumably this makefile should actually be in extras (?) Change-Id: Ie38c7f5662c5577f5de11600645049757031a697
2019-04-10Fix typoAndrea Gelmini
Change-Id: I1560aac1ed7c6119aabf1410a592ac0a9bcc357b Reviewed-on: https://gerrit.libreoffice.org/70532 Reviewed-by: himajin100000 <himajin100000@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-10weld ScCorrelationDialogCaolán McNamara
this is first of the calc dialogs with a range selector, so some temp scaffolding is required during interim case of both welded/unwelded in existence Change-Id: I5480179092da7b56864cef066af781b35f735ebc Reviewed-on: https://gerrit.libreoffice.org/70474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-10tdf#124652 Guard Gtk3KDE5FolderPicker::execute with SolarMutexGuardMichael Weghorn
S.a. commit 8dbe0af729c9e054135a0f41706165033441f867 which already did the same for Gtk3KDE5FilePicker. Change-Id: I35f837b7b8fdaebc5625ff8ea5e20b3f48a3b4ec Reviewed-on: https://gerrit.libreoffice.org/70519 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-04-10tdf#82009 TreeList move painting of drag target into Paint func.Tomaž Vajngerl
When we drag a entry in TreeListBox, we execute a PaintDDCursor which paints a "cursor" of a possible drag target (for example to show where the entry will be moved to if we want to change the order). The problem with this fuction is that it paints a line directlly at that location, and that it uses invert raster operation to draw a line. So to hide the line it just needs to draw again. On MacOS this invertion causes a problem and draws the whole area black, which is the cause of this bug. So instead of inverting the drawing of the drag target cursor has now been moved into the main Paint method, where it redraws the whole entry, and if present, also the drag target cursor. This means that all we need to do is Invalidate the entry, which then just gets redrawn in a normal Paint pass. One exception is still MacOS, which doesn't invalidate the entry, but redraws the entry directly. DnD is MacOS is a bit different as it is not async (if I understand correctly) so the invalidate has no effect. Change-Id: I8542f47940a3b90114ea4bbbac57fd303ca3434b Reviewed-on: https://gerrit.libreoffice.org/70521 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-10tdf#124238 - Show a Tip-Of-The-Day dialog on startupheiko tietze
New dialog Change-Id: If1e501de26eb5a9c20a59e621f9e805c3b5e2cf8 Reviewed-on: https://gerrit.libreoffice.org/69498 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-04-10clang-tidy: Silence warnings from WIP unhandled-self-assignment checkTamás Zolnai
Where it can be done by removing useless / duplicate code. For XFListStyle I removed the copy operator entirely, because it was bugous and it seems not to be used anyway. Change-Id: Iba0eb0d5c45b42f0e78be466c617acdc1216eb22 Reviewed-on: https://gerrit.libreoffice.org/70482 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-10tdf#42949 Fix IWYU warnings in include/vclGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. There were some changes since last run and some omitted files Change-Id: I666ac8ed7d06684e252ca590e3d7d454e9e10975 Reviewed-on: https://gerrit.libreoffice.org/70497 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-10vcl PDF import: clean up CompatibleWriterMiklos Vajna
It's cleaner to avoid member functions and constructors when we inherit from a C struct and we pass it to pdfium's C API. Change-Id: Iac9ab99b3d1b66241bb49d3a7707e242078ab5df Reviewed-on: https://gerrit.libreoffice.org/70472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-10clang-tidy: Fix suspicious catches of WIP unhandled-self-assignment checkTamás Zolnai
Change-Id: I1cb16b180f4cc5bf4d65485f03c44a06414d3580 Reviewed-on: https://gerrit.libreoffice.org/70481 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-09Just use the ResettableGuard's functions...Jan-Marek Glogowski
... instead of the nested MutexGuard and clear. Really had to look twice, that the MutexGuard and ResettableGuard use the same Mutex - who came up with this... yup myself. Change-Id: I70326772a9be8352f169a26467529a7c4100a20d Reviewed-on: https://gerrit.libreoffice.org/70385 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-09remove some usages of BitmapColor outside of VCLTomaž Vajngerl
You get BitmapColor only from reading pixels from a Bitmap and we want to avoid usage of Bitmap outside of VCL (and use BitmapEx as the alternative which will eventually replace Bitmap). Change-Id: Iddfa3ef739bfdd4dce5fb47fd9f67a5a36f3388b Reviewed-on: https://gerrit.libreoffice.org/70447 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-09n_children is count of toplevel nodesCaolán McNamara
Change-Id: I38302045bfe096781ce9c59c6f2dbe0a7625efda Reviewed-on: https://gerrit.libreoffice.org/70453 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-09tdf#103322 GlyphItem::m_aLinearPos use getX() instead of X()Alexander Farrow
GlyphItem::m_aLinearPos is a tools::Point variable. Eventually it will be changed to a basegfx::B2DPoint variable - to add support for sub pixel glyph positioning. basegfx::B2DPoint has the getX() method to retrieve a point's X coordinate. tools::Point has two methods to retrieve a point's X coordinate: 1. X() 2. getX() Both of these methods return the same value because getX() just calls X(). So any call to X() can replaced by getX() and vice versa. By replacing calls to X() with getX() now we won't have to make these changes later when we swap from tools::Point to basegfx::B2DPoint. Change-Id: Idfa0584cb3a7ce246b5499814b7e29f86167d8b8 Reviewed-on: https://gerrit.libreoffice.org/70436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-08IsInPopupMode returns true when !mbInPopupModeCaolán McNamara
it returns mbPopupMode which is set to false on the next event cycle after the one where mbIsInPopupMode is set to false Change-Id: I66b0812cb9b9fc5cfe00c88f145f704bd1ecce2f Reviewed-on: https://gerrit.libreoffice.org/70413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08pdf: always write resource dict for content streamsThorsten Behrens
Take out: - revert i#42884 workaround for AR5: use implicit resources in transparency groups Since verapdf complains with FAIL 6.2.2-2 in this case - missing resource dict for content stream. Change-Id: Ic186d2b4b393ac34f991a6747667332cf8f4658b Reviewed-on: https://gerrit.libreoffice.org/70391 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-08tdf#124567 Print dialog: distance & margin mixed upRasmus Jonsson
Change places of distance and margin input boxes (note: ids were set correctly, they were merely labelled incorrectly). Also moved the object in the .ui file to make it easier to read. Change-Id: I180d7afdf9dfb483f5dbfcf7ba68c73900499807 Reviewed-on: https://gerrit.libreoffice.org/70303 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-08improve combining in hash functionsNoel Grandin
specifically, use boost::hash_combine to combine values in hash functions, except for a couple of places where I use the small-prime-number strategy popular in the Java world, to avoid including boost in header files that are widely shared. Change-Id: I0e184c9ec8803bf09fc6e84fe20131b203e1652a Reviewed-on: https://gerrit.libreoffice.org/70384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06weld OTableSubscriptionDialogCaolán McNamara
Change-Id: Idf66a9e49471d6651c03deecc4fb2f9a722f512c Reviewed-on: https://gerrit.libreoffice.org/70325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06tdf#124579: ensure to provide an event to wake up main loop when notifyingMike Kaganski
Without that, Request::waitProcessMessages might wait indefinitely for Application::Yield() to return; while the latter would wait for a message in GetMessage. If there's no visible LO window, the message might never arrive by itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa Reviewed-on: https://gerrit.libreoffice.org/70346 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06crashtesting, threading crash with bitmapinfoaccess_null_ptr_deref.sampleCaolán McNamara
on export to .ods Thread 1: 5 0x00007f758fde4969 in raise () from /lib64/libc.so.6 6 0x00007f758fde5f98 in abort () from /lib64/libc.so.6 7 0x00007f758f485afd in __gnu_debug::_Error_formatter::_M_error ( this=0x7f7588872860 <__gnu_debug::_Error_formatter::_M_at(char const*, unsigned int)::__formatter>) at ../../../.././libstdc++-v3/src/c++11/debug.cc:1069 8 0x00007f7587b42922 in __gnu_debug::_Safe_iterator<std::__detail::_Node_iterator<ImpGraphic*, true, false>, std::__debug::unordered_set<ImpGraphic*, std::hash<ImpGraphic*>, std::equal_to<ImpGraphic*>, std::allocator<ImpGraphic*> > >::operator++ ( this=0x7f755a58e440) at /srv/crashtestdata/gccbuild/gcc8/include/c++/8.2.0/debug/safe_iterator.h:295 9 0x00007f7587b415d5 in vcl::graphic::Manager::registerGraphic (this=0x5fe9860, pImpGraphic=std::shared_ptr<ImpGraphic> (use count 1, weak count 0) = {...}) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:123 10 0x00007f7587b418e2 in vcl::graphic::Manager::newInstance (this=0x5fe9860) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:156 11 0x00007f758798c406 in Graphic::Graphic (this=0x7f755a58e6d0) at /home/buildslave/source/libo-core/vcl/source/gdi/graph.cxx:187 12 0x00007f758799c85a in ImpGraphic::loadPrepared (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1540 13 0x00007f758799c999 in ImpGraphic::ImplSwapIn (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1561 14 0x00007f758799c813 in ImpGraphic::ensureAvailable (this=0x80d2500) and a bunch of other threads looking like they've just come from the same family of methods Change-Id: Ic13d3c7cb2fb4adaa2a0a6b8845fc2156d53005e Reviewed-on: https://gerrit.libreoffice.org/70271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06tdf#119931 Fix accessibility warnings in printerpaperpage.uiRasmus Jonsson
Change-Id: If92bf6ac4c466524da2eab33440bf765b3d5d6f6 Reviewed-on: https://gerrit.libreoffice.org/70335 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-05Replace legacy dynamically-loaded functions with statically linked onesMike Kaganski
We don't need the dynamic load complexity for these now with baseline Windows version being Windows 7 SP1. Stuff used only for compatibility with older versions was dumped. Change-Id: I810f271796cfd875cfa18a3081c9ad444fe57b3e Reviewed-on: https://gerrit.libreoffice.org/70321 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05fix spinbox right press SVG - plus sign didn't define a colorTomaž Vajngerl
Change-Id: I1db6c5e4841530be7d46e8829899bf3f8cef8a3b Reviewed-on: https://gerrit.libreoffice.org/70293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-05support opacity for widget definition draw SVGsTomaž Vajngerl
This opacity influences the whole shape (stroke and fill). Change-Id: I82e10e07dbf2f321805b55a5f4831a513e52dab8 Reviewed-on: https://gerrit.libreoffice.org/70292 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04Revert "raise cairo baseline to 1.12.0"Caolán McNamara
This reverts commit 50580f452cc7c88a231831619a3f05958ce56460. Revert "raise cairo baseline to 1.10.0" This reverts commit 58a0e60dee0d27a699f856827c20b792417d3478. 32bit baseline is currently at cairo 1.8.8 Change-Id: I5156df6aee03dbbb2e209dbd5717a98580256170 Reviewed-on: https://gerrit.libreoffice.org/70260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04ios widget defs: update combobox, checkbox, spinbox SVGsTomaž Vajngerl
In addition remove spinbox pressed state (it wasn't useful) and draw white filled empty rect for spinbox as we don't draw the background automatically. Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944 Reviewed-on: https://gerrit.libreoffice.org/70258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>