summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2012-11-05fdo#46808, rename methodNoel Grandin
Rename utl::OConfigurationTreeRoot::tryCreateWithServiceFactory to utl::OConfigurationTreeRoot::tryCreateWithComponentContext Change-Id: Ib39b44b21d206b5fdfa4162106fbdeb30b1dd37c
2012-11-05replace %PRODUCTNAMECaolán McNamara
Change-Id: I2fa2786366adf0b3d8875baa98a9a558cdf497db
2012-11-05convert basic dialog to .uiCaolán McNamara
Change-Id: I1ed45e5990aca4be8b499fe300d7d43fda16bd6a
2012-11-01vcl/headless: [HACK] workaround solarMutexx splat with headless modeRiccardo Magliocchetti
Apply mmeeks temporary solution until a proper fix is found. With the patch applied unoconv testsuite runs fine. mmeeks analysis of the problem: It looks really interesting :-) it's hard to tell (from valgrind) where the threads were pre-empted [ actually logging that might be quite a nice feature to add to for valgrind ;-], but there is already the SolarMutex guard to try to stop this from happening. I append the odd trace with some thoughts. It is -possible- that we never get around to taking the solar mutex in the first instance in 'main' - such that by the time we come to release and re-take it in vcl/headless/svpinst.cxx: void SvpSalInstance::Yield( bool bWait, bool bHandleAllCurrentEvents ) the count is zero - could you add some fprintf debugging to check that - just dump nAcquireCount ==28574== Thread 1: ==28574== Invalid read of size 8 ==28574== at 0x739C702: SfxStateCache::SetState_Impl(unsigned short, SfxPoolItem const*, unsigned char) (statcach.cxx:454) ==28574== by 0x738042E: SfxBindings::UpdateControllers_Impl(SfxInterface const*, SfxFoundCache_Impl const*, SfxPoolItem const*, unsigned short) (bindings.cxx:1500) ==28574== by 0x7383C5B: SfxBindings::Update_Impl(SfxStateCache*) (bindings.cxx:437) ==28574== by 0x7383FD7: SfxBindings::NextJob_Impl(Timer*) (bindings.cxx:1646) ==28574== by 0x92BF4AD: Timer::ImplTimerCallbackProc() (timer.cxx:142) The YieldMutex -should- be held at this point excluding this other thread (?). ==28574== by 0x95D152D: SvpSalInstance::CheckTimeout(bool) (saltimer.hxx:57) ==28574== by 0x95D17D7: SvpSalInstance::Yield(bool, bool) (svpinst.cxx:288) ==28574== by 0x92B4530: Application::Yield(bool) (svapp.cxx:434) ==28574== by 0x92B45E6: Application::Execute() (svapp.cxx:413) ==28574== by 0x50AED58: desktop::Desktop::Main() (app.cxx:1711) ==28574== by 0x92BDFB8: ImplSVMain() (svmain.cxx:173) ==28574== by 0x92BE8E4: SVMain() (svmain.cxx:210) ==28574== by 0x50E1CF4: soffice_main (sofficemain.cxx:83) ==28574== by 0x40069A: main (main.c:25) ==28574== Address 0x1466bdc8 is 56 bytes inside a block of size 72 free'd ==28574== at 0x4C27FF2: operator delete(void*) (vg_replace_malloc.c:387) ==28574== by 0x737F479: SfxBindings::DeleteControllers_Impl() (bindings.cxx:325) ==28574== by 0x7380572: SfxBindings::~SfxBindings() (bindings.cxx:264) ==28574== by 0x7380718: SfxBindings::~SfxBindings() (bindings.cxx:275) ==28574== by 0x758B91E: SfxFrame::DoClose_Impl() (frame.cxx:178) ==28574== by 0x75AAFC1: SfxBaseController::dispose() (sfxbasecontroller.cxx:1041) sfx2/source/view/sfxbasecontroller.cxx: This method has a live: SolarMutexGuard aGuard; ==28574== by 0x16B8E785: framework::Frame::setComponent(com::sun::star::uno::Reference<com::sun::star::awt::XWindow> const&, com::sun::star::uno::Reference<com::sun::star::frame::XController> const&) (frame.cxx:1380) ==28574== by 0x16B8E1CF: framework::Frame::close(unsigned char) (frame.cxx:1633) ==28574== by 0x758BE87: SfxFrame::DoClose() (frame.cxx:140) ==28574== by 0x797F51C: SfxBroadcaster::Broadcast(SfxHint const&) (brdcst.cxx:49) ==28574== by 0x7511211: SfxModelListener_Impl::notifyClosing(com::sun::star::lang::EventObject const&) (objxtor.cxx:173) ==28574== by 0x7534972: SfxBaseModel::close(unsigned char) (sfxbasemodel.cxx:1491) ==28574== by 0x1E776909: SwXTextDocument::close(unsigned char) (unotxdoc.cxx:578) ==28574== by 0x7537FB0: SfxBaseModel::dispose() (sfxbasemodel.cxx:788) ==28574== by 0x1211D6E7: gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, unsigned int, double*, unsigned int) (callvirtualmethod.cxx:128) ==28574== by 0x12120FEE: cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (uno2cpp.cxx:246) ==28574== by 0x12121ACD: bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (uno2cpp.cxx:440) ==28574== by 0x15D5CE5E: binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const (incomingrequest.cxx:251) ==28574== by 0x15D5D8AB: binaryurp::IncomingRequest::execute() const (incomingrequest.cxx:80) ==28574== by 0x15D61B4C: request (reader.cxx:89) ==28574== by 0x663A506: cppu_threadpool::JobQueue::enter(long, unsigned char) (jobqueue.cxx:115) ==28574== by 0x663B00D: cppu_threadpool::ORequestThread::run() (thread.cxx:179) ==28574== by 0x663B4E9: threadFunc (thread.hxx:196) ==28574== by 0x4E467AE: osl_thread_start_Impl (thread.c:261) ==28574== by 0x5E53EFB: start_thread (pthread_create.c:304) ==28574== by 0x5B8E89C: clone (clone.S:112) Change-Id: I84aea49aff1dbc6c0d34e522d57d5af90eebfc62
2012-11-01Resolves: fdo#54466 right-aligned label text slightly clipped on rightCaolán McNamara
aae8a0c8ea27a1a6451c28d66de1ee7f0f0323ef with rather unhelpful "#99188# enlarge textrect to get rid of rounding problems" comment appears to be the root. Lets assume that commit is necessary and just adjust alternatively for right align Change-Id: I0b60c12199226ca757596c034599b81c1a4db433
2012-10-31fdo#46808, Deprecate configuration::ConfigurationProvider old-style serviceNoel Grandin
...in favor of existing new-style configuration::theDefaultProvider singleton. Theoretically, ConfigurationProvider instances can be created with specific Locale and EnableAsync arguments, but this is hardly used in practice, and thus effectively all uses of the ConfigurationProvider service use the theDefaultProvider instance, anyway. theDefaultProvider is restricted to the XMultiServiceFactory interface, while ConfigurationProvider also makes available XComponent. However, dispose must not be called manually on theDefaultProvider singleton anyway, and calls to add-/removeEventListener are so few (and in dubious code that should better be cleaned up) that requiring an explicit queryInterface does not really hurt there. This commit originated as a patch by Noel Grandin to "Adapt configuration::ConfigurationProvider UNO service to new style [by creating] a merged XConfigurationProvider interface for this service to implement." It was then modified by Stephan Bergmann by deprecating ConfigurationProvider instead of adding XConfigurationProvider and by replacing calls to ConfigurationProvider::create with calls to theDefaultProvider::get. Change-Id: I9c16700afe0faff1ef6f20338a66bd7a9af990bd
2012-10-31default ScrolledWindow to autoscrollCaolán McNamara
Change-Id: I5297e4b9480066000bf6d72e54a5d8117528b90c
2012-10-31support cursor-visible propertyCaolán McNamara
Change-Id: I2dfb2fa16c64035ef529cec650df7e4bd9c80483
2012-10-31Get rid of vcl::unohelper::GetMultiServiceFactoryStephan Bergmann
...which effectively is just a glorious wrapper around comphelper::getProcessServiceFactory. In turn gets also rid of ImplSVAppData's mxMSF and mpMSFTempFileName and the rSMgr parameter to InitVCL. All the VCL users "soffice", "spadmin", and "unopkg gui" appear to still work fine. Change-Id: I797d48f7d0d8c35bb82124c9ab0ee63850c4d863
2012-10-30fdo#46808, Adapt linguistic2::LinguServiceManager UNO service to new styleNoel Grandin
Create a merged XLinguServiceManager2 interface for this service to implement. Which is backwards-compatible, but does not require creating a new service. Change-Id: I297bada1066cd74809108641b56ee4d5898112ec
2012-10-30trivial empty-init String::Fill -> comphelper::padToLengthCaolán McNamara
Change-Id: I6c41b8f4d3ad739eff545063bd1f8fe8f4fba65e
2012-10-29fdo#46808, Adapt i18n::LocaleCalendar UNO service to new styleNoel Grandin
Did not need to create a new interface, because XCalendar3 already covers the whole service interface. Change-Id: Iaf094014c16e872d2003ca6e8e7588abd081d882
2012-10-28UniString->rtl::OUStringBufferCaolán McNamara
Change-Id: I9938d7c4ab5594baeb10f405f0aa0964ef84d6c5
2012-10-26fix fractured commentCaolán McNamara
Change-Id: Ib4227a74232b1ba6ca48d037340c4a7441ab08e7
2012-10-26add hook to block use of markup in .ui filesCaolán McNamara
Change-Id: Ia7eed5e9e1f8fba9876730e909461dabc167deb9
2012-10-26set width in chars for url field to avoid character dialog overgrowingCaolán McNamara
Change-Id: I892a77f65ad420d0fbf4b95179e4bcfc2ec55192
2012-10-25graphite: convert to gbuildMatúš Kukan
Change-Id: I47c279d1cf53ef2c092467070d97b13f949d06f6
2012-10-25vcl: don't print gtk version on startupMiklos Vajna
All the other messages are already > 1, makes no sense to have this as > 0. Change-Id: I816239903cef650f34d9c57446018843e2acb64a
2012-10-25remove .ui mark-up in favor of font attributesCaolán McNamara
so we can keep translations markup free, and it matches better our existing font use in controls Change-Id: Ib762030f8bf831f2b0afabdd643508e660ad9266 See: https://live.gnome.org/GnomeGoals/RemoveMarkupInMessages
2012-10-25convert Mnemonic markup automaticallyCaolán McNamara
Change-Id: I55b6bf11468ce958aea7c98894d3a76343b53a9a
2012-10-24vcl: uipreviewer: remove spurious "return false"Michael Stahl
Change-Id: Ie853d55f78f27a7249b8e960587c8d2bd833d1a7
2012-10-24honour padding property in VclBoxCaolán McNamara
Change-Id: Ie387898535ec8f638c4a2a2785cdb39273136f0e
2012-10-24fdo#46808, Adapt awt::Toolkit UNO service to new styleNoel Grandin
Create a merged XToolkit2 interface for this service to implement. Which is backwards-compatible, but does not require creating a new service. Also mark sub-interfaces as non-optional. Change-Id: I278d0288e92be277033013302267cf93f7d70480
2012-10-24convert index dialog to .uiCaolán McNamara
Change-Id: I4b16cb517dca25f862b9dd612785dae4d0f21793
2012-10-24improve optimal height of empty comboboxesCaolán McNamara
Change-Id: I481e079136ab0496ac79b60931bfce8509b4af23
2012-10-24refactor buttonbox calculations to allow nonhomogeneous buttonsCaolán McNamara
Change-Id: If0f3c09a2fb6577615f33576fee1dde5b627ca82
2012-10-24merge and correct buttonbox spacing calculationCaolán McNamara
Change-Id: Ibd378c85c6b7cf774ed2a6f652264a2a78bfe366
2012-10-24map some more stock imagesCaolán McNamara
Change-Id: I19fbc2062b2857e194d5850f2febea514fde50d9
2012-10-24fdo#46808, convert comphelper::ConfigurationHelper to XComponentContextNoel Grandin
Convert the helper methods to take an XComponentContext parameter, instead of XMultiServiceFactory. Change-Id: I9f0098af37b91f107d8799f14caa04756eac82b1
2012-10-23fdo#46808, use service constructor for i18n::BreakIteratorNoel Grandin
Note that I found a pre-existing bug in linguistic/source/gciterator.cxx but I was not able to fix it, because doing so appears to expose bugs elsewhere! Change-Id: I17fb9108d98a98d0ae13fe5a8e043d2db5b27a6a
2012-10-22disable cursor in about dialog and message boxesIvan Timofeev
Change-Id: I060872e0a468f2ce26a2ab519c5bfe271574170b
2012-10-22Resolves: rhbz#868479 / fdo#56281 doubled ~ in German ok/cancel translationsCaolán McNamara
We have unix-specific code adding ~ to OK/Cancel. So don't add ~ if string already contains those. Though its an open question if the presence of ~ is a bad thing for the Windows case. i.e. if we should have tooling to not allow the OK/Cancel translations to contain ~ in the first place, of if we should drop the ifdef UNX and do it globally now Change-Id: I461c6ac9ca574ed188f51472919be82ec582e389
2012-10-22explictly require Bitmap to get imageCaolán McNamara
Change-Id: I0f7e0510f6c946be7cf930659db961d3c17e1c4f
2012-10-22-Werror,-Wtautological-constant-out-of-range-compareStephan Bergmann
Change-Id: I320c11d4b3d295c65dcd966f70a2de4f05926ebb
2012-10-22implement secondary button groups in buttonboxesCaolán McNamara
Change-Id: I0e60b7e197ba4f6ebd3f24cb2e9072ce3e1353fb
2012-10-22add infrastructure for secondary button groupsCaolán McNamara
Change-Id: I5fd1bbc31a0259e92f6eb23beef5d3c77b74eed8
2012-10-22add a stock index image to vcl, ala gtk-indexCaolán McNamara
Change-Id: I96cd80f14d557752c19b88bb2c99298d7c3e3e0b
2012-10-21Fix Variable 'eState' is reassigned a value before the old one has been usedJulien Nabet
See http://nabble.documentfoundation.org/Cppcheck-report-in-vcl-unx-gtk-gdi-salnativewidgets-gtk-cxx-td4014513.html Change-Id: I9f59ed1fa0cd325d65f5574332b19625b27f8900
2012-10-21Some cppcheck cleaningJulien Nabet
Change-Id: I5c119795077f9fbb84c32bc6ca95533d689998b9
2012-10-21Fix some Variable "X" is reassigned a value before the old one has been usedJulien Nabet
Change-Id: I2fbdf26441f64183676035692391e65db0efe069
2012-10-20use correct deferred parent windowCaolán McNamara
Change-Id: Id9d56d9f014cee216f1478d764082b97ddd30b01
2012-10-20deliberately no parent for dialogCaolán McNamara
Change-Id: Id28797b9c40694e1b43d1fdd1205833562d760b9
2012-10-19In the 10.7 SDK CoreText is in the ApplicationServices frameworkTor Lillqvist
Although I don't understand why this worked before, huh. Change-Id: I67ea314330630f331acaabd1c47128de6e340bb2
2012-10-19fdo#44657 Remove hack that "simulates" a mirrored horizontal scrollbar.Jan Holesovsky
We are able to paint mirrored scrolbars with the 'gen' plugin, so just fix the rendering of the scroolbar with the Gtk+ plugin. Change-Id: I5dbd13420c6290e165ed2f5827769979298abf37
2012-10-19replace sxub_Unicode by sal_UnicodeNorbert Thiebaud
Change-Id: Icf4b434a1961cc4964ee6e362491868e898a1831 Reviewed-on: https://gerrit.libreoffice.org/887 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2012-10-18support width-chars property for labelsCaolán McNamara
Change-Id: Iba51f30a5e74d1e486bce10901ccb58f3488ce97
2012-10-18minimize calls to queue_resizeCaolán McNamara
Change-Id: Idbb7da30c985253a37ff6fe0e86fe04dec2dbbeb
2012-10-18SetMaxWidthInChars should be SetMinWidthInCharsCaolán McNamara
Change-Id: I5cf508e7930eb7e04016ffa43683f76a07e5173e
2012-10-18add stock new and edit button textsCaolán McNamara
Change-Id: Ia8f5f6592211e50323de66a4177f752a1adcf584
2012-10-17XubString->OUStringCaolán McNamara
Change-Id: I45ddca425871eb19aabd9876b64c2e2dac5bc774