summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-10-14Fix typosAndrea Gelmini
Change-Id: I8f689ba1a26b2380b1962a47837b943fbefbd6b6 Reviewed-on: https://gerrit.libreoffice.org/43383 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-13tdf#107605: Fix reading version 0 OS/2 font tableKhaled Hosny
The version 0 table os exactly 78 bytes since it does not have any of the extra fields from the later versions. Change-Id: Ie2e478bdefb201b988dc0844240d4ff193d66583 Reviewed-on: https://gerrit.libreoffice.org/43374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-13WIN fix redraw during window move and resizeJan-Marek Glogowski
During window move and resize, Windows spawns a nested message loop, blocking our direct processing. In this case we switch to timer messages for all timeouts. But if LO is busy with background jobs, the posted 0ms timer messages will block any system event processing, halting any updates until we're idle again. So for these cases we switch to the WM_TIMER based SetTimer timer. Change-Id: I854f4984d7c75d6829f82cda5cb4479967edce48 Reviewed-on: https://gerrit.libreoffice.org/43350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-13tdf#112975 WIN correctly handle VclInputFlags::OTHERJan-Marek Glogowski
On Windows we can just check the message queue for existing messages. But VclInputFlags::OTHER is used to check for any messages, which can't be explicitly checked. In the case of checking for VclInputFlags::OTHER while excluding an other message type, we have to make multiple PeekMessage calls and exclude all non-checked message ids. Change-Id: I1cedd4b76444769842c74228fc547f0d924f8b60 Reviewed-on: https://gerrit.libreoffice.org/43337 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-13WIN another system loop integration attemptJan-Marek Glogowski
This time we skip the intention to handle our Scheduler completely via the system event loop. Instead we basically guarantee to process a Scheduler event during each DoYield, if one is available. This way we won't block system events when busy in our event loop. Change-Id: I37094e61cbf928733151d9cc3299cdac76b3a5cd Reviewed-on: https://gerrit.libreoffice.org/43349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-13Fix typoAndrea Gelmini
Change-Id: Icb23e192961aadcd23d17546aa397df18dd32979 Reviewed-on: https://gerrit.libreoffice.org/43366 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-10-13tdf#110742 add support for icon themes via extension managerCaolán McNamara
Change-Id: Ic33c086ef67cdcb634d9f03f84799c234fe3beec Reviewed-on: https://gerrit.libreoffice.org/43341 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-12Notebookbar: allow only one tab lineSzymon Kłos
Change-Id: I5f671bdc34e5852af06c99db93e859e8cf837c0d Reviewed-on: https://gerrit.libreoffice.org/43009 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-10-12prevent crash while disposing ListControl when children are disposedMarkus Mohrhard
Change-Id: I9e69d0b29ab41428d87bf37edeebe652f7e9c297 Reviewed-on: https://gerrit.libreoffice.org/43251 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-12allow adding a menu to a modal dialogMarkus Mohrhard
Change-Id: I3da2ec747f73c44bf7bcb8a7ec3d116272dc806f Reviewed-on: https://gerrit.libreoffice.org/43252 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-11Replace list by vector fontconfig/manager (vcl)Julien Nabet
+ refactor a bit "analyzeFontFile" to return a vector of std::unique_ptr<PrintFont> instead of just a bool Change-Id: I9c8c307c5c323e40667359f5094672c1cde589fd Reviewed-on: https://gerrit.libreoffice.org/43317 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-10-10add a method to get all entries from ListControlMarkus Mohrhard
Change-Id: I9ff73dab53f5769270e8eb32889314e9c61a1828 Reviewed-on: https://gerrit.libreoffice.org/43254 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-10store vcl::Window in ListControl to allow adding VclContainerMarkus Mohrhard
Change-Id: Ib7f145ae1137ec29749e0a60a21e84dd747ac5c1 Reviewed-on: https://gerrit.libreoffice.org/43253 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-10iOS, solve missing vcl referencesjan Iversen
needed more dummy stuff Change-Id: I96392415a8f778be3ef1a44fb485d27049f7f324
2017-10-09tdf#112939 Color on drop-down color chooser is always blackNoel Grandin
regression from commit 404630c6052919c1a0b5dab405084c2a39fc2f5c simplify Bitmap operator==/IsEqual (stage1) Change-Id: Ifabbfb28e0ccbe28b19db7f2c50e6d6f55569f9a Reviewed-on: https://gerrit.libreoffice.org/43239 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-09tdf#112931 always signal AllUserEventsProcessedJan-Marek Glogowski
If the last user event triggers a nested event loop, there is no event in the nested loop, but AllUserEventsProcessed will not be signaled, resulting in a busy loop in the gtk backend. So just always signal AllUserEventsProcessed, if it was not yet signaled. While at it catch and std::abort on uncaught exceptions and fix the default to have been signaled, so we won't signal on an empty list on first run. Change-Id: I480da906d87d3b95ba30b4c18420d2e20ffb5b2e Reviewed-on: https://gerrit.libreoffice.org/43282 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-09shrink bmp fuzzerCaolán McNamara
Change-Id: I9119c61f80631bb57bc8eade552a4d88b0c699df Reviewed-on: https://gerrit.libreoffice.org/43288 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-09shrink png fuzzerYour Name
Change-Id: I61b89eae0131c000c0a9861ab245fa21e5febc0b Reviewed-on: https://gerrit.libreoffice.org/43287 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-09shrink xpm fuzzerYour Name
Change-Id: Iacae6fa5135c427ad22d185658c25f44af2ac5d0 Reviewed-on: https://gerrit.libreoffice.org/43286 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-09shrink xbm fuzzerCaolán McNamara
Change-Id: I0f17bd2b931a6216c749fbb0db5f29fd20486ef1 Reviewed-on: https://gerrit.libreoffice.org/43281 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-09shrink gif fuzzerCaolán McNamara
Change-Id: I68561045548bfcff509d439837b7f31c650796f7
2017-10-09shrink jpg fuzzerCaolán McNamara
Change-Id: I1222f17cd3cb692db41416fe152c11a8f9a4a290 Reviewed-on: https://gerrit.libreoffice.org/43273 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-09allow adding the ListControl through UI filesMarkus Mohrhard
Change-Id: Ie97b027860e02cf774dc71fae6599342b8a380c4 Reviewed-on: https://gerrit.libreoffice.org/43258 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-10-08knock 200M off wmf fuzzerCaolán McNamara
Change-Id: I78f642071eb2dbcb5127d7df5839dfade158cac9
2017-10-08Make Color a forward declarationChris Sherlock
Change-Id: Ib28833555661b119de8e967b05e3c8691fca826a Reviewed-on: https://gerrit.libreoffice.org/43227 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-10-06Process all pending events during Cppunit setUpJan-Marek Glogowski
Larger unit tests collect a lot of events, which are just processed on shutdown. But since the Scheduler is just an unsorted linked list, processing these in order is O(n^2) for lookup, which really adds up, e.g. sw_ooxmlexport8 has 35047 tasks on shutdown. So this just processes all pending events before running each unit test. Also adds missing spellchecking components to some calc tests. Change-Id: Icf12146015afc17a1f52f79c18f248b72650ad46 Reviewed-on: https://gerrit.libreoffice.org/43199 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06KDE update system loop integrationJan-Marek Glogowski
This updates the system loop integration to be on par with the other backends. This includes: 1. Process LO user events before other LO events 2. Correctly handle elapsed QTimer events 3. Don't wait-yield in the main thread from a non-main thread Change-Id: Ia17be032ae39dc4c7bfa44cadd22d85a1b9c4fbd Reviewed-on: https://gerrit.libreoffice.org/43198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-06coverity#1418966 static_cast should be sufficientCaolán McNamara
Change-Id: Ieae8695cb36b1779f1b8437bddb887cd24d621e8
2017-10-06Improve performance of loplugin:commaoperatorStephan Bergmann
...by avoiding calls to parentStmt, thereby also improving the precision of exactly which comma operators to ignore (which turned up a handful more finds). Also added tests. Change-Id: Ie74f824fd7f54131aab09b59086452fb4f3ff827 Reviewed-on: https://gerrit.libreoffice.org/43181 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-10-06gtk3+hidpi: ScreenSize is in real pixels, scale it downCaolán McNamara
Change-Id: I867425bfd20ec67f76e570a6e71e11c437af427c Reviewed-on: https://gerrit.libreoffice.org/43174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05Resolves: tdf#86547 width of button box is taken before spacing addedCaolán McNamara
Change-Id: I2497dfcea98682db7e507704227052c13a18d9dd Reviewed-on: https://gerrit.libreoffice.org/43168 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05Rename and move SAL_U/W to o3tl::toU/WMike Kaganski
Previosly (since commit 9ac98e6e3488e434bf4864ecfb13a121784f640b) it was expected to gradually remove SAL_U/W usage in Windows code by replacing with reinterpret_cast or changing to some bettertypes. But as it's useful to make use of fact that LibreOffice and Windows use compatible representation of strings, this commit puts these functions to a better-suited o3tl, and recommends that the functions be consistently used throughout Windows-specific code to reflect the compatibility and keep the casts safe. Change-Id: I2f7c65606d0e2d0c01a00f08812bb4ab7659c5f6 Reviewed-on: https://gerrit.libreoffice.org/43150 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-10-05tdf#112890 some dialog don't appear under gtk2Caolán McNamara
Change-Id: I90a59bfdaec0e78d93888e5cc30d1c7fa147a7e7 Reviewed-on: https://gerrit.libreoffice.org/43162 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05Minimize GtkSalData scope in timeout callbackJan-Marek Glogowski
After commit 2e8a95d1f87a3dbdcc8846fa44d1899abc8edd9c this doesn't anymore generate false positives in the constparams clang plugin: vcl/unx/gtk/gtkdata.cxx:817:39: error: ... ... this parameter can be const [loplugin:constparams] static gboolean call_userEventFn( void *data ) ^~~~~~~~~~ 1 error generated. /vcl/unx/gtk3/gtk3gtkdata.cxx:782:39: error: ... ... this parameter can be const [loplugin:constparams] static gboolean call_userEventFn( void *data ) ^~~~~~~~~~ 1 error generated. Change-Id: Id8d42a0c14bfcc887ec1ecbf70f4c41c26e26efb Reviewed-on: https://gerrit.libreoffice.org/42912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-05Blind fix for MSVC warning C4211Stephan Bergmann
..."nonstandard extension used: redefined extern to static", after the 'static' in the friend declaration had to be removed for clang-cl with e5d943d984bb0918f971eec45f45384cc0c72b67 "'static' is invalid in friend declarations" Change-Id: I14524ec0a5d8e7e12c5b506cbf7ac43508ae26ae
2017-10-05Related: tdf#112063 validation dialog legitimally changes modalityCaolán McNamara
so to keep tdf#112063 working as with... commit e66c9aa362c1e8729d76090023960610321b14f3 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Sep 1 16:23:20 2017 +0100 Related: tdf#112063 unsetting and resetting gtk modality is a problem for gtk3, so just set it on execute and no need to unset and reset it for whatever vcl nuttiness the existing code is doing then let the proper calls to SetModalInputMode call the frame modality switch and the hackery vcl calls the underlying vcl-specific body as ImplSetModalInputMode Change-Id: I853ca50e0d9830ca7ba3077e243ccdee6e84e696 Reviewed-on: https://gerrit.libreoffice.org/43142 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-05loplugin:finalclasses in vclNoel Grandin
Change-Id: I7de9cd6c5569217aa8d379c6d112cd1874bca8e2 Reviewed-on: https://gerrit.libreoffice.org/43151 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-05'static' is invalid in friend declarationsStephan Bergmann
Change-Id: I993e4dd219e247ca33022010da350f565c5e0dcf
2017-10-05Missing #include <tools/time.hxx> (--disable-pch)Stephan Bergmann
Change-Id: I8cf1092bb2a5718b90fda8925eeb5dd281842b70
2017-10-04It's called 'DirectWrite', one wordTor Lillqvist
Change-Id: I4892da38182295ca474e89bb061f713039cfd8e1
2017-10-04add << operator for css::uno::ExceptionNoel Grandin
Change-Id: Ia23dafd07133779144965682df3b7125a3214235 Reviewed-on: https://gerrit.libreoffice.org/43046 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-10-04Convert tick-based timer events to versioned onesJan-Marek Glogowski
Instead of storing the system ticks in the timer event message simply store a version. Moves the version handling code into a VersionedEvent class, inherited by WinSalTimer and AquaSalTimer. Change-Id: I5add85031d36b3424a26a9ef798294cbfb00b2e4 Reviewed-on: https://gerrit.libreoffice.org/42959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-10-04don't add WB_CLIPCHILDREN to toplevel dialog builder creationCaolán McNamara
Change-Id: I402ebea3acf6ca7f4d61785944c933663b35e1f3 Reviewed-on: https://gerrit.libreoffice.org/43125 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-10-04Revert "check for unnecessary DLLPUBLIC annotations"Stephan Bergmann
This reverts commit a599eeab786ecbe1b5b6509e3c792e5c1ba31248, plus follow-up fa4431449d0306e8179f53a2a69c549800bd24bd "Avoid bogus loplugin:dllmacro 'unnecessary *DLLPUBLIC declaration ...'". See (abandoned) <https://gerrit.libreoffice.org/#/c/42983/> "loplugin:dllmacro: Handle implicit member functions" how this would have needed to be extended to give consistent results across Linux and macOS, but then would have started to remove DLLPUBLIC from entities that apparently need to at least have default type visibility on macOS and started to make tests fail.
2017-10-04loplugin:redundantcastStephan Bergmann
Change-Id: Ia00af1b79ac30ca00345f52a1981d3bfc1620f76
2017-10-04tdf#95656 fix orientation for Bopomofo tonal marksMark Hung
A few Spacing Modifier Letters ( 0x2ca, 0x2c7, 0x2cb, 0x2d9 ) are used as Bopomofo tonal marks. This patch force their vertical orientation property to be transformed upright. This patch also set the script type of them to WEAK to keep them with nearby Bopomofo symbols in the same portion. Change-Id: Ib226ebbcaf140124dee806dd6b2859150eb53f67 Reviewed-on: https://gerrit.libreoffice.org/43001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-04tdf#112486 Do not force GDI in no OpenGLXisco Fauli
See: http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html Change-Id: I19bb4b58d2260fd23c32a687a9f504540c229985 Reviewed-on: https://gerrit.libreoffice.org/42897 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-03tdf#107605: Fix line height cslculation for broken fontsKhaled Hosny
Change-Id: I06368dd15d7898dda61bc07b0f96bf82b00733b9 Reviewed-on: https://gerrit.libreoffice.org/43095 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-10-03convert WB_FORCECTRLBACKGROUND to bool field on EditNoel Grandin
Change-Id: I7a8731635bd22926df98cd70c8bb850408c1854c Reviewed-on: https://gerrit.libreoffice.org/43076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-10-03WB_DOCKBORDER is deadNoel Grandin
the only place that passes it to a window class, does so to a window class that does not implement that style. Change-Id: I74d705ed928b797c3456cf23a8074c62d0c12247 Reviewed-on: https://gerrit.libreoffice.org/43072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>