summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-09-28wmf spec says that these are only allowed bitcount valuesCaolán McNamara
Change-Id: Ia174feec73ee676567a3632d2f88b11c176b6363 (cherry picked from commit b107353addfe35cc40864b7fb5ff4fee42fff6cf) Reviewed-on: https://gerrit.libreoffice.org/18903 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-17don't crash with unknown out color spaceCaolán McNamara
Change-Id: Ib066ff1fad686d611a86510e768b1109ef7a5e75 (cherry picked from commit 7aa2f8c75d7bda103748fa73766a30fd77e50c16) Reviewed-on: https://gerrit.libreoffice.org/18641 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-09-14tdf#92505 vcl: fix substituting missing glyphsMiklos Vajna
Commit a6b00d16eb27a5e7e31c721671001a909ecef960 (Related bnc#822625: Cache FontEntry with the original FontSelectPattern.) and the follow-up 16a62079018aea0e72636bdb00576487b4e830b9 (Oops, this reference can't be const., 2014-05-28) changed the font cache key, so that it's directly what was the argument to ImplFontCache::GetFontEntry(), which leads to missing glyphs in the bugdoc, e.g. the 4 check mark characters are rendered as a check mark only in the DejaVu Sans case on my machine, the other 3 cases result in placeholders. Fix the problem by changing back the key to aFontSelData, which is possibly modified in ImplFontCache::GetFontEntry() before used as a key. Change-Id: I80eb4ba0f986a10100b6ae421d1346f235ce83b7 (cherry picked from commit e047caf4bb461fb168d9fe08228c049938ca1698) Reviewed-on: https://gerrit.libreoffice.org/18561 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-09-04Fix mis-mergeStephan Bergmann
...where fb6f2e1109abdd09e80dbcd6660a9530fc06ff0f "Resolves: #i121407# Gallery reorganizations..." first cherry-picked the younger 8012fae6cedcf325130d70adf0a486e8918f452f before f7d373d18f965b36f310d44044bdba6476f6eb03 "Added ColorDepth change test with assertion to the Bitmap::Scale method" then cherry-picked the older 4be8cc079667cca2cae91dba9e46c16ccff1537f, leading to the two checks at the top of Bitmap::Scale to not return early as intended. Thanks to clang-tidy clang-analyzer-deadcode.DeadStores for flagging this. Change-Id: Id89cc517a9f7efdff040c70f3b0e640d969cf24d (cherry picked from commit 0aa9cd69598e1c022aa676f81dc7bc2f03e58b2c) Reviewed-on: https://gerrit.libreoffice.org/18311 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-09-02check stream statusCaolán McNamara
Change-Id: I27bb289288d319a93201e9c3d703114924ca258c (cherry picked from commit daf1578d752531e2b48d183531d9a4a7cedfc37e) Reviewed-on: https://gerrit.libreoffice.org/18178 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-31vcl: Improve management of mnRef0Count.Jan Holesovsky
Follow-up to 34700400247e378e074ce4164ab2809edb092201; this fixes sw_ww8export unit test on Windows. Reviewed-on: https://gerrit.libreoffice.org/18175 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 44377b911f9e19e43f14e390b69db4055f423b6a) Signed-off-by: Michael Stahl <mstahl@redhat.com> Change-Id: Ic0c3228efb59a182e1562b73117418cd8b5e6017
2015-08-29vcl: fix resource management issue in WinSalLayoutMichael Stahl
Since commit 65a66d41fd0e13d0aad9df935091b731b4af650a the sd_exports_test crashes on Windows in UniscribeLayout because it uses a ImplFontEntry that has been removed from the font cache. Tweak the refcount in WinLayout so it will be valid. (cherry picked from commit 34700400247e378e074ce4164ab2809edb092201) Change-Id: Ic4bf984ea9fd70de9fa95ca964ae12d95d47d5bf Reviewed-on: https://gerrit.libreoffice.org/18120 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-08-28don't loop on overly-short nEndPosCaolán McNamara
Change-Id: I60d3388ece28a69c31a85b9e3b495cbe8a03e7dc (cherry picked from commit 42732d255423700461f4abadfed77d89efa9cdd0) Reviewed-on: https://gerrit.libreoffice.org/18084 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-08-24tdf#89381 Revert "vcl: SalGraphics::mirror() - always use GetGraphicsWidth()"Maxim Monastirsky
This reverts commit 28effca640fff262866d1d3ada6e51a3821a6725. Change-Id: Ie21ae1ef969b2cfdce81a152c195a69ad3c27f65 Reviewed-on: https://gerrit.libreoffice.org/17937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d2c09305084c218facdd282c3232a9929b81e342) Reviewed-on: https://gerrit.libreoffice.org/17961
2015-08-20rhbz#1247588: Hold UNO objects by css::uno::ReferenceStephan Bergmann
...instead of raw pointer and manual acquire/relase. It is unclear to me why the original code thought it was necessary (or merely "better") to hold by raw pointer; but at least from the backtrace in rhbz#1247588, it seems plausible that UNO method calls through such raw pointers could recursively call into atk_object_wrapper_dispose and make the raw pointer stale. (cherry picked from commit 07ebec47da4a096aaab53bf6a90bb219ce29bfbf) Conflicts: vcl/unx/gtk/a11y/atkaction.cxx vcl/unx/gtk/a11y/atkcomponent.cxx vcl/unx/gtk/a11y/atkeditabletext.cxx vcl/unx/gtk/a11y/atkhypertext.cxx vcl/unx/gtk/a11y/atkimage.cxx vcl/unx/gtk/a11y/atkregistry.cxx vcl/unx/gtk/a11y/atkselection.cxx vcl/unx/gtk/a11y/atktable.cxx vcl/unx/gtk/a11y/atktext.cxx vcl/unx/gtk/a11y/atktextattributes.cxx vcl/unx/gtk/a11y/atkutil.cxx vcl/unx/gtk/a11y/atkvalue.cxx vcl/unx/gtk/a11y/atkwrapper.cxx Change-Id: Idc0a4f9e2f7ffe610261c1b7b98ce9c5e040db43 Reviewed-on: https://gerrit.libreoffice.org/17764 Tested-by: Eike Rathke <erack@redhat.com> Reviewed-by: Eike Rathke <erack@redhat.com>
2015-08-18tdf#88831 fix inverted textures when OpenGL is enabledTomaž Vajngerl
GLX returns a wrong value if the y coords are inverted. Most other programs don't even ask for this (gnome-shell for example) and just assumes "true" (and this works because most relevant X servers work like this). We make this more robust and assume true only if the returned value is GLX_DONT_CARE (-1). (cherry picked from commit f7f0486376adbabf3ea66bfd8a7b692c335ec3c8) Change-Id: I4800b3364fd00f5f4a8f5a459472bfa8d97827ba Reviewed-on: https://gerrit.libreoffice.org/17707 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-08-16limit access to dx array to min of input len and len of arrayCaolán McNamara
i.e. the sal_Int32 nDXLen = std::min<sal_Int32>(nLen, aOldDX.size()); line and its usage Change-Id: Ib0100d2de210a45b340c3a7de6c6dcf2a07443d0 (cherry picked from commit 6d4f97b05b1bfe5aae395134b2dc35805c23b8c4) Reviewed-on: https://gerrit.libreoffice.org/17752 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-15tdf#44621: Fixed drag and drop in OSX 10.7+mmeof2
Change-Id: I8f9e1e9205dd9611f4bc1ef47c8cde2e284b403f Reviewed-on: https://gerrit.libreoffice.org/17461 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-08-13another avoid endless loop with busted wmfCaolán McNamara
Change-Id: Ie4068fdc1e54e0ad3e55354938a4c5e1459e7fe0 (cherry picked from commit 7ffe6aebb44ed3f7b5fd1ffe3ccfccf0f61984b3) Reviewed-on: https://gerrit.libreoffice.org/17683 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-23avoid 1-past-the-end string accessLionel Elie Mamane
Change-Id: Ia475ce737c430fab8d019e1b8a762f81897e0847 Reviewed-on: https://gerrit.libreoffice.org/17261 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-14use same limit in ProcessOneCode as AddToTableCaolán McNamara
Change-Id: Id0345e5d867d18bf7eb341f04086226b7fa79680 (cherry picked from commit 59197f1892777a5629bad210b9ed1071ed550570) Reviewed-on: https://gerrit.libreoffice.org/17040 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-07-14WaE: comparison of integers of different signsTor Lillqvist
Change-Id: Ie3c7fd8b72cd3cd3f9943c026ca348d9ed3c31f0 (cherry picked from commit bc4a2d7ce9d4417f9d6cd58505d4ea3e959b1354) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-14-Werror,-Wsign-compareNoel Grandin
Change-Id: I18e4249d574f0d48e2c2027a89a37125d09e6702 (cherry picked from commit 08a9452b677bc68f56fbac3638cfaeff9f90b1eb) Signed-off-by: Michael Stahl <mstahl@redhat.com>
2015-07-14fix a third emf crashCaolán McNamara
Change-Id: I3b5d0daf05e3272d2afa0da84ff0b1f8d5c965a4 (cherry picked from commit 173fd90387e8bb7f33c2608628f12c7f772f0277) Reviewed-on: https://gerrit.libreoffice.org/17023 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13emf: fix another hangCaolán McNamara
Change-Id: I971ba5f422827f3b8fcdb86c447fc48415225eca (cherry picked from commit fe20502c86ef6156a54bb37ba2560c8b64d129a4) Reviewed-on: https://gerrit.libreoffice.org/16979 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13emf: test for empty polygonsCaolán McNamara
Change-Id: I3c8896230e3d48a37f4b8d702b0f673e44f45ba4 (cherry picked from commit 7df4d8544c6b12e31bcb81d9389d03ae7c11bfea) Reviewed-on: https://gerrit.libreoffice.org/16974 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13emf: test for negative numbersCaolán McNamara
Change-Id: I9d9b6f3e9592ca7b85cee5422e43d4ca46b8bb36 (cherry picked from commit 4661b2dd34bd7c56b6d783d49f265e9ecde19caa) Reviewed-on: https://gerrit.libreoffice.org/16970 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13fix another gif import crashCaolán McNamara
Change-Id: I0ffa569e0c4240e11184df7dd56b95d87a12425d (cherry picked from commit ee35b72064d8d1333709b102b051360018f8044b) Reviewed-on: https://gerrit.libreoffice.org/16962 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13fix and test for xbm import crashCaolán McNamara
Change-Id: I47e7cb259908ffc6a00475369af1a841acda1da7 (cherry picked from commit 7eb693f87b6a01044999564cce0a18fefca11c99) Reviewed-on: https://gerrit.libreoffice.org/16955 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13fix gif import crashCaolán McNamara
Change-Id: I3a5e0efef6843fb8f8b485fa2369ac5b99513c31 (cherry picked from commit 839e051c658a638a259be6a6bb091b654fac405f) Reviewed-on: https://gerrit.libreoffice.org/16954 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13fix potential hang hereCaolán McNamara
Change-Id: Id62cdb90420b9ccf4e98fc1af46c70db6ed60ee0 (cherry picked from commit 7eef63bb2a4d14cb35201f84f38855910f468e20) Reviewed-on: https://gerrit.libreoffice.org/16923 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13emf: fix hangCaolán McNamara
Change-Id: I2410308ecccb8c5318a718bafadc7b40a98cb82b (cherry picked from commit 8695633023cc321a095753db98bdc69d2aeee058) Reviewed-on: https://gerrit.libreoffice.org/16977 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-13coverity#1266485 Untrusted value as argumentCaolán McNamara
Change-Id: I7708ecaf5412535055584ed6c71beaa9cd71c10c (cherry picked from commit 0934ed1a40c59c169354b177d7dab4228de66171) min legal size here is > 4 (cherry picked from commit 3131205c05a3fde4ef1e3322cc48ca23c443f6d3) Change-Id: I9f68d000b32623db4d949d13284043630f5689f4 (cherry picked from commit 964000d415bcf491704dad57aee7e0656ea60dab) Reviewed-on: https://gerrit.libreoffice.org/16983 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2015-07-10avoid endless loop with busted wmfCaolán McNamara
Change-Id: I104de360f2e861e959ad2dad434a768440877f6f (cherry picked from commit fd2749455fe25e24b448a44f9ada6113e5ac0d13) Reviewed-on: https://gerrit.libreoffice.org/16915 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2015-07-06Resolves: tdf#92467 crashes with empty history list on pressing downCaolán McNamara
regression from some 16->32 bit listbox limit changing Change-Id: I045eeef935afed4154fe11bfd11916c2d6a722e9 (cherry picked from commit c51d5706205cd0282c07d778ffac5f265c3eaf5f) (cherry picked from commit a8ddd3b0280baa1b770f439fbbca9ff073faa16b) Reviewed-on: https://gerrit.libreoffice.org/16699 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-07-02tdf#91641 adjust cursor when deleting preceding charactersJustin Luth
IMDeleteSurrounding is used by input methods to take multiple keystrokes and convert them into a special character. Then the composing keystrokes are removed. Before this fix, the cursor placement was not adjusted, so the special character was inserted in the wrong position and if 3+ keystrokes were involved, the wrong characters were deleted. Also fixes "editLine should have focus on accessibleText init." The first time an accessibleEdit is created, it didnt recognize any focused text when editing in the "Input Line". Change-Id: Ib2608c46bba1c84bb49aa29619a004c125a3bf98 Reviewed-on: https://gerrit.libreoffice.org/16637 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-06-16Resolves: tdf#46440 SIGSEGV on toolkit bootstrap without running instanceCaolán McNamara
(cherry picked from commit 3f69547397e5841d0915921be5be8b3edfdfdbc5) Change-Id: I9a78a75b3d72586b1702ed6fa63bb0b62ce6cd72 Reviewed-on: https://gerrit.libreoffice.org/16078 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-05-27fix buildCaolán McNamara
Change-Id: Ie620107c7ce3ca7a3235adc296daf964a78f0540
2015-05-27Resolves: tdf#89231 if no font has 0x202F fallback to a normal spaceCaolán McNamara
Change-Id: I2325c0b09ccf66ee15597251ad027b295de5502f (cherry picked from commit f76ecc3e9ce51b35fc18db55b808270079a3652b) Reviewed-on: https://gerrit.libreoffice.org/15912 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-05-26add missing includesDavid Tardon
Change-Id: I2b091eb8c407f032f15674338c917bbe7e06d15b (cherry picked from commit 75155bcf07d296352162d0b963493b4ba0238cca)
2015-05-26Resolves: tdf#90155 don't hide+show window before initial show completesCaolán McNamara
(cherry picked from commit c4bae028efbd32c8938c3a6051d58c1f202d5b8a) Change-Id: I16f6fb4ef025f2e464ca581fc348e8dd18981285 Reviewed-on: https://gerrit.libreoffice.org/15910 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-05-20tdf#90604: vcl: reduce MapMode precision further to 32 bits...Michael Stahl
tdf#91195: vcl: reduce MapMode Fraction precision to avoid... ... overlow in ImplMapLogicToPixel. 50 bits is still too much, 44 appears to work for exporting PNG. DocumentToGraphicRenderer::renderToGraphic() converts a double to Fraction which is the source of the excess precision. (cherry picked from commit c8dad7ebb7c1738ae1348f92d67124c165d83f00) ... which mysteriously causes the Export PNG to produce a non-blank image again. The cause is probably that DocumentToGraphicRenderer::renderToGraphic() records a VCL MetaFile, and the ReadFraction/WriteFraction do only 32 bits, while the Fraction interface promises to handle "long". (regression from 2ce0aededea43231d91a0955fc0676120dcc4f13) (cherry picked from commit 21be3257d9d10f0f65c2ae49d7ef3beb81018bfc) vcl: fix the MapMode ctor too to limit precision to 32 bits (cherry picked from commit 0a9b99787c65e49f08b27566d277eab8306cca54) Change-Id: Ic4289a3157ea802c17f0bc24db94ea45eabd9728 Reviewed-on: https://gerrit.libreoffice.org/15800 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-29tdf#71034: [OS X] Ugly (too heavy) fake boldKhaled Hosny
Instead of using a hardcoded stroking value, adopt the formula used by AOO which seems to give better results. Change-Id: I87d55e1fadccf4521c26cd60458d968fcd8a2386 Reviewed-on: https://gerrit.libreoffice.org/15563 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-27-Werror,-Wformat-securityStephan Bergmann
Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d (cherry picked from commit b8cf9b3359195f4f9f7e92f5db224a91cf994306)
2015-04-25Resolves: tdf#73211 gtk checkboxes need erase afer togglingCaolán McNamara
because an unchecked checkbox can have a smaller paint area than a checked checkbox. This has always bugged me (cherry picked from commit d194074aa34e3724dd9b93fbc81bf2ba793cd37a) Conflicts: vcl/unx/gtk3/gdi/gtk3salnativewidgets-gtk.cxx Change-Id: Iac0f075089611b47c381863a9655445d732bfddc Reviewed-on: https://gerrit.libreoffice.org/15508 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-20tdf#71278 Fix cursor hiding in presentation modeMatthew Francis
The original commit was based on a misunderstanding. In fact, the call to GetSalData()->getCursor() at the end of AquaSalFrame::getCurrentCursor() already handles POINTER_NULL correctly, or at least in the same way as on other platforms. The cursor in presentation mode disappears after 10 seconds - if this is to be changed, it should be changed for all platforms. (cherry picked from commit 58a3a99efec9d4bcb4ab61c41bf2feb707c8e1ef and commit b144821188aac238a38d647dff489fc53d9bf3f6) Change-Id: I6d468caa597afa39d17317a60b3dffc190165ac4 Reviewed-on: https://gerrit.libreoffice.org/15395 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-04-17tdf#86793: vcl: speed up OutputDevice::GetEllipsisString()Michael Stahl
The ridiculous algrorithm used for TEXT_DRAW_CENTERELLIPSIS will go faster if we cut out most of the text at the beginning instead of one at a time. (regression from 912ecaf565e68d2ca3fb9584712313e712749f75) (cherry picked from commit c6ec3e4cee8c7c22380780f2661ac23946cdb050) Change-Id: I9310dda1847222215bafe372e3efef9d365e1ad9 Reviewed-on: https://gerrit.libreoffice.org/15355 Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-04-16tdf#84294: vcl: fix PDF export of transparent Writer frames in LO 4.3Michael Stahl
The transparent frame background is painted opaque because OutputDevice::DrawTransparent() records a MetaTransparentAction instead of returning early. Note that master and 4.4 use drawinglayer to paint backgrounds so the problem is only visible in 4.3. (regression from 36b59f2efc2bfb2c9256c39eb5687808deb) Change-Id: Ide7a076b72123097a9fe099b96d36cda7f7bb082 (cherry picked from commit 581314958f0ddd6c3a0536ce2d7e7e6f0c53a8ec) Reviewed-on: https://gerrit.libreoffice.org/15342 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-13Resolves: tdf#90384 queue_resize needs to Invalidate the optimal cache sizeCaolán McNamara
but the PanelLayout didn't (cherry picked from commit b39a6449d5debc7cdf55c3f967b441f3de4d50f3) Conflicts: svx/source/sidebar/PanelLayout.cxx vcl/source/window/dockwin.cxx vcl/source/window/syswin.cxx Change-Id: I38a8975f1488fa2a2ffe91b66745e1a1c6c48a28 Reviewed-on: https://gerrit.libreoffice.org/15215 Tested-by: David Tardon <dtardon@redhat.com> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-04-08Resolves: fdo#84795 Menus don't disappear with right mouse clickCaolán McNamara
re-do this so right-clicking when a menu is open closes that menu but doesn't cause another popup menu or otherwise pass that click through to the app Revert "fdo#84795 Menu, DropDown-List don't disappear with right mouse click" This reverts commit fa022a9c4fe74f3f67fb3c35ef49022842d7499b. because if a right-click context menu is active and we click outside it in order to remove it then that click goes to whatever is underneath the mouse which is undesirable the list dropdown part of this looks good, its the general menus that are the problem Conflicts: vcl/source/window/winproc.cxx (cherry picked from commit 473eae3a7d43ca13ef14eca844b991ffd143e3a0) Conflicts: vcl/source/window/winproc.cxx Change-Id: Ib96e52f22cdeefd59dbf4333f555d9f52b3385e2 Resolves: fdo#84795 Menus don't disappear with right mouse click Change-Id: I95ae2e2d564ec1c45de6df5158e4dec1d93053cb (cherry picked from commit 4f9e20c46b616c7c51bae74bfefd5247f922b2a6) why would we ever want FLOATWIN_POPUPMODE_PATHMOUSECANCELCLICK if we're from the menubar we never set it, but if we are a submenu from a menu in the menubar we set it. with it set, and on right click, the right click is passed through to what ever is underneath the pointer I don't see why we want to do that, especially the inconsistency from e.g. the File menu, vs the "File->New" menu Change-Id: I548f5c95e2511b5e921e8b74600f65eecdd8f498 (cherry picked from commit a8f9dd59de4e655bc77fa0546b81440aee46b837) remove the gap now to pretend it was never there Change-Id: I234defd865e6bf5d9d9eccc85cde7e69c0549c3f (cherry picked from commit a62d7f3b08b413d17e650279110ab8a48c419b18) Reviewed-on: https://gerrit.libreoffice.org/15092 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-08Resolves: tdf#86399 don't clobber cluster start caret posCaolán McNamara
with other cluster element bounds (cherry picked from commit b1030f75d3e47719ca63ec518f1da75196bead1a) Conflicts: vcl/source/gdi/sallayout.cxx Change-Id: I2cc976eb6a0ef42a2678be80637c7220e2247921 Reviewed-on: https://gerrit.libreoffice.org/15119 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-04-03tdf#81813: Typing to select value in dropdown resets after space characterJulien Nabet
Change-Id: I6972cdad9708a46bb8338590312196e55c4f8778 Reviewed-on: https://gerrit.libreoffice.org/15024 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 44c87a5dc921ea6dd28fdc016c61aa62cfd4f4d6) Reviewed-on: https://gerrit.libreoffice.org/15098
2015-04-02fix hang with ooo71962-1.odtCaolán McNamara
script run ends after chunk we are rendering (cherry picked from commit 00bf3a4259c1f960eff05b17649cc734c275950f) Change-Id: Idbfe11c385db72a80d3d204f8638d67395580d1b Reviewed-on: https://gerrit.libreoffice.org/15115 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2015-03-26tdf#67990: Management of case in comboboxJulien Nabet
I noticed these 2 points: 1) Combobox were used with autocomplete with default (false) value for matchCase => so initialize autocomplete with true value for matchCase 2) FindMatchingEntry uses bLazy as !matchCase but when bLazy = false, no autocomplete can work since you must type the whole word so just use "entryCombo" startsWith "typed string" instead of "entryCombo" == "typed string" (thank you Lionel for this tip: http://nabble.documentfoundation.org/Finding-the-right-location-for-tdf-67990-Base-module-td4143324.html) Change-Id: Ib1063002c3284122fd5279f27c1ccbc177bbac7c Reviewed-on: https://gerrit.libreoffice.org/14885 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 76f33f10309b0ee384a75a7a854858b068d60495) Reviewed-on: https://gerrit.libreoffice.org/15021
2015-03-19vcl/text: fix duplicate text in fontwork tdf#81876Pierre-Eric Pelloux-Prayer
Regression introduced by commit 2ba05b4800d6cc322276a6911792363f8eb32051 because space character will take the error code path. The error propagates up to GetTextOutlines which then uses the fallback method. In this case, we now reset any work done before, to avoid having duplicate outlines. Change-Id: Ie15524ac462d4b4bb3c482e49c4fe96a2f2d2c71 Reviewed-on: https://gerrit.libreoffice.org/14850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 162f11cdb94b415ff9d58674e94fb01a745a69eb) Reviewed-on: https://gerrit.libreoffice.org/14899 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-06-22 06:20:34 +0000