summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-02-21Typo: trough->throughJulien Nabet
Change-Id: I5af784709df88492695d1ac9c9a5b020e909f362
2015-02-21Typo: paragaph(s)->paragraph(s)Julien Nabet
Change-Id: I3d82703a59ec749b723d62b15a36937b61156874
2015-02-20tdf#84881: Work in progress: Code to add the timestamp to the signatureTor Lillqvist
Inside #if 0, as the two NSS functions I would want to use aren't exported from libsmime, despite being declared in public headers. Back to the old drawing board. Change-Id: I8b868b4d645a7bbab670e237568c8ff7d97c98cc
2015-02-20tdf#84881: Work in progress: Decode the TimeStampRespTor Lillqvist
OMG, it is really horrible to use the NSS SEC_ASN1DecodeItem() API. Figuring out how to set up the SEC_ASN1Template data structure for decoding TimeStampResp was much harder than setting up the template for encoding a TimeStampReq. Luckily I don't actually need to look into the timeStampToken, but can copy that as such into the CMS as an unsigned attribute. I'll cheerfully ignore for now RFC3161's requirements on how the TSA client should check the validity of the response. Let's leave that up to the PDF viewing (and validating) application. Also improve the SAL_INFO logging, use a timeout for the curl operation, add more ASN.1 in comments for information, etc. Still to do: Actually add the TimeStampResp to the NSSCMSSignerInfo. Change-Id: Id4f800e2cf12a01106b326a31c34eb99f2aa724e
2015-02-20Use curl_easy_strerror() for more information in SAL_WARNTor Lillqvist
Change-Id: I633bd5d697321678d5c179161ac18bc5655246ec
2015-02-19Disable C4324 structure was padded due to __declspec(align()) warningDavid Ostrovsky
Change-Id: I0b4dfe8fe06eb8f7f9fd2929d4efb4f52b25abea Reviewed-on: https://gerrit.libreoffice.org/14560 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-19gdk_screen_get_font_options is always available in gtk3Caolán McNamara
Change-Id: I680ed37995b12abf54526b9205b131a62b5cf734
2015-02-19bPrinter is always false, simplifyCaolán McNamara
Change-Id: If40d1ccdec77c1bf0753411da71ac5c0b42c2765
2015-02-19tdf#84881: Work in progress: Perform the RFC3161 interaction with the TSATor Lillqvist
Use libcurl to perform the request and get the response. Improve error messages (only use SAL_WARN, though, so sadly not visible to end-users). Still to do: Decode the response and attach it to the signature. Implement request encoding and response decoding for Windows. I probably should extend (and rename) the HashContextScope class to handle all resources that need explicit deallocation, instead of calling curl_slist_free_all(), curl_easy_cleanup() and SECITEM_FreeItem() in so many places. The error handling of the PDF export functionality would need to be re-designed so that we could show actual error messages to the user instead of generic "signing failed" ones. But that is typical for much of our code... Change-Id: I6288de3f09021f8e0f385870143fefffbac2a706
2015-02-19tdf#84881: reqPolicy and certReq are optionalTor Lillqvist
Change-Id: Ia5687bf2d68eef06aeb618d5387c663807d24560
2015-02-19tdf#84881: WiP: Fill in more fields of the TimeStampReqTor Lillqvist
Use the digestAlg in the NSSCMSSignerInfo, once we have it, as hashAlgorithm. Use a random number as nonce. Temporarily, dump the TimeStampReq object to a file for inspection in a DBG_UTIL build. Change-Id: I696271b3ccc6cef86a70bc78f86d6eae27a4af77
2015-02-19gtk3: improved checkbox and radiobutton renderingSzymon Kłos
Change-Id: I6da03869dea172fb8d50396010152479afec9cde Reviewed-on: https://gerrit.libreoffice.org/14554 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-19tdf#83099 fix Top of formula bar is missing when expanding on Windows 7Tomofumi Yagi
This is workaround patch. ToolBox::ImplFormat() method places it to the new position, when the new item is added. ToolBox::ImplFormat() method determines whether or not the item is newly added, using that the new item's Top Coordinate is 0. However, it seems that the non-new item's Top Coordinate is 0 on Windows 7 with default(aero) theme, using small icons. We also need to consider in this case. Change-Id: I35cf81502799432f63e0920219fcbaac9050d81f Reviewed-on: https://gerrit.libreoffice.org/14538 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-18tdf#84881: WiP: Handle TimeStampReq::extensions correctlyTor Lillqvist
Also, pass dest as NULL to SEC_ASN1EncodeItem(). Now we can call SECITEM_FreeItem(item, PR_TRUE) on its return value. Change-Id: Ia30b70990971aba15158f97528524d879a04da3c
2015-02-18-Werror,-Wunused-const-variableStephan Bergmann
Change-Id: I79d47b843be844bcb413018522564d6e6d65a4db
2015-02-18-Werror,-Wunused-variableStephan Bergmann
Change-Id: I9b99b893c8b981bac481e528f2c8f62fa1702c07
2015-02-18tdf#84881: Intermediate commit: Construct RFC3161 TimeStampReqTor Lillqvist
It took a while to figure out how to use the NSS API to construct ASN.1 DER-encoded data using the SEC_ASN1_Template data structs. But I am getting closer. Now the SEC_ASN1EncodeItem() doesn't crash at least. Change-Id: I863542bbeed47d48d05a67b851648f87ba9ccf31
2015-02-16boost::noncopyable->'= delete'Caolán McNamara
Change-Id: If0f898a1e912fcd2095d8ba88b2b8046596e16ea
2015-02-16boost::foo_ptr->std::foo_ptrCaolán McNamara
Change-Id: I9219619b538b6530a89f5932ac51eb3b62eb396a
2015-02-16SALEVENT_ VOLUMECHANGED, DATETIMECHANGED and KEYBOARDCHANGED are unusedNoel Grandin
Change-Id: I9207b490cf0bc7fa6c0192cc3ad60d19eea89333 Reviewed-on: https://gerrit.libreoffice.org/14460 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-16add GetSelectEntryData to ListBox and ComboBoxNoel Grandin
to reduce code clutter like pLbSelect->GetEntryData(pLbSelect->GetSelectEntryPos()) since this is a fairly frequent operation. Change-Id: I41daf30fdeda2442ad1ac829e12f553233bae184 Reviewed-on: https://gerrit.libreoffice.org/14472 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2015-02-14see if we can merge floating window and dialog child size/pos settingCaolán McNamara
Change-Id: Idda1a5fbfec7d10fab4fcef47ee0d10945510d50
2015-02-14coverity#1266485 Untrusted loop boundCaolán McNamara
should be equivalent Change-Id: I7bec152b8abb26b34f7b5362a47dc5bdcbee02a9
2015-02-14Related: tdf#63690 - remove rtl_logfileThorsten Behrens
This was unused since the earlier cleanup. Change-Id: Ia56641c4242037a0ce501e43939b8dc862499f0e
2015-02-13Resolves: tdf#86159 floating windows have complicated bordersCaolán McNamara
take the border window dimensions into account on the layout size, but not the layout position Change-Id: I9deb722933e325c92e93ae917fa8e34eaccfca2d
2015-02-12Resolves: tdf#87663 update checker tries to add icon to toc preview toolbarCaolán McNamara
i.e. CRASH when attempting to add ToC to document if the updatechecker fires while this dialog is activating/active because the preview has hidden menubars which have no associated window Change-Id: I45a254dba647910d7743f6d8173c2547dd82c791
2015-02-12do not silently fail if the optimized blend path doesn't do anythingLuboš Luňák
Otherwise e.g. rotated images in Draw may show as empty. Broken in d53103dd83bf20ac. Change-Id: I0b99b6c39b96f87a78ccb09c9db0a1bfac0f3296
2015-02-12coverity#1266485 Untrusted value as argumentCaolán McNamara
Change-Id: I235a65f5521de1b90c8af3dc64b09eb2726d00ae
2015-02-12Resolves: tdf#89252 Fix bold, regular font spacing bug for Graphite fontsMartin Hosken
Change-Id: I31a09fa753ed15e302e5407ce8a0c46f3b13e099 Reviewed-on: https://gerrit.libreoffice.org/14380 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-10Revert "Werror: C4324 structure was padded due to __declspec(align())"Michael Stahl
This reverts commit 9150bb0b3ea3f32e867aad478ef82a74fe0726ce. It causes CppunitTest_vcl_filters_test to segfault in longjmp() on Linux.
2015-02-10Werror: C4324 structure was padded due to __declspec(align())David Ostrovsky
Change-Id: I5a065f9e875640bda2cab67733a5e2684f63d000 Reviewed-on: https://gerrit.libreoffice.org/14391 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-02-10coverity#1267630 Logically dead codeCaolán McNamara
Change-Id: Idf857f5681766923675bdc210c02a796e0f58024
2015-02-10coverity#1267683: vcl: try to suppress a silly oneMichael Stahl
Change-Id: Idcd0cc761121dd356e307003441f56c239efd4f1
2015-02-09EMF clip regions should be ignored sometimes.Eilidh McAdam
Specifically, the record EMR_EXTSELECTCLIPRGN specifies the default clip region if the RegionMode field is set to RGN_COPY. See EMF specification section 2.3.2.2 available from http://msdn.microsoft.com/en-us/library/cc230624.aspx A unit test had to be changed for this - instead of checking for a specific clip region, it now checks that no clip region is specified. This is under the assumption that the default clip region for our device context is "show everything" - i.e. no clip. Note also that RGN_COPY seems to be a common mode value for this record type. Change-Id: I7bd4fe305dda184d121465005fe09d3c113e3063
2015-02-08coverity#1267681 Dereference before null checkCaolán McNamara
Change-Id: I629b12d53ef3bbadeb43e9555a8499252c1a1800
2015-02-07loplugin:deletedspecial (Mac OS X)Stephan Bergmann
Change-Id: Ia09e2e7b3e40bd04da64b52fe29258017b90b156
2015-02-07loplugin:deletedspecialStephan Bergmann
Change-Id: I9ea64443350ed2e1341b99270fa8b29189f07eb2
2015-02-07tdf#88836: UI: in-form navigation bar icons goneZolnai Tamás
Regression from: 6419c745e5e9802da264250d5e131fb9a3b6e4de Revert it and use IsEmpty() instead of operator!(). Change-Id: Icc4f5dbba848a1d4ef807e598f0aa3b940459c82
2015-02-07Fixup --without-x buildRiccardo Magliocchetti
Accept gl linkage in hope of future offscreen mesa support. Avoid linking with GLX though. Change-Id: I4e666f60e74fe34075a8da9eeba95807cf8fe38c Signed-off-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/13452 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-02-06fix mac buildCaolán McNamara
Change-Id: Ic98ada6d0bca124194cea24a1ed30d30a1c0a85e
2015-02-06shared_ptr<T>(new T(args)) -> make_shared<T>(args)Caolán McNamara
and boost:make_shared->std::make_shared Change-Id: Ic1e187c52c856a7b27817967b2caa8920f23a98d
2015-02-05Resolves tdf#89129: crash when defining a specific relationshipJulien Nabet
Returns early if comparison matches so you can reduce iterator scope and avoid last test for logging. /usr/include/c++/4.9/debug/safe_iterator.h:168:error: attempt to copy- construct an iterator from a singular iterator. Objects involved in the operation: iterator "this" @ 0x0x7fffffff3a30 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = past-the-end; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } iterator "other" @ 0x0x7fffffff3a90 { type = N11__gnu_debug14_Safe_iteratorIN9__gnu_cxx17__normal_iteratorIPPvNSt9__cxx19986vectorIS3_SaIS3_EEEEENSt7__debug6vectorIS3_S7_EEEE (mutable iterator); state = singular; references sequence with type `NSt7__debug6vectorIPvSaIS1_EEE' @ 0x0x7fffffff4088 } 4 0x00002aaab193d6e9 in boost::void_ptr_iterator<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem>::base (this=0x7fffffff3a90) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:121 5 0x00002aaab193d269 in boost::operator==<__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem, __gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<void**, std::__cxx1998::vector<void*, std::allocator<void*> > >, std::__debug::vector<void*, std::allocator<void*> > >, ImplBtnDlgItem> (l=..., r=...) at /home/julien/compile-libreoffice/libreoffice/workdir/UnpackedTarball/boost/boost/ptr_container/detail/void_ptr_iterator.hpp:179 6 0x00002aaab193c2ca in ButtonDialog::RemoveButton (this=0x7fffffff3d90, nId=1) at /home/julien/compile-libreoffice/libreoffice/vcl/source/window/btndlg.cxx:340 7 0x00002aaad8ed109b in dbaui::ORelationTableView::lookForUiActivities (this=0x317ef30) at /home/julien/compile-libreoffice/libreoffice/dbaccess/source/ui/relationdesign/RelationTableView.cxx:342 Change-Id: Ied45c222c94d2a362075a3b1550b6092aad77c62 Reviewed-on: https://gerrit.libreoffice.org/14325 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2015-02-05convert all remaining BOOST_STATIC_ASSERT to static_assertCaolán McNamara
and we can include a few less headers Change-Id: Id742849ff4c1c37a2b861aa3d6ab823f00ea87f8
2015-02-05Remove uses of deprecated salhelper/refobj.hxxStephan Bergmann
Change-Id: Ibf4a2ed99024568b2d370b22919e3a25c43c6fbf
2015-02-05-Werror,-Wformat-securityStephan Bergmann
Change-Id: I62ff8a172a9c4f361ef5fcb6d60bd9fd2e959c2d
2015-02-05tdf#84102: Expose XAccessibleExtendedAttributes through ATKJacobo Aragunde Pérez
Those attributes contain a lot of interesting properties, among them the heading level which fixes this bug. Change-Id: I634ef404123cb1b2831563b9b186db4b7e9e7d8b
2015-02-05Updated all precompiled headers.Ashod Nakashian
Change-Id: I955c8ac4dbe002d23531df7eb10fb4444d6b5157 Reviewed-on: https://gerrit.libreoffice.org/14292 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-02-05callcatcher: update unused codeCaolán McNamara
Change-Id: I540d192a361938cd4dca811e7170d762841662ee
2015-02-04fix leak from framework::AddonMenuManager::BuildMenuCaolán McNamara
provide a callback when a menu item gets deleted Change-Id: I5b5f1a181fb10f53f6b1fe7b5637d385e1517530
2015-02-04discard excessive (X11) autorepeat keyboard events if they overload LOLuboš Luňák
If e.g. a document is slow to redraw, scrolling it by holding down a key such as PageDown can make LO lag behind and continue processing the queued up input events even (long) after the key has been released. Since with autorepeat keyboard events the normal user expectations are to hold it until something happens and the exact number of the events doesn't matter, simply discard excessive autorepeat keyboard events if LO can't keep up with them. Change-Id: I45acdc9aa5033647fb80760991437dddfcb6591c
generated by cgit (git 2.34.1) at 2024-08-07 15:13:41 +0000