summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-03-13tdf#115649: ensure we own SolarMutex in the callbackMike Kaganski
The crash is caused by releasing SolarMutex we don't own; the release happens in Application::Reschedule() inside SalPrintAbortProc. The crashing callstack: ucrtbase.dll!abort() mergedlo.dll!comphelper::GenericSolarMutex::doRelease(bool bUnlockAll) Line 72 mergedlo.dll!SalYieldMutex::doRelease(bool bUnlockAll) Line 177 [Inline Frame] mergedlo.dll!SolarMutexReleaser::{ctor}() Line 1473 mergedlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 550 mergedlo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 469 mergedlo.dll!SalPrintAbortProc(HDC__ * hPrnDC, int __formal) Line 1308 gdi32full.dll!vSAPCallback() gdi32full.dll!ExtEscapeImpl() gdi32.dll!ExtEscape() [Frames may be missing, no binary loaded for KMUU727V.DLL] KMUU727V.DLL!0000000011d0dc21() Change-Id: I955eab7894186900d0d99e28f62d87cc645e4a5a Reviewed-on: https://gerrit.libreoffice.org/51052 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 43bf50d5ced4b878f747075f8c0f1b32991c290e) Reviewed-on: https://gerrit.libreoffice.org/51153 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13forcepoint #27 check region bands loaded from stream for consistencyCaolán McNamara
Change-Id: I92376b5fb4208c78fa25a94d4dd394256793161c Reviewed-on: https://gerrit.libreoffice.org/51145 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-13forcepoint #25 ensure null terminationCaolán McNamara
Change-Id: I37f4787fb5772e959c45280d9650adcc15591033 Reviewed-on: https://gerrit.libreoffice.org/51129 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-08tdf#115420 WIN clean up WinSalFrames DC handlingJan-Marek Glogowski
We still don't return a SalGraphics object from AcquireGraphics without a valid DC. But internally we keep the WinSalGraphics objects around, so we now have to verify the DC before using it. In the end this also fixes the leak of the threaded SalGraphics of the frame. Change-Id: I267c96c04b7d00cb66a6c84c63d1373ebe0f529f Reviewed-on: https://gerrit.libreoffice.org/50908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit c15ea73f960bbd3d2a4b0c43b467ac62eeba3505) Conflicts: vcl/win/window/salframe.cxx Also includes the following patch: WIN rename SalFrames SalGraphics pointers This renames mpGraphics => mpLocalGraphics and mpGraphics2 to mpThreadGraphics. Change-Id: I649b956abc9587f1be74872d439fefc5f5b21135 Reviewed-on: https://gerrit.libreoffice.org/50907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 352bd98892c1cdf95756a49f38c84212eebffd7b) Reviewed-on: https://gerrit.libreoffice.org/50958 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-07tdf#115353 Status bar: no cache in settextTamas Bunth
Change-Id: I6c1312bbba553be738e23cee0c76d589c809dff8 Reviewed-on: https://gerrit.libreoffice.org/50584 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-02forcepoint #16: fix heap-use-after-freeMiklos Vajna
PDFDocument::Tokenize() in the aKeyword == "obj" case allocates a PDFObjectElement, stores it as an owning pointer inside rElements, and also stores two non-owning references to it in m_aOffsetObjects and m_aIDObjects. So make sure those 2 other containers are also cleared then elements go away. LO_TRACE="valgrind" bin/run pdfverify <sample> doesn't report errors anymore after the fix. Change-Id: Ie103de3e24a1080257a79e53b994e8536a9597bc Reviewed-on: https://gerrit.libreoffice.org/50631 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-03-02forcepoint #14 check to see if we incremented at allCaolán McNamara
Change-Id: Ia4670adbddcc8501cf522be296b3061a3529f880 Reviewed-on: https://gerrit.libreoffice.org/50606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-01tdf#115297: alternative fix for displaying 1bit imagesVasily Melenchuk
Previous fixes for 1bit monochrome / paletted images produced some regressions, so here is attempt to fix problem at the root. Partially reverted 66dbd4da3afcadb1393daf9be9cecff71b86509a and fixed in a different way without tdf#115297, tdf#114726 and related. Change-Id: I6849ed5ac41770ba905c930065c80e58509dba2e Reviewed-on: https://gerrit.libreoffice.org/50454 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 25cd843664919974f0d21ca7a0b02cc43e9eeabb) Reviewed-on: https://gerrit.libreoffice.org/50540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-26tdf#103571: Avoid spurious heavy SalEvent::DisplayChanged callbacksTor Lillqvist
It seems that on some Macs that the NSApplicationDidChangeScreenParametersNotification is sent for unknown reasons quite often. I can reproduce the problem by changing the Dock size in System Preferences while LibreOffice is running, but others seem to get it without resorting to such trickery. The code used to invoke the SalEvent::DisplayChanged callback in all cases, which can be extremely heavy, as it involves re-measuring text layouts all over the place in all open document windows. Avoid that if the geometry in fact has not changed. Sure, there still is the problem that LibreOffice can become unresponsive for several seconds when the display geometry *does* change, like when you attach or detach a display. Change-Id: I659881e5e392bd599f6be190835e32a77d9f4725 Reviewed-on: https://gerrit.libreoffice.org/50249 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 715b7b6f346fdd9c856db268dcd66334b58c273c) Reviewed-on: https://gerrit.libreoffice.org/50264 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-26forcepoint #6 release virtual devices before releasing font cacheCaolán McNamara
Change-Id: Iacfbe7da788235c96519ecd106d09ab534c83849 Reviewed-on: https://gerrit.libreoffice.org/50284 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-23tdf#67744, tdf#68889: Fix weight reported by the system for these fontsTor Lillqvist
A hack, but oh well. Let's hope there won't be a lot of these special cases. Maybe some generic heuristic would be better. Like if a font's GetStyleName() is "Medium", "Medium Oblique", or "Medium Italic" then always force its weight to be WEIGHT_NORMAL? Reviewed-on: https://gerrit.libreoffice.org/50172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 1d7f96a324a4c2ab82a04513c6a38dc31fd061fa) Change-Id: I13580d27acfb0cc200bdb0cc1911518675d3e32e Reviewed-on: https://gerrit.libreoffice.org/50198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-23tdf#100784 macOS: Don't attempt to handle shortcuts via the menubarMaxim Monastirsky
... when it's hidden. Change-Id: I7930afb8124dd552843512cd30bce4d82ade0c70 Reviewed-on: https://gerrit.libreoffice.org/49399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 9d77e7551e56b85d7f1b40bc42b9ba6876091f22) Reviewed-on: https://gerrit.libreoffice.org/49707 Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-02-22tdf#103690: Set up notifications only after VCL has been initialisedTor Lillqvist
On some Macs, it seems that LibreOffice (or any app?) gets an NSApplicationDidChangeScreenParametersNotification as soon as it has started and asked for such a notification. Our handler for that notification assumes that VCL is initialised. Thus we should not ask for such notifications before VCL has been initialised. I could not reproduce the reported crash with an unmodified LibreOffice, only after inserting a sleep after the notifications had been set up. But I am fairly sure this change fixes the problem. Change-Id: I18d342eb7dc0c77cb7fc8623756bead65a1bd329 Reviewed-on: https://gerrit.libreoffice.org/50164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/50197 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-22forcepoint #4Caolán McNamara
Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I569ca80267ad9b5a21da0029ba903d2a4c45a035 Reviewed-on: https://gerrit.libreoffice.org/50085 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-02-21tdf#115315 Cursor not in focus with new documentTelesto
Partial revert of 7aae8772aa18744cb1bbd8348272be99cc882c47 ("Clear VclPtr instance reference on removed UserEvents.") Disposing of child controls should not affect focus events of the parent frame. Change-Id: I583311050560a2851cfcc372741b675b52375d06 Reviewed-on: https://gerrit.libreoffice.org/49855 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> (cherry picked from commit 11fab5aeaaa72012c63b2c812656a932ef0debf9) Reviewed-on: https://gerrit.libreoffice.org/49869 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09various sft fixesCaolán McNamara
use ptr diff rather than int (cherry picked from commit 5b426038a7befcaf0d05824ffb20200ff8833ad3) fix mem leak (cherry picked from commit 603cb6cf31a5212d03736a552770e5734b0e8066) check more table sizes (cherry picked from commit 1828490bb22f1c8273c4a9f5b1db819b173ca70d) check cmap offset (cherry picked from commit 683d9883ad8fd6568e6a7832e5bb347c1d043e4b) check tableoffset against size (cherry picked from commit ae73c3ff112e1ed38eb4678ac5745990661a2e66) check ntables offset (cherry picked from commit 75a171a405afd6eac236af93aa9d29a9c3ec9c64) use safeint on calculations (cherry picked from commit 139b6c6cf898467098f3a6f29fa84013a182285f) simplify returns (cherry picked from commit e8b2aad1cb2107304761e68aa380b5c29d8ef22f) extend to cover the last byte needed (cherry picked from commit c7b0117f26a386c98a721ff3897479c268103d74) bounds check (cherry picked from commit bb32616bdd6e3b327654bab0e1d790d8d50b893d) move largest bounds check to start (cherry picked from commit f832198e6a33052c7cc86b25843badfb962a2ae8) Change-Id: Ia174fd94c57cc3c899c10e1c0dc5968965a50427 0d329357ac282d4652b0f7ebc401cbd51963461b 004a6d322f60d916cc4635b362ce948e8a10d7c7 5aae26c38f3645020f0e1d6d7b6877c2727af1b4 a79be052dd3f6b6ed38fb326558924c853af5fff d75f5f4b578fd176c17e5763569f1403260c6594 c063786ba41aa9a985f505e62b43d3d543a0d48f 1a67cb2f1c686032438852fec1267a59fbd04d7f 5177d42b47a4bca614878dce4a69ab16b5cfe163 6d32a6b6f1dd91db42a3f154700ea55603f0e4dd 03fe80f9568759b829fac4e9bcfd496efebe6a26 Reviewed-on: https://gerrit.libreoffice.org/49484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-09check O_hhea and O_vhea sizesCaolán McNamara
Change-Id: I82e47732815f0112801c8c3a3e5b0b09ac25610a Reviewed-on: https://gerrit.libreoffice.org/49438 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-09check O_head sizeCaolán McNamara
Change-Id: Idf5d30eaed0196cfa9266e35131c538c606a0960 Reviewed-on: https://gerrit.libreoffice.org/49365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b10ae2faae6f3c448bbab71585550387e18cc248) Reviewed-on: https://gerrit.libreoffice.org/49366 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-09check table size before reading nglyphsCaolán McNamara
Change-Id: Ib511fdf16006877ca76085137eb9200601b2f8f7 Reviewed-on: https://gerrit.libreoffice.org/49363 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 08dd51bfcaa6b493e134bcc7787cc18c36ad5db1) Reviewed-on: https://gerrit.libreoffice.org/49435 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-09Removed unused code for reading kern tableKhaled Hosny
Change-Id: I66b17dbee0a04e61b99e23933a7fed4be30f3a93 Reviewed-on: https://gerrit.libreoffice.org/49426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> (cherry picked from commit e3caecb5a33288dd46a80b2ffcc47a2288305052) Reviewed-on: https://gerrit.libreoffice.org/49451 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-08tdf#112990: Hack-around: Do not crash on mac with opengl enabledXisco Fauli
Change-Id: Id8d1ffe593fa42b7e37e26e8d66ffad87d6685c1 Reviewed-on: https://gerrit.libreoffice.org/49251 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com> (cherry picked from commit c83d2ac99dc3da4ef85b193543a93e02e3858844) Reviewed-on: https://gerrit.libreoffice.org/49442 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-08return early on short streamCaolán McNamara
Change-Id: Ia9cb4dec5358281322a2428c5f2153836a1ee1af Reviewed-on: https://gerrit.libreoffice.org/49374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08stay within font boundsCaolán McNamara
Change-Id: Ie8ed610b71cb1b20963827c2be97155d2d8aa22c Reviewed-on: https://gerrit.libreoffice.org/49370 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08what matters is the availability of the last element, not the firstCaolán McNamara
Change-Id: I23d3abdbe62b735d66261fb337613da88cc4206b Reviewed-on: https://gerrit.libreoffice.org/49379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-08check kern table sizeCaolán McNamara
Change-Id: I65b5f0a8950d54c00d6fd7c385ca1c5dca2ef2c8 Reviewed-on: https://gerrit.libreoffice.org/49383 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-07sanity check cmap table sizeCaolán McNamara
Change-Id: I010c2fd221bcd86a62efd9996a0c34930828cb6d Reviewed-on: https://gerrit.libreoffice.org/49349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-05tdf#115416 allow build with classic libjpegCaolán McNamara
Change-Id: I96252e1a78dbc52d21095e11b7bdb0807e5d76b6 Reviewed-on: https://gerrit.libreoffice.org/49205 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-04tdf#32935 tdf#49134 tdf#114466 Activate newly opened modal dialogsMike Kaganski
... based on ForceFocusAndToFront setting Change-Id: Ic76faa082f433d5a0150e49c30d7eda3c6c24c5f Reviewed-on: https://gerrit.libreoffice.org/48287 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/49214 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-29gtk3: single click with selection set doesn't unselectCaolán McNamara
this is a safe backportable fix, the unconditional nFlags |= SelectionEngineFlags::CMDEVT looks the real dubious thing to me, but only the gtk3 backend has swipe support so just returning immediately on a swipe definitely ok Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4 Reviewed-on: https://gerrit.libreoffice.org/48529 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-29tdf#109062 restore osx scrollwheel logicCaolán McNamara
to pre commit f7d2bf216afa10268e6a7c1d4613a2fd8f7c7f3c Date: Tue May 16 10:12:09 2017 +0100 Resolves: tdf#103174 & rhbz#1367846 improve gtk3 trackpad scrolling state. Change-Id: If5a494441731e73136158b4905c2744ba8bc8875 Reviewed-on: https://gerrit.libreoffice.org/48305 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-01-29fix build with glm 0.9.9Rene Engelhard
In file included from /usr/include/glm/gtx/norm.hpp:18:0, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/VertexUti ls.hxx:16, from /data/rene/git/LibreOffice/master/vcl/inc/opengl/LineRende rUtils.hxx:14, from /data/rene/git/LibreOffice/master/vcl/opengl/LineRenderUti ls.cxx:11: /usr/include/glm/gtx/quaternion.hpp:23:3: error: #error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." # error "GLM: GLM_GTX_quaternion is an experimental extension and may change in the future. Use #define GLM_ENABLE_EXPERIMENTAL before including it, if you really want to use it." ^~~~~ so just define it. Change-Id: I981bfb5fd944f32a3774b3f9b183989773bf235f Reviewed-on: https://gerrit.libreoffice.org/48799 Tested-by: Jenkins <ci@libreoffice.org> Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2018-01-27tdf#115057 Never use ImplPopupFloatWin for anything except ToolBoxMaxim Monastirsky
ImplPopupFloatWin draws the window title and frame directly on the client window, which is incompatible with .ui layouts, as they try to occupy the whole available space. Instead just use a plain FloatingWindow whenever possible, and change the border window code to mimic the behavior of ImplPopupFloatWin, wrt removing part of the frame of toolbar popups w/o a title. Change-Id: If72ea89e31f913470faad7fcb8083f9b9787c9a8 Reviewed-on: https://gerrit.libreoffice.org/48094 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 829b0564959411d0cc64169fe69153a714050c0d) Reviewed-on: https://gerrit.libreoffice.org/48202 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24tdf#69254: Tweak mapping from CoreText weight to our FontWeight a bitTor Lillqvist
Make the mapping of light weights more likely to hit different enum values for slightly different weights. We want to be able to distinguish between for instance Overpass Light (with weight -0.4) and Overpass ExtraLight (with weight -0.5). Change-Id: If83fbce68149b267a49ef9bcb6624d8790de7c56 Reviewed-on: https://gerrit.libreoffice.org/48426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-23tdf#115023 Check mpControlData for nullptrMaxim Monastirsky
Control::ImplClearLayoutData happens to be called post dispose, but Control::dispose already destroyed mpControlData. So put back the nullptr check that was removed in e8b49f09074fe184374bee5062715357427ae044 ("new loplugin: useuniqueptr: vcl"). (But IMHO it's odd that we even try to send lose focus events to disposing windows. So maybe it would make sense to replace the "! pOldFocusWindow->IsDisposed()" check inside Window::ImplGrabFocus with "isDisposed()" which comes from VclReferenceBase, and set much earlier?) Change-Id: Iddaf7e05d6cb56c28a34884876770753fcf7179e Reviewed-on: https://gerrit.libreoffice.org/48246 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 2a2b37202a735b34da914c03b2f6e1495f833b51) Reviewed-on: https://gerrit.libreoffice.org/48251 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-23Resolves: tdf#115106 don't assume fullscreen is impressCaolán McNamara
writer can too, so revert this part of commit 277395b6266c57a7709c3c47986f135f6789c8e7 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Jun 13 18:09:08 2017 +0100 make opengl transitions under X flicker free on enter/leave which should restore matters to its former glory, at this point gtk3 opengl transition support now works so it all moot to me now. Change-Id: I78a8a774aead6482d0541575dbf10ad977ceccc0 Reviewed-on: https://gerrit.libreoffice.org/48208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-23tdf#114460 vcl: handle nested parentheses in PDF roundtripMiklos Vajna
The roundtrip of the pdf image failed due to this. (cherry picked from commit f58a16d5987c8e8c16580c514ce0c7b0895b4105) Change-Id: I88a9657e242dd2659f9bf06233e5fcbfeb43ceb5 Reviewed-on: https://gerrit.libreoffice.org/48378 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-23tdf#114985: Tell NSWindow to never use automatic window tabbingTelesto
Based on https://codereview.chromium.org/2325313002/ Change-Id: I8838449d57b1d1b010491a405c87645d38199fdf Reviewed-on: https://gerrit.libreoffice.org/48330 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit ce88f2a7374bb8c53d57e8263e0701db19d62f30) Reviewed-on: https://gerrit.libreoffice.org/48384
2018-01-23tdf#112153: Set button theme properlyTelesto
Change-Id: I0665880c0d0348fcbb3bcf04d9172405c8e31eb7 Reviewed-on: https://gerrit.libreoffice.org/48334 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 44af50465a02b6f5566be45913a34fdbdba90133) Reviewed-on: https://gerrit.libreoffice.org/48385
2018-01-23its defineresource not define resourceCaolán McNamara
regression from commit 64d624b65124ac02d8ee59b135593fd9d8eb9067 Date: Sat Jan 9 22:55:28 2016 +0100 Fix typos Change-Id: I9a5940027423ff0791fa7da0b79b617412ce6b86 Reviewed-on: https://gerrit.libreoffice.org/21209 Tested-by: Jenkins <ci@libreoffice.org> Change-Id: Ifdf45e97b81523c84c73b93d14ed75b7b6909f77 Reviewed-on: https://gerrit.libreoffice.org/48356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-11tdf#113874 Guard against invalid statesSamuel Mehrbrodt
Change-Id: I013dd4eb81f0fbef25d9f58e27fe72d800d910ba Reviewed-on: https://gerrit.libreoffice.org/47702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit d2763bde00f0f840585e1ec4c8f94c0ef804a580) Reviewed-on: https://gerrit.libreoffice.org/47744 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-09tdf#114704 use of float as intermediate causes out by one on large offsetsCaolán McNamara
table offset integer value of 21281769 is correctly read, but on cast to float it is represented as 21281768 and we're off by one when cast back to integer later Change-Id: I5694e14d72c04493ba15cc77485a734498a45468 Reviewed-on: https://gerrit.libreoffice.org/47608 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-08tdf#114818 hold the mutex before executing the error dialogXisco Fauli
Also add an assert to ErrorBox to ensure the mutex is acquired Change-Id: I3e426024dad6ddfc5cffc7861b0cba9e8989c018 Reviewed-on: https://gerrit.libreoffice.org/47388 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0ddd15c1134dde249552ebe763c1cd005e8b4591) Reviewed-on: https://gerrit.libreoffice.org/47570 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-28Prevent out-of-order LO event processingJan-Marek Glogowski
There's a callback processing loop, introduced by a7c84375db517769035080c8fed33b2f303fc42f, which releases the SolarMutex and is triggered by a queued user event. Such a scenario can easily be reproduced by any LOK client resulting in hitting the empty user event processing list assertion. I'm not sure this should be handled via LO events at all. So this - again - gets rid of the the assertion and tries to prevent processing the user events out-of-order. In the case of giving up the SolarMutex while processing a user event an other thread or even nested loop can "steal" the user event list and continue processing. Most VCL backends run the event loop just in the main process, so for them this scenario is guaranteed. But the headless backend - running without UI or from LOK - is still allowed to process events in any thread. This is harder to fix and probably should use the same solution the gtk* backends use. This also changes the dequeues into lists to use splice for appending them. Change-Id: Id4a93a01dea415271ad96098830f18f06d4a75b9 Reviewed-on: https://gerrit.libreoffice.org/46550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk> (cherry picked from commit 5469ac13b13e458904900539e6542d4a83d44c4e) Reviewed-on: https://gerrit.libreoffice.org/46890
2017-12-21Resolves: tdf#114592 mark geometry as provisionalCaolán McNamara
when we predict what it will be and use that flag to decide to forward notification of arrival of confirmation of geometry Change-Id: I4a7334d75eb7977c85aebcf2b652cc4b2d6b25bb Reviewed-on: https://gerrit.libreoffice.org/46912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-12-19Report more debug information about caught exceptionStephan Bergmann
...in an attempt to track down why various tinderbox builds started to fail CppunitTest_sw_filters_test with an "Uncaught exception during Task::Invoke()!" abort. On IRC, jmux claims that catching exceptions and turning them into abort() here (instead of letting them propagate) is necessary: "The main problem was the wrong state in the scheduler. So something actually handled the exception, but the next caller into the scheduler had an invalid linked list of tasks, breaking things left and right." Change-Id: Ic3365e282404483518652c00160c2036b79991cf Reviewed-on: https://gerrit.libreoffice.org/46450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ba81ac19b7aec4fd7f07fcec9f6ea6f85d9aaa24) Reviewed-on: https://gerrit.libreoffice.org/46532 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-12-18ofz: ensure null terminationCaolán McNamara
Change-Id: I6b6b0763e85a41d03f9e03c6abc17c6c311f6519 Reviewed-on: https://gerrit.libreoffice.org/46642 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-18tdf#114262 Respect text+image toolbar styleMaxim Monastirsky
Regression of 67c9d054517fc3b5cbc203c330eedef4b50f0e57 ("fdo#84938: replace TIB_ constants with enum"). Change-Id: Ib90473a80fd491f4a136b4e76864c107a9240990 Reviewed-on: https://gerrit.libreoffice.org/45920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> (cherry picked from commit 291ea673180a37912697646850959b3f6553cc7a) Reviewed-on: https://gerrit.libreoffice.org/46144 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-12-15tdf#114408 set correct tooltip rectangleCaolán McNamara
The original code tried to get the position of the window relative to its parent and then ask the parent to adjust that position to a position relative to the toplevel. But the position to use in that case should have be WindowImpl::nX/WindowImpl::nY not GetPosPixel() Much easier to just directly ask the the current window for its position relative to the toplevel. Change-Id: Iff202f052bc651a8c0e3a57ff3322e5e2a3e4b9a Reviewed-on: https://gerrit.libreoffice.org/46315 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-08tdf#108302: keep the font unrotated if @font isn't available.Mark Hung
We will create the font in ExTextOutRenderer for glyphs that are expected to be sideway in vertical writing, so we can reset the font escapement and orientation if @font ( windows notation of fonts for CJK vertical writing. ) isn't available. That will keep the font consistent with @fonts for those glyphs expected to be upright in vertical writing. Note that it is necessary to change text alignment of DC when such font is used. Change-Id: I1a4a6e8aa232119dd136beeb6c19505d7980a534 Reviewed-on: https://gerrit.libreoffice.org/45609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit 2392238e480ecc1d1a5e2e69789e79c10f142d6c) Reviewed-on: https://gerrit.libreoffice.org/45919 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07gpg4libre: add KDE4 fpicker gpg crypt chechboxThorsten Behrens
Change-Id: Iba8fb0e0ac732f36cd1d880884bde1121e6b1eab
generated by cgit (git 2.34.1) at 2024-06-18 07:12:30 +0000