summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-11-07make size group defaults match and document what the default isCaolán McNamara
Change-Id: Ic9a90d50d19b82ffd2ad599a106c2bc58d138f17 Reviewed-on: https://gerrit.libreoffice.org/82237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07remove some unused gettersCaolán McNamara
Change-Id: Iaa556491add4a7674f90ecfbf8e44f0b1d6583ee Reviewed-on: https://gerrit.libreoffice.org/82198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07drop unused TreeView::set_top_entryCaolán McNamara
Change-Id: I70171b95baf29486c253e7d388ba59385da1d929 Reviewed-on: https://gerrit.libreoffice.org/82196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07rename FloatingWindow::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I55babcf716292fa9fac3e9cb4ba66a2038a1d80b Reviewed-on: https://gerrit.libreoffice.org/82203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07rename Dialog::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I01a8591def7a559d3152e9c4875c6785940331f7 Reviewed-on: https://gerrit.libreoffice.org/82202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07loplugin:unusedmethodsNoel Grandin
Change-Id: I65354c7476dfaede1a607441d7c1b0c7ad038df4 Reviewed-on: https://gerrit.libreoffice.org/82186 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-07loplugin:unusedfieldsNoel Grandin
Change-Id: Ic1c0a2144f39373f93384bccbfc74356cac65ba0 Reviewed-on: https://gerrit.libreoffice.org/82185 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06vcl PDF export: fix re-exporting PDF images with page-level rotationMiklos Vajna
PDF images are effectively 1 page PDF documents. The page object may have a /Rotate key, which was simply ignored before. We turn page objects into form XObjects on PDF export, such rotation can be expressed with a /Matrix key. Add support for the 90 degrees rotation case, this can be generalized later if wanted. Change-Id: I55a4f63e0b986637ccdeba0b783f1db9a85c4d93 Reviewed-on: https://gerrit.libreoffice.org/82154 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-06fix --disable-gui build on 32bit (missing -ldl)Rene Engelhard
Change-Id: I66cd04efe5486459d9cc777a532925d25fbd1e86 Reviewed-on: https://gerrit.libreoffice.org/82118 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2019-11-06erase matching container if notebook page removedCaolán McNamara
Change-Id: I15c1bb40f301684e58adcf7d366d7fa1bd171b04 Reviewed-on: https://gerrit.libreoffice.org/82136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06set mpCloseButton to null after it is destroyedCaolán McNamara
Change-Id: If1a0bec30d2bcfdf6846712a67efbe2dcfbbec5c Reviewed-on: https://gerrit.libreoffice.org/82133 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-06loplugin:unusedvariablecheck tweak to find more stuffNoel Grandin
but leave the tweak commented out, since it generates false positives Change-Id: Iaf3f92414d2618f8780561f98765e33e282afe0c Reviewed-on: https://gerrit.libreoffice.org/82121 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-06loplugin:indentation find broken if statementsNoel Grandin
so I don't read the "then" block as being a sequential statements Change-Id: Ib2004acd3518bd4ebd2246f02a26c2c0a8bbab4c Reviewed-on: https://gerrit.libreoffice.org/82069 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05Drawing calc grid misses pixels on bottom and right.Michael Meeks
Change-Id: I2ac7911b35d942b7167a3243d04e1b5710ed367d Reviewed-on: https://gerrit.libreoffice.org/82091 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-05ensure maEndDialogFn is unset after std::moveCaolán McNamara
Change-Id: I9809cc082157bd18562f812155a9ed68f522a703 Reviewed-on: https://gerrit.libreoffice.org/82084 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05vcl PDF export: fix re-exporting PDF images for dict obj resource sub-keysMiklos Vajna
Re-exporting PDF images works by tokenizing the PDF image, identifying which PDF object is the page object and then copying that over to the PDF output, together with the dependencies of that object. This involves copying the resources of the page object. Previously we assumed that the sub-keys of the resources are always inline dictionaries, but the bugdoc shows that they can be references as well, which point to dictionary objects, so add support for this scenario. Change-Id: I78ee1c726e6ecd958232e9fab64773595e5b9c86 Reviewed-on: https://gerrit.libreoffice.org/82076 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-05Resolves: tdf#128599 null derefCaolán McNamara
Change-Id: If71a32b15b5ffab11185e2ce253ab65faf7e6ac3 Reviewed-on: https://gerrit.libreoffice.org/82056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05make some classes module-privateNoel Grandin
Change-Id: Ice9a57eedb166672dbdfae6da2a172ab77566a19 Reviewed-on: https://gerrit.libreoffice.org/81983 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-05ofz#18653 slow and uninterestingCaolán McNamara
Change-Id: I9043de56063caec225850eb1103435b44640781e Reviewed-on: https://gerrit.libreoffice.org/82043 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-05tdf#109135 Don't handle Ctrl key in SvTreeListBox HandleKeyInputJim Raykowski
This patch allows shortcut keys to work when focus is in tree list box Change-Id: Id47e004276c5f56f44c404c2d39d62dacbe234ee Reviewed-on: https://gerrit.libreoffice.org/82049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-04lok: avoid ILibreOfficeKitNotifier null ptr de-reference on shutdown.Michael Meeks
Change-Id: I79c8fa3ebf7ed457b7bebb4da536eb83f5cac567 Reviewed-on: https://gerrit.libreoffice.org/82035 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-04ProgressBar now only use in vcl and toolkitCaolán McNamara
Change-Id: I5d56a4df155806e41cafa6f65a3a030e8443b8f7 Reviewed-on: https://gerrit.libreoffice.org/82005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04readme not a sufficient indicatorCaolán McNamara
Change-Id: Idd5cd004b873280e202b16c182356977045bdab4 Reviewed-on: https://gerrit.libreoffice.org/81993 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04improve pivot table dnd highlightingCaolán McNamara
unhighlight row when widget is unhighlighted and only highlight a row if the widget is highlighted Change-Id: I415207b4b263c5125f52abd57efe3543e2411b36 Reviewed-on: https://gerrit.libreoffice.org/81999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04FixedHyperlink now only used in vcl and toolkitCaolán McNamara
Change-Id: Id1eacb01ab7ed985d1495d3949bc185556246e3a Reviewed-on: https://gerrit.libreoffice.org/82003 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04improve pivot table dnd highlightingCaolán McNamara
if we're dropping into a treeview that is in list mode then use GTK_TREE_VIEW_DROP_AFTER instead when GTK_TREE_VIEW_DROP_INTO_OR_AFTER is suggested. Change-Id: I446e70a1e10a2e6e50bd7a098c54a91bcfa6abb9 Reviewed-on: https://gerrit.libreoffice.org/81998 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04survive missing atk_object_set_accessible_id symbolCaolán McNamara
Change-Id: If18380dfe3ab17a4584602869928b3ff50fc15d6 Reviewed-on: https://gerrit.libreoffice.org/81987 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-04Update listbox after scrollSzymon Kłos
To show updated content in the Online after scroll. Change-Id: Ieb58c2a24bfcd76495d7046a0721db789b5c141a Reviewed-on: https://gerrit.libreoffice.org/81967 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-03make some classes module-privateNoel Grandin
improve the script, but it still generates some false positives Change-Id: If8ee1cba8c04ac0be11f73220149e6de15f24f44 Reviewed-on: https://gerrit.libreoffice.org/81929 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03size some stringbuffer to prevent re-allocNoel Grandin
I started with 32 and kept doubling the size until the site did not need re-alloc, but clamped it at 512. Change-Id: I55fe36b31cd3d40f86e5729337a927cf920f2af6 Reviewed-on: https://gerrit.libreoffice.org/81960 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03loplugin:stringaddNoel Grandin
tweak the plugin to be more permissive, then validate by hand afterwards Change-Id: I40c5c911fe6ff7e45baaca372abf7dac211d9654 Reviewed-on: https://gerrit.libreoffice.org/81942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-03Only initialize function pointer onceMike Kaganski
Change-Id: I559e90948b9dc1c78fa7ff03a96edc1cb9fbe3e2 Reviewed-on: https://gerrit.libreoffice.org/81958 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-03find symbols that can be privateNoel Grandin
update the script and make private standalone functions Change-Id: Icb26ce258107700c90f89ad4e0d3329d075a2eb1 Reviewed-on: https://gerrit.libreoffice.org/81879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-02New loplugin:conditionalstringStephan Bergmann
Change-Id: I2eab990c15f845b44a3b598571aca361dadf9ff3 Reviewed-on: https://gerrit.libreoffice.org/81946 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-02tdf#128441: blacklist nvidia on Win10 deviceid 0x2182Julien Nabet
Change-Id: I033da69ee4f001f7dd2546822626fb2777dd040f Reviewed-on: https://gerrit.libreoffice.org/81943 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-02weld SfxRecordingFloat_Impl utility windowCaolán McNamara
we can't abuse action_name anymore as the uno command are not legal actions Change-Id: Iaf9306c6e3eec852d2a50df9161bd20383881a04 Reviewed-on: https://gerrit.libreoffice.org/81902 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-02Remove useless bool manipulation.Tamás Zolnai
Must be a left over of sal_Bool -> bool conversion. Change-Id: I8b37e513dc1f36b015b29ce3dad4ade2df7807d9 Reviewed-on: https://gerrit.libreoffice.org/81898 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-11-01Removed executable permission on src fileAndrea Gelmini
Change-Id: Id4dc99968fc453f5ab3ee5e7b30bfacf79e843b7 Reviewed-on: https://gerrit.libreoffice.org/81867 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-01tdf#126966: Use larger buttons for the colours in the sidebar on iOS - 2Marco Cecchetti
Attempt to merge this with Noel's re-work of the color picker. Change-Id: I9687546889bc20ef95a50aeafbc6f40e939d57a9 Reviewed-on: https://gerrit.libreoffice.org/81755 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/81900 Tested-by: Jenkins
2019-11-01ofz#18660 don't parse past endCaolán McNamara
Change-Id: I3d18202ec637c0231dcf71f2d02c79fab0dc7403 Reviewed-on: https://gerrit.libreoffice.org/81906 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01Fix use of uninitialised variableLuke Deller
Ensure ImpGraphic::maSwapInfo.mbIsTransparent/mbIsAlpha are initialised in the case where image type detection fails. Change-Id: I103d77760326aa3833dd3730ec65fd53d360271b Reviewed-on: https://gerrit.libreoffice.org/81882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-01the label sync button will relaunch itself from its close handlerCaolán McNamara
so rearrange things so that runAsync can survive that Change-Id: I7d40637fb861ceb64ce32f0e9ecb3451c0d17bad Reviewed-on: https://gerrit.libreoffice.org/81884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-01Workaround for crash on macOS Catalina at least when built with Xcode 11Tor Lillqvist
For some unclear reason, for me at least, when I have built with Xcode 11.1 or 11.2 and run on macOS Cataline, I run into a crash caused by boundless recursion related to the progress bar in the recovery dialog. Not setting mbProgressNeedsErase to true for the "NWF" seems to help. Whether this has some unintended visually bad side effect I don't know, but hey, it's just a progress bar, who cares if it in some circumstances doesn't look perfect? Change-Id: I6c990adde7689633b2c4b5aa42a4a07966565af2 Reviewed-on: https://gerrit.libreoffice.org/81874 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-11-01Tooltips: Use HELPWINSTYLE_BALLOON when tooltip contains \nSerge Krot
Change-Id: I33ef48b5a90338471d85a613ede73eada323381c Reviewed-on: https://gerrit.libreoffice.org/80825 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de> (cherry picked from commit ba5722319a585bf887965177f2d26e859b8e732b) Reviewed-on: https://gerrit.libreoffice.org/81641 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-31remove some stray random propertiesCaolán McNamara
Change-Id: I0f20e057b97bcb3ab120ae6b211729ea60937bd8 Reviewed-on: https://gerrit.libreoffice.org/81769 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-31jsdialogs: send grid attach dataSzymon Kłos
Change-Id: I667e1ba97f42ac3e7b806bcec929ff346400bdda Reviewed-on: https://gerrit.libreoffice.org/79699 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/81764 Tested-by: Jenkins
2019-10-31Fix IsTransparent() for unloaded graphicsLuke Deller
Fix Graphic::IsAlpha() and Graphic::IsTransparent() for unloaded graphics. This fixes tdf#118036. GraphicDescriptor::Detect(true) is currently used to read the image size from the header of images which are not being fully loaded yet. This change extends GraphicDescriptor to also report whether the image supports transparency or alpha, implemented only for PNG format so far. Change-Id: I1753c0d11491f1dc518e23da8d7b3842945770cb Reviewed-on: https://gerrit.libreoffice.org/81785 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-30honour closeable flagCaolán McNamara
Change-Id: I4b37d6698d3ebd6449c5ba797784b49cc7b2cada Reviewed-on: https://gerrit.libreoffice.org/81757 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-30split WindowStateData into its own headerCaolán McNamara
Change-Id: I2ad8f4edd1d8e0f4a4f9a1eec546f98d94a48198 Reviewed-on: https://gerrit.libreoffice.org/81743 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-30fix vcldemo lookup of iconsLuboš Luňák
Icon themes are in [srcdir]/icon-themes, which is not necessarily the same as $PWD/icon-themes. Change-Id: Id2c5037afcbea4ea7dd511a9e10e19e05fa52a5a Reviewed-on: https://gerrit.libreoffice.org/81701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-17 01:34:34 +0000