summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-04-06tdf#98989: vcl: fix handling of non-scalable fonts like "Courier"Michael Stahl
For a VirtualDevice only scalable fonts are cloned, but for non-scalable bitmap fonts still an empty PhysicalFontFamily with no PhysicalFontFace is created, which causes text to disappear (height 0). Suppress creation of such families like it was done in LO 4.3, so that the fall-back can handle it and map "Courier" to "Courier New". (regression from 8d6697587776136f3121733e1c29d4200720dbd9) (cherry picked from commit 2f89245fb7e1c94bed49dde10b08ab1cf41b597b) Change-Id: I6542a3f7a01bdf46ae2bcf328fa04064f7f86332 Reviewed-on: https://gerrit.libreoffice.org/23851 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-31vcl: tdf#98812: acquire reference count of WinFontInstancesMichael Stahl
... when they are inserted in WinSalGraphics::mpWinFontEntry. Not sure why one of these drops to 0 but is not removed from the WinSalGraphics when formatting this particular bugdoc. Acquiring the instances when retaining pointers to them should make the life cycle a little less insane. (cherry picked from commit 99207a26df0083851ba8e23be72d5c6974f98a3b) Reviewed-on: https://gerrit.libreoffice.org/23504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit 4ae7ec8c8d22e751b868459e1f51fcecc37dd6b1) tdf#98812: follow-up pFont->mpFontInstance can be NULL. Reviewed-on: https://gerrit.libreoffice.org/23654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 9fa87bb1a42c45446f78b4d8c8096d7ce90a8022) Signed-off-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 4ab36bbd1816d6f297892a638e6826f28ca87150) Change-Id: If1404f46a13736b2a226e198bdf0c3ca8e09bb38 Reviewed-on: https://gerrit.libreoffice.org/23651 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-17tdf#98052 - even polygons were not drawn on the alpha deviceMarco Cecchetti
Change-Id: I5725ec23869b295c8021bef0330ee6f69f206351 Reviewed-on: https://gerrit.libreoffice.org/23025 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-03-14tdf#96687 - force validation after External InputJustin Luth
After external input (EndExtTextInput), the selection was marked as invalid, but bFormatted remained true, so all the functions that re-evaluated and marked the portion as valid again were skipped and therefore the invalid portion was not painted. Change-Id: Ibb2208bdaeb8ed17a4a34fa378a2fc750abf1b07 Reviewed-on: https://gerrit.libreoffice.org/20986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 5a217ada5e28e17f052ebec8e53dce05c2aa9cae) Reviewed-on: https://gerrit.libreoffice.org/23190 Tested-by: Justin Luth <justin_luth@sil.org>
2016-03-06Fix the import of line joins and caps from EMF filesStephan van den Akker
Backported fix to 5.0. Note that commit 42f771d6e changed from constant values for line joins to an enum, but that only got into the 5.1 branch so have had to use the old constants. Change-Id: I976336d35366b661e402db484820b4dd9a7b0228 Reviewed-on: https://gerrit.libreoffice.org/22821 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/22947 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-03-05Improve the import of pen styles from EMF filesStephan van den Akker
Change-Id: I643c29befeb29b7b1cdd66375f661f4adb0e6cfa Reviewed-on: https://gerrit.libreoffice.org/22638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com> (cherry picked from commit 9db34a7712e277389b2041cfbd77a60476d7f7f1) Reviewed-on: https://gerrit.libreoffice.org/22718 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2016-03-04tdf#98052 - polypolygons were not drawn on the alpha deviceMarco Cecchetti
In OutputDevice::DrawPolyPolygon when b2dpolygon are used for drawing the source polygon is not drawn on the alpha device. Change-Id: I54f4e5a13469d9844866cea61b074420219b836d Reviewed-on: https://gerrit.libreoffice.org/22893 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5bdbf99c3ec6e5e0793c52c34ff4f3a17afab107) Reviewed-on: https://gerrit.libreoffice.org/22902
2016-02-24tdf#85761 vcl: JPEG export does not save PPI values correctlyChris Sherlock
JPEG values are currently hardcoded to 96PPI when we export JPEGs. The Graphic class doesn't have an easy way to get the PPI, but this can actually be calculated from the pref size and pref map mode (no idea why it is called "Pref"). Interestingly, you need to get a multiplier to work this out, relative to units of 100th mm. The EPS filter code had a function that does exactly this, but it's entirely based on MapMode units so it was really implemented in the wrong class IMO. I have thus moved it out of PSWriter and into MapMode. This also fixes tdf#65695, which was partially fixed, but had the JPEG PPI hardcoded to 96dpi. Also fixes tdf#97481. Change-Id: Iedb674141dd4e22fcbfb7be357dc777f732aa3aa Reviewed-on: https://gerrit.libreoffice.org/22339 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/22380 Reviewed-on: https://gerrit.libreoffice.org/22454
2016-02-18fix inverted logic regressionCaolán McNamara
regression from... commit 051b29e1025253f35f87a04e297760aa8b40611f Author: Luboš Luňák <l.lunak@collabora.com> Date: Sun Sep 14 15:45:02 2014 +0200 convert Edit autocomplete Hdl to boost signals2 where the conversion was... - if ( maAutocompleteHdl.IsSet() ) + if ( autocompleteSignal.empty() ) instead of the correct + if ( !autocompleteSignal.empty() ) Reviewed-on: https://gerrit.libreoffice.org/22477 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e919bfcaa5561445ebf39f73171bf1c934818d1a) Change-Id: Ie87944d66958af595e64b41236bbf515ef7a1f98 Reviewed-on: https://gerrit.libreoffice.org/22478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-02-18Resolves: rhbz#1285356 force swing not to use gtk2 if gtk3 is loadedCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/22433 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> (cherry picked from commit 9f7f881d11ceb4e2534758b9507a55292ec697b0) Change-Id: I6347bf4c25ce649073afdfe4225182ab2dc84af1 Reviewed-on: https://gerrit.libreoffice.org/22464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-02-17update graphite to 1.3.5Caolán McNamara
(cherry picked from commit c64ea526dc71da6e3aad188ac71e58047ed74b5a) and sync the various upgrade patches together Change-Id: I3287d51430d7a0901dd8bbf2458b845bcf92a8d2 Reviewed-on: https://gerrit.libreoffice.org/22210 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-02-04Resolves: tdf#96653 distorted images on export to pdfCaolán McNamara
regression from: commit ffe150ce903d9cdc62c25ad3437e61d24ede17d6 Date: Fri Dec 4 18:19:08 2015 +0100 tdf#94739 use GetScanlineSize instead of calculating it which was on the right track in the sense that the original code was wrong and only worked for <= 8 bit depth images Change-Id: Iee54a9f29dd0fdaf3e1f2aeb7b9898cecb453e37 (cherry picked from commit 384c815eda697d75706f686dc2ceb227b4d3f245) Reviewed-on: https://gerrit.libreoffice.org/22076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-01-27Resolves: rhbz#1257635 after httpConnectEncrypt use cupsGetDests2Caolán McNamara
sometimes after calling httpConnectEncrypt + httpClose and then calling cupsGetDests we get no printers found. Using cupsGetDests2 with the return of httpConnectEncrypt consistently provides results. Change-Id: I7ea5b11fbaabbd7ca73e5c94d0757ebdea8445ad (cherry picked from commit 6b86edae5c1eee51ee754b8013d463497bb75f65) Reviewed-on: https://gerrit.libreoffice.org/21716 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>
2016-01-26Resolves: tdf#97331 use VclPtr instead of pointers to avoid crashCaolán McNamara
(cherry picked from commit 5d29ed1801a07d4649e095c25935b50f5ad32eb4) (cherry picked from commit 53e693ccfb19aa653ab2b5762c10ae87c9320954) Change-Id: Ia653a67046cb2cfb7c96367a7483ddc0cb29819e Reviewed-on: https://gerrit.libreoffice.org/21810 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-01-25valgrind: memleak on thrown exceptionCaolán McNamara
(cherry picked from commit f5aefab2a62a90c631e05ec29022a2f7e19f00c3) Change-Id: I2788c5fe04a984d6534adbd3186cc652685152e8 Reviewed-on: https://gerrit.libreoffice.org/21737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-01-25valgrind: memleak on thrown exceptionCaolán McNamara
(cherry picked from commit 15b1080e624447ca1af1396023bb1fbfdb44fb26) Change-Id: If562dc69290021f898feff9f8e3983b867075172 Reviewed-on: https://gerrit.libreoffice.org/21736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2016-01-20Related: rhbz#1149116 collateEquals was set with OString::booleanCaolán McNamara
but extracted with toInt32() since commit c76cd71fe9bdefaef3f33f8ca193c32e3ab112ed fdo#41524: CUPS printing: use "collate" option when PDF is available though actual reported problem works fine for me with default f23 configuration already, this looks suspicious however Change-Id: I6fcb5df8039296c0e8b0fe931cb490396182de38 Reviewed-on: https://gerrit.libreoffice.org/21629 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e220ba8610f8315af473a230565daa978ca6a16c) Reviewed-on: https://gerrit.libreoffice.org/21631
2016-01-12tdf#94831: Check for null mpReadAccess before first useMatúš Kukan
There was erroneously added code before check in 45e8e0fbee40f9a8d91f4c559c8bbb16dd7b3f36. Change-Id: Ie2e84cfc061097c25e5d799e9c388abd9724bd93 (cherry picked from commit d5dcfe40ff3774d82a7b8f9f3d75b5b3cdac78ba) Reviewed-on: https://gerrit.libreoffice.org/21373 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-16Resolves: rhbz#1285364 urls cannot be opened under waylandCaolán McNamara
because we're setting DISPLAY always, and under wayland that resolves to "wayland", not the original ":0" so the gtk2 gvfs-open eventually called open xdg-open cannot open the correct display (cherry picked from commit 3bb7557d541328194eae928fda32b73650f13360) Change-Id: I246120f2430b92cd2d3e5003445aa4c9da4f6a68 Reviewed-on: https://gerrit.libreoffice.org/20721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-16Resolves: tdf#95700 index dialog cut offCaolán McNamara
queue_resize needs to invalidate the size cache even if there is a pending layout idle awaiting Change-Id: I6dba3d37fbb33125cc3f5d17aff6d2f7a3388654 (cherry picked from commit d40d756f4079a228035b5db346da50fe7aed0bd2) (cherry picked from commit c3a4bfcb0b6191665e63440b99fbf57080bd5c56) Reviewed-on: https://gerrit.libreoffice.org/20374 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-16tdf#95194: We need to set the GF flags in UniscribeLayout::GetNextGlyphs()Tor Lillqvist
The old SimpleWinLayout::GetNextGlyphs() did it. PDFWriterImpl::drawVerticalGlyphs() expects GF_ROTL etc to be set when necessary for vertical text when exporting to PDF. Change-Id: I1971dd2784efa3cd7274a32a51f61fdf197ec81a Reviewed-on: https://gerrit.libreoffice.org/20329 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-12-14tdf#94851 can't use OpenGLSalBitmap with WinSalGraphicsTomaž Vajngerl
Printing is done with the WinSalGraphics and not with WinOpenGLSalGraphics on Windows even when OpenGL is enabled, but the SalBitmap is still using the OpenGLSalBitmap which can't be used with WinSalGraphics. So detect when the implementation of SalGraphic is "wrong" and convert. (cherry picked from commit 1cc30679765ce996a009865e6bad3e5b74b96b41) also includes commit: tdf#94851 use BGR color order in Windows (cherry picked from commit 8a498fad249b3a92f275f33b683f242cb8d68b7b) and commit: tdf#94851 check SalBitmap & convert in all drawBitmap methods (cherry picked from commit 917d59a84124d1022bd1912874e7a53c674784f1) Change-Id: I67c730514a8a016c828b5cafdf6e70ddeca450ec Reviewed-on: https://gerrit.libreoffice.org/20659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-12-14gtk3: implement drawPolyLine for svp/gtk3 backendCaolán McNamara
by stealing the quartz impl (cherry picked from commit 3d22df17b33d6c66c3b7441bd220712ada53e667) Change-Id: I548042328144e23c68b83e461a63cdb0d7d8ff2c Reviewed-on: https://gerrit.libreoffice.org/20230 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2015-12-11tdf#94739 use GetScanlineSize instead of calculating itTomaž Vajngerl
We calculate the scanline size wrongly when writing a PDF so the image is not exported correctly. BitmapAccess already has a method to determine the scanline size so use that instead. Change-Id: Icccba8f26c5e0fd4bd4c37bba7c5a7fe8d0094bd (cherry picked from commit 82e0c38e1205a3c8a70234a95ca33ab1400fbe57) Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/20595 Tested-by: Jenkins <ci@libreoffice.org>
2015-12-09tdf#96070: Just give up on glyph caching for non-horizontal textTor Lillqvist
Change-Id: I60f54523f927e97d739a4c735e54b2cc3400aff3 Reviewed-on: https://gerrit.libreoffice.org/20436 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2015-12-04tdf#94138 Use correct fonts for multiline edit when printingTomaž Vajngerl
When drawing a multiline edit we need to use a different device (current window) to get the correct font and adjust for the Draw method's input device. Change-Id: I7993790c02d10e4283c7a4e2caefff0c7747e978 (cherry picked from commit 6c41727484a04ab89005ffb052937dae5d7dc223) Reviewed-on: https://gerrit.libreoffice.org/20332 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-30gtk3: implement GetIndicatorStateCaolán McNamara
(cherry picked from commit 503864037b2f6b73979f46d11df5d365b81f9dcf) (cherry picked from commit 6408b735283751cf6cacb8c758b99a2d90a9868a) Change-Id: I006c739a9dc876dd9ec83375f76fd1343b39557a Reviewed-on: https://gerrit.libreoffice.org/20312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-30gtk3: glitches because yours truly cannot tell x from yCaolán McNamara
(cherry picked from commit 2ca429e781cba94608e9838e2c1c50f1e8632b90) (cherry picked from commit 9401a065d0d53b31427f85a936ef53244ac8a6b8) Change-Id: I3b8620a4d8bffeb5e0558c35cb3a063238c12ba5 Reviewed-on: https://gerrit.libreoffice.org/20311 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-27fix baseline build (old cairo) - 'cairo_rectangle_int_t' does not name a typeChristian Lohmaier
Change-Id: I723122069541bc5752164554e693268267969b1a Reviewed-on: https://gerrit.libreoffice.org/20240 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-26Resolves: tdf#92687 implement drawPolyPolygon via cairoCaolán McNamara
modeled on the quartz impl (cherry picked from commit 742da70e6dd2407641835cbcac54b09aeddcb9db) Change-Id: I2f6776c14c7350954932df2bffcca36172f13473 Reviewed-on: https://gerrit.libreoffice.org/20083 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-26vcl: OutputDevice::GetTextArray() should always init pDXAryMichael Stahl
CppunitTest_writerperfect_writer file libmwaw/pass/Acta_1.0.hqx uses the font "Courier", and for unknown reasons we can't properly load that font, because the PhysicalFontFamily::mpFirst for "courier" is null. This causes OutputDevice::GetTextArray() to fail to create a SalLayout and return early before initializing the passed pDXAry, which then generates lots of DrMemory warnings. Let's hope the callers are happy about an all-0 pDXAry. Change-Id: I07b29a59660cf5cd060fd77da5d96021f9d8f9f5 (cherry picked from commit e6e409b684f9b046dcde9f0615018508f769c369) Reviewed-on: https://gerrit.libreoffice.org/20206 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-26tdf#95783: Don't calculate width of text with glyph fallback as way too wideTor Lillqvist
The old code in MultiSalLayout::GetTextBreak() only makes sense if the base level character width is zero where a fallback level has a non-zero character width, and vice versa. But this is not the case for Windows, at least not any more now when using UniscribeLayout and not SimpleWinLayout. This simple change fixes that: Only use the width from a fallback level if the width at the base level is zero. Hopefully it does not cause regressions for other documents or on other platforms. (But, I repeat, I find it hard to believe that the intent of the code could really have been to ever add two or more non-zero widths for the same character from different levels of fallback and use that.) Change-Id: Ic66c55db4b7463f9e04fcedec76f1c44f5e62e03 (cherry picked from commit a0d112a53023758a28d180ffd12766b4d325bf52) Reviewed-on: https://gerrit.libreoffice.org/20172 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-26tdf#91288 Does not display traditional Chinese variant ofMark Hung
Noto fonts correctly. LanguageTag()::getLanguage() would always return "zh" despite traditional Chinese were choose. hb_language_from_string() requires iso639-3 language tag except for Chinese, so we use use Bcp47() language tag for Chinese to differ zh-CN and the others. Change-Id: I6700a79a9c49a97d840b430def77741912935f72 Reviewed-on: https://gerrit.libreoffice.org/20027 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4424daa225e73d291a3fd64d369cdda5857f3d51) Reviewed-on: https://gerrit.libreoffice.org/20204
2015-11-18tdf#94008 Crash opening password protected file - CJK UITakeshi Abe
This fixes a buffer overflow writing over the end of pCaretXArray, which can happen e.g. when drawing mnemonics in the password dialog. Based on a similar calculation of nCurrIdx found in GenericSalLayout::GetCaretPositions(). Change-Id: I7d723cf8cfaeb66f340c7d9ea5b3bc728c6d6209 Reviewed-on: https://gerrit.libreoffice.org/19385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f630b6d5f165c8c507b8904b99594936edfd8da0) Reviewed-on: https://gerrit.libreoffice.org/20031 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-17Resolves: rhbz#1278885 gtk3 allocated size doesn't match configure-event sizeCaolán McNamara
so LibreOffice thinks its window is smaller than what gtk3 has allocated for it. For gtk3 (like firefox does) split size and position handling, leave position/move handling to the configureEvent, but listen to sizeAllocate and use that for the size handling. Leave gtk2 as it always was (cherry picked from commit 6adfbe62f6bb67d7d78c1561e9af5169d7f5bb9a) Change-Id: Ic52d6971595741ed658247b651e9e16c2ef9ed0b Reviewed-on: https://gerrit.libreoffice.org/19924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-12Resolves: tdf#93847 gtk3: paint blocking is unnecessary and harmfulCaolán McNamara
for gtk3. Probably also a fairly dumb idea for gtk2, but with the extra unblocking opportunities it probably just "works out ok" in that model. Change-Id: I3d4716c691fc84a5e68c210fee51f9e31cfacc02 (cherry picked from commit f9dfd0129ce0b0e21e3f57488ff513794dbbaae5) Reviewed-on: https://gerrit.libreoffice.org/19929 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-11-12Resolves: tdf#93317 Modified Document Dialog misses focus on Gtk3Caolán McNamara
Change-Id: I16ddac82a76a1e665797e4be192d3642f2660d9f (cherry picked from commit 82abd23f3ee1900b7579e5a0afa23581d5836f01) Reviewed-on: https://gerrit.libreoffice.org/19933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2015-11-12tdf#95761 All Hotkeys with CTRL+ALT+ not workedJuergen Funk
The problem was always masked out the combination ALT+CTRL, this only needed when press the ALTGR key, but the other ALT-Key (left side) is valid. Change-Id: I8a6f953f519627418fb48ee8d1d68b3cbf797250 Reviewed-on: https://gerrit.libreoffice.org/19923 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/19932
2015-11-11tdf#95481 catch out-of-range access in vcl bitmapArmin Le Grand
blendBitmap24 assumes bitmap is 2 lines high for doing interpolation. For bitmaps of height 1, really nothing to interpolate there. Fix cornercase by 'blending' between the very same line instead. Reviewed-on: https://gerrit.libreoffice.org/19863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Cherry-picked from 99e3ab6effa9356a1a444160e60ed8df099b15a3 Change-Id: I9b94000aa563e525d0bb2418346ad2c86af26df8 Reviewed-on: https://gerrit.libreoffice.org/19888 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2015-11-10tdf#81144 Chinese full-width punctuation does not align properlyMark Hung
Ideographic fullstop and comma in most Chinese fonts are centered, while those in Japanese fonts align closer to the left. Original compression algorithm trimed right side of the punctuation, making fullwidth fullstop or comma in Chinese font visually unbalanced. In worst case, it crowds together with the followed compressed punctuation. This patch fix the situation in the folowing way 1) make compression less stronger. 2) Trim space according to glyph bearing to font height ratio. 3) fix a memory access violation issue Reviewed-on: https://gerrit.libreoffice.org/19517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Conflicts: sw/source/core/txtnode/fntcache.cxx Change-Id: Icff215064e6c442fd36eac8e01b01fb6acb27594 Reviewed-on: https://gerrit.libreoffice.org/19764 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10compilerplugins: enhance "badstatics" plugin to find membersMichael Stahl
Finds static variables of types that have bad non-static members. (cherry picked from commit 10afa00c8ce4f0de9191cd182409a3a5d8e55bb8) Omit the actual compiler plugin, just the fix for the release branch. Change-Id: I81ee940580c0f043feb543840ea4d3dd27734202 Reviewed-on: https://gerrit.libreoffice.org/19829 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-10afl-eventesting: deref of null mpTextObjCaolán McNamara
Change-Id: Icdb7d1cc250640f428984b96b0a51ac950013cb2 (cherry picked from commit 0c39c456f47c14e2b7f86d1bc6857dc0e2ca6cb3) Reviewed-on: https://gerrit.libreoffice.org/19814 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-11-03svx: add result of "badstatics" plugin to fix abuse of VCL BitmapsMichael Stahl
VCL Image/Bitmap/BitmapEx instances must not have static life-time because then they will be destructed after DeInitVCL() and that likely segfaults. (cherry picked from commit bf18f1b3535dd17f9bf584cab15ee6a7fd431257) Omitting the plugin itself, the fixes should be enough for release branch. Change-Id: I3ff8d32de729c971b190028094cb4efe206395e2 Reviewed-on: https://gerrit.libreoffice.org/19742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-10-30tdf#94138 also apply settings when printing (Draw call)Tomaž Vajngerl
(cherry picked from commit 93a007b1b02c13025b08bcefe19dd54e24e2b80f) Change-Id: I72056f3e167923f00c37648a24190b533eb9b471 Reviewed-on: https://gerrit.libreoffice.org/19655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-10-28tdf#75637: Resolve help images via a vnd.libreoffice.image UCPStephan Bergmann
...which uses the logic already available in VCL's ImplImageTree to locate the image zip files and find fallbacks for incomplete themes and for localized images. (cherry picked from commit 6948c546fdc00dddec7d58e03150dcc87921d6b2, plus f5174c89cd037d35b975590083cf91b36633808d "...but do not erase localize attributes from image elements," which is needed to make localized image references work again) Conflicts: vcl/osx/vclnsapp.mm Change-Id: Ic1c15fcacb6596a27a2b051093232902202bf472 Reviewed-on: https://gerrit.libreoffice.org/19644 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-10-28tdf#94022 Print dialog: hide Installable OptionsMichael Weghorn
Options specified in PPD files can be grouped using the keywords "OpenGroup" and "CloseGroup". The keyword "InstallableOptions" is used as a group name for a group containing options that define optional hardware features of the printer that can be present or not (s. section 5.4 in version 4.3 of the PPD specification). As they are not print job specific, it is recommended not to show them in the print dialog. To be able to distinguish those options, the PPD group name was added as an attribute to the PPDKey class. Reviewed-on: https://gerrit.libreoffice.org/19623 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit f8d0dc09e15b36ae83a5e89280d1f7fbc01da48b) Conflicts: include/vcl/ppdparser.hxx Change-Id: I4a3abf23a711ad98556c0b608a07ef0a91e77e2b Reviewed-on: https://gerrit.libreoffice.org/19630 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2015-10-27take the world scaling factor for fonts, but not the rotationCaolán McNamara
regression from commit 8f705df1221c3f92d8cde68bdf726a7c3ce8fe1b Author: Tomaž Vajngerl <tomaz.vajngerl@collabora.com> Date: Fri Jul 18 13:36:13 2014 +0200 bnc#881024 Don't world transform font size in WMF/EMF import which seems to be a regression from commit 1281c1f52b77c4c4fb08e129542c2c4912b38555 Author: Armin Le Grand <alg@apache.org> Date: Mon Dec 10 16:08:58 2012 +0000 Resolves: #i121382# Corrected size handling including font size handling... for EMF/WMF imports Change-Id: I87307c9993d3343b4db636257e2567b10a73b79d (cherry picked from commit 4eb70290210022860294644d67ba50d55806621c) Reviewed-on: https://gerrit.libreoffice.org/19559 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-10-27afl-eventtesting: crash on undoing insert new page in impressCaolán McNamara
this is an intermittent crash in the real world but under event testing we can see that the PaintView is informed that the page has been deleted, but doesn't clear its use of the page if it so happens that there was earlier modification events that caused the fire-modification-timer to be launched If there happens to be no such events then the page is correctly cleared If the timer is active, then the page is not cleared, but eventually the timer will fire and access the deleted page and fall over and die minimal change for backporting ease, follow ups now (cherry picked from commit f8b975995c5d0dc6a9fc8febba0667fe24542ad2) Change-Id: I090ad62cc175545902574c93dec7082225d97ab7 Reviewed-on: https://gerrit.libreoffice.org/19551 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-10-27tdf#95096 avoid invalid cursor position exceptionJustin Luth
Somehow, accessible text can lose focus and so when attempting to set the cursor, the string we were just working with may no longer be available, so verify that the cursor position is still valid before setting it. If the text can just disappear like that, then potentially we are still forcing the cursor into the wrong place (since the string is different than expected). However we can at least make sure the program doesn't crash/exit without saving... Change-Id: I8dcaf4625d187cb75008bdc0af0e3a546090a018 Reviewed-on: https://gerrit.libreoffice.org/19414 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit d9cf47449e88032803aa4fa3429cd607a074d5ad) Reviewed-on: https://gerrit.libreoffice.org/19418 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-10-23tdf#94138 fix printing of edit form fieldsTomaž Vajngerl
There are 2 bugs: - In Window::GetDrawPixelFont we asked for the font to the current window, which didn't work correctly when printing. The device itself should provide the font and not the window. - In paint method the font wasn't setup correctly which should happen before painting by calling ApplySettings. The effect of this is that print preview didn't show the correct font for the edit control and similar when you copy + paste the edit control. The work around for this is to call ApplySettings again. Change-Id: I74960355823c71c1d5a18a82bbc86561a3c4b760 (cherry picked from commit 825b3df7f1d987021ec4a08ff8e7ed78e5772c97) Reviewed-on: https://gerrit.libreoffice.org/19530 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-01 10:07:09 +0000