summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2022-02-14jsdialog: correctly clean statically created message dialogsSzymon Kłos
- remember WindowId for statically created message dialogs - remember _DIALOG_ handle for message dialogs so response action can be done Change-Id: I1f6c9877e20dcbed4855b32d1e89d9ce3ff12111 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125686 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129169 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-14jsdialog: send popup when launched using Popover widgetSzymon Kłos
- enable validity listbox in online - flush when sending close popup to be sure it is sent Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Icf33e26c48b78ab60030a7395e8c7ee5462fbf7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125647 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129168
2022-02-14jsdialog: use string identifiersSzymon Kłos
Thanks to that it is easier to debug and find widgets in maps. Sidebar and notebookbar are now in different map entries. This fixes the issue when destroying notebookbar deleted sidebar's widgets. After this patch sidebar works correctly when using notebookbar mode in lok. Change-Id: Ie9dcb82675129bdb567b766e29779744f500cb48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125216 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128853 Tested-by: Jenkins
2022-02-14jsdialogs: use for MessageDialogsSzymon Kłos
Change-Id: Ie82558356cd9669f21afefd1ee88d769bf28eb8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124270 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127676 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2022-02-14Make View Certificate sub-dialog asyncSzymon Kłos
Change-Id: I0e1a6a59d856ab266511fc3d6be87fe04c5afdfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124143 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128840 Tested-by: Jenkins
2022-02-14Make View Certificate dialog asyncSzymon Kłos
Change-Id: Id93145ecf6be3cb558f0ce8d3cc340bbc67095e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124061 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128839 Tested-by: Jenkins
2022-02-14jsdialog: enable Digital Signatures dialogSzymon Kłos
In LOK case run it in the readonly mode. In readonly mode we can run it asynchronously. Change-Id: I721dd14fa23d4e30255dd976e0cc2a4f30470a3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124058 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128838 Tested-by: Jenkins
2022-02-14jsdialog: activate tabpage after switchSzymon Kłos
Change-Id: Ib9f61f9e219f1775bccccdb2304cc7ce9fc8a1ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124150 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127675 Tested-by: Jenkins
2022-02-14jsdialog: weld Image widgetSzymon Kłos
Change-Id: Iaf900da5d6256b1aa441dc0dad07ba967f88b085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123877 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127671 Tested-by: Jenkins
2022-02-14Move SalInstanceImage decl to header fileSzymon Kłos
Change-Id: Ic71e10a9cb296e8fed366b7dd622d8875d68f2d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123876 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127670 Tested-by: Jenkins
2022-02-14jsdialog: export common properties for ImageSzymon Kłos
Change-Id: Id01686106477cc1911fb5ec345ffcff5537e0de6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123884 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127668 Tested-by: Jenkins
2022-02-14lok: add drag & drop functionalityHenry Castro
In the desktop case, the drag over and drag drop events are handled external like GTK framework. In tiled rendering case, we do not have it, so handle the drag and drop events in the cloned ImplLOKHandleMouseEvent function. Change-Id: Ib41232b3b9d5d6d859b2c965311b87af5d193ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118869 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117896 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: fix the "mbStartDragCalled" statusHenry Castro
The drag starts it is only called when mouse down + mouse move. Change-Id: Ifadfd904c2be28bd123c17a47a82f49dd6d5a04a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118867 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117895 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: add private member transfer data to GenericDragSourceHenry Castro
In tiled rendering case, the class GenericDragSource is created by default, but it does not hold the transfer data and it cancels the drag & drop. Change-Id: Ib96f426a42e1fdae823e2412dc5280d70b59c44f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118866 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117894 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: add generic class DragContext, DropContextHenry Castro
In tiled rendering case, there is no exists a generic dummy to fire drag over and drag drop events. Change-Id: I1d334df8316a09950c11bc365f12f28f0352dfc6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118860 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117893 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: introduce local mouse trackingHenry Castro
Add the term local mouse tracking per frame window (per user) instead of global mouse tracking in the desktop case. Change-Id: I3f8c55fc770b4ac7dea167385586d8639ac4d93b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118856 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117777 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: introduce Application::LOKHandleMouseEventHenry Castro
Entry point to call the ImplLOKHandleMouseEvent function mainly to process mouse events. Change-Id: I17513643733bf5990d41ab8cf47cdc322ed526ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118846 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117711 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14lok: sc: introduce ImplLOKHandleMouseEventHenry Castro
In tiled rendering case, each user has a View/Controller object to interact with a unique document (Model) for collaborating purposes. However, in the desktop case a unique user has many View/Controller objects to handle a unique document, so the user has only one global active focus, capture and tracking window object. In order to handle independent drag & drop for each user, it is created ImplLOKHandleMouseEvent. Change-Id: I735fae9b9858a75f9fedb603798220ab302d65f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118843 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117708 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-02-14use more cppu::BaseMutexNoel Grandin
Change-Id: Iddd7438161ead93b27cf8e8058ca5b1eae3d8001 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127075 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-02-14tdf#126319 Corrected bitmap creation from metafileArmin Le Grand (Allotropia)
The conversion from Metafile to Bitmap in GraphicExporter is based on metafiles which does just not deliver enough precision when getting the bounds to do the correct size calculation for the target Bitmap. So I changed that to use Primitive functionality what produces better data. That old fix/correction itself was based on hairlines only which is anyways no longer sufficient since LO uses less hairlines nowadays, what is good in general (They are a relic of non-AA times when it was not possible to paint/work with lines taller than one pixel). Thus, cases need to be solved more generic based on better data. It would also be good to change this to primitives completely, but that is too much for now. Change-Id: I71bd136b106ef8ff3ba51458c46df08269773c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129235 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129810
2022-02-14tdf#147251 can't generally shrink popovers if they don't fit under/overCaolán McNamara
so instead forget about forcing under/over if it doesn't fit on either side and just position so its visible Change-Id: I529bf0d2bb1a3108a8702792ef067372441c2002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129614 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-14PDF export: increase default precision of doublesMiklos Vajna
Follow-up to commit 50682cea4196819980c8e2d4018f80384097ce6f (PDF export: improve precision of pdf image sizes, 2022-02-04), sounds like a good idea to do this in general, not only in that specific case that was required for the test to pass. Change-Id: I5b36a5a3be26132e96a4de9d224abcaaf79beadb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129599 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 30585873ca8c861aa2d13f85797930f62195ee55) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129613 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-14PDF export: improve precision of pdf image sizesMiklos Vajna
This helps exporting full-page PDF images from Draw more accurately. In case the page size was A4, then the page height is 841.8897637795276 i.e. 842 points. Full-page PDF images are scaled to this size, so the referred PDF form XObject has the reciprocal of that scaling. We used to just write 0.00118, doubling the precision leads to 0.0011878840. In practice the old precision resulted in e.g. hyperlink rectangles to get out of sync with link text after 2 roundtrips, while the new precision doesn't result in any noticeable modification to the link text position after a roundtrip. Change-Id: I72cc68696b9b9bcc1cbfde8df331c2b9c5f9eb29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129482 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 50682cea4196819980c8e2d4018f80384097ce6f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129608 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-13[cp] Collabora Office brandingAndras Timar
Change-Id: I694d9a6c508853d2d980f76cc259ce1e39149da4
2022-02-07test fails with both fedora KacstBook and bundled KacstBook installedCaolán McNamara
fedora KacstBook ver is less than bundled KacstBook ver so bundled is preferred, bundled KacstBook has no Latin glyphs, but glyph fallback finds system one and sees it has the missing glyphs, determines that the whole thing can be done in the fallback font, so the toplevel is unused and so "invalid" and this test fails on checking that. The test is supposed to ensure that glyph caching gives the same result as uncached, which it does, so just assert if there is a difference between cached and uncached Change-Id: I3c424a17f3e544aa64f4af98e0c151fc00b2e6e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129437 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07this test assumes KacstBook has no Latin glyphsCaolán McNamara
which is true for the one bundled with LibreOffice but is not true for the fedora one (kacst-book-fonts-2.0-26.fc35), but neither of them have Cyrillic glyphs Change-Id: Ide8b84502886c7b9e0bc4fcef4685b4b89ec2bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129436 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07this test is endian-dependantCaolán McNamara
Change-Id: I03c1c926441f80c3741bb7d9231363603d0dbffe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129551 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-07qt5: crash entering ë with french IMCaolán McNamara
which for me with french IM enabled on my keyboard is physically AltGr+[ (crashes here on trying to underline ¨ with a length of 2) then e. Change-Id: Id59bd84af2ab4d8403b11b1a13efb2bbdb608199 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129547 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-02-06Resolves: tdf#147218 label doesn't have use-underline setCaolán McNamara
so the _ is shown to the user, not used to add an underline Change-Id: I2de707a2d1da8d842ef03497f9b8f69d37368f12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129442 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-05Avoid -Werror=dangling-pointer=Stephan Bergmann
> vcl/source/bitmap/Octree.cxx: In constructor ‘Octree::Octree(const BitmapReadAccess&, sal_uLong)’: > vcl/source/bitmap/Octree.cxx:69:17: error: storing the address of local variable ‘aColor’ in ‘*this.Octree::mpColor’ [-Werror=dangling-pointer=] > 69 | mpColor = &aColor; > | ~~~~~~~~^~~~~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘aColor’ declared here > 67 | BitmapColor aColor; > | ^~~~~~ > vcl/source/bitmap/Octree.cxx:67:21: note: ‘<unknown>’ declared here (new with GCC 12) Change-Id: I5b1ffa15b92f2c41dbe51dfa843eb6bab3a4b449 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128517 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5db574727f4564238a54159a1a0673eaa2884b69) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129444 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-02-04fix direct leaks in vcl cppunit testsCaolán McNamara
the uses of new are wholly unnecessary Change-Id: Id7238be6e73567add8a0d3ed6dc9f3262e15c043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129435 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-02-04tdf#125849 cannot modify the ruler unit of measure in translated UICaolán McNamara
Change-Id: Ica74dd5e55d30605ee03affa4b724ffa4ec65b5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129333 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-02-03fix std::min() used instead of std::max()Luboš Luňák
In 534fc16a9f8cd01bb88485e2cf6b9cd33aed3745 I got this backwards, if the value is not supposed to be 0, then it should be at least the small value, not at most. Change-Id: Ic55d2b2402985d26e77be0d1605b9ba5985b5ac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129277 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129325 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-30Resolves: tdf#147013 transform the control point positions tooCaolán McNamara
Change-Id: Ia73317a79de66778d4b2d0face07ee4c41e328d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129078 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-29make sure to not divide by zero when computing miter limitLuboš Luňák
The minimal angle is valid only if the line join style is miter, and e.g. FileDefinitionWidgetDraw can call these with round join style and 0 angle, which would divide by 0. So either clamp the value or compute it only when needed. Change-Id: I2a2c71481490c03ec6d01b8e33cab991400adb35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129006 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129029 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-27tdf#144166 use border drawing style for VclScrolledWindowCaolán McNamara
to avoid rounded rectangles on Windows. Change-Id: I29b9631ec0f3d125cbf103b0c12580a41f9b9264 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128964 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-26tdf#146992 gtk_window_set_attached_to causing widgets to shiftCaolán McNamara
which isn't desirable, just drop its use. Change-Id: Ic29efa9e785cad3c221e0ef37816b8485979e719 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128957 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-26avoid Xlib cairo surfaces for small virtual devices (bsc#1183308)Luboš Luňák
The (private :( ) document contains a large number of small shapes for which VclProcessor2D::RenderTransparencePrimitive2D() gets called, which results in GetBitmapEx() on the VirtualDevice. And Cairo normally needs to do a roundtrip to the XServer to fetch the content, which makes the rendering pretty slow. Forcing image-based surface for small sizes of VirtualDevice actually has better performance for the document, and the lack of possible HW acceleration generally shouldn't matter for a surface this small. Additionally drawinglayer's VirtualDevice reusing tries to reuse even a large one when a small one is needed, so a hack is needed to avoid that in this case, I couldn't find a better way. Change-Id: I0f58659ab88165a6bd915f100fc3b1d4802a0fa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128309 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit cf9be3417bc2be5f772c03180b7cbd248b82cad5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128815 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-25tdf#146941 qt: QtFilePicker::finished needs SolarMutexGuardMichael Weghorn
Change-Id: I4165c72ddd6370c8fe7faf55f9db831359f6f8a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128923 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit a85908f507f39c88a6cf244f5f4120361ad5e2ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128826 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-25gtk3: "expand" icon in reference windows goes missing on entering shrunk modeCaolán McNamara
Change-Id: Ie303f82d1cc0de10ebd14248a31111a16be344f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128814 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-25tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issuesCaolán McNamara
so leave it alone, and do the conversion just for the originally report situation as a safely backportable change with a follow up to not allow us to get into this situation in the first place Change-Id: I4f95f85791d0f937e53d7541804870b2cbf62b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-20tdf#141340 PDF export: fix hyperlinks on the wrong page with page num rangeMiklos Vajna
Regression from commit 01dbb38680aa39a4d3bc7afd05d44a4b2c9bc6ab (tdf#61274 sd PDF export: fix links ending up on wrong pages with hidden slides, 2020-03-10), the problem was that the sd/ code that mapped page numbers between the model and the PDF output only handled hidden slides, but not partial exports. Fix this by revisiting the decision to handle hidden slides in sd/, the filter/ code at the end does have enough information to correctly do this mapping at the end, and this way both tdf#61274 and tdf#141340 can work at the same time. (cherry picked from commit 31bbaf478783e3a2c21bd3ea94ddf39299a63d1e) Change-Id: I5679743ca67fab562e14c73e32f1a06ead8e7a31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128647 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-16Qt notify LO of many QScreen related eventsJan-Marek Glogowski
LO just has a single display event, SalEvent::DisplayChanged, Qt has a multitude. So this will generate multiple LO notifications. I don't see any reasonable way to prevent that. Doesn't seem a problem here. Change-Id: I2f11e53765869a4ca292a1d337347e4e7470e3c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128474 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ced4cde59eb51e4364daf69520a184b55c2c54db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128434 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-01-11PDF export of PDF images: preserve hyperlinksMiklos Vajna
The input file has a single page, with a full-page PDF image, which contains a hyperlink. Similar to pdfcrop, we used to wrap this into a form XObject, so page-level annotations like hyperlinks were lost. Explicitly merge page-level annotations from the source page to the page that contains the PDF image to preserve those annotations. Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128108 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 1984a5c140cc3c7c291047dacf3bddd7061d2047) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128156 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#73523 support WinBMPv3-NT version of BMP files (found in Visio files)Andras Timar
It is a special case when there are additional 12 bytes of color bitfields after the info header. See also the useful comments at https://searchfox.org/mozilla-central/source/image/decoders/nsBMPDecoder.cpp#47 It turned out we generate this type of BMP files internally from EMF files, but in that case the bfOffBits of BITMAPFILEHEADER struct points to the pixel data. In case of Visio, bfOffBits points to the color mask. There was no better solution than preventing jumping back in the stream. Change-Id: I97f0fd4f184ea77beeab8b22fc98fdb78472d9bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127920 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127927 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3a0d539b3a8a76efc2cdac04c658645fe750bec4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128158 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-09tdf#146641 allocations attempted while hidden are discarded by gtkCaolán McNamara
Change-Id: I46288cf4c106e2763feba298f1c44dbbf6c85581 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128080 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-09Resolves: tdf#129745 don't override child help for application framesCaolán McNamara
the glue WindowInstance is created on demand, and on creation descends into any existing open dialogs and changes their help handlers. We could not descend into child dialogs, but we shouldn't change the app frame help handler anyway. Change-Id: I8d149d324f04824fbe9eec517d8c482fd96b125b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128075 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-04Always use <poll.h>, no modern system needs <sys/poll.h>Ismael Luceno
This was standardized in IEEE 1003.1-2001, so more than 20 years old. Verified following systems using online resources: - FreeBSD 3.0 (1998) - NetBSD 1.3 (1998) - OpenBSD 2.0 (1996) - CentOS 5.0 (2007) - Debian 4.0 (2007) - IRIX 6.5.30 (2006) - SunOS 4.1.3 (1992) - SUSE 10.2 (2008) - Red Hat 5.0 (1998) So the check used for BSDs on vcl/unx/generic/dtrans/X11_selection.cxx was never correct. On GNU/Linux specifically, <poll.h> is provided since glibc 2.0 (1997). musl libc produces the following warning if the non-standard header is included: /usr/include/sys/poll.h:1:2: warning: #warning redirecting incorrect #include <sys/poll.h> to <poll.h> [-Wcpp] Change-Id: Ia8f4b9e1ee069f86abe03140c18a77d17336d09c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127666 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 4242c7b91887236375e08e2b6b24de0cecbf1626) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127586 Reviewed-by: Ismael Luceno <ismael@iodev.co.uk> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-22tdf#131467 Qt set default position on first resizeJan-Marek Glogowski
Setting the position in Show() is too late, because LO will try to set the mouse pointer to the default button, if configured. That obviously needs the window position. And also take the menubar offset into account. Change-Id: Ia280539c082ff6f675966869fb6643a41a17d696 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127154 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit ca28826a087245686d7fca3ffc8ca1f03307924d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127185 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-21Qt use asChild for pointer positioningJan-Marek Glogowski
.. and refactor some variable names. Change-Id: I7d31a7a377f614bdd78f8d09852a2eda0cc47442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127153 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit e63fe68fb1d0915b64fdf63f7fa6eed866fa3a0d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127173 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2025-03-10 13:38:05 +0000