summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-05-11remove some unnecessary temporary OUStringsNoel Grandin
found with: git grep -nP 'OUString\(\s*\w+\s*\)' | grep -v new | grep -v return Change-Id: I923109b4339210aed2639e423fbc4d5f19233f02 Reviewed-on: https://gerrit.libreoffice.org/37463 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-10Resolves: rhbz#144437 make gnome-documents not crash the whole timeCaolán McNamara
accept that once initted that LibreOffice cannot be deinitted and reinited (without lots of work), but allow the main loop to quit and restart so LOKs thread can run and exit successfully, new LOK connections will restart the main loop. The buckets of global state continues to be valid the whole time this way Change-Id: Ide54c0df2ce4065f7c192ae8c2cedfaaa2b58d72 Reviewed-on: https://gerrit.libreoffice.org/37399 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-09cleanup osl/diagnose.h includesJochen Nitschke
with command > git grep -l osl/diagnose.h *.cxx | xargs grep -L -w 'OSL_\w*' | xargs sed -i '/#include *\(<\|\"\)osl\/diagnose.h\(>\|\"\).*/d' headers need more work Change-Id: I906519ebbd47a04703b4fa5943b2f7abea7a97ab Reviewed-on: https://gerrit.libreoffice.org/37350 Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-05-09make loplugin constantparam smarter about string paramsNoel Grandin
Change-Id: Id3df69b38fd35f46735246a6d307a89aa10d4294 Reviewed-on: https://gerrit.libreoffice.org/37426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-09coverity#1250405 Division or modulo by float zeroCaolán McNamara
another stab at this Change-Id: I893f4b4a211a85718bf51bfbdb3e8bdb1df0066c Reviewed-on: https://gerrit.libreoffice.org/37405 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-05-09remove unnecessary empty OUString fields and varsNoel Grandin
Change-Id: I940120087a0bc6b1b0abc30a3e7727ce22b7d9a7 Reviewed-on: https://gerrit.libreoffice.org/37394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08vcl: split jpeg import into two partsMiklos Vajna
Split the import into two: 1) Just create the bitmap, this part is not thread-safe (e.g. OpenGLContext::makeCurrent() is called when OpenGL is enabled). 2) Import the image into an existing bitmap. The point is that the second part takes much more time than the first, and in the future that part may be executed on a thread, while without such a split the whole ImportJPEG() can't do that. For now GraphicFilter::ImportGraphic() simply invokes the two parts after each other, so no real functional changes yet. Change-Id: Iee742a2cd3c581aeaf1a1ed9f55cd543955a85e0 Reviewed-on: https://gerrit.libreoffice.org/37397 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-08Resolves: tdf#107693 move CreateAutoMnemonics from Execute to ActivateCaolán McNamara
Change-Id: Id65dfcc40dd20c391e12108abc6a6531e4c96523
2017-05-08cleanup tools/debug.hxx includesJochen Nitschke
with command > git grep -l tools/debug.hxx | xargs grep -L DBG_ | xargs sed -i '/#include *\(<\|\"\)tools\/debug.hxx.*/d' don't change files in includes/ and */pch Change-Id: Ie429d6a7dca5dfa1073e0f5ba037f7c84bdbec08 Reviewed-on: https://gerrit.libreoffice.org/37349 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08hNonAliasedFont is unusedNoel Grandin
ever since commit e45d80f20ff6a05888f92ae942abed67609d5b20 Author: Tim Eves <tim_eves@sil.org> Date: Tue Feb 23 16:45:21 2016 +0000 "tdf#97171: Use DirectWrite for OpenGL glyph caching" Change-Id: Ib6675e89caa68a5ee725a36a0d5ded973cc98723 Reviewed-on: https://gerrit.libreoffice.org/37348 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-08teach loplugin:constantparam about simple constructor callsNoel Grandin
Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9 Reviewed-on: https://gerrit.libreoffice.org/37280 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-07tdf#106265 ScopedHDC to clean-up hDC when rendering glyphsTomaž Vajngerl
Change-Id: I96ecf625126740610200c012c3c7002fac7e1548 Reviewed-on: https://gerrit.libreoffice.org/37347 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2017-05-07Revert "coverity#1250405 Division or modulo by float zero"Caolán McNamara
This reverts commit 445ac42cc2f2f759a43d97198039b980026ed70e. Change-Id: I4f106a67385776262f187e63c445ea8c0cb0207b
2017-05-07break circular includeJochen Nitschke
of include/vcl/window.hxx and include/vcl/vclevent.hxx Change-Id: Iacb3cc942693a732de5899af26e08e0977a83102 Reviewed-on: https://gerrit.libreoffice.org/37338 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-05-07revert OSL_ASSERT changesChris Sherlock
Change-Id: I365d140446bd2a62cf8256acbfdd53fe72987380
2017-05-07tdf#43157: convert most of vcl codebase away from OSL_ASSERT to assertChris Sherlock
Change-Id: Ifaae7af7169fe6c24d152f8aba51ba3ff3bdb9f8
2017-05-05tdf#103158 ctrl+shift should work on key upMaxim Monastirsky
Under gtk/gtk3 we send CommandEventId::ModKeyChange on key down, to support the auto-accelerator feature. But at least the handler in SwEditWin::Command must get it on key up, in order to not interfere with other ctrl+shift+X shortcuts, which work on key down. To achieve that, we need: - On key up pass the key that was just released, instead of the current state of nothing being pressed. - Have a flag of whether it's a key down or up event, so it can be checked by the application code. Change-Id: If188d6ccdc3b214a2c3ed20aad291d74d46b358f Reviewed-on: https://gerrit.libreoffice.org/37275 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-05-05loplugin:checkunusedparams in vclNoel Grandin
Change-Id: I0d8f230b52fc64a2f8a8519d458a7a766ce685eb Reviewed-on: https://gerrit.libreoffice.org/37277 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-04CppunitTest_vcl_pdfexport: replace std::search() with pdfium callsMiklos Vajna
The old code would also pass if the page has e.g. a literal "re f*" string (since the tokenizer doesn't parse streams), the new one uses a proper parser. Change-Id: Iabb242b420c14f619f716f5ba47a1165a942f88a Reviewed-on: https://gerrit.libreoffice.org/37223 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-05-04Replace all OUString("") with OUString()Arnaud Versini
Change-Id: Ie14c4d76cb61cfbe0410103adfc1afc8ade0f3e0 Reviewed-on: https://gerrit.libreoffice.org/37146 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-05-03iOS remove unused parameterjan Iversen
Removed pSys parameter from IosSalFrame Change-Id: Ib61f09448ef0c6751d4261b11d6a7b9dc45e786b
2017-05-02log exception that results in crash for crashreporterMarkus Mohrhard
Change-Id: I05bb38f9c440c26bfaa1d37ef67e5aab13d7a4d2 Reviewed-on: https://gerrit.libreoffice.org/37174 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-05-02printerinfomanager.hxx can be moved into vclCaolán McNamara
probably was exposed while padmin was still a thing Change-Id: I9605b7ae0c5bc59aa998580f5a28dc7b527219e9
2017-05-02add ww6 fuzzerCaolán McNamara
Change-Id: I7e84f29b321676c373f86acba375816a0e9ad386
2017-05-02Resolves: tdf#99467 pasting text from java apps to gtk3 gives bad resultsCaolán McNamara
Change-Id: Ib2625c900def20baa470f0a15e4f72a3f763099e
2017-05-01tdf#107526: fix icon managementJulien Nabet
by following http://opengrok.libreoffice.org/xref/core/vcl/inc/svdata.hxx#91 Change-Id: I57d13e33c31f25580c93ef2abfec78e9386a8c04 Reviewed-on: https://gerrit.libreoffice.org/37126 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-30coverity#1405737 (golden) Logically dead codeCaolán McNamara
regression since commit 46a153cbcac1a3e2881b83b5537037321c34797c Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Sun Apr 23 18:53:58 2017 +1000 vcl: update error codes to defined constants for code clarity Change-Id: I6e86c45b71fc15d6645501128e7d86f8e179e652 Reviewed-on: https://gerrit.libreoffice.org/36851 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com> Change-Id: Id1a3f26a84c7641b0b6af71dc842a683d0c1dd0c
2017-04-30coverity#1405740 Resource leakCaolán McNamara
Change-Id: I6537e818a783ef908e2ae4d068752669529fb75e
2017-04-28loplugin:salunicodeliteral: vclStephan Bergmann
Change-Id: I4a982da10ad76f8ae05355cec9629b906c95afdb
2017-04-28move builder attributes from OString to OUStringCaolán McNamara
Change-Id: I235188c9a086337b104e600f31a1c81deeca6c17 Reviewed-on: https://gerrit.libreoffice.org/37076 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-28loplugin:cppunitassertequals: vclStephan Bergmann
Change-Id: I0b1b279b9bbb82b5e7aff0b0fb6a5be0ee0b3f62
2017-04-28iOS, fixed build breaker.jan Iversen
Fast fix to build breaker from commit 3a36cf434fb4a967c9ea767cb7ac5f4da0502a0d Removing the parameter from the constructor gave ripple effects to move/copy constructors, so not done for now. Change-Id: I98e060e80946dbfe6586744e4f362ccb358a210d
2017-04-28probably android build fixCaolán McNamara
Change-Id: I95fe4879fe2e43e5b11165a703066ae1a029b5b1
2017-04-28loplugin:checkunusedparams in configmgr and vclNoel Grandin
Change-Id: I7226d01f38e6edaf3868d7267d9b02dbdbc9e5ba Reviewed-on: https://gerrit.libreoffice.org/36975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27tdf#39468 cleanup source code commentsdennisroczek
* translate German source code comments * remove ascii art * remove bogus source Code comments * remove old StarOffice/Sun internal bug tracker references Change-Id: I443bf2fdba3780c411d69809111daf3aa3a48451 Reviewed-on: https://gerrit.libreoffice.org/36005 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-04-27no bitmaps in .src files anymoreCaolán McNamara
Change-Id: I0228cae8590366be5d5f0d431cf655942bbb891c
2017-04-27loadFromResource is now unusedCaolán McNamara
Change-Id: Ibea3defdf8d2642c4ba523db7f4fc8fbc2473488
2017-04-27Uwinapi is not used any moreTakeshi Abe
since de030cd7a234fd9191364647deb1a4836ca992cb. Change-Id: I4cd908cc08481c5a6cf6d41c89ac8a5fef95f6db Reviewed-on: https://gerrit.libreoffice.org/37021 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-27WaE: declaration of ‘nUserId’ shadows a member of ‘StringErrorInfo’David Tardon
Change-Id: I027346fb3c98e830b9515ae842cb5a3fb231420d
2017-04-27vcl: change pImpl class names to fit with existing conventionChris Sherlock
Change-Id: Iec6ce77f922df222d48240be09a817f5289a6662 Reviewed-on: https://gerrit.libreoffice.org/36861 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: move doxygen comment to headerChris Sherlock
Change-Id: I486843fc4b9da3fc5fc161e90768b0443530071a Reviewed-on: https://gerrit.libreoffice.org/36859 Tested-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: rearrange order of functions in errinf.cxxChris Sherlock
Change-Id: Ifbde0423e228151e1572e81a443f63355c9bc760 Reviewed-on: https://gerrit.libreoffice.org/36858 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: lUserId -> nUserIdChris Sherlock
Change-Id: I7617b25b1d63fc2926c1b500830ba3c1ddc8105c Reviewed-on: https://gerrit.libreoffice.org/36857 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: move RegisterDisplay() from ErrorHandler to ErrorRegistryChris Sherlock
It is the error registry that should register the display, not the error handler. Move this function to the class that is responsible for it. Change-Id: I95ca1662b907a7f38a42a39ec729b35fd530bb79 Reviewed-on: https://gerrit.libreoffice.org/36853 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: add newline for easier readingChris Sherlock
Change-Id: I871b51d2cca33b3ebcb96f9e2b673dd43a077467 Reviewed-on: https://gerrit.libreoffice.org/36862 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: remove inaccurate and misleading commentChris Sherlock
Change-Id: I16d53d10f02736dda3202ac02b2a4909f53f19ab Reviewed-on: https://gerrit.libreoffice.org/36860 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: ErrorHandler_Impl renamed to ErrorStringFactoryChris Sherlock
This isn't just a pImpl class, it's actually a factory used to determine which error handler should create the error strings. Change-Id: I2901a45d7c1e16608b3fbe39e9c5cd9d5cb9627b Reviewed-on: https://gerrit.libreoffice.org/36852 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-27vcl: update error codes to defined constants for code clarityChris Sherlock
Change-Id: I6e86c45b71fc15d6645501128e7d86f8e179e652 Reviewed-on: https://gerrit.libreoffice.org/36851 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2017-04-26vcl: cleanup vcl/source/window/errinf.cxxChris Sherlock
Change-Id: Ib5bb764040a0ffe7ca58b9abc29a80be672437e9 Reviewed-on: https://gerrit.libreoffice.org/36850 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-04-26vcl: refactor ErrorHandler functionsChris Sherlock
Current, HandleError_Impl is called on by GetErrorString, and HandleError_Impl also creates the error string. However, when you look at what each function does, HandleError_Impl has been imbued with some extraneous parameters: 1. bJustCreateString, and 2. rError bJustCreateString is unnecessary, in fact it just mutates HandleError to create the string, which is not really the core purpose of this function. In fact, the string should be created when we get the string from the error ID (GetErrorString), and in fact the error handler function should call on GetErrorString and not the other way around! This has the happy side effect of vastly simplifying this code, and allows each of the functions only do the thing they are meant to do, and we no longer need these extraneous parameters which just cause problems for code readibility. On to of this, by simplifying the HandleError_Impl function, we just move the code into the public HandleError function because these parameters aren't necessary any more. Change-Id: I4a727b5bbc6d3cdb0519f49b48dc52f8a8976629 Reviewed-on: https://gerrit.libreoffice.org/36849 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-11 19:19:09 +0000