summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-05-10loplugin:unnecessaryvirtual improvementsNoel Grandin
look for virtual methods where all of the overrides of the method are empty Change-Id: I87d99a0b647700a8d53498e0ab5f0437d3508553 Reviewed-on: https://gerrit.libreoffice.org/54060 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-10Related: tdf#117499 set default titles for non-gtk3 message dialogsCaolán McNamara
Change-Id: Ie2de7fe79e5861351c3fd6512bb970def9a31e4e Reviewed-on: https://gerrit.libreoffice.org/53991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-10tdf#117517: Fix OpenGL text rendering on WindowsKhaled Hosny
Use the HDC we already selected the HFONT on instead of creating a new HDC and selecting the font on it, apparently selecting the font the second time fails. Change-Id: I2a26469ce70bce763562b6cd2171707e482fb1d8 Reviewed-on: https://gerrit.libreoffice.org/54046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-09ImplNumericReformat always returns trueCaolán McNamara
Change-Id: Icfb555a59d0a221bdbdcf17601440fda43680d4b Reviewed-on: https://gerrit.libreoffice.org/54032 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-09Fix some IWYU warningsMiklos Vajna
Change-Id: Iab61e0a7cac2dc89e6b04875a62894b181aa0ff4 Reviewed-on: https://gerrit.libreoffice.org/54016 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-09Blind attempt to fix UBSAN error in FreetypeFontKhaled Hosny
The only place that calls FreetypeFontInstance::SetFreetypeFont() is FreetypeFont::FreetypeFont() calling it with “this”: static_cast<FreetypeFontInstance*>(mpFontInstance)->SetFreetypeFont( this ); So I don’t think we need to manage that FreetypeFont pointer, as it it is guaranteed to be valid as long as this FreetypeFontInstance is valid. Too many font classes and it is really hard to reason what is doing what… Change-Id: Iee50d2ecc4084116c13a2d2464594d6cffdcfcfe Reviewed-on: https://gerrit.libreoffice.org/54008 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-09tdf#117477: blacklist Intel HD Graphics 630 for LenovoJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=117477#c4 Change-Id: Ifdd55d5b26ae7ef6d635527050296aa69c2244ab Reviewed-on: https://gerrit.libreoffice.org/54015 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-09vcl: get rid of Bitmap{Ex}::Filter() and Animation::Filter()Chris Sherlock
Change-Id: I510d7b286df732712aa9206b0a7c7910af34c83f Reviewed-on: https://gerrit.libreoffice.org/53206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08ofz#8185 Undefined-shiftCaolán McNamara
Change-Id: I818ee989774da1499b1e6ac92b47bd09aedec754 Reviewed-on: https://gerrit.libreoffice.org/53992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08Related: tdf#117470 docking windows are toplevelsCaolán McNamara
but are not system windows according to vcl Change-Id: I7f404acc82ca51520b4fabd4d8a06769dc0f0fee Reviewed-on: https://gerrit.libreoffice.org/53971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-08tdf#117491 Base crash when editing text in SQL query editorNoel Grandin
regression from commit 148b84160667ed3ec74c8767f6e62567479488f9 loplugin:useuniqueptr in TETextPortionList Change-Id: I464a56c26876a9153278d2f99931ca4e3cc3e01f Reviewed-on: https://gerrit.libreoffice.org/53959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-08config entries for the new graphic manager, deprecate old entriesTomaž Vajngerl
Add 2 new GraphicManager config entries GraphicMemoryLimit and GraphicAllowedIdleTime. At the same time, deprecate the existing config entries used in GraphicObject's GraphicManager, which are not relevant anymore. Change-Id: Idb775e5e1a623f6c23d0c67fea5334a6c713c6c2 Reviewed-on: https://gerrit.libreoffice.org/53561 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-05-08Refactor CommonSalLayout font handlingJan-Marek Glogowski
Moves all platform specific code from CommonSalLayout into the platform specific plugins. This way the vcl library won't depend on the Qt5 libraries and the Qt5Font header can be moved into the qt5 VCL plugin. While at it, switch the CommonSalLayouts font reference from the FontSelectPattern to the LogicalFontInstance and also add the harfbuzz font handling to the instance. Change-Id: Ida910b8d88837ea949a2f84394ccc0cfae153060 Reviewed-on: https://gerrit.libreoffice.org/47408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-07Move PhysicalFontFace member of FontSelectPatternJan-Marek Glogowski
A FontSelectPattern describes a general font request. It can be used to find the best matching LogicalFontInstance. The instance will be created based on a PhysicalFontFace, which is really a factory since commit 8b700794b2746070814e9ff416ecd7bbb1c902e7. Following this workflow, this moves the PhysicalFontFace pointer to the instance and makes it constant. Which leaves some special symbol font handling code in the hash and instance lookup code path. It used to query the font face directly from the instance. I'm not sure of the correct handling. The related commits where made to fix #i89002#, which has an attached test document. 1. commit 849f618270da313f9339dda29a9f35938434c91d 2. commit 8c9823d311fdf8092cc75873e4565325d204a658 The document is as broken as it was before the patch. The symbol substitution still works, but the 'Q's are missing when displaying a symbol font. I also don't understand all the reinterpret_casts for fake font ids. I guess this was used to prevent the crashes I see, where a PhysicalFontFace referenced in a valid LogicalFontInstance is freed and a later FontId check in the GlyphCache crashes. So this now checks for a valid cache instead. Change-Id: If8ee5a6288e66cfa4c419289fbdd5b5da128c6ea Reviewed-on: https://gerrit.libreoffice.org/47279 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-07-Werror=unused-variableStephan Bergmann
...when vcl/inc/unx/x11_cursors/salcursors.h included vcl/inc/unx/x11_cursors/null_mask.h defining nullmask_bits and vcl/inc/unx/x11_cursors/null_curs.h defining nullcurs_bits, which are both unused here. Change-Id: Ib17870dce18a1071fb9b38922cdb0e698c18cbc5
2018-05-07vcl: Fix accessibility issues in demo.uiSamuel Thibault
Change-Id: I8da9fabe80f9c487b0c5ef225d55048ef544bf8e Reviewed-on: https://gerrit.libreoffice.org/53843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-07Allow building Qt5 backend on HaikuKacper Kasper
Change-Id: I7e928e9e29076bdfaaeffb83791bdc35f1952055 Reviewed-on: https://gerrit.libreoffice.org/53892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-06coverity#1435442 silence Unchecked return valueCaolán McNamara
Change-Id: Ifb8a72f250e20f2932c0c03a4d41c999b85db0a3 Reviewed-on: https://gerrit.libreoffice.org/53916 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-06Resolves: tdf#117413 char doubling appearing under X with gtk3Caolán McNamara
like happened on gtk2, so make the rhbz#1283420 bodge happen for XLIB surfaces, regardless of the backend Change-Id: Ic51679a71523e8cc76832858411b102d915638cf Reviewed-on: https://gerrit.libreoffice.org/53860 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jean-Baptiste Faure <jbfaure@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-06tdf#117007 - Elementary not appearing on some backendsheiko tietze
unity & mate added in iconthemeselector Change-Id: I9a10af148b405068726645940d482c89962fec5c Reviewed-on: https://gerrit.libreoffice.org/52880 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-05Replace Galaxy icon theme by Colibreheiko tietze
Galaxy goes into an extension, fallback updated Change-Id: I4b6998035857f01368b39d4f16b2639d8a665065 Reviewed-on: https://gerrit.libreoffice.org/53092 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-05Fix typosAndrea Gelmini
Change-Id: I92078fdece135754744d85424956dbb071f3899e Reviewed-on: https://gerrit.libreoffice.org/53638 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-05Fix typosAndrea Gelmini
Change-Id: Id7d66c06e18dbccd5c85ba36143bdb6cee7a5197 Reviewed-on: https://gerrit.libreoffice.org/53564 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-04weld SwOutlineTabDialogCaolán McNamara
Change-Id: I55c0e9a62dd9dd970a87ef295bb5fbb82c80d2d8 Reviewed-on: https://gerrit.libreoffice.org/53848 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04weld SwNumPositionTabPageCaolán McNamara
Change-Id: I12171eb00d5b8354456b629d58d20b22109e24f8 Reviewed-on: https://gerrit.libreoffice.org/53845 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04memory from getenv is not ours to freeCaolán McNamara
regrssion from... commit c3074cb5784329eaf558c2f58d96a64085b42d48 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Sun Jan 7 00:39:33 2018 +1100 vcl: remove dead code Change-Id: I3295ece62e97d00e56db95d0005d13d2a97984c2 Reviewed-on: https://gerrit.libreoffice.org/53858 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04tdf#117364 Special Character dialog grid font issuesNoel Grandin
Revert "tdf#113643 Editing tables in Impress lags terribly" This reverts commit 13a1bc409d9b2f0d14f4d316b7977b1fc2eb3c8a. Will probably need more sophisticated caching, so just revert this for now. Change-Id: I05cc26b911d3d138b57098656ea0c9c3c4e82592 Reviewed-on: https://gerrit.libreoffice.org/53784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-04give icon data directly to gtk, skipping internal loadersCaolán McNamara
Change-Id: I4168b78d68a99e56105c49e1a1b6e1aa457609af Reviewed-on: https://gerrit.libreoffice.org/53812 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04can make good use of fact its a SvMemorystreamCaolán McNamara
Change-Id: Iad581202fab8bace4a730bf2c318718bcc065e9d Reviewed-on: https://gerrit.libreoffice.org/53811 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-04tdf#112607 Use better wording for single/multiple print job optionGabor Kelemen
Separate seems to be more straightforward here Change-Id: I214211d75354da4b01ca5fe23dd51525d9892743 Reviewed-on: https://gerrit.libreoffice.org/53816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-04logging: add some strategic places around vcl messagesThorsten Behrens
Change-Id: I3eb1076a0dd697ceb3b4310444542f324848b358 Reviewed-on: https://gerrit.libreoffice.org/53777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-03fix 4 separate new bugs in BitmapMosaicFilterCaolán McNamara
coverity#1435274 Dereference after null check coverity#1435276 Resource leak coverity#1435278 Resource leak and on success it returned its input, throwing away the result of its calculation commit 63a716783a555e91ad3a32f25f20cffc88ca15e4 Author: Chris Sherlock <chris.sherlock79@gmail.com> Date: Fri Apr 20 20:39:48 2018 +1000 vcl: ImplMosaic() -> BitmapMosaicFilter Change-Id: Ia0910ae9166c4eb6b870ab25db761bc1703fec68 Reviewed-on: https://gerrit.libreoffice.org/53203 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Change-Id: I4eb74ef279b2ead268d07ac572ab76cd911dacb6 Reviewed-on: https://gerrit.libreoffice.org/53807 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03coverity#1435279 unused fieldCaolán McNamara
Change-Id: Iade24ac33f59e7a7138ace68a0edcb240e0d8f84 Reviewed-on: https://gerrit.libreoffice.org/53801 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03support native focus for drawing sub regionCaolán McNamara
Change-Id: I9862f060b9d5b2c3015c084060887f2d66f1ed01 Reviewed-on: https://gerrit.libreoffice.org/53768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-03weld SvxTextAttrPageCaolán McNamara
with a a11y rework to be more like the insert special char a11y also, route a11y questions about a custom widgets parent to the gtk toolkits underlying default implementation, keeping only questions about ourself to be handled by the XAccessible focus rectangles in RectCtl work again, seems that got lost somewhere along the way Change-Id: I62237d45668f4438aec6031cc5a48c38de21bf98 Reviewed-on: https://gerrit.libreoffice.org/53767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-02weld SvxTextAnimationPageCaolán McNamara
Change-Id: I5aadf86648483be254157d3ca148eb16258980e1 Reviewed-on: https://gerrit.libreoffice.org/53723 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-02tdf#109143 PDF export: don't reuse compressed bitmaps for cropped imagesMiklos Vajna
PDF wants to loose the pixels masked out by cropping, so the "reuse original compressed image" optimization should not be used in that case. Change-Id: Ifdf2cc4ff6bff0ed456a2159395314817c1cf417 Reviewed-on: https://gerrit.libreoffice.org/53743 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-02loplugin:useuniqueptr in GlyphCacheHolderNoel Grandin
Change-Id: I09aca185c6ca2efee037225e9924876030f47efe Reviewed-on: https://gerrit.libreoffice.org/53705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in NWPixmapCacheDataNoel Grandin
Change-Id: Ie71583f2fb1f2471ddeaf7a10572c679a4e5cbe0 Reviewed-on: https://gerrit.libreoffice.org/53707 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-02loplugin:useuniqueptr in X11SalBitmapNoel Grandin
Change-Id: I3fedb4b25683bafbdb7c761387d47a8b30ef8083 Reviewed-on: https://gerrit.libreoffice.org/53706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-01weld ScMoveTableDlgCaolán McNamara
Change-Id: I4d5601d0fb02a20bf6c83fc10411f610bdb5ce32 Reviewed-on: https://gerrit.libreoffice.org/53698 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-01weld ScShowTabDlgCaolán McNamara
Change-Id: Ice5da193d0efbf8e4a61d68c0fcef90f6c6d8e78 Reviewed-on: https://gerrit.libreoffice.org/53665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-01fix out of range spinbutton value reformatCaolán McNamara
Change-Id: I5da9da35d4bf40e2c4107df7ab9b07a6ca2fc836 Reviewed-on: https://gerrit.libreoffice.org/53684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-01disable/enable notify for GtkInstanceButtonCaolán McNamara
Change-Id: I477d5eed61d82cf711df3120c92f6011177f88ab Reviewed-on: https://gerrit.libreoffice.org/53686 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-01Store a pointer to GlyphItem in PDFGlyphKhaled Hosny
Instead of ad hoc bits and pieces of it as we go. Change-Id: Ife826405850efbd84d84b19cba6a80d735864d3e Reviewed-on: https://gerrit.libreoffice.org/53683 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-05-01These tests should check for HAVE_MORE_FONTSKhaled Hosny
TEST_FONTS_MISSING checks only for DejaVu and Carlito, besides even if the system has a font with the same name it does not mean it is the same version (or even the same font) as the test requires. So better limit this to builds not using --without-fonts. Change-Id: I9d5b9e6aaed65513d37e4c897fcdddf0ac050084 Reviewed-on: https://gerrit.libreoffice.org/53676 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-04-30std::min on unitialized valueCaolán McNamara
Change-Id: I3d1fdf90094170f8b256bbd0a9af28b69ef16a8c Reviewed-on: https://gerrit.libreoffice.org/53662 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-30crashtesting: ooo43029-4.odg initial j of 0 decremented wraps aroundCaolán McNamara
since commit 2815499d7c0b32fa05fcd697e7b2c2d897f78dfb Date: Fri Apr 27 05:21:29 2018 +0200 tdf#105913: Fix applying DX array to ligatures Change-Id: I989aa70d5e8a99061a1b0e4db63c47c7c92d92da Reviewed-on: https://gerrit.libreoffice.org/53647 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-30hook up can-focus to ability to tab into the widgetCaolán McNamara
Change-Id: I55915254d784a0887a8d5bf6128396ab875e7ae6 Reviewed-on: https://gerrit.libreoffice.org/53634 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-30Avoid getTokenCount (fix 1a2ee0ecd5b0cff52922c1d261f7d03a57a52ca0)Matteo Casalin
Change-Id: I2def3a427585fd281fb0b25e90060b2a2037212b
generated by cgit (git 2.34.1) at 2025-02-14 16:23:34 +0000