summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-02-15loplugin:simplifybool extend to !(a == b) where comparison an overloaded opNoel Grandin
Change-Id: I08fcbe2569c07f5f97269ad861fa6d38f23a7cc7 Reviewed-on: https://gerrit.libreoffice.org/67816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-15move Calendar to vcl and map to GtkCalendarCaolán McNamara
Change-Id: I1784d4d69c6c069ef1b0ad6412e83e6a0b1db12a Reviewed-on: https://gerrit.libreoffice.org/67840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-15Fix typo in codeAndrea Gelmini
It passed "make check" on Linux Change-Id: I81d83b9053329a19af4f478d21f8c452dcf39538 Reviewed-on: https://gerrit.libreoffice.org/67849 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-02-14don't need a special function to get the BlueOrIndex colorTomaž Vajngerl
Change-Id: Idee5a82f8b69a25afa603ce8743d071d0093d617 Reviewed-on: https://gerrit.libreoffice.org/67824 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14move pngwrite/pngread to vcl/filter/pngTomaž Vajngerl
Change-Id: Ib6bf092854208eea5257c357850213815639968c Reviewed-on: https://gerrit.libreoffice.org/67821 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-14weld MoreOptionsDialogCaolán McNamara
Change-Id: I2fd6ffcbd03e1b797634bdb4646f1951cd665a1c Reviewed-on: https://gerrit.libreoffice.org/67810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-14tdf#123439 Assert wrt PointerStyle fails when moving cursor over toolbarNoel Grandin
regression from commit a2b687a88feedfae0087bfc999b3cf49b9d3d24b Date: Tue Feb 12 10:12:03 2019 +0200 Pointer is pointless Change-Id: I727e68c71f4ebacb9adae83f1f9b43ce999d5374 Reviewed-on: https://gerrit.libreoffice.org/67803 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-14vcl: test rendering of bitmaps with alphaTomaž Vajngerl
Change-Id: I6fde9581793fe85fc30d0660de3d62f0ddbfe9fd Reviewed-on: https://gerrit.libreoffice.org/67807 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13Improve the algorithm of disabled image creationTomaž Vajngerl
Main change is to not change alpha channel at all. For RGB channels, calculate the luma value and map the value into 160-224 range. Much simpler and better result. Change-Id: Ied108c2135f98d78f230a2c0b305bd3396d9ccfd Reviewed-on: https://gerrit.libreoffice.org/67791 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13tdf#120787: fine-tune window flags w/ focus on floating toolbarsKatarina Behrens
Floating toolbars are tool windows (Qt::Tool, not Qt::Window which has a separate taskbar entry). They are frameles (Qt::FramelessWindowHint) bc LibO takes care of drawing window decorations itself. They also must be able to receive keyboard focus (remove Qt::WindowDoesNotAcceptFocus) Change-Id: I61e8a905fdc4fde1a64df5a0824d358036cfcdea Reviewed-on: https://gerrit.libreoffice.org/67768 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-13tdf#123266 make cursors svg ready for better resizing.andreas kainz
Change-Id: I1980cfd444e4ccee6574878fb6d6dd507bc972d5 Reviewed-on: https://gerrit.libreoffice.org/67673 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-02-13weld CertificateViewer clusterCaolán McNamara
CertificateViewer, CertificateViewerGeneralTP, CertificateViewerDetailsTP, CertificateViewerCertPathTP Change-Id: I5792b673f17b3cd465ff17444776066139877ec1 Reviewed-on: https://gerrit.libreoffice.org/67756 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-13tdf#123420 Fix RGB/BGR issue with PNG readerTomaž Vajngerl
Change-Id: I4c6ffc89a21f46dea8775d4ec9aacc4f7ca71d94 Reviewed-on: https://gerrit.libreoffice.org/67764 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-13Pointer is pointlessNoel Grandin
since it is just a wrapper around PointerStyle Change-Id: I51f065e0d4ad8bd91f5c84c5819048c720a19267 Reviewed-on: https://gerrit.libreoffice.org/67711 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-13tdf#120786: show undocked toolbar only when it's readyKatarina Behrens
in SetAlwaysOnTop set window flags only, don't show the widget yet (it'll be shown later, when it can be painted in full) Change-Id: I5e855f1ebba1eb9985744ece055a0f141e965940 Reviewed-on: https://gerrit.libreoffice.org/67739 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-12weld ScNamePasteDlgCaolán McNamara
Change-Id: I197a917458fdd75b08f888deac1926dc363202d5 Reviewed-on: https://gerrit.libreoffice.org/67735 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12Resolves: tdf#123298 resize before writing to vectorCaolán McNamara
Change-Id: I8fc25d254781b31e4ffafcf4397a95d79e042cd8 Reviewed-on: https://gerrit.libreoffice.org/67736 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12weld SdInsertPagesObjsDlgCaolán McNamara
Change-Id: Ie8e0eaa6122274d86f2d16597cd928acd15df05c Reviewed-on: https://gerrit.libreoffice.org/67695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-12loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ibd47c9b9dfcd33527739a7e7bbabb21f7af24ed7
2019-02-11Resolves: tdf#123080 don't require wayland at runtimeCaolán McNamara
if it existed at buildtime Change-Id: I8a3285b7ee3b0556605b0c3d4b1fef222eb62d1a Reviewed-on: https://gerrit.libreoffice.org/67691 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11weld SvBaseLinksDlgCaolán McNamara
Change-Id: I40afcb99ae0e8fd27387077aea688906f037d6f4 Reviewed-on: https://gerrit.libreoffice.org/67676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-11tdf#119853: Set window state only, don't actually show the windowKatarina Behrens
showMaximized, showNormal etc. makes the windows visible, but it is not always desirable (e.g. documents opened with 'hidden' flag on) Change-Id: I15364c816c35865dbc2d74f1d1a46817b1277f43 Reviewed-on: https://gerrit.libreoffice.org/67679 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-02-11new loplugin writeonlyvarsNoel Grandin
largely based on the relevant portion of the unusedfields loplugin, but adapted for local vars Change-Id: Ic522a941573940e8f75c88f90ba5f37508ca49b1 Reviewed-on: https://gerrit.libreoffice.org/66835 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-11tdf#123311: Label "Order" in Print dialog should be left alignRoman Kuznetsov
Change-Id: Ibaeac1ddfbe34a11d3205abc6257367497dc855e Reviewed-on: https://gerrit.libreoffice.org/67581 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2019-02-11tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I67462369d93e9d9ff3c056800947c4b75f71ba5f Reviewed-on: https://gerrit.libreoffice.org/67486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-11loplugin:indentation in vclNoel Grandin
Change-Id: Idd7166833764fdf1d9c42a050490572a8b330199 Reviewed-on: https://gerrit.libreoffice.org/67610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-10Converted mouse pointer from indexed color to RGBMatthias Seidel
(cherry picked from commit 85e843067bb07211eba8fb6abcb9224b340bcc65) Change-Id: I7c686e11a9449d0107b821e42feb3b360b42b50a Reviewed-on: https://gerrit.libreoffice.org/67593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-10Converted mouse pointer from grayscale to RGBMatthias Seidel
(cherry picked from commit e98508d60780866d836d19d41ae6a0ed67414767) Change-Id: I990b1be02b2f9cf47a7587982f7a28159ad2f139 Reviewed-on: https://gerrit.libreoffice.org/67592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09weld SvxEditDictionaryDialogCaolán McNamara
Change-Id: Ia35ef42a570353e26a8969a322b04768a4ac042f Reviewed-on: https://gerrit.libreoffice.org/67553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-09Use PngImageReader for loading the icons from the icon-themesTomaž Vajngerl
Change-Id: Id48c7707fd6c0ef72a41b102048be5749d5c4858 Reviewed-on: https://gerrit.libreoffice.org/67578 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-09add PngImageFilter that uses libpng for PNG loadingTomaž Vajngerl
This adds loading of PNG images that uses libpng instead of our own solution. It always loaded the image as either RGB or RGBA image and if the source PNG is using something else, libpng converts to either RGB or RGBA. In addition this adds tests for loading of various PNG files to make sure the resulting bitmaps are using pixel data as expected. (especially needed to check the RGBA bitmaps) Change-Id: I194321caf76c2ec2365bb6075c79c5e84983658a Reviewed-on: https://gerrit.libreoffice.org/67571 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-02-08getToken+comparison+copy ==> startsWithMatteo Casalin
Change-Id: I3d243cecc21b0364b2ceac1f64cbfa1764c3ddf1 Reviewed-on: https://gerrit.libreoffice.org/66938 Tested-by: Jenkins Reviewed-by: Matteo Casalin <matteo.casalin@yahoo.com>
2019-02-08o3tl::make_unique -> std::make_unique in tools..xmloffGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: Ib3201f865d43f372007cdf381c7e244e9cbeae26 Reviewed-on: https://gerrit.libreoffice.org/67474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-08drop propagate naturalCaolán McNamara
rather than have version specific behaviour Change-Id: I75866a45859f93d290f79c63b586fee2a19816f3 Reviewed-on: https://gerrit.libreoffice.org/67529 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-08weld AddConditionDialogCaolán McNamara
Change-Id: Ib685ea89b31c1f000bc2276e3362ba059f997422 Reviewed-on: https://gerrit.libreoffice.org/67521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-07tdf#123165 cache recently scaled bitmaps for reuseCaolán McNamara
dropping the cached scaled bitmap when the bitmap is accesed via BitmapAccessMode::Write for writing Change-Id: Ib6539522944838238bd699ec3531039d21dc0f8b Reviewed-on: https://gerrit.libreoffice.org/67459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-06Harmonize SalPrinterQueueInfo::mnJobs and QueueInfo::mnJobsStephan Bergmann
The former was of type sal_uLong while the latter has been of (potentially smaller) type sal_uInt32 ever since at least a02e8af56ba44e9bb3ba2c6e995a23745ee629a0 "INTEGRATION: CWS hedaburemove01", and Printer::GetQueueInfo (vcl/source/gdi/print.cxx) assigns from the former to the latter (so potentially truncates). But it appears the only non-zero values ever stored in the former are QUEUE_JOBS_DONTKNOW (defined as 0xFFFFFFFF in include/vcl/prntypes.hxx, fitting into sal_uInt32) and Windows-specific PRINTER_INFO_2W::cJobs (in WinSalInstance::GetPrinterQueueState, vcl/win/gdi/salprn.cxx), which is of Windows type DWORD, i.e., unsigned 32-bit, compatible with sal_uInt32. So change the former (and QUEUE_JOBS_DONTKNOW) to sal_uInt32, too. Change-Id: I0cc993d26831313b362cc31ee06fd879c854d146 Reviewed-on: https://gerrit.libreoffice.org/67468 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-02-06Extend MetafileXmlDump with MetaActionType::TransparentMuhammet Kara
Change-Id: Ia74c43372b12eb71a8cc443de15458b374ee6b85 Reviewed-on: https://gerrit.libreoffice.org/67446 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-02-06missing cairo_surface_destroyCaolán McNamara
Change-Id: I4ff8dcf928ebefed1eaeebdcdcfb90c56ddfd39e Reviewed-on: https://gerrit.libreoffice.org/67440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-06tdf#107792 vcl/win: simplify WinSalVirtualDevice::~WinSalVirtualDevice()Dmitriy Shilin
Change-Id: I61c2ee1e8363a022239d5572e3506df9da0d5e1d Reviewed-on: https://gerrit.libreoffice.org/67433 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2019-02-06no need to use OUStringHash here anymoreNoel Grandin
Change-Id: I2faa8c971dc7f4642353dceafa25b9022a0dfd2a Reviewed-on: https://gerrit.libreoffice.org/67436 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-02-06tdf#107792 vcl/win: simplify WinSalInstance::CreateVirtualDeviceDmitriy Shilin
Change-Id: I7e2fd41f8c4359374af143aaf7544bb61a8878c7 Reviewed-on: https://gerrit.libreoffice.org/67189 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-02-05weld WebConnectionInfoDialogCaolán McNamara
Change-Id: Idff8a0589075c8b7c774f187f5082fd954251d77 Reviewed-on: https://gerrit.libreoffice.org/67420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-05tdf#123058 qt5 fpicker: Honor autoextension settingMichael Weghorn
Store the file extension associated with the named filters in a map, and use that information to set the default file extension in QFileDialog accordingly if the corresponding checkbox in the dialog is enabled. Change-Id: I66f4f35da5d4378ac6337429e39260a4ed710a24 Reviewed-on: https://gerrit.libreoffice.org/67392 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-05qt5 fpicker: Fix initial directory selectionMichael Weghorn
This takes over the fix from the KDE5FilePicker from commit 1af4ab72e2488515fcaedeb4a377ee070d68a495 for the qt5 one. Change-Id: Ibe34ecff9913fc91df2b9bd25b559375bab0ff83 Reviewed-on: https://gerrit.libreoffice.org/67385 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-02-04weld OSelectLabelDialogCaolán McNamara
Change-Id: Icbf9f05e69667cb8161942dde84ded6b3fc61138 Reviewed-on: https://gerrit.libreoffice.org/67367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-02-04vcl_graphic_test requires Library_gie for .gifLuboš Luňák
Change-Id: I771ea527cf38c5ba19b337fe1a6b377312de9fbb Reviewed-on: https://gerrit.libreoffice.org/67370 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-02-04workaround to make Qt5 code build with Clang+icecream (#2)Luboš Luňák
This fixes and extends dad7c2213979695cf3573a130309206191b45157 . Change-Id: I29352d4b4809aa254e832a932bfeb595d065565b Reviewed-on: https://gerrit.libreoffice.org/67368 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-02-04vcl: make it easier to spot missing fonts (fontconfig backend)Miklos Vajna
Even better would be to show this on the UI, but that's more tricky: it's not clear how to differentiate between the replacements which are metric-compatible and the ones which are not. Sample output: PrintFontManager::Substitute: replacing missing font: 'Liberation Sansfoo' with 'Arial' Change-Id: I96bf24f7e538fdfc163b9b6cab4b5a381bb4d760 Reviewed-on: https://gerrit.libreoffice.org/67342 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-02-03weld SvxMultiPathDialogCaolán McNamara
Change-Id: I9a509654d72bbe5b346002a3b23793bf69330720 Reviewed-on: https://gerrit.libreoffice.org/67297 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-12 12:40:15 +0000