summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-12-19coverity#1426314 silence Resource leakCaolán McNamara
Change-Id: I266463184f902df11943a23fa4129086c6441783 Reviewed-on: https://gerrit.libreoffice.org/46703 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-17ofz#4678 ensure null terminationCaolán McNamara
Change-Id: I6b6b0763e85a41d03f9e03c6abc17c6c311f6519 Reviewed-on: https://gerrit.libreoffice.org/46641 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-16Fix typosAndrea Gelmini
Change-Id: Iedb99e41887ebfd6fa290bc113b473c5cc9693b4 Reviewed-on: https://gerrit.libreoffice.org/46600 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-16sal_uLong->SalPrinterError in SalPrinterNoel Grandin
and define a default implementation in the base class that returns SalPrinterError::NONE, since only one of the subclasses wants to override and return something useful Change-Id: Id41ff90693527e8624cc2993b7481114af85fcee Reviewed-on: https://gerrit.libreoffice.org/46509 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-16sal_uIntPtr->sal_uInt32 in yieldCountsNoel Grandin
to match the underlying field in GenericSolarMutex Change-Id: I98dcab3b684278c4a184534ba782b5b03b0504f0 Reviewed-on: https://gerrit.libreoffice.org/46508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15lokdialog: Give non-programmatic name to autofilterPranav Kant
Change-Id: I8670a5aaa1703677cab173b2341c6e70e689f61a (cherry-picked from 04abf03ecb18ccf1f805faa763d6f29013efc6bb)
2017-12-15lokdialog: If we already have the title, emit it during creationPranav Kant
Some dialogs load the UI before we "Execute()" the dialog, or before the dialog fires the InitShow event. In those cases, the title event has already been fired and won't be fired after dialog is created. Make sure that we send the title for such dialogs. Change-Id: Ib66238298ad9b0dc85bd269aff37aeadf1fc82e4 (cherry picked from commit 10a88598a4233f2b24548571644a83dc9d20e15d)
2017-12-15Protect all LogicalFontInstance constructorsJan-Marek Glogowski
This way LogicalFontInstance can just be constructed by a PhysicalFontFace based factory. The patch also drops the wrong "Java logical font" comment added by commit 125cdf3404e60cf78f2a5547e9a06ce994df5c8e. Change-Id: Ibd5d7da0c3a65dbfa2c8ae6b05cf616d39b749f2 Reviewed-on: https://gerrit.libreoffice.org/46475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-12-15Report more debug information about caught exceptionStephan Bergmann
...in an attempt to track down why various tinderbox builds started to fail CppunitTest_sw_filters_test with an "Uncaught exception during Task::Invoke()!" abort. On IRC, jmux claims that catching exceptions and turning them into abort() here (instead of letting them propagate) is necessary: "The main problem was the wrong state in the scheduler. So something actually handled the exception, but the next caller into the scheduler had an invalid linked list of tasks, breaking things left and right." Change-Id: Ic3365e282404483518652c00160c2036b79991cf Reviewed-on: https://gerrit.libreoffice.org/46450 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15loplugin:salcall (macOS)Stephan Bergmann
Change-Id: I297ac09358ce948acae9b73e8ed605964520c73b Reviewed-on: https://gerrit.libreoffice.org/46437 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-15sal_uIntPtr/sal_uLong->void* in Popover idsNoel Grandin
Change-Id: Ifd7eeadeacffb90ea303c1e6bca807d310098f66 Reviewed-on: https://gerrit.libreoffice.org/46484 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-15sal_uIntPtr->sal_uInt32 in X11SalGraphicsImplNoel Grandin
which matches the call sites Change-Id: I4db0c87f29c3368f32d600a10b5f43cb5ea6027c Reviewed-on: https://gerrit.libreoffice.org/46483 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-14Fix memleakPranav Kant
Change-Id: I557b2f43263fc125d0ee87b968dee1893e4ca7cf
2017-12-14lokdialog: Unblock custom window mouse key eventsPranav Kant
In some cases, the mouse event blocks. Eg: when the mouse event is responsible for launching a new dialog (cf. Spell dialog -> Options). We don't want any kind of blocking behavior whatsoever in LOK. Post all custom window mouse events back the main-loop thread and keep the current LOK thread free. Change-Id: I018870fadcb62dbb7b33a7d93f8af3a0000442b5
2017-12-14Move call to Scheduler::ImplDeInitScheduler in DeInitVCL back to orig. placeStephan Bergmann
Dec 13 16:18:27 <sberg> jmux, any reason fd0fff67798fea87217e65bb1561aa0d0e741c51 moved the call to Scheduler::ImplDeInitScheduler() in DeInitVCL (vcl/source/app/svmain.cxx) past the call to the pSVData->maDeInitHook? Dec 13 16:18:30 <IZBot> core - Assert active Tasks on scheduler de-init - http://cgit.freedesktop.org/libreoffice/core/commit/?id=fd0fff67798fea87217e65bb1561aa0d0e741c51 Dec 13 16:20:06 <sberg> jmux, observing a crash in CppunitTest_dbaccess_firebird_test here when comphelper::geProcessServiceFactory wants to be used after it has been cleared, <https://paste.fedoraproject.org/paste/H8bVCcpNjSipm59Ih952nw> Dec 13 16:22:41 <jmux> sberg: no. That was still during the analysis with all those static tasks and cleanup problems. Dec 13 16:23:17 <sberg> jmux, I'll see what breaks if I move the call back to its original place, then The relevant backtraces from <https://paste.fedoraproject.org/paste/H8bVCcpNjSipm59Ih952nw>: > #0 0x00007fffee08c160 in comphelper::setProcessServiceFactory(com::sun::star::uno::Reference<com::sun::star::lang::XMultiServiceFactory> const&) (xSMgr=...) at comphelper/source/processfactory/processfactory.cxx:55 > #1 0x00007fffe8b120eb in (anonymous namespace)::Hook::deinitHook((anonymous namespace)::Hook*, LinkParamNone*) () at test/source/setupvcl.cxx:54 > #2 0x00007fffe8b11f8d in (anonymous namespace)::Hook::LinkStubdeinitHook(void*, LinkParamNone*) (instance=0x0, data=0x0) at test/source/setupvcl.cxx:37 > #3 0x00007fffe76a9cb1 in Link<LinkParamNone*, void>::Call(LinkParamNone*) const (this=0x7fffe8374418 <rtl::Static<ImplSVData, (anonymous namespace)::private_aImplSVData>::get()::instance+984>, data=0x0) at include/tools/link.hxx:84 > #4 0x00007fffe79c5baf in DeInitVCL() () at vcl/source/app/svmain.cxx:517 > #5 0x00007fffe8d1cc0a in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:34 > #6 0x00007fffe8d1cc5e in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:43 > #7 0x00007ffff7b962f3 in CppUnit::ProtectorChain::pop() (this=0x630e00) at ProtectorChain.cpp:56 > #8 0x00007ffff7ba65d4 in CppUnit::TestResult::popProtector() (this=0x7fffffff2870) at TestResult.cpp:196 > #9 0x0000000000408998 in (anonymous namespace)::ProtectedFixtureFunctor::run() const (this=0x7fffffff2840) at sal/cppunittester/cppunittester.cxx:328 > #10 0x0000000000409484 in sal_main() () at sal/cppunittester/cppunittester.cxx:469 > #11 0x000000000040900b in main(int, char**) (argc=23, argv=0x7fffffff2be8) at sal/cppunittester/cppunittester.cxx:376 and > #0 0x00007fffee08c213 in comphelper::getProcessServiceFactory() () at comphelper/source/processfactory/processfactory.cxx:64 > #1 0x00007fffee08c651 in comphelper::getProcessComponentContext() () at comphelper/source/processfactory/processfactory.cxx:96 > #2 0x00007fffe79a7281 in setupPersonaHeaderFooter(WhichPersona, rtl::OUString&, BitmapEx&, boost::optional<Color>&) (eWhich=PERSONA_HEADER, rHeaderFooter=..., rHeaderFooterBitmap=..., rMenuBarTextColor=...) at vcl/source/app/settings.cxx:2135 > #3 0x00007fffe79a7c96 in StyleSettings::GetPersonaHeader() const (this=0x15d7130) at vcl/source/app/settings.cxx:2214 > #4 0x00007fffe757285f in MenuBarWindow::ApplySettings(OutputDevice&) (this=0x1644ee0, rRenderContext=...) at vcl/source/window/menubarwindow.cxx:1022 > #5 0x00007fffe7488fdb in PaintHelper::DoPaint(vcl::Region const*) (this=0x7fffffff1720, pRegion=0x0) at vcl/source/window/paint.cxx:298 > #6 0x00007fffe748a74e in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x1644ee0, pRegion=0x0, nPaintFlags=(ImplPaintFlags::PaintAll | ImplPaintFlags::PaintAllChildren | ImplPaintFlags::PaintChildren | ImplPaintFlags::Erase)) at vcl/source/window/paint.cxx:606 > #7 0x00007fffe748a0e5 in PaintHelper::~PaintHelper() (this=0x7fffffff1890, __in_chrg=<optimized out>) at vcl/source/window/paint.cxx:540 > #8 0x00007fffe748a7a7 in vcl::Window::ImplCallPaint(vcl::Region const*, ImplPaintFlags) (this=0x1510d40, pRegion=0x0, nPaintFlags=ImplPaintFlags::PaintChildren) at vcl/source/window/paint.cxx:603 > #9 0x00007fffe748a8ea in vcl::Window::ImplCallOverlapPaint() (this=0x1510d40) at vcl/source/window/paint.cxx:630 > #10 0x00007fffe748aa34 in vcl::Window::ImplHandlePaintHdl(Timer*) (this=0x1510d40) at vcl/source/window/paint.cxx:651 > #11 0x00007fffe748a929 in vcl::Window::LinkStubImplHandlePaintHdl(void*, Timer*) (instance=0x1510d40, data=0x1511940) at vcl/source/window/paint.cxx:634 > #12 0x00007fffe79c7f33 in Link<Timer*, void>::Call(Timer*) const (this=0x1511960, data=0x1511940) at include/tools/link.hxx:84 > #13 0x00007fffe79c7d97 in Timer::Invoke() (this=0x1511940) at vcl/source/app/timer.cxx:76 > #14 0x00007fffe799a873 in Scheduler::ProcessTaskScheduling() () at vcl/source/app/scheduler.cxx:440 > #15 0x00007fffe7999d95 in Scheduler::CallbackTaskScheduling() () at vcl/source/app/scheduler.cxx:263 > #16 0x00007fffe7ad3bbb in SalTimer::CallCallback() (this=0x156fbc0) at vcl/inc/saltimer.hxx:55 > #17 0x00007fffe7ad3209 in SvpSalInstance::CheckTimeout(bool) (this=0x730900, bExecuteTimers=true) at vcl/headless/svpinst.cxx:188 > #18 0x00007fffe7ad35b8 in SvpSalInstance::DoYield(bool, bool) (this=0x730900, bWait=false, bHandleAllCurrentEvents=true) at vcl/headless/svpinst.cxx:272 > #19 0x00007fffe79be4a1 in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=true) at vcl/source/app/svapp.cxx:469 > #20 0x00007fffe79ba4c7 in Application::Reschedule(bool) (i_bAllEvents=true) at vcl/source/app/svapp.cxx:486 > #21 0x00007fffe79ba4f9 in Scheduler::ProcessEventsToIdle() () at vcl/source/app/svapp.cxx:492 > #22 0x00007fffe79991a9 in Scheduler::ImplDeInitScheduler() () at vcl/source/app/scheduler.cxx:114 > #23 0x00007fffe79c5f80 in DeInitVCL() () at vcl/source/app/svmain.cxx:579 > #24 0x00007fffe8d1cc0a in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:34 > #25 0x00007fffe8d1cc5e in (anonymous namespace)::Protector::~Protector() (this=0x6f6b50, __in_chrg=<optimized out>) at test/source/vclbootstrapprotector.cxx:43 > #26 0x00007ffff7b962f3 in CppUnit::ProtectorChain::pop() (this=0x630e00) at ProtectorChain.cpp:56 > #27 0x00007ffff7ba65d4 in CppUnit::TestResult::popProtector() (this=0x7fffffff2870) at TestResult.cpp:196 > #28 0x0000000000408998 in (anonymous namespace)::ProtectedFixtureFunctor::run() const (this=0x7fffffff2840) at sal/cppunittester/cppunittester.cxx:328 > #29 0x0000000000409484 in sal_main() () at sal/cppunittester/cppunittester.cxx:469 > #30 0x000000000040900b in main(int, char**) (argc=23, argv=0x7fffffff2be8) at sal/cppunittester/cppunittester.cxx:376 Change-Id: I75ee6a7b663f6117f004877fc9ba5a3ed79d66e4 Reviewed-on: https://gerrit.libreoffice.org/46415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-14sal_uIntPtr->unsigned long in SystemEnvDataNoel Grandin
to match the type used by X11 Change-Id: I5fe043e33602be21c84b81780c89df751c3bc96c Reviewed-on: https://gerrit.libreoffice.org/46393 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13tools: reimplement SVLIBRARY macro & remove it from solar.hMichael Stahl
Change-Id: I03f8f5fd656d62410821f2f2851f1c584c97d1f4
2017-12-13tools: remove unused #include from solar.hMichael Stahl
Change-Id: I214e13add371380701ae39403d90a574a63e495d
2017-12-13Fix --enable-qt5Stephan Bergmann
...after e75abe6e0a4ea250366bb29c0ece697e9b1b80a1 "convert tolerance params to sal_uInt8" Change-Id: I6677fa21d4786ebadcded53e1542514465d5d0a2
2017-12-13sal_uLong->void* for userdata in MenuNoel Grandin
Change-Id: I58fb10136a23c445edfd63a1f86ace3995524704 Reviewed-on: https://gerrit.libreoffice.org/46350 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-13convert tolerance params to sal_uInt8Noel Grandin
since their range is 0-255 Also drop pTols from ImplColReplaceParam, since it is always nullptr. Change-Id: I9e9ab7f7596e18cab1d67dd69922e5ac9867f45b Reviewed-on: https://gerrit.libreoffice.org/46274 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-12Remove obsolete "explicit operator bool" hackStephan Bergmann
...and fix the call sites that exploited the hack's internals being non- transparent. Change-Id: Ib3b06c3945e303d4088c4e1b65be5beed8613bac Reviewed-on: https://gerrit.libreoffice.org/46325 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-12tdf#114408 set correct tooltip rectangleCaolán McNamara
The original code tried to get the position of the window relative to its parent and then ask the parent to adjust that position to a position relative to the toplevel. But the position to use in that case should have be WindowImpl::nX/WindowImpl::nY not GetPosPixel() Much easier to just directly ask the the current window for its position relative to the toplevel. Change-Id: Iff202f052bc651a8c0e3a57ff3322e5e2a3e4b9a Reviewed-on: https://gerrit.libreoffice.org/46314 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12tdf#114407 let tooltip children of non-nwf widgets be nwf themedCaolán McNamara
alternative is to not use themed text color when writing text in non-nwf tooltips Change-Id: I12556d5fd9a38c4b36f77c97144898f08fa4d738 Reviewed-on: https://gerrit.libreoffice.org/46312 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-12Revert "lok: Assertion `m_aProcessingUserEvents.empty()' failed"Henry Castro
This reverts commit ad35cc9ed0faa6555bc09e5e065abb5cdc6c4ee6. Change-Id: I8943deb0b78a14d10ed6e8d052b2ac8eb58bccae Reviewed-on: https://gerrit.libreoffice.org/46321 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Henry Castro <hcastro@collabora.com>
2017-12-12lok: Assertion `m_aProcessingUserEvents.empty()' failedHenry Castro
This occurs after saving a writer document loolforkit: /home/hcastro/projects/lo-sid/vcl/source/app/salusereventlist.cxx:56: bool SalUserEventList::DispatchUserEvents(bool): Assertion `m_aProcessingUserEvents.empty()' failed. /home/hcastro/build/gcc-lool-sid/loolforkit(_ZN7SigUtil13dumpBacktraceEv+0x49) [0x55ba3f0740c6] /home/hcastro/build/gcc-lool-sid/loolforkit(+0x149fb1) [0x55ba3f073fb1] /lib/x86_64-linux-gnu/libpthread.so.0(+0x110c0) [0x7f57a41350c0] /lib/x86_64-linux-gnu/libc.so.6(gsignal+0xcf) [0x7f57a3db7fcf] /lib/x86_64-linux-gnu/libc.so.6(abort+0x16a) [0x7f57a3db93fa] /lib/x86_64-linux-gnu/libc.so.6(+0x2be37) [0x7f57a3db0e37] /lib/x86_64-linux-gnu/libc.so.6(+0x2bee2) [0x7f57a3db0ee2] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN16SalUserEventList18DispatchUserEventsEb+0x86) [0x7f5798f2178c] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN14SvpSalInstance7DoYieldEbb+0x3b) [0x7f57990ce48d] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(+0xa7b2fd) [0x7f5798f5b2fd] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN11Application5YieldEv+0x13) [0x7f5798f5735b] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_ZN11Application7ExecuteEv+0x167) [0x7f5798f56f11] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(+0x4e419) [0x7f57a30d3419] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(+0xa87119) [0x7f5798f67119] /home/hcastro/build/gcc-lo-sid/instdir/program/libvcllo.so(_Z6SVMainv+0x4d) [0x7f5798f67282] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(soffice_main+0x1bf) [0x7f57a312a6b5] /home/hcastro/build/gcc-lo-sid/instdir/program/libsofficeapp.so(+0xe8db2) [0x7f57a316ddb2] /home/hcastro/build/gcc-lo-sid/instdir/program/libuno_sal.so.3(+0x77581) [0x7f579f807581] /lib/x86_64-linux-gnu/libpthread.so.0(+0x7494) [0x7f57a412b494] /lib/x86_64-linux-gnu/libc.so.6(clone+0x3f) [0x7f57a3e6daff] Change-Id: I455bd44d40c6c9b3ed49d047b8bce23a4600c265 Reviewed-on: https://gerrit.libreoffice.org/46206 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-12-11loplugin:salcallStephan Bergmann
Change-Id: I7521b2adb9572efbb1d28f9f44f9d29c62d6e1e9
2017-12-11loplugin:salcall fix functionsNoel Grandin
since cdecl is the default calling convention on Windows for such functions, the annotation is redundant. Change-Id: I1a85fa27e5ac65ce0e04a19bde74c90800ffaa2d Reviewed-on: https://gerrit.libreoffice.org/46164 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-10Use some for range loops in vclJulien Nabet
Change-Id: I58a334e4d1252b2addd6784ab60d15b60593f722 Reviewed-on: https://gerrit.libreoffice.org/46184 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-12-09headless: improve popup menu background defaults.Michael Meeks
Change-Id: Icda7df363827e1942486c961bf9eef9402aba96c Reviewed-on: https://gerrit.libreoffice.org/46123 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-12-08vcl: Rectangle does not name a typeMichael Stahl
Change-Id: Ia90b67d80383856f0b277a86117ced3732a2ac24
2017-12-09Use ImplIsFloatingWindow instead of dynamic_castPranav Kant
Change-Id: I09f351ae5d8d1b5c1a405d7aa8082be6014268b3
2017-12-09lokdialog: Move lok cursor invalidation callbacks to vcl::CursorPranav Kant
Change-Id: I5cbb845259b6802fb2a0776f8d8f19f9680115ad
2017-12-09lokdialog: Open floating window on InitShow onlyPranav Kant
Okay, my bad. InitShow happens after Visible. And InitShow also does some layouting. Emitting the created callback on InitShow means sending more accurate sizes, etc. The different in sizes is 0 for combo boxes, but significant for custom controls like color picker, etc. So emit created callback on InitShow to keep custom controls working. Change-Id: I40b6a18b917dff0eebcfd4c273f3399f3bdc7456
2017-12-08add mathtype fuzzerCaolán McNamara
Change-Id: I14a1f496dfc94bf678112d67f63a2c0101013472 Reviewed-on: https://gerrit.libreoffice.org/45815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-08loplugin:salcall vcl builder methodsNoel Grandin
these don't need to be SAL_CALL, and the function pointer definition was not annotated SAL_CALL either Change-Id: I3082d3d34c53dc723ad8d2083010fd0de0e89a1e Reviewed-on: https://gerrit.libreoffice.org/46067 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-07Fix typoAndrea Gelmini
Change-Id: I6c2a81ec4f60d09819112952a4384b8096ea414f Reviewed-on: https://gerrit.libreoffice.org/46004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-12-07fix fuzzer buildCaolán McNamara
Change-Id: Ibd2d1700c3bb69c6339110088ba531f95071ebd3 Reviewed-on: https://gerrit.libreoffice.org/46042 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-12-07gpg4libre: add KDE4 fpicker gpg crypt chechboxThorsten Behrens
Change-Id: Iba8fb0e0ac732f36cd1d880884bde1121e6b1eab
2017-12-07gpg4libre: add gtk fpicker gpg crypt chechboxThorsten Behrens
Change-Id: I27b494530a2b61eb37c4a9f7c3e1f9845f045e66
2017-12-07lokdialog: sc: Prevent assert when invoking autopopup filter dialogPranav Kant
We set the notifier in sc, so don't try to set it again in vcl. Change-Id: Ic7ab3d0030532a4e8630aa7e9266d32057373a65
2017-12-07incomplete type GraphicCaolán McNamara
Change-Id: I471d43be4b34f3bdb3db5b5ff316ff0a414c8996
2017-12-07loplugin:constparamsNoel Grandin
Change-Id: Ia322ecf8f80b28c58ec33d17ca9607401a92534b Reviewed-on: https://gerrit.libreoffice.org/45959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-12-06Remove unused #include <vcl/metaact.hxx> from vcl/outdev.hxxStephan Bergmann
...and fix the fallout Change-Id: Ie514bd95d5a9f990a887566619031e9844c40b92 Reviewed-on: https://gerrit.libreoffice.org/45195 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-12-06tdf#114262 Respect text+image toolbar styleMaxim Monastirsky
Regression of 67c9d054517fc3b5cbc203c330eedef4b50f0e57 ("fdo#84938: replace TIB_ constants with enum"). Change-Id: Ib90473a80fd491f4a136b4e76864c107a9240990 Reviewed-on: https://gerrit.libreoffice.org/45920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2017-12-06lokdialog: Show/Hide floating window on StateChangedType::VisiblePranav Kant
In the earlier approach, other state change events like SetText are emitted which ends up in "else if !IsVisible()" block and tries to close the floating window before it's even registered. Interestingly, this is not the case every time. Anyhow, better safe than sorry. Guard the floating window 'created', 'close' callbacks in a StateChangeType::Visible event. Change-Id: Ib997e11fd4a0f50b8911e9891918112e8ff8ef85
2017-12-06Document SAL_RTL_ENABLED env varSamuel Mehrbrodt
Change-Id: I6242f6028daaa0eb4d14134658e2eb50fd8f8275 Reviewed-on: https://gerrit.libreoffice.org/45932 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-12-06lokdialog: Window* -> VclPtr<Window>, and a small simplification.Jan Holesovsky
Change-Id: I853e2d6ec2e55c78894a9942aa201763a57fe195 Reviewed-on: https://gerrit.libreoffice.org/45900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2017-12-06loplugin:salcallStephan Bergmann
Change-Id: I5c21f95f763f1491cc68087ecec0909493fd7f63
2017-12-06loplugin:redundantcastStephan Bergmann
Change-Id: I7e73878f263be57d91a1db2fc3d65d411bd49228 Reviewed-on: https://gerrit.libreoffice.org/45912 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-05 00:46:44 +0000