summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-09-07Revert: #i47175# update eventual pointer grab with cursorCaolán McNamara
revert commit: commit d4f61372b23d6bb7f4df1e563f0823b3a3211c1d Date: Mon Mar 5 14:25:35 2007 +0000 INTEGRATION: CWS vcl74 (1.59.42); FILE MERGED 2007/01/31 15:25:15 pl 1.59.42.1: #i47175# update eventual pointer grab with cursor this got later modified by... commit e9cb118e6e98eb13b3ad1901c8c912bed674f096 Date: Tue Jan 29 15:21:11 2008 +0000 INTEGRATION: CWS vcl85_SRC680 (1.71.70); FILE MERGED ... 2007/12/13 15:30:31 pl 1.71.70.1: #i80791# use correct owner events parameter in SetPointer but now in impress, under wayland, if I click and hold on the border of a textbox and then try to use SetPointer while the mouse is captured then the cursor doesn't change, the regrab drops the cursor. The original problem reported back in #i47175# no longer arises in gtk as the dialog is a native gtk one. Drop this workaround as its weird to potentially do a special grab when we just want to change the mouse cursor. Change-Id: Ifb7f55a17692a5e79cd4221d1e0f440dacbee0bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121775 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07explain a 'not sure why' comment about cairo (1,1) sizesLuboš Luňák
This is from 9090dc1f3b27195f5defd35586ac79357992be21. Change-Id: Iae98628b58022c8bb3c50eef6889923023b67319 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121777 Tested-by: Luboš Luňák <l.lunak@collabora.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-07Related: tdf#142458 don't change border size during PaintCaolán McNamara
so GetOptimalSize/get_preferred_size before/after paint has the same result Change-Id: I25abe31c069561e30a9af7c4b9b81582298e0f9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121616 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-07vcl: followup tdf#74702 vcl: remove GetOutDevType() from ImplNewFont()Chris Sherlock
virtual keyword was missing on ImplNewFont(), without it the previous change effectively removed the PDFWriterImpl code. Thanks to Noel for pointing this out. Change-Id: I3148ee90e61cdb9d2d6b242ebe4964fb0394416d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121734 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-07Avoid repeating the return type from the declarationMiklos Vajna
Change-Id: I0dce02d10b8c74e80f5672e2dd580b6837ba3291 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121732 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-07vcl: move OutputDevice rasterop functions to outdev.cxxChris Sherlock
Split off RasterOp enum into own header, and also add unit tests for SetRasterOp() and GetRasterOp(). Change-Id: I1c97e87ef2d0684cb15b6ac544597eace5adb48a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121018 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-06clang-tidy:readability-redundant-member-initNoel Grandin
Change-Id: I51f4e8affac41023110042b534a915f096ccd0c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121692 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-06ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I979b11badd0df454aa0d344b90c809a2a3f6c392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-06ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I139458eee9176e6c86a800b5547cbd8ba80dba35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121720 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-06vcl: migrate ImplLayoutRuns to own filesChris Sherlock
Wrote a set of unit tests for ImplLayoutRuns, and added ImplLayoutRuns to vcl::text namespace. Change-Id: Id6ae8882acb8e3d821bb38551e78019cbdcaa662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121204 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-06vcl: move ImplLayoutArgs to own header and source filesChris Sherlock
Add unit tests for ImplLayoutArgs. Also add to the vcl::text namespace. Change-Id: I9fa0943548be8ca17ea3dac104e9cb609337a70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-05ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3de2dd1032f0b43f484b67be0ba470ae08395e91 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05ofz: fods timeout, set SAX_DISABLE_THREADSCaolán McNamara
sax/source/fastparser/fastparser.cxx:857 rEntity.maConsumeResume.wait() seen in timeout backtrace Change-Id: Ic1ab15e06dc5ac776101715026a334957bb8e868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ib63d500480a78a144b127c4230542507132d0a5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121669 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Iad99d728cea33e8a3b81ccd654258bddd3f96a13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05ofz: Timeout, break earlier on stream failureCaolán McNamara
Change-Id: If6612493224be5daa06288773c0aa1d22414c738 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-05vcl: unit tests for Bitmap::Crop() and Bitmap::GetDownsampledBitmap()Chris Sherlock
Bitmap::Crop() test: - If crop rectangle is fully outside of the bitmap, then return false and don't change the bitmap. - If crop rectangle is same size as bitmap, then return false - If crop rectangle is larger than the bitmap, then return false - If crop rectangle partially overlaps the bitmap, return true and crop the bitmap - If crop rectangle is fully within the bitmap, then return true and crop the bitmap Bitmap::GetDownsampledBitmap() tested to check when empty or not. Change-Id: Id2a6f739fdb1961748ce218862e628dfa8512122 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121546 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-04duplicate modules/scalc/ui/ttestdialog.ui test in vcl/jsdialog/enabled.cxxJulien Nabet
Change-Id: Ic8e7ebb59cace56fdd8202b7d1c7eec7f62368a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121639 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-04tdf#144289 invert / disable default OpenGL supportJan-Marek Glogowski
... and as a result drop setting a default in SalSvpInstance. This is also more consistent: now you must explicitly implement CreateOpenGLContext() and set "m_bSupportsOpenGL = true". Change-Id: I591580bf134907213b8308e0843c278d2f470ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121632 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-09-04ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Id576a38ed93b3ac0c3d1e886b65c7c13ced129aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-04use std::vector for fetching DX array dataNoel Grandin
because I'm trying to track down a related heap corruption, and that is much easier if the access to the array is checked by the std::vector debug runtime Change-Id: Ia665f5cebb7f14d88942e88b4b400ad3c28ef5d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121527 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04fix comment left behindNoel Grandin
in commit e25ba7dc57229d1cb9794abd1ca23c0d87ebecb3 use a dummy clipboard when running unit tests Change-Id: If5f57d1777dddbd70771299c8e161b33da10711d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121600 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-04vcl: Add unit test for SetRefPoint(), IsRefPoint() and GetRefPoint()Chris Sherlock
Change-Id: I4fbc85015326b03fba15daf73176826669a16210 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121017 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-03tdf#142458 Set correct ScrolledWindow BorderWidth in the ctorCaolán McNamara
and keep it updated when the relevant properties that affect it change. This avoids the problem that the borderwidth can change during "Paint" (which is something we strongly want to avoid) since... since: commit f39f21d92ec83c3a5062f29dd26214fc83012c06 Date: Thu Nov 19 11:51:13 2020 +0100 tdf#138010 (IV) VclScrolledWindow: Use actual border width hopefully after this we can then double-check to see if we can remove the potential change of BorderWidth during paint. Change-Id: I2ec317d86687fdb75e6323905f6d1c3b8fc655e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03pull duplicate field out of GlyphItemNoel Grandin
we already store it in SalLayoutGlyphsImpl Change-Id: I772c08966572e42789bcede1a148b2b7710f29d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6bafceac5ebd1852aaf296abe89b49b74ad884d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I95e6cb59a1f379dccd844f05648ba3652f3cb82c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121594 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6180ebe39cb5925882071892611dd6237b426fcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121609 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03pack GlyphItem structNoel Grandin
56 bytes -> 48 bytes Change-Id: I30d9763162b701e3d07a153deae3f5e03c290393 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121583 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03rename NeedFallback to AddFallbackRunNoel Grandin
Change-Id: I5d91e7b28075026198444036fbfc220296deac77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03rename NeedFallback to HasFallbackRunNoel Grandin
Change-Id: Iec45f84b330fc4e4a62b352cb007747a19a27bed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121578 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03backendtest: Rectangle on wide surfaces Drawing testhomeboy445
This tests draws a rectangle using all possible drawing methods for drawing a rectangle on a wide surface(1028x1028 and 4096x4096) and check it the usual way. Change-Id: I6fcf9c9b4b150cbe959b8151f327bcdce1b1139a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119464 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-09-03Fixing Unicode Arabic LiteralsHossein
Some Unicode literals are now available inside the LibreOffice code, so I think we can use Arabic Unicode literals directly inside LibreOffice code. It is more intuitive, and gives better insight to those who develop to understand what a foreign language script should look like. This patch consists of two things: First, converting a Unicode literal that was consisting of \uxxxx characters into an Arabic Unicode literal; Second, fixing an Arabic literal that was converted to shaped characters instead of normal Arabic characters. Change-Id: I11003cc471b2c83098cb0ebc4f4085771a132ecc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121164 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I3a45c8141b9f824c985dcf1aaac5d1aa45c0f70d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121575 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9f67d463958e3b3ce88b771dd8ca0f71f7393e32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121537 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ibd35c1aee4324620fb7ae17e20027057f1934c6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03simplify ApplyDXArray method paramsNoel Grandin
pass only the required data to it Change-Id: I849780371b71d3620dc36681453f5dbe1527b7bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I00531cdb266c4277af742cee6ce5d05f0ea3334e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121523 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I6a8dd39528038fbcc496e56d6fcefc4ec8db68cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-03vcl: Migrate OutputDevice font functions to font.cxxChris Sherlock
Add unit tests for SetFont() and GetFont() Change-Id: I5b66cd5531aa0f9fd73357dd2a168d9c5b655b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121016 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-02tdf#35129 a11y: Let SPINBUTTON have role SPIN_BOX, not PUSH_BUTTONMichael Weghorn
Change-Id: I3aaac19890a356e930203ecdb003edfbfed1b52b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121516 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I5b06808b7b676b9e7cbcea2d9330431c82055d0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121521 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I9284239851472d6776e80d9d9c283b7f45db13c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02convert malloc/free to std::vectorCaolán McNamara
Change-Id: Icc9bb8cd6851ee027d5a5469c78d26cf6a943708 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02move variables to where they're usedCaolán McNamara
Change-Id: Iaf7e7bf1a58aedb0ad6852812f969fc7e6153a54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121500 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02vcl: make GetFillColor() and IsFillColor() inline class functionsChris Sherlock
Change-Id: I5f80765658f1c1679f56df59d4b8212caa9d1357 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121486 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I827ddc6692280dbad44b03cfa07f1f35375080c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02unused definesNoel Grandin
Change-Id: I494e64c69decb9fb3d5b13ffc2f18d99f6b7749f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I08bffde6c08d97d140e2985876a62084035d657f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121484 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-02ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
bodge dodgy SetStreamSize for now Change-Id: I4f15a2f2e196eb7b4a22331e66966f242d8968c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121483 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-01-10 15:00:43 +0000