summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-09-23WB_DEFAULTWIN should be sufficient to flag that no icon is requiredCaolán McNamara
Change-Id: Ibb5d8331d5d47e2b5c163c2797b2e7b5cee4b285 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-23gtk4: fix buildCaolán McNamara
Change-Id: I6bee4180ea2d91a2917765bc1934a8403b72c07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122513 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-23Related: tdf#142704 ReadStringHook may not be set in testing configurationsCaolán McNamara
Change-Id: Iab2cd0cccb781a39af7b9315ccf8c242a2cc49a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-23tdf#144624 Prevent infinite recursion when loading SVG iconAleksei Nikiforov
When Generic/X11 VCL backend plugin loads SVG icon, it creates virtual device for rasterizing an SVG icon, which in turn tries to load an SVG icon, and thus infinite recursion happens. Change-Id: I7559b6255e6718e64ef4a6e7c79d597375e5823a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122344 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-23Related tdf#144618: add check in bin/ui-rules-enforcer.pyJulien Nabet
+ fix vcl/qa/cppunit/builder/demo.ui Change-Id: I556cf99687f138e2d9667dc742dd44cafe7b1a02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122488 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-23Removed duplicated includeAndrea Gelmini
Change-Id: I437754f53c45965ec6026a6ce21ea3e67528f732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122411 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-09-23external: update pdfium to 4643Miklos Vajna
Change-Id: I4e86b163a9abef88f26c6c0ae91ae0a4008658f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122485 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-09-22Resolves: tdf#142704 %PRODUCTNAME shown in gtk3 extended tipsCaolán McNamara
Change-Id: I61d8b83ce326816c498f54e3cfc053270d82c1a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-22Extend loplugin:stringviewparam to starts/endsWith: vclStephan Bergmann
Change-Id: Ic208697fd985da223819d203e67325b03028fca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122469 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-09-22fix deadlock in vcl::GraphicManagerNoel Grandin
after commit 300753bf1d4db7eff42d707f427180f0d1d1dffb no need to use recursive_mutex in graphic::Manager Change-Id: I85b6f83d513ea1998e1bd7c3be5cea999c590c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122426 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-22ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7c514aaa500e14794d0fc7aad2def695fb6a6420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-22Fix Skia/Raster descriptionJulien Nabet
See https://bugs.documentfoundation.org/show_bug.cgi?id=144598#c16 Change-Id: I5a39fbc324af0944560e91d4249ab572e5579af1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122404 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-22add a TestImportDBFCaolán McNamara
Change-Id: Iddb0d69d2ffaafd81076cd52a8424c32fe3c4114 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-21qt5 a11y: Implement Qt5AccessibleWidget::is{Column,Row}SelectedMichael Weghorn
Change-Id: I2abfbc69a422a56dc07afd76f0c7a8ead1891830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122398 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-21qt5 a11y: Implement QAccessibleTableCellInterfaceMichael Weghorn
Let 'Qt5AccessibleWidget' derive from 'QAccessibleTableCellInterface' and implement the most important methods. This is e.g. one of the steps needed to make Orca announce the focused cell in Calc. Since there's no specific XInterface for table cells make use of the fact that a table cell's parent is a table and query information from there, similar to how the following commit does for winaccessibility: commit 97a88e30e2e084ab860635ff4e0a03442d8a12af Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Sep 8 14:37:53 2021 +0100 tdf#100086 tdf#124832 wina11y: Implement IAccessibleTableCell Change-Id: I160bc04f3e4fcf7b77723540aba6945b8fdf36ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122395 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-21qt5 a11y: Drop Qt5AccessibleWidget::{text,value}InterfaceMichael Weghorn
They're unused and at first glance look like they might be overriding the non-virtual methods from 'QAccessibleInterface' with the same name that do something more useful (calling 'interface_cast' with the corresponding 'QAccessible::InterfaceType' param). Change-Id: I9258a5f9386f9a7d23bb35cfa33e55a169eb753e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122394 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-21add commentNoel Grandin
Change-Id: I0f9627d0d573c5a5bade00f40dea2d0f1b518528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122391 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-21no need to use recursive_mutex in graphic::ManagerNoel Grandin
regular std::mutex is fine Change-Id: I820bb83117a0ea920f550f6ad459a623b4939ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-21stack allocate this TextLayoutCache object (tdf#125892Noel Grandin
Change-Id: I838543c47ec420ec3b562e0b7e8524c4b2f070a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-09-21vcl: remove OutputDevice's GetDevFontSizeCount() and GetDevFontSize()Chris Sherlock
The OutputDevice::GetDevFontSize() function is only used for non-scalable (bitmap) fonts. We have stopped supporting bitmap fonts since LO 5.3, see tdf#103514: Support for bitmap-only fonts on Windows has been removed (Khaled Hosny) I found the following when removing PhysicalFontFace::SetBitmapSize(): 1. as mnHeight and mnWidth and not set by anyone, I realized I could remove them, which meant removing GetHeight() and GetWidth() 2. PhysicalFontFamily::GetFontHeights() populates heights from the collection of font faces into a sorted vector of font heights taken from PhysicalFontFace. As this no longer exists this function serves no purpose, it has been removed. 3. PhysicalFontFamily::GetDeviceFontSizeList() calls upon PhysicalFontFace::GetFontHeights(). This function takes this sorted list of font heights, and then populates and returns a new list of sizes (or rather, heights). As the heights aren't available any more, this function is also unneeded, so it has been removed. 4. OutputDevice::GetDevFontSizeCount() calls upon PhysicalFontFamily::GetDeviceFontSizeList(). This function has the side effect of initializing the list of fonts. 5. When I checked what calls on GetDevFontSizeCount(), there is only one caller - FontList::GetSizeAry() in svtools. The function returns a standard font size list if the family name is empty, or there are no font sizes (via OutputDevice::GetDevFontSizeCount()). As this will *always* be empty (see chain above) then this function just needs to always return a standard font size list. Thus OutputDevice::GetDevFontSizeCount() and GetFontSizeList() are no longer called upon by anything, so they can be removed. 6. svtool's FontList::GetSizeAry() no longer uses the FontMetric parameter, so this has been removed from the function signature, and cleanup done of the function that calls upon it in svtools, framework, editeng, and desktop. A number of variables that were no longer used due to this change were also removed. 7. This change removed the need for the mpSizeAry unique_ptr in FontList. ImplFontListFontMetric::GetDevice() and mpDevice could also be removed as it was no longer used anywhere. 8. After simplifying GetSizeAry(), it turns out it was the same as GetStdSizeAry(), so removed FontList::GetSizeAry() and used FontList::GetStdSizeAry() in its place. 9. Changing to use GetStdSizeAry() revealed that FontSizeBox::Fill() no longer used the pFontMetric paramter, so this was removed, and call sites updated. 10. Due to change to Fill(): a. SvxFontSizeBox_Base::UpdateFont() no longer uses the const css::awt::FontDescriptor& rCurrentFont parameter, so removed this. This also removed the member variable m_aCurrentFont b. SvxCharNamePage::FillSizeBox_Impl() had a number of newly unused variables removed. c. SwStdFontTabPage::Reset() and SwStdFontTabPage::LoseFocusHdl() had a number of newly unused variables removed. Change-Id: If840e240155c36ed351c63e3136b5b44bb058697 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121932 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-21vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. This patch is created in preparation of a patch I have queued to test and move PhysicalFontFace to vcl::font namespace. Change-Id: I15dd24d7f01e077d407ac192a0413d796517eb72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122228 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-20tdf#124176 - Use pragma once instead of include guardsChris Sherlock
This patch is created in preparation of a patch I have queued to test and move PhysicalFontFace to vcl::font namespace. Change-Id: I805a8bd1fa881fc4bc6d2f26f1051b9247587701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122226 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-20clean up ambiguous confusing rectangle APIs like IsInside()Luboš Luňák
Reading 'rectA.IsInside( rectB )' kind of suggests that the code checks whether 'rectA is inside rectB', but it's actually the other way around. Rename IsInside() -> Contains(), IsOver() -> Overlaps(), which should make it clear which way the logic goes. Change-Id: I9347450fe7dc34c96df6d636a4e3e660de1801ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122271 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com> Tested-by: Jenkins
2021-09-20Add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. I have a patch queued to be able to create a FontMetric from a PhysicalFontFace. Submitting this patch so I can hopefully one day land this patch. Change-Id: I5817acd6e194da576f2c8a13539d38954a4f4e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122172 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-20vcl: unneeded functions in PhysicalFontFaceChris Sherlock
Nothing uses PhysicalFontFace::SetBitmapSize(), so remove it. This in turn meant that the class doesn't ever use CompareWithSize() directly, as this calls on CompareIgnoreSize() when no width or height is set I have removed CompareWithSize(). Change-Id: I1012ffd3bc0f39f917a8b725f9985844967533dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121931 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-19cid#1492159 Uninitialized scalar fieldCaolán McNamara
since... commit c2e6a068c112f4c5866b6371d02362bd71f903a3 Date: Wed Sep 8 12:07:48 2021 +1000 vcl: create FontMetric from PhysicalFontFace where previously we had... FontMetric aFontMetric; ... aFontMetric.SetFamilyName( rData.GetFamilyName() ); ... return aFontMetric; so the FontMetric default ctor was called which initialized all FontMetric's members, but afterwards with... return FontMetric(rData); the new FontMetric ctor taking a const PhysicalFontFace& arg left all the non-inherited members of FontMetric uninitialized Change-Id: I91ee08ed1d63d15eccec44c87841884b2992eacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122317 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-19ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I8de015f7c748de338f989a383838ce3921d176a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122315 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-19vcl: test PhysicalFontFamily and move to vcl::font namespaceChris Sherlock
- Adds a series of unit tests for PhysicalFontFamily - Moves PhysicalFontFamily into vcl::font - Move PhysicalFontFamily.hxx into vcl/inc/font This is part of a series of patches where I also move font files into the relevant font directories, and into the vcl::font namespace. Change-Id: I9e8d7ceb5ec3494bf3ab6560645e52e88223ee69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121903 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18ofz: reduce size of hwp inputCaolán McNamara
fuzzer seems to hover right at the edge of an intermittent timeout Change-Id: I478c0f355ceb4d05c60834db3f2dc14a72696794 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122303 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. I have a patch queued to test PhysicalFontFamily and move it to vcl::font. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I92275250bc5e12f7e6f7c0d4b6405d6a6e8de033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122179 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18vcl: create FontMetric from PhysicalFontFaceChris Sherlock
A FontMetric can be created from a PhysicalFontFace, so setup a constructor that takes a PhysicalFontFace object to instantiate the FontMetric. The OutputDevice functions GetDevFont() and GetDevFontCount() don't necessarily make much sense, so have changed GetDevFont() to GetFontMetricFromCollection() and GetDevFontCount() to GetFontFaceCollectionCount(). Change-Id: I1577679b949a49a7cf1248838786d0f5e84a5245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121796 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18vcl: rename ImplDeviceFontList to PhysicalFontFaceCollection and testChris Sherlock
- renamed ImplDeviceFontList to PhysicalFontFaceCollection and moved to own header file - wrote unit test for PhysicalFontFaceCollection Note that this is part of a series of patches where I also move font files into the relevant font directories, and into the vcl::font namespace. Change-Id: I43669137bcd9a9b2a9417b2369a5cb1b93b93733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121663 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-09-18vcl: add sal/config.h in preparation for patchChris Sherlock
The convention is that we need to add sal/config.h to the start of files. <chris_wot> mikekaganski do you want me to add sal/config.h to cxx files <chris_wot> as well as headers? <mikekaganski> chris_wot: rather ask sberg :) <@sberg> chris_wot, always, always as first include, by convention <chris_wot> thanks, I'll make sure I do this on any files I touch - if that's OK I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting this patch so I can hopefully one day land this patch. Change-Id: I9d74f850745760774a9f8050023f584cf52dc070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122167 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-18tdf#124176 - Use pragma once instead of include guardsChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the include guards to pragma once Change-Id: I091817905599089edec1138eeee06ba3dacd6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122225 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17gtk4: fill context menusCaolán McNamara
Change-Id: Ie59f569f8917dee730e79a3bea6c3e6161ae9fea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122241 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17vcl: update vim modelines in preparation for new changeChris Sherlock
I have a patch queued to rename ImplDeviceFontList to PhysicalFontFaceCollection, which I am adding a test to. Submitting patch to update the modelines in the files that I will change in that patch. Change-Id: I3b0b022cbfa7b05dbfbb5c2d03f6d68128c0598f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122232 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-09-17gtk4: guard vcl calls from gtkCaolán McNamara
Change-Id: Iff35ff96c5df987258979b388485af4f3d1f039e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17Fix gtk4 build ('--enable-werror')Michael Weghorn
Fixes [CXX] vcl/unx/gtk4/transferableprovider.cxx In file included from vcl/unx/gtk4/salnativewidgets-gtk.cxx:10: vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:364:19: error: ‘gTreeViewWidget’ defined but not used [-Werror=unused-variable] 364 | static GtkWidget* gTreeViewWidget; | ^~~~~~~~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:363:19: error: ‘gListBox’ defined but not used [-Werror=unused-variable] 363 | static GtkWidget* gListBox; | ^~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:362:19: error: ‘gComboBox’ defined but not used [-Werror=unused-variable] 362 | static GtkWidget* gComboBox; | ^~~~~~~~~ vcl/unx/gtk4/../gtk3/salnativewidgets-gtk.cxx:355:19: error: ‘gSpinBox’ defined but not used [-Werror=unused-variable] 355 | static GtkWidget* gSpinBox; | ^~~~~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:307: workdir/CxxObject/vcl/unx/gtk4/salnativewidgets-gtk.o] Error 1 make[1]: *** Waiting for unfinished jobs.... In file included from vcl/unx/gtk4/notifyinglayout.hxx:13, from vcl/unx/gtk4/gtkinst.cxx:14: vcl/unx/gtk4/../gtk3/gtkinst.cxx:4385:11: error: ‘static void {anonymous}::GtkInstanceWidget::LinkStubasync_drag_cancel(void*, void*)’ defined but not used [-Werror=unused-function] 4385 | IMPL_LINK(GtkInstanceWidget, async_drag_cancel, void*, arg, void) | ^~~~~~~~~~~~~~~~~ include/tools/link.hxx:45:13: note: in definition of macro ‘IMPL_LINK’ 45 | RetType Class::LinkStub##Member(void * instance, ArgType data) { \ | ^~~~~ cc1plus: all warnings being treated as errors make[1]: *** [solenv/gbuild/LinkTarget.mk:304: workdir/CxxObject/vcl/unx/gtk4/gtkinst.o] Error 1 make: *** [Makefile:288: build] Error 2 Change-Id: Id570c22aa66bf134fdc4dda31a0cf1f867f3653d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122235 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-17gtk4: get menus attached to menubuttons after load time workingCaolán McNamara
run update_action_group_from_popover_model on the newly attached menu Change-Id: If871dea4833c60efc5853de19031fc6e45544170 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122198 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-09-17gtk4: listen to "toggled" so callbacks see get_menu_item_active of trueCaolán McNamara
Change-Id: I130ebbb6dad9c0f69667a1c95e97583183656710 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-17Drop conditional WM_GETOBJECT define from vcl/win/window/salframe.cxxMichael Weghorn
WM_GETOBJECT is already defined in WinUser.h. Change-Id: I7594560698dd2a17412f5075f8b689decbd4ca49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122202 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-09-17avoid more window invalidation in LOK modeLuboš Luňák
This is an extension of 9b73d3e8926d5f9b10464d19b539eef3eb088f50. If we're not painting to windows in LOK mode, then it's a waste of CPU time to calculate invalidations for them when it'll be thrown away anyway. Change-Id: I20b1064cb9e41fd6d88b8dc2ee4edb80ae0e9104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122194 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-09-16gtk4: use gtk_menu_button_set_child when available to fill in iconCaolán McNamara
Change-Id: I3da421969cf1775cbf0072bf94891d883a96b70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: 4.6.0 will have gtk_menu_button_set_childCaolán McNamara
which will solve the problem of setting icons and keeping the drop down for GtkMenuButtons used in toolbars Change-Id: I9e0632c8756e7085868541d11709aa598f738bf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set always-show-arrow on GtkMenuToolButton replacementsCaolán McNamara
Change-Id: I4c1be40e40d2f1e2bcbf26cffda7a6dd52e4f731 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: adjust to GtkMenuButton changes in 4.6 onwardsCaolán McNamara
Change-Id: I892aae979f8fb9b5a7c13a790905d7e7e3f2c087 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122190 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16find_menu_button only needed for gtk3Caolán McNamara
Change-Id: I3eeb7dea4ff36b8c969aec210161c1729ab9b372 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122189 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set can-shrink to False for GtkPictureCaolán McNamara
for the icon in GtkMenuButton in the calc, insert, header and footer in gtk 4.6 where the MenuButton begins to support a child widget again but the icon while now shown in squished Change-Id: Ibc274d88b1185eee0ee61973b40b5cde2d08f554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-16gtk4: set newly available always-show-arrow propertyCaolán McNamara
since 4.4 Change-Id: I6d7d0077617077606a7ef48f22183fcd3ca69c88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122181 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-09-15add some logging for intermittent windows jenkins crashNoel Grandin
Change-Id: I8ad589dd8d0a64f75179d3330c80c9c43a21ff32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122155 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-01-25 06:35:10 +0000