summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2016-09-20loplugin:unusedfieldsNoel Grandin
Change-Id: I852e98b16fdcb88b04e39d11e3101d502c918c24 Reviewed-on: https://gerrit.libreoffice.org/29078 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-20Related: rhbz#1362451 avoid recursive ownerchanged handling during ownerchangeCaolán McNamara
Change-Id: Id9c12b7ce6458348890d7c7ff7fdb2cd37c4601c
2016-09-20tdf#102295: remove mutex - use atomic for watchdog timingsTomaž Vajngerl
Change-Id: I6587bad8b7906faeae39735343278b10be78c05b
2016-09-20tdf#102295: AMD actually has two vendor id's.Jan Holesovsky
Change-Id: I9cc1341c8f8d154927a778dfa15b8d3013a9a487
2016-09-20tdf#102295: The relaxed values were actually too pessimistic.Jan Holesovsky
Change-Id: Ia117ae4a60a10994f3c59316e8c9a161aa8e5baf
2016-09-20Obsolete workaround for SUNPRO 5 compilerStephan Bergmann
Change-Id: Ib51f08e1d0e0dff066b06ecd85976b777d722a33
2016-09-19tdf#102295: relax timeout timings for the GL watchdogTomaž Vajngerl
Some OS/GPU combinations need more relaxed watchdog timeout timings as the shader compilation takes too long to complete. Change-Id: Ifd9ff7ecfa4b004d5411d6d364dd01a389a3fcec
2016-09-19loplugin:unusedenumvaluesNoel Grandin
Change-Id: I9dcc9f73af6db5b4f7cc946bc28931e5c230b34c Reviewed-on: https://gerrit.libreoffice.org/29012 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-19Related: rhbz#1373933 gtk3 emits a lot of style-updateds signalsCaolán McNamara
so don't throw away font settings every time, check if the font settings changed and only emit FontChanged if they differ from the last seen settings. Change-Id: I129887e3e866f395da3b906a38cf568abea5de8e
2016-09-19GtkSalMenu: Need a way to remove icons tooMaxim Monastirsky
e.g. user switches menu icons option off. Change-Id: I2a3f2c170f262a4542bfea24eb746f3aa405cbd6
2016-09-19Missing g_variant_unrefMaxim Monastirsky
because g_icon_serialize is calling g_variant_take_ref on it, followed by a g_variant_ref_sink call inside g_lo_menu_set_attribute_value. Change-Id: I1b68c64b6845f2f58b70c54f1b0f3f53141c1d5c
2016-09-18loplugin:unusedenumvaluesNoel Grandin
Change-Id: Icf17f936ce6d07d0e152252833c8645cf9b1163b Reviewed-on: https://gerrit.libreoffice.org/28942 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-16Resolves: rhbz#1373933 gtk 3.21 emits a lot more "style-set" signalsCaolán McNamara
also deb#837356 since gtk3 commit of... commit 0f116135f4a5033ce4e9dfa19f10624701fa615c Author: Matthias Clasen <mclasen@redhat.com> Date: Fri May 6 10:12:14 2016 -0400 Avoid emitting ::style-set by name GtkStyle is deprecated, but we still emit ::style-set quite a bit, so lets at least not be slow while doing it. docs say... 'GtkWidget::style-set has been deprecated since version 3.0 and should not be used in newly-written code. Use the “style-updated” signal' and this code just came over from gtk2 without any thought about it at the time, so change it over to the "style-updated" which makes everything happy again Change-Id: I9e920d2fb2d820ff1b1b5a9ecb228484df3d6146
2016-09-16tdf#96505 - Remove "long" integer literals in vcl/source/gdi/e12346
Removed the "long" integer literals in "vcl/source/gdi/". Some literals are left to match external methods Change-Id: I55aa9bd2935bfd82c9c1cc5cd1efcc4b7c3d9346 Reviewed-on: https://gerrit.libreoffice.org/27784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-09-15vcl: consistently use sal_IntPtr to marshal drag source / drop targetMichael Stahl
This may be either an X11 Window or a GtkSalFrame*. Change-Id: Ib963cfb329bb711cfaab47f2748da139117cdbae
2016-09-15replace sal_Size with std::size_t (or sal_uInt64 for SvStream pos)Michael Stahl
... except in include/rtl, include/sal, include/uno, where sal_Size is retained for compatibility, and where callers of rtl functions pass in pointers that are incompatible on MSVC. Change-Id: I8344453780689f5120ba0870e44965b6d292450c
2016-09-15Remove OutputDevice::PaintScopeNoel Grandin
PaintScope was introduced in commit bfceb557efcd607ef018ae35fc73f8d61a9b9a4e Author: Michael Meeks <michael.meeks@collabora.com> Date: Wed Sep 16 09:17:37 2015 +0100 GL paint-flushing guard re-work. Unfortunately, since we can have 2x SalGraphics' on a OutputDevice, and one of these can be a printer - things got very confused around which context to glFlush. This de-tangles the various reference- counts. and then mostly removed in commit 33fac4828038bc38ab4a0c4b891d762a5ae73e5e Author: Noel Grandin <noel@peralex.com> Date: Thu Dec 24 09:21:23 2015 +0200 loplugin:unnecessaryvirtual and unwind some apparently now unused VCL OpenGL and GlyphCachePeer stuff. Finish the job, it's not doing anything at all anymore Change-Id: I1365c2d0652ee92630d0649b2df6e5a7b7e37e73
2016-09-15loplugin:singlevalfields in sc..vclNoel Grandin
Change-Id: I68752a3daf5ddd8581c07759b8be2c1dabbb9258
2016-09-15loplugin:countusersofdefaultparams in vclNoel Grandin
Change-Id: I046e6f16c5b171a06e2be2da2f72340634f3e979 Reviewed-on: https://gerrit.libreoffice.org/28891 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-14loplugin:overrideStephan Bergmann
Change-Id: Ica137897f02c5caa4c4891f75531ada3957025d9
2016-09-14loplugin:constantparamNoel Grandin
clean up the plugin a little, and try to catch params which are default constructed, which doesn't seem to be working yet Change-Id: Ife45f18502a45cd26306424b7432c55fcbb0fd12 Reviewed-on: https://gerrit.libreoffice.org/28861 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-09-13tdf#74377 Keyboard shortcuts for context menusMaxim Monastirsky
Configurable through the options dialog. The default behavior depends on the current vclplug (hide for gtk2/3 and OS X, show otherwise). Menus currently affected by this change: - SfxDispatcher based context menus - chart2 context menus - vcl's Edit control context menu - Several MenuBarManager based toolbar dropdowns. Change-Id: Iad9fb99dc90e01c17cba9c07c1a2b262b920e11d Reviewed-on: https://gerrit.libreoffice.org/28849 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2016-09-13chmod 644 some source filesStephan Bergmann
Change-Id: Icd8821278635c1bd27b5185cddf5dc25dfba7eb4
2016-09-13loplugin:override: No more need for the "MSVC dtor override" workaroundStephan Bergmann
The issue of 362d4f0cd4e50111edfae9d30c90602c37ed65a2 "Explicitly mark overriding destructors as 'virtual'" appears to no longer be a problem with MSVC 2013. (The little change in the rewriting code of compilerplugins/clang/override.cxx was necessary to prevent an endless loop when adding "override" to OOO_DLLPUBLIC_CHARTTOOLS virtual ~CloseableLifeTimeManager(); in chart2/source/inc/LifeTime.hxx, getting stuck in the leading OOO_DLLPUBLIC_CHARTTOOLS macro. Can't remember what that isAtEndOfImmediateMacroExpansion thing was originally necessary for, anyway.) Change-Id: I534c634504d7216b9bb632c2775c04eaf27e927e
2016-09-13Remove nonsense comments: // bitfieldTor Lillqvist
Surely the actual bitfield syntax is enough to tell the code reader that it is a bitfield. Change-Id: Ic9552e01b19c8b34b2a17db56b9ff63e7c7de926
2016-09-12Bin some noise comments and superfluous vertical whitespaceTor Lillqvist
Change-Id: I3c19457bb29cd1392f14598fc8798aed4b1a1a7f
2016-09-12Resolves: tdf#101879 explicitly put menubars at the start of task listsCaolán McNamara
Change-Id: Ia6a36b08f84960b01472833504cd65bfbad473eb
2016-09-12tdf#101889: add absent brackets to OpenSymbolMike Kaganski
The code points for the glyphs were chosen according to IANA and Unicode: http://www.iana.org/assignments/character-sets/character-sets.xml ftp://ftp.unicode.org/Public/MAPPINGS/VENDORS/ADOBE/symbol.txt Adobe Symbol font map has been corrected accordingly. Fixed MT Extra font to always have symbol charset. Change-Id: I45d4f33f2b640cc852175c7c5d5c875cb72a9297 Reviewed-on: https://gerrit.libreoffice.org/28677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2016-09-10Typo: (un)kown->(un)knownJulien Nabet
Change-Id: I7455c928293cd8d2d2ff16aa85fe02c9a54959d2 Reviewed-on: https://gerrit.libreoffice.org/28801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-09-09Hack to make Arabic subtending marks workKhaled Hosny
E.g. in Amiri. Change-Id: Ibdac6b02bdbae40786d7c2c4725641be5cbfb80d
2016-09-08Resolves: tdf#101881 gtk3 3.18 menubar doesn't grab keyboard...Caolán McNamara
the same way gtk3 3.20 does with gtk_grab_add, so on gtk_menu_shell_deselect the keyboard focus doesn't remain in the menubar. bisecting gtk itself I find... commit 5cbbb90e311d95192d1b68ba89c3190cdb652868 Author: Carlos Garnacho <carlosg@gnome.org> Date: Thu Nov 26 19:54:31 2015 +0100 GtkCellRendererAccel: Use gdk_seat_grab() https://bugzilla.gnome.org/show_bug.cgi?id=759309 is the commit that makes it do what I want, so add an extra gtk_grab_add/gtk_grab_remove around our entry and exit of the menubar Change-Id: I5bf09834b4e1a14d30403208d03b3abd28a382a8
2016-09-08rename CollapsAttribs -> CollapseAttribsNoel Grandin
Change-Id: Ic70f67fb7e0e557a3a726f44aef25931def49835
2016-09-07Resolves: tdf#100443 handle sun keyboard copy/cut/paste keysCaolán McNamara
Thanks to Charles Lindsey for these suggested changes Change-Id: I22d14f16ee560f189c40ba0b143718278e0a8b7d
2016-09-07Related: tdf#100443 don't use deprecated gtk keysym definesCaolán McNamara
Change-Id: I7c018a304844b06e66b7f344a4deeabb43ae4026
2016-09-07tdf#101869 Allow toolbox to open from spacebarAkshay Deep
Change-Id: I3a60c8f590f78a9d750a428170d2a0521f267fd8 Reviewed-on: https://gerrit.libreoffice.org/28727 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07less dlopen, call gtk2 things direct, baseline is newer nowCaolán McNamara
Change-Id: Iff385fe836f8e959fb8b16aa76603b490bc44d9f Reviewed-on: https://gerrit.libreoffice.org/28719 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-07Fix not-so-newly introduced perf regression in vclKhaled Hosny
Reverts f688acfdae00ebdd891737e533d54368810185e1 and the cluster boundaries part of 1da9b4c24e806ad2447b4a656e2a7192755bb6a8, checking the user of the GlyphItem::IS_IN_CLUSTER flag again, I think the old code provides what they expect. Change-Id: I47d279837af963a6db74ebd0019dcef83d98ae7a
2016-09-07BigToolBox painting fixSzymon Kłos
If the button was dropdown only type the arrow was on the same position as a text. Change-Id: I3d9693ef57c5c2d27549987339a1c388bc3ff724 Reviewed-on: https://gerrit.libreoffice.org/28721 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-09-07gtk: drop unneeded X11 includesCaolán McNamara
Change-Id: Iea6f90e40401bd3f0e4c54de598df2262f14b686
2016-09-07loplugin:constantparam in vclNoel Grandin
Change-Id: I0cae8e5de1170dec4c82df7f1f5377143a079876 Reviewed-on: https://gerrit.libreoffice.org/28686 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-07loplugin:constantparam in vcl..xmlscriptNoel Grandin
Change-Id: Icf66c08071b154259c9e551342d30331caf2b15a Reviewed-on: https://gerrit.libreoffice.org/28685 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2016-09-06Work around loplugin:unnecessaryoverrideStephan Bergmann
("public virtual function just calls public parent", in the gtk3 case) Change-Id: I0d5653f835fe0e62a905943fda7d79538dabfee3
2016-09-06use same GtkInstance::AnyInput impl for gtk2 and gtk3Caolán McNamara
Change-Id: Ib69884e0d02b0b245459eb05d5dfb54797d566ce Reviewed-on: https://gerrit.libreoffice.org/28680 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-06GtkInstance should use default no-op I18NImeStatusCaolán McNamara
gtk3 already did, gtk2 claimed to support it, but will use the built-in gtk support for this. So this leaves this as gen/kde4 only now. Change-Id: I640ffafc93bf45a4729ecd33f0f85f23fa67b4bf
2016-09-06move all X11SalData stuff togetherCaolán McNamara
Change-Id: I2dc27e8aa0231ad66955721029f61720d757967f
2016-09-06don't need to include all these headers, reduce to required minCaolán McNamara
Change-Id: I1f05ed32cabc059309f46ec0a195705f0e774bd6
2016-09-06SalI18NImeStatus is stubbed the same way for everyone except...Caolán McNamara
the gen vclplug, which is then unused for the gtk/gtk3 case so only possible to use in gen/kde. Make the default impl the no-op case and override just in gen Change-Id: Id0dd3fe4ae4e5b94bfc56219defab56905ec710a Reviewed-on: https://gerrit.libreoffice.org/28675 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-09-05Simplify Sequence constructionStephan Bergmann
Change-Id: I24b53d2879d1aa34d7882300c7b51e42e621160e
2016-09-05Convert PPDKey::SetupType to scoped enumNoel Grandin
Change-Id: I7c39c9bd4bc3b8fe82840665906f8d520e2e2d2a
2016-09-05convert PrinterInfoManager::Type to scoped enumNoel Grandin
Change-Id: I3ae15e3ef9505b9857ab1dfa0ecdbf57e3a08150