Age | Commit message (Collapse) | Author |
|
Found by FindBugs.
Change-Id: I223841f7bb8c515c9612322abc0b13e134385abd
|
|
Change-Id: I14f9b8e7b7e2cdcbdc60de17471b1a3a381d83f0
|
|
Change-Id: I899164412ad90653b4228423283f9fbd4cb5fccc
|
|
Change-Id: I169624820cd7d25eab18a6b90482e075ebfebcc6
|
|
Change-Id: Ic67c5562d0e9936cd6a524ecd4f798aaf885a6e8
|
|
No need for redundancy.
Change-Id: Ia68d2e57af33cdca90246de54cdff656ea6c3942
|
|
Change-Id: I010146e9b7181d0cc704a26ae1d373794cf6facb
|
|
This reverts commit 3e5371aba3eb29efb9574881212cba0975c168d7.
Change-Id: I9e02a3d72f66a1eabb1f25d95417c855459556cc
|
|
Especially given that lines are sometimes actually drawn using polygons.
Change-Id: I429a24faff94f8b9accc20bdee3ff66f47669bde
|
|
Change-Id: I600e7dd96bcf1e173398a51f63efd66300853fb0
Reviewed-on: https://gerrit.libreoffice.org/12492
Reviewed-by: Katarina Behrens <bubli@bubli.org>
Tested-by: Katarina Behrens <bubli@bubli.org>
|
|
Change-Id: I931a4b618f35188e4e0cca07305ff15bbbacc20a
|
|
Change-Id: Ifdfcbd9d3d62d2a55e3e050d4723700f8436e57a
|
|
start docked, move to undocked
start undocked, move to dock, back to undocked
start undocked, with and without size saved in settings and restored
Change-Id: I0bfdceb11aabdf9fdb855b97433b2af0532e4d03
|
|
Change-Id: I3efcac58f7a6629ae2615e29ea564e583414479c
|
|
Change-Id: Iffdc04464bd70ca70684f28e6d6e23a054bfc8a7
|
|
Change-Id: I90375232aefbe40412614ca0f30ba467cf393f2e
|
|
Change-Id: Idb4f91ffc89a3a7857ee36bfa977e37b37211c5f
|
|
|
|
Change-Id: I85996380ea5b3a157ba573182da0bc380effa1e5
Reviewed-on: https://gerrit.libreoffice.org/13464
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia90a4c371e66f4a5b9a37b4c4ac7d3118ad518a5
|
|
Change-Id: I9965f58b8f06f1cec2c419dcf16d8aebf9cd97b8
|
|
I.e. make it possible for the opengl backend to decide to use a different
scaling algorithm.
Change-Id: I36e76de071797129c7636b3048c93bc6e5d93aca
|
|
Change-Id: I491a6410f70b063fd74834d5837be34e4b9552d7
|
|
Change-Id: Iffe850d99f2dcd9e955a4ba1190e010be905434b
|
|
Change-Id: Ia65754272ff5c1661241dd503cef23c7a89b660e
|
|
Change-Id: I424ac73f23bed5b3782c148d9242ca8fc29d200d
|
|
Change-Id: I3a67da89cedbb6a58b2556abf4553857125af5a6
|
|
I.e. between one PreDraw()/PostDraw() pair.
Change-Id: I358d603ff33fa7416a4033bf074fe390b1112fcc
|
|
Change-Id: I2a2f18d76b0deb5f6cfd68b36699d940703372b3
|
|
One clear bug in the code, in my opinion, was that
PDFSigningPKCS7PasswordCallback() returned its argument as such. However, a
PK11PasswordFunc should return "a pointer to the password. This memory must
have been allocated with PR_Malloc or PL_strdup", says
https://developer.mozilla.org/en-US/docs/Mozilla/Projects/NSS/SSL_functions/pkfnc.html
.
I could not test this fix fully before my hardware token decided to block
itself, thanks to too many wrong PIN attempts. Possibly it would work to even
just pass NULL for the password callback function and its argument to
NSS_CMSEncoder_Start(). After all, at least with the hardware token and
associated software that I tested with, the software itself pops up a dialog
asking for the PIN (password).
Change-Id: I85a8b2833cfdd1a1d7b7779016fefb71dd53ab80
|
|
Change-Id: Ie230115d71bffeb08fc13380648e8216c43f3a5d
|
|
Change-Id: I0ff1e44f17976fd3a3060d8ee7fe15d77c918b79
|
|
Change-Id: I6b1b790bfcc94823f703679689bbd76312ee3e5b
|
|
Change-Id: I44648fb951d03090759d8afaa20cab7d945f684d
|
|
Change-Id: Ie1431f24031265e6fe54c6f0523261da88d71b00
|
|
Change-Id: Iaa0c47bcd53eaaf2577a5401762afaabe44e7514
|
|
otherwise vcl's clipping doesn't work quite right when the render text
with vcl apis fallback is used.
Manually forced in my case, but it should happen in practice with vertical
text, so if there is a bug about vertical text not appearing in slideshows then
this is part of the fix for that.
Windows and Mac remain unchanged as initialized with 1, 1. If the same problem
affects those platforms then they'll need to be adjusted to remember their
height/widths from the ctor and those values plugged in here instead
Change-Id: I2f82f0db0cf446d7db21f0a7ee4f8c15c7ebdb42
|
|
Change-Id: Ifce85b1a7fa8e8b6fc57802a5fb559d2db50ba2a
|
|
As agreed with Adolfo (and others) at the Design hangout on 2014-12-10.
Change-Id: Ibe0e8075566523e746866b9d2c15c348c345d2df
|
|
Change-Id: I0b6fd63f796598e56b2d8abe67df939240019217
|
|
Change-Id: I240d2b44e77d28af3cd5952b6d666a1709c4c54a
|
|
Conflicts:
include/vcl/opengl/OpenGLContext.hxx
Change-Id: Id9c7932976ce9d9282776c20d93d9cca4d290056
|
|
Change-Id: I66496fae902db9df5b8301b00bb779f42adaa7a7
|
|
Conflicts:
vcl/source/opengl/OpenGLContext.cxx
Change-Id: Ie2b93de8efe5ea56b0420adf23639c0153103385
|
|
Conflicts:
vcl/unx/generic/gdi/openglx11cairotextrender.cxx
Change-Id: I469b34c9f1047a274550229391d3dfb578291df6
|
|
Change-Id: I516cdbc466f3d6427e36fea8c5cdbe718ce7d0ea
|
|
Change-Id: Id446d20599f072f657c6106d6c6457fce08830e6
|
|
Change-Id: Iec9f8c7d8f7cded0aef9e017373e44387dc0b05c
|
|
found by PMD
Change-Id: Id6737916b68ccbdbdeec5d314747a38410923ac6
Reviewed-on: https://gerrit.libreoffice.org/13409
Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org>
Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
|
|
The signature should be in DER-encoded PKCS#7 format and what CryptSignHash()
produces is nothing like that. Luckily CryptSignMessage() is actually almost
easier to use and is capable of doing what we need. This also means that we
won't need any HCRYPTPROV or HCRYPTHASH after all so all the code related to
that can be removed. CryptSignMessage() handles both calculating the hash and
signing it.
One less than ideal issue with CryptSignMessage() is that it needs all the
data to be hashed and signed at the same time, so we need to keep both buffers
around for signing.
It also turns out that we don't need to look up the certificate anew from the
user's certificate store after all.
Now Adobe Reader doesn't complain any longer about the signature's format and
contents.
Change-Id: I25cfb93b516ffa723c6228d068d9ffa8e7cc4790
|