summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-10-16WindowType::CALCINPUTLINE newly unusedCaolán McNamara
originally introduced by... commit cba0dad4566652f63ea3114660da4e5c7dd88c31 Date: Wed Jun 13 14:08:28 2012 +0200 calc input line: Fix crash with accessibility enabled. Change-Id: Iee0914b79d3b48f4479e62622fbdb5dbdf26d527 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-16pdfium: add an FPDFBitmap_Create() wrapperMiklos Vajna
Fixes a leak in PDFiumPage::getChecksum(). Change-Id: I57471a26702f1d3dd69e9e18a4067ce0e724e358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104386 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-16fix some *printf which are using "%l" ie. long specifiersNoel
which are not portable between Linux and Windows because long is not portable. In preparation for converting long -> tools::Long Change-Id: I8bf1aa1570946ca887a6c83dd5f99c024d437336 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104374 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-16try to make available all slide images using threadsLuboš Luňák
Graphic::makeAvailable() is not thread-safe, but the jpeg loader is capable of that, and the graphic can be loaded using the stream data (which is what ultimately makeAvailable() will do anyway). This loads all images faster using threads instead of them being loaded one by one on-demand. Change-Id: Ifc39a2757834a9fb0dbafa61f13f5454e69af330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104082 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-15Replace list by vector in vcl/svpframeJulien Nabet
Change-Id: I0980a46869f11998f1529c8b95d93e302cb2692c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104181 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-15tdf#137432 only do EnableInvalidate(false) optimization when not shownCaolán McNamara
Change-Id: If7f35d19061a7a2db2e5df31227834526bbf0905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-15pdfium: add reading of attachment points to the wrapperTomaž Vajngerl
Attachment points are used to define where to highlight the text. Quad points - points of the rectangle that can be rotated (typical text). Change-Id: I5438a6520195b89149c9cd1a8235a77dbc622243 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104362 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-15pdfium: add support for border property of PDF annotationsTomaž Vajngerl
This extends PDFium with readon of "Border" property from the PDF annotations and adds the API to PDFium wrapper. Border is mostly used for border (line) width and the radius of rounding of the border (for drawing a rounded rectangle for example). Change-Id: I03f189eee03155ec699b2f56ceed23e6839a3f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104361 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-15pdfium: add getColor and getInteriourColor to PDFiumAnnotationTomaž Vajngerl
Interiour color is used as a fill color. Change-Id: If0c55fdaef083001abeb55e5c7ce3bae8d232713 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104360 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-10-15pdfium: add an FPDFImageObj_GetBitmap() wrapperMiklos Vajna
Replaces both FPDFBitmapDeleter and most manual calls to FPDFBitmap_Destroy(). Change-Id: I4676dd2f51b6b348ebbb6edc0379d7afd8fa79d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104324 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-15Replace list by vector in vcl/impdelJulien Nabet
Change-Id: I91f5859413ec3265647b8d55225b29ee95a06857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104182 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-14More fixes of uses of now-explicit OUString ctor taking raw sal_Unicode pointerStephan Bergmann
...in Windows-only code, after c927aab29ebfff1ce3ac0b2f27ae343025a9890c "Make the OUString ctors taking raw sal_Unicode pointer/non-const array explicit". Interestingly, these occurrences were accepted by MSVC and only cause errors with clang-cl, so happened to go unnoticed until now. Change-Id: I33e7653e28a21541ef793b4b0750abb6037752db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104314 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14use shadowcolor for bordercolorCaolán McNamara
this is what the calc inputbar has always done Change-Id: I17d3dd0b45575e81d6f2e2f109d371cfe366883b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14send ComboBox "changed" on autocomplete suggestionCaolán McNamara
and put include_mru into its own function Change-Id: I9e7c669df7c538ae7271b16a0fdc31f102e9333f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104323 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14Fix typoAndrea Gelmini
Change-Id: I6265c482cdc1468516d0e9eff704f2017effd411 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104315 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-10-14Related: tdf#137250 need signal-changed for ComboBoxText tooCaolán McNamara
e.g. changing font in format, character with up/down/typeahead Change-Id: I2aabae8ea4108830bb5a0ca89ad694fe88a7444d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104311 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14ImageTree::getImageStream may sub a req for a .png with svg dataCaolán McNamara
so we can't rely on the input path name as to its data format. its going to be either png or data, so select which based on the first byte, so presumably keeping the startup optimization of commit 9e5cbcf90f15f46f84900a58bcaee437b98587f6 Date: Wed Dec 18 15:35:19 2019 +0200 load images by explicit type Change-Id: I0b2b743c138075f651d376767984be88745327a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14add unittest for SkiaSalBitmap copy-on-write data sharingLuboš Luňák
Change-Id: I2e331785d49c55116bf9cb893be25da1067df8ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104283 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-14better fix for tdf#136455 without destroying widgets we don't truly ownCaolán McNamara
Change-Id: I9c3148fc6dd8658e1ff4a91ff83888288806f9e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104256 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-14-Werror,-Wshadow (clang-cl)Stephan Bergmann
Change-Id: I3f76ca202c38b42f55d669a0160fa8203b136031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-14pdfium: add an FPDFImageObj_GetImageMetadata() wrapperMiklos Vajna
And in general use more pdfium wrappers in CppunitTest_vcl_pdfexport, so all the '#if defined OSL_BIGENDIAN' checks can be removed. Change-Id: Id05e6ecf3dbb103a263d6068085eede847be320f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-14loplugin:unreffun (clang-cl)Stephan Bergmann
Change-Id: I9e478c71662aa5a5347d11adae0435e737fced82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-13uilogger : Add support in the Logger and DSL for Vertical TabAhmed ElShreif
For example the DSL syntax will be: >> Choose Tab number 2 in 'tab_id' from parent_id We don't need DSL change as it will already handled by normal Tab grammar Change-Id: I51f294134be88c4ac88baf73c53d81187a023061 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101516 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-10-13VclScrolledWindow vertical scrollbar one pixel too far to the leftCaolán McNamara
Change-Id: I6d9afb87b8d99e3c622b9d69fbfa88528adadb81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104228 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-13with a DND_ACTION_NONE drag action and zero target-formats disable dragCaolán McNamara
so we can support dynamically disable/enable dnd Change-Id: Icfec79c332ef073e04be5a57747e849b27098732 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104221 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12don't disable the fast path in DrawDeviceAlphaBitmap() (tdf#137311)Luboš Luňák
Only OpenGL and Skia implement the BlendBitmap*() calls, and so I disabled the direct path in an attempt to avoid forcing the mirroring if it takes place. But there's also the DrawAlphaBitmap() call that is implemented for other backends. So always do the mirroring already there if it takes place. Change-Id: I8c4c96ea18ac55ebad041e0d28c4228542d9b2e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104206 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12similar to tdf#120764 dismiss tooltips on showing popup menuCaolán McNamara
Change-Id: I4a3dd3d30fcab84bf9987f71a9c9cf0657ecfbb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104210 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-12try to read JPEGs as BGR if wanted and availableLuboš Luňák
BGR(A) is actually the format used by most VCL backends (Cairo and Skia at least). Change-Id: I1574aadabafcea274049d4c7021352913813bae2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104130 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12implement ImplFastBitmapConversion() for 8bit gray sourceLuboš Luňák
With some documents SvpSalGraphics::drawTransformedBitmap() ends up calling StretchAndConvert() with 8bit grayscale source bitmap (e.g. OutputDevice::DrawTransformBitmapExDirect() uses them as dummy alpha masks). But ImplFastBitmapConversion() doesn't handle this case, so StretchAndConvert() falls back to doing it manually, easily making this 3x slower. But 8bit grayscale bitmaps sort of are actually non-paletted, so this is easy to optimize. Change-Id: I93aa3f283c8a182d76f3aa267ebd471e63d945e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104129 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12the alpha used by our 32bpp formats is true alpha, not transparencyLuboš Luňák
Apparently this code path has never been tested. Change-Id: I112543ad4f403bb50e5789ceacf57e0c009a9ef7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104128 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12implement fast bitmap variant for CopyScanline()Luboš Luňák
JPEG reads RGB, but e.g. with Skia the default bitmap format is BGRA. Change-Id: Iad1a9e99f286b03db0fa683c14d70b8ad48d3d9d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104120 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-12Allow invalidate after queue_resize for lok in sidebarSzymon Kłos
This is a fix for regression introduced by 61a35560cb412d7ab0e3d0574eec4a790e3b9dfd Sidebar wasn't properly refreshed in Online eg. in Impress change 'Background' in sidebar 'Slide' deck to 'Color' -> resulted in overlapping content Change-Id: Id64f5d8694908d28cf5fa9787b65e555fb317e35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103724 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104012 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2020-10-11Revert "Permit scrollable AWT tab pages a la scrolled Dialog"Caolán McNamara
UITest_sort failing https://gerrit.libreoffice.org/c/core/+/103942 Jenkins Verified-1 Patch Set 7: Verified-1 where UITest_sort failed Jenkins Verified+1 Patch Set 7: Verified+1 but that's just an android build which doesn't run any tests This reverts commit b3f2530aa2767ba43cd4702422fc3ed0d37821d6. Change-Id: I9414e5d7cc5873848f95dab65f03836ccb2ff0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104194 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-11Permit scrollable AWT tab pages a la scrolled DialogThorsten Behrens
UNO dialogs since LibreOffice 4.0 permitted setting HScroll / VScroll properties to enable scrolling for too large a content. Conceptually clone this code over to TabPage as well, and register necessary UNO properties in the toolkit UNO wrappers. Add missing API documentation also to UnoControlDialogModel, plus the new properties to the UnoControlTabPageModel Change-Id: Iff90f60d0152ca21e4fe61c31315b9e1feab0dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103942 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: Ib604edbb62b5d6e7caa5aa444ee6d64611b9cf60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104110 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-09ofz: Invalid-enum-valueCaolán McNamara
Change-Id: Ic1408ba7cf776dbf4923b8c9cef50bbd7fe94bdd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104108 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-0932bpp SKIA_USE_BITMAP32 bitmaps always need kPremul_SkAlphaTypeLuboš Luňák
I'm not sure if kOpaque_SkAlphaType would guarantee 255 in the alpha, so better be safe. This should be a rare case anyway. Change-Id: Iadec97a83621403a56f62ac07e238d8e98a3a905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104090 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-09vcl: PDFiumLibrary: add PDFiumDocument::getFileVersion()Miklos Vajna
Allows not exposing the underlying FPDF_DOCUMENT in PDFiumDocument. Change-Id: Icff455af406405aff9099e950c26ce824517b57a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104097 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-08track dirty areas for Skia drawingLuboš Luňák
Updates to the screen in raster mode aren't _that_ slow, in fact it seems using SkRegion can make things slower because of manipulating the region, but with SkIRect this could sometimes help a bit. It also appears that StretchDIBits() that is used by the Windows raster code doesn't work correctly if only a subset of the y-axis range is specified, which reduces the usefulness. Change-Id: Ia93d2b60f2c62461e4c2c81210ab1d5d652a2cfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104047 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-07Resolves tdf#117463 - Dialog to show UI optionsHeiko Tietze
* New dialog to pick and apply one of the UI variants * Tip-of-the-Day enhanced to execute UNO commands in order to advertise the UI chooser on first start Change-Id: I5e5c4a8e0fb11d11bafc99cc37b7ec244a993781 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99957 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-10-07raise min version of gtk to 3.20.0Caolán McNamara
Change-Id: I7e463f48dabbcc27b0d5533fa2c46610cbd7aa82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07support pan-down-symbolic/pan-up-symbolic as SPIN_DOWN/SPIN_UPCaolán McNamara
Change-Id: I37bb7474207a084cfce7a3c2a6d9ec507b963aba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104044 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-07try more to match Skia's alpha type for source and destinationLuboš Luňák
This is an extension of the other recent commit, matching alpha type is faster, and knowing the content is opaque should also allow more optimizations. Change-Id: I632d3f50e3f4729a64403c3c3ed1b79d63f0c5dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104046 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-07faster Skia from-image conversions if no alpha is involvedLuboš Luňák
Skia's drawImage() is faster if alpha types match. So if the source is opaque, use that and not unpremultiplied alpha (which is technically the same if no alpha is involved, but it leads to a slower path). Change-Id: Ie55eaa55099a9a4c9e6db1e66e212da0acef71f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104043 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-10-07CppunitTest_vcl_pdfexport: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
This suite is large enough so that avoiding the declaration/registration/definition of each test manually saves a lot of space. Change-Id: I0fd161f54312370cc1ce13f4111ce1724dc22c4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104041 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-10-07ui files: fix some capitalisation issuesNoel
Change-Id: Id2efb6e5f1c115cb31a6afd3f988fe156c5ad56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06Online: Copy hyperlink location. / Core side.gokaysatir
Payload format is added to LOK_CALLBACK_CLIPBOARD_CHANGED. Clipboard changed event is not fired when "copy hyperlink location" command is issued. So i added a call to LOK_CALLBACK_CLIPBOARD_CHANGED inside TextDataObject::CopyStringTo function. Change-Id: I8157572288da88b5522662e13abe151ef8548b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103164 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103872 Tested-by: Jenkins
2020-10-06move set_user_managed_scrolling to an initial weld argumentCaolán McNamara
gtk is creating a11y objects on widgets changing parents so manage when that can happen to avoid premature creation of custom widget a11y objects Change-Id: I4879a93a897b2e4084cf6af0c9c0b0f0c1062254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104025 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-06loplugin:const& make some params and methods constNoel
Change-Id: I2973128a9c6c53187e1da400d1a5df763d515596 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104020 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-06add missing null pointer checkLuboš Luňák
It's possible to trigger this case, and the windows variant already has the check. Change-Id: I465fbccb8910bd1b529a2639f34249c18289baa8
generated by cgit (git 2.34.1) at 2024-08-08 13:28:21 +0000