summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-03-01fdo#74064 The filename gets properly highlighted in the Save As dialog.Rachit Gupta
The filename was missing the extension which was causing problems. The extension is retained now by disabling the autoextension checkbox. Change-Id: If913124c22265da2bacb043d83386fd8f5710ca8 Reviewed-on: https://gerrit.libreoffice.org/8364 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28[bug 75240] - removed unnecessary white spacesMihai Varga
Change-Id: I369ec4b2535b83673341ce389064d5a9c2050a48 Reviewed-on: https://gerrit.libreoffice.org/8388 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28Rename GetGraphics to AcquireGraphicsChris Sherlock
Currently there are a number of classes that have a function called GetGraphics(). It returns a SalGraphics instance if one is available for the sole use of the caller. Some variants keep a pool of available SalGraphics and return one not currently in use by anyone, creating extra ones on demand, sometimes up to a set limit and returning NULL on reaching that limit of simultaneously in use SalGraphics. This is confusing. What is really happening from the perspective of the calling is that is that we are attempting to *acquire* ownership of a SalGraphics instance. Therefore, rename GetGraphics to AcquireGraphics() which returns a handle to a SalGraphics if we can acquire a free graphics instance, and NULL if we cannot, which makes it cleared that ReleaseGraphics should be called on the result of AcquireGraphics. The classes that were changed to include the new acquire function are: * SalFrame * SalVirtualDevice * SalInfoPrinter * PspSalInfoPrinter * X11SalFrame * X11SalVirtualDevice * GtkSalFrame * KDESalFrame * TDESalFrame * WinSalFrame * WinSalInfoPrinter * WinSalVirtualDevice * SvpSalFrame * SvpSalVirtualDevice * AquaSalFrame * AquaSalInfoPrinter * AquaSalVirtualDevice Change-Id: Ic39c08a4bcaf665ae08ba2808cd03b0e80790c46 Reviewed-on: https://gerrit.libreoffice.org/8070 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28Resolves: rhbz#1007697 Update on a Window triggering delete on windowCaolán McNamara
Change-Id: Ic6374ce45e3a3ba97217ae77e91f9143f46e277b Reviewed-on: https://gerrit.libreoffice.org/8396 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28Add SAL_OVERRIDETor Lillqvist
Change-Id: I3b85e2524ce5d8c643daa593e179c22c4c49608f
2014-02-28Add SAL_OVERRIDE markup for the vcl OS X and iOS code, and follow-up cleanupTor Lillqvist
Thanks to SAL_OVERRIDE, I found a couple of unused functions and several that were virtual even if they did not override anything and were not overridden in any derived class. Change-Id: I5981111d2fc38f75a384c52359546a973e772393
2014-02-28Unvirtualize a couple of functionsTor Lillqvist
Change-Id: I1df9d7d1f0186a6983e54906c2d1b1684663826d
2014-02-28sal_Bool/bool falloutTor Lillqvist
Change-Id: Id31598b9c6485ecddcbbc3b2f216f67daca9a795
2014-02-28bool clean-up fixupStephan Bergmann
Change-Id: I0a302d7f91ef07992f95a8ccd48efec862519ab1
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
Change-Id: I3431d256bde60a2b3fa8de9a0ef43d1a0f1dc3df
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
Change-Id: I8094180c898c89351caa4805e395c3f3f2b0a946
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
Hack to avoid false positive from loplugin. Change-Id: I2b25f06299e40ea0cb155a6b748f38e1cb1ffc0d
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'long'Tor Lillqvist
Change-Id: If0d7ca02e8ecbc15eabc7807a71554ce11d92552
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
Change-Id: Ifaeeb0f01dbcd0225ee50c15d0b2417f99b1bd0e
2014-02-28WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist
Change-Id: I826f7649a1e9ed8aad06848aa1f2ed5a5827f3ab
2014-02-28WaE: implicit conversion of literal of type 'sal_Bool' to 'bool'Tor Lillqvist
Change-Id: I70eb7c04d12fad8f46f549bf5d43e1d1ffb724a1
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'long'Tor Lillqvist
Change-Id: I065858bdacf88f87eabe6cec516f6357acc11152
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'sal_uInt16'Tor Lillqvist
Change-Id: If6c41795a4015eb6bdd6bf785dd5ea6f7069e76b
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
Change-Id: I75d079a34355454a6e6b741f029c5ec37c149b17
2014-02-28More EndDialog() cleanupTor Lillqvist
Change-Id: I2e79190936d1eb7f55b521d2ce558fba45bf5f28
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
The bIncludeUntil parameter is used as a bool, so make it a bool. It is passed bool values anyway. Change-Id: If477419e8d94af69ad2bd5b452819e83a5a8149f
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'sal_uLong'Tor Lillqvist
Change-Id: I5089279745c4247ec0006f2273f6ec3d40d7c2a2
2014-02-28WaE: implicit conversion from bool to 'boolean' (aka 'int')Tor Lillqvist
'boolean' is from the JPEG library, typedeffed as int, yay. Change-Id: I6d35c3616e50127f1e00b47c25cf962fdc92c3db
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'int'Tor Lillqvist
These two functions should surely be of type bool.
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'long'Tor Lillqvist
Use the proper RET_OK amd RET_CANCEL parameters to EndDialog(). Change-Id: I2500e5e9793ee98c8cf38fc094d9f984576b67db
2014-02-28WaE: implicit conversion (IntegralCast) from bool to 'long'Tor Lillqvist
Presumably RET_OK is what is meant here (that is how the code has worked, anyway, as RET_OK == 1 == sal_True). Change-Id: Ib6afffc606c6bc36b5ef4cf04991207c8c109973
2014-02-28sal_Bool -> bool in mostly vcl moduleChris Sherlock
Conflicts: include/vcl/settings.hxx svtools/source/table/tablecontrol_impl.cxx sw/source/core/frmedt/fecopy.cxx vcl/inc/canvasbitmap.hxx vcl/inc/headless/svpframe.hxx vcl/inc/unx/salframe.h vcl/inc/win/salframe.h vcl/inc/win/salprn.h vcl/inc/win/salvd.h vcl/osx/DragSource.cxx vcl/osx/DragSource.hxx vcl/osx/DropTarget.cxx vcl/osx/DropTarget.hxx vcl/osx/OSXTransferable.cxx vcl/osx/OSXTransferable.hxx vcl/osx/clipboard.cxx vcl/osx/clipboard.hxx vcl/osx/salprn.cxx vcl/qa/cppunit/canvasbitmaptest.cxx vcl/source/components/fontident.cxx vcl/source/control/edit.cxx vcl/source/control/spinfld.cxx vcl/source/gdi/gdimtf.cxx vcl/source/gdi/virdev.cxx vcl/source/helper/canvasbitmap.cxx vcl/source/window/dockwin.cxx vcl/unx/generic/dtrans/X11_selection.hxx vcl/unx/kde/UnxFilePicker.cxx vcl/unx/kde/UnxFilePicker.hxx vcl/unx/kde4/KDE4FilePicker.cxx vcl/unx/kde4/KDE4FilePicker.hxx vcl/unx/kde4/KDESalFrame.hxx Change-Id: I9866d985da86dea2a56feff23f91c1467a1636b0 Reviewed-on: https://gerrit.libreoffice.org/8219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-28constructor only used on WNT in FontSelectPatternAttributesNoel Grandin
Change-Id: Iffbd9702f5a81e4bfe3baa3952824f4c6ba3bca3
2014-02-28remove unused code in vcl/ImplRegionBandNoel Grandin
ImplRegionBand::IsInside(long, long) ImplRegionBand::IsOver(long, long) Change-Id: I607c589d62a0c9178a32df5cf48fcbe279878030
2014-02-28fix name of method in vcl/Menu, SetHightlightItem to SetHighlightItemNoel Grandin
Change-Id: I89a61aeffeebc69e06da6c1130436fb25528f1c7
2014-02-28remove unused code Menu::GetHighlightItem()Noel Grandin
Change-Id: I9b538bacbb98705b0345c3f6dc38fb554ce25bcf
2014-02-28debug only code SalDisplay::PrintInfo()Noel Grandin
Change-Id: I9ead37ff69dc7198faae6758a346111ed1d029e3
2014-02-27images: Skip comments in links.txt.Jan Holesovsky
Change-Id: I446dec8447fb9b0b4fa37bf6343e130539211b50
2014-02-27Resolves: #i15508# Added support for BMP file typeArmin Le Grand
(cherry picked from commit 9956ed1303545cd61901e33b110698c4e5e224c4) Conflicts: filter/source/msfilter/escherex.cxx include/vcl/gfxlink.hxx svx/source/xml/xmlgrhlp.cxx sw/source/ui/docvw/romenu.cxx vcl/source/filter/graphicfilter.cxx Change-Id: Ibcbb69b9c57cd8a438788e9a9c95744e99b6fcdd
2014-02-27normalize values of USE_XINERAMAMichael Stahl
Change-Id: Iac70c0872b723f57a63b0df3759c3c6d38271eea
2014-02-27-Werror,-Wunused-variableStephan Bergmann
Change-Id: Ib207ea292a2ea389005510bad0ae931df91424f0
2014-02-27badCaolán McNamara
Change-Id: Ife660e5738d862e28260abe412817fb06272f4e8
2014-02-27coverity#1187685 Dereference null return valueCaolán McNamara
Change-Id: I7f34eae7eedfa067f0f8a360aa6ae8dc5b0381bd
2014-02-27coverity#1187675 Dereference null return valueCaolán McNamara
Change-Id: I313772d7382c303990f7333990e340803678be79
2014-02-27coverity#1187674 Dereference null return valueCaolán McNamara
Change-Id: I4fdf0e324463285d086c1503214e2aee0c0537e8
2014-02-27coverity#1187660 Dereference after null checkCaolán McNamara
Change-Id: I41a05e34c9b1dd312602f2c499793a4568473394
2014-02-27coverity#1187659 Dereference after null checkCaolán McNamara
Change-Id: I31b1a55a72be7fac80cd7bbac52b723d7e33a13a
2014-02-27coverity#1187658 Dereference after null checkCaolán McNamara
Change-Id: I4924903f1763c6afc975efb45e43223ee3829951
2014-02-27coverity#1187640 this code has no effectCaolán McNamara
Change-Id: I526e636fe80001f4cd5c94f0ba1df27134895d83
2014-02-27GetContextMenuDown is always trueCaolán McNamara
Change-Id: Ib2ce1dd91cc7bfaf38feca7b056874a2508869e6
2014-02-27callcatcher: update unused codeCaolán McNamara
Change-Id: I560471a3c2ac9d8ccf759fca1d8c30ae00d73484
2014-02-27Removed unnecessary comment decorations and wspace from VCL sourcesChris Sherlock
Change-Id: I190b57bb476a35ede1b6050f3c1edabd0ab00397 Reviewed-on: https://gerrit.libreoffice.org/8374 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-02-26cppuhelper: retrofit std::exception into overriding exception specsStephan Bergmann
Change-Id: I56e32131b7991ee9948ce46765632eb823d463b3
2014-02-26sal_Bool -> bool fixupStephan Bergmann
Change-Id: I1104fc57f9f82944d258208f70993da1b00f1843
2014-02-26Removed unnecessary comment decorations from VCL sourcesChris Sherlock
Conflicts: vcl/headless/svpgdi.cxx vcl/source/app/dbggui.cxx vcl/source/app/help.cxx vcl/source/app/idlemgr.cxx vcl/source/app/settings.cxx vcl/source/app/stdtext.cxx vcl/source/app/svdata.cxx vcl/source/app/svmain.cxx vcl/source/control/fixed.cxx vcl/source/control/ilstbox.cxx vcl/source/control/spinbtn.cxx vcl/source/filter/sgfbram.cxx vcl/source/filter/sgvmain.cxx vcl/source/filter/sgvtext.cxx vcl/source/filter/wmf/emfwr.hxx vcl/source/filter/wmf/winmtf.hxx vcl/source/filter/wmf/wmfwr.hxx vcl/source/fontsubset/cff.cxx vcl/source/fontsubset/fontsubset.cxx vcl/source/fontsubset/xlat.cxx Change-Id: Ifc4fa21e552a8b031645eb883bdc23563eebb602 Reviewed-on: https://gerrit.libreoffice.org/8357 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-15 09:20:20 +0000