summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-04-08IsInPopupMode returns true when !mbInPopupModeCaolán McNamara
it returns mbPopupMode which is set to false on the next event cycle after the one where mbIsInPopupMode is set to false Change-Id: I66b0812cb9b9fc5cfe00c88f145f704bd1ecce2f Reviewed-on: https://gerrit.libreoffice.org/70413 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-08pdf: always write resource dict for content streamsThorsten Behrens
Take out: - revert i#42884 workaround for AR5: use implicit resources in transparency groups Since verapdf complains with FAIL 6.2.2-2 in this case - missing resource dict for content stream. Change-Id: Ic186d2b4b393ac34f991a6747667332cf8f4658b Reviewed-on: https://gerrit.libreoffice.org/70391 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-04-08tdf#124567 Print dialog: distance & margin mixed upRasmus Jonsson
Change places of distance and margin input boxes (note: ids were set correctly, they were merely labelled incorrectly). Also moved the object in the .ui file to make it easier to read. Change-Id: I180d7afdf9dfb483f5dbfcf7ba68c73900499807 Reviewed-on: https://gerrit.libreoffice.org/70303 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-08improve combining in hash functionsNoel Grandin
specifically, use boost::hash_combine to combine values in hash functions, except for a couple of places where I use the small-prime-number strategy popular in the Java world, to avoid including boost in header files that are widely shared. Change-Id: I0e184c9ec8803bf09fc6e84fe20131b203e1652a Reviewed-on: https://gerrit.libreoffice.org/70384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-07Don't use resettable/clearable guard where plain guard is enoughMike Kaganski
Also use scope where possible. This allows to limit guard scope at language level; visualises the scope clearly; and helps avoiding errors like fixed in commit 61e4437c857854b331fa01da6f39b2b3b58a800b. Change-Id: Ifeca96e2df8e8a0897770d9546b2536806275f41 Reviewed-on: https://gerrit.libreoffice.org/70376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06weld OTableSubscriptionDialogCaolán McNamara
Change-Id: Idf66a9e49471d6651c03deecc4fb2f9a722f512c Reviewed-on: https://gerrit.libreoffice.org/70325 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06tdf#124579: ensure to provide an event to wake up main loop when notifyingMike Kaganski
Without that, Request::waitProcessMessages might wait indefinitely for Application::Yield() to return; while the latter would wait for a message in GetMessage. If there's no visible LO window, the message might never arrive by itself. Co-authored-by: Jan-Marek Glogowski <glogow@fbihome.de> Change-Id: Ie2622053a8d4467eb1cbd579d8496cb5ddef08aa Reviewed-on: https://gerrit.libreoffice.org/70346 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-06weld OTableSubscriptionPageCaolán McNamara
Change-Id: I55c23448480384c9a7d78cd55550bb4812ebde72 Reviewed-on: https://gerrit.libreoffice.org/70314 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06crashtesting, threading crash with bitmapinfoaccess_null_ptr_deref.sampleCaolán McNamara
on export to .ods Thread 1: 5 0x00007f758fde4969 in raise () from /lib64/libc.so.6 6 0x00007f758fde5f98 in abort () from /lib64/libc.so.6 7 0x00007f758f485afd in __gnu_debug::_Error_formatter::_M_error ( this=0x7f7588872860 <__gnu_debug::_Error_formatter::_M_at(char const*, unsigned int)::__formatter>) at ../../../.././libstdc++-v3/src/c++11/debug.cc:1069 8 0x00007f7587b42922 in __gnu_debug::_Safe_iterator<std::__detail::_Node_iterator<ImpGraphic*, true, false>, std::__debug::unordered_set<ImpGraphic*, std::hash<ImpGraphic*>, std::equal_to<ImpGraphic*>, std::allocator<ImpGraphic*> > >::operator++ ( this=0x7f755a58e440) at /srv/crashtestdata/gccbuild/gcc8/include/c++/8.2.0/debug/safe_iterator.h:295 9 0x00007f7587b415d5 in vcl::graphic::Manager::registerGraphic (this=0x5fe9860, pImpGraphic=std::shared_ptr<ImpGraphic> (use count 1, weak count 0) = {...}) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:123 10 0x00007f7587b418e2 in vcl::graphic::Manager::newInstance (this=0x5fe9860) at /home/buildslave/source/libo-core/vcl/source/graphic/Manager.cxx:156 11 0x00007f758798c406 in Graphic::Graphic (this=0x7f755a58e6d0) at /home/buildslave/source/libo-core/vcl/source/gdi/graph.cxx:187 12 0x00007f758799c85a in ImpGraphic::loadPrepared (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1540 13 0x00007f758799c999 in ImpGraphic::ImplSwapIn (this=0x80d2500) at /home/buildslave/source/libo-core/vcl/source/gdi/impgraph.cxx:1561 14 0x00007f758799c813 in ImpGraphic::ensureAvailable (this=0x80d2500) and a bunch of other threads looking like they've just come from the same family of methods Change-Id: Ic13d3c7cb2fb4adaa2a0a6b8845fc2156d53005e Reviewed-on: https://gerrit.libreoffice.org/70271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-06tdf#119931 Fix accessibility warnings in printerpaperpage.uiRasmus Jonsson
Change-Id: If92bf6ac4c466524da2eab33440bf765b3d5d6f6 Reviewed-on: https://gerrit.libreoffice.org/70335 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-05Replace legacy dynamically-loaded functions with statically linked onesMike Kaganski
We don't need the dynamic load complexity for these now with baseline Windows version being Windows 7 SP1. Stuff used only for compatibility with older versions was dumped. Change-Id: I810f271796cfd875cfa18a3081c9ad444fe57b3e Reviewed-on: https://gerrit.libreoffice.org/70321 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-05fix spinbox right press SVG - plus sign didn't define a colorTomaž Vajngerl
Change-Id: I1db6c5e4841530be7d46e8829899bf3f8cef8a3b Reviewed-on: https://gerrit.libreoffice.org/70293 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-05support opacity for widget definition draw SVGsTomaž Vajngerl
This opacity influences the whole shape (stroke and fill). Change-Id: I82e10e07dbf2f321805b55a5f4831a513e52dab8 Reviewed-on: https://gerrit.libreoffice.org/70292 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04Revert "raise cairo baseline to 1.12.0"Caolán McNamara
This reverts commit 50580f452cc7c88a231831619a3f05958ce56460. Revert "raise cairo baseline to 1.10.0" This reverts commit 58a0e60dee0d27a699f856827c20b792417d3478. 32bit baseline is currently at cairo 1.8.8 Change-Id: I5156df6aee03dbbb2e209dbd5717a98580256170 Reviewed-on: https://gerrit.libreoffice.org/70260 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04ios widget defs: update combobox, checkbox, spinbox SVGsTomaž Vajngerl
In addition remove spinbox pressed state (it wasn't useful) and draw white filled empty rect for spinbox as we don't draw the background automatically. Change-Id: I892108c5839dc463cdb9e4f4f09276fc184f4944 Reviewed-on: https://gerrit.libreoffice.org/70258 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04change GetColorCount to use sal_Int64Tomaž Vajngerl
Hopefully fixes problems on 32-bit linux. Change-Id: I1fc22f1bb37c8297bd3bd6828206d1ffa9ae722d Reviewed-on: https://gerrit.libreoffice.org/70241 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04Qt5 / KDE5 refactor create_SalInstanceJan-Marek Glogowski
Move most common code into Qt5Instance (static) functions. Not much saved with regard to LOC, but since the code was 95% C'n'P, I hope it'll be less error prone this way. Also handle all QApplication argument pointers via std::unique_ptr from the beginning. Change-Id: I87b2f571d398db7ccce3e740f16205b251be4ced Reviewed-on: https://gerrit.libreoffice.org/69578 Tested-by: Jenkins Reviewed-by: Aleksei Nikiforov <darktemplar@basealt.ru>
2019-04-04KDE5 merge KDE5SalData into Qt5DataJan-Marek Glogowski
Currently there is no point for a seperate KDE5 SalData class. The additional NWF settings fix the wrong popup menu for qt5, so this just moves all the NWF data and gets rid of KDE5SalData. Change-Id: I1c02d1f660df288a0d2e1c6607b34fc1ce593727 Reviewed-on: https://gerrit.libreoffice.org/70005 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-04-04raise cairo baseline to 1.12.0Caolán McNamara
Change-Id: I1816f23fea88e6b840539a88504956b00a546522 Reviewed-on: https://gerrit.libreoffice.org/70243 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04raise cairo baseline to 1.10.0Caolán McNamara
Change-Id: I721b80d7ce28d36babbd2bd1957fcbd6a2d27a27 Reviewed-on: https://gerrit.libreoffice.org/70242 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04Resolves: tdf#124219 check at runtime for availability of cairo functionsCaolán McNamara
Change-Id: I0ab3055760d8be690bdfff560212db368a0fa261 Reviewed-on: https://gerrit.libreoffice.org/70240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04weld ClassificationDialogCaolán McNamara
with the extra problem of hosting an EditView/EditEngine within a weld::DrawingArea Change-Id: Id48a57ed0dfd2d92217209c43f752edd9cf8e1bd Reviewed-on: https://gerrit.libreoffice.org/70219 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04split cursor drawing into Window/OutputDevice partsCaolán McNamara
Change-Id: I6027abd3c385f838dc02cc85fda0eef212d2541f Reviewed-on: https://gerrit.libreoffice.org/70218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04allow SelMouseButton[Down|Up] without pWinCaolán McNamara
Change-Id: If5031390ac4a0cdd3dad3b43b23f4319c2dfc53a Reviewed-on: https://gerrit.libreoffice.org/70217 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04add nullchecking SelectionEngine::CaptureMouseCaolán McNamara
Change-Id: Ie8594c8fe2a9e2d84121f3a6a1ee8afab265b14f Reviewed-on: https://gerrit.libreoffice.org/70216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04SelectionEngine::ReleaseMouse checks for null pWinCaolán McNamara
Change-Id: I80e6a304d07fcc290e73e6251f520926398a7ecb Reviewed-on: https://gerrit.libreoffice.org/70215 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04aRect is always in pixelsCaolán McNamara
Change-Id: Ib122a2f970a7852e2979a5301f635f9f1a4ce87b Reviewed-on: https://gerrit.libreoffice.org/70214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-04ios theme definition: add slider disabled stateTomaž Vajngerl
Change-Id: Ie4388f00c4a0c11df77782691fe9ea7f706d2b5c Reviewed-on: https://gerrit.libreoffice.org/70231 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-04tdf#124155 fix slider to not go beyond rect boundsTomaž Vajngerl
We need to ask the NWF for the size of the thumb and not just use the hard-coded value. Change-Id: I98c6b5782c6a043fc358198ddf844d36d7aa90d6 Reviewed-on: https://gerrit.libreoffice.org/70201 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03various cleanups - no behavior changeTomaž Vajngerl
Change-Id: I28749d31ba272f26df9b79201cb106911692f6f7 Reviewed-on: https://gerrit.libreoffice.org/70199 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03tdf#114316 vcl opengl windows: fix missing context menu in full-screen modeMiklos Vajna
Full-screen mode on Windows used to work by measuring the space needed by window caption (title) and borders, then positioning and sizing the window in a way, so that the caption and borders are not visible. This approach breaks at least in the OpenGL case where a large enough negative position results in rendering errors. Fix the problem by explicitly requesting the window to have no caption, so we render less outside the screen (30 pixels -> 8 pixels in my case), which makes the "exit fullscreen" toolbar appear, also the context menu is visible. Change-Id: I6cf2b9774b505d3887b958a6a018b5ae84bbe4bc Reviewed-on: https://gerrit.libreoffice.org/70191 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-04-03Support for native 32bit Bitmap in VCL and SVP (cairo) backendTomaž Vajngerl
This adds basic support for 32bit bitmaps for the SVP backend. For other backends the support is disabled for now as we need to add it for each backend separately and enable support. When this patch is applied it is possible to a Bitmap with bit count 32, but currently no input filter uses this with the exception of the new PngImageReader(libpng based), which is used only for the icons. For a general support more things need to be implemented and tested: - conversion back and fourth between 32-bit and 24-bit + 8bit alpha (or other supported pairs) - 'raw' export of the bitmap needs to be handeled properly (like in SVM import/export) so it creates the correct image. - input filters need to be checked and converted if this is necessary - look for possible bugs when drawing transparent bitmaps - check of UNO API Change-Id: I7a7be0e6134dfdd9a7aeaef897131bb6e710ae7e Reviewed-on: https://gerrit.libreoffice.org/69289 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-03Related: tdf#124148 null-deref on clicking inside empty listboxCaolán McNamara
since... commit ce9dab8c161e29769131cec741a6a9cceec8552d Date: Thu Mar 28 17:43:29 2019 +0900 tdf#124148 add configurable margin for the listbox pop-up list Change-Id: Id0bedb86f4fb74aff230d65f1e4371959814fd0f Reviewed-on: https://gerrit.libreoffice.org/70151 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02weld XMLFilterSettingsDialogCaolán McNamara
Change-Id: Ia027fa0b5e99651988f2447bf29f6f5653dd0c48 Reviewed-on: https://gerrit.libreoffice.org/70139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02weld CrashReportDialogCaolán McNamara
Change-Id: Ifc4b606596db1469af03748da2d04659b8fa443a Reviewed-on: https://gerrit.libreoffice.org/70124 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-02only use GdkSeat where availableCaolán McNamara
Change-Id: I346ab7a7c88350eef289c58b8bce299bdd891fbb Reviewed-on: https://gerrit.libreoffice.org/70085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01drop unnecessary includesCaolán McNamara
Change-Id: I12c02a03202d778d9c2d7bf41022db64af492e04 Reviewed-on: https://gerrit.libreoffice.org/70075 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Resolves: tdf#123175 don't use NWF to draw buttons with an overridden bgCaolán McNamara
Change-Id: I434f476f62c5c754d96eeb0cb9ad7c0b8d38ccec Reviewed-on: https://gerrit.libreoffice.org/70069 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Resolves: tdf#124411 default dnd to MOVE for internal and COPY for externalCaolán McNamara
which what the macosx version appears to also do Change-Id: Icff9cada2c821544d0130e28cc3e3862154a57dc Reviewed-on: https://gerrit.libreoffice.org/70063 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01Resolves: tdf#124440 nospin has no subeditCaolán McNamara
Change-Id: I4e801ec234e86be935a79c9e29f0e5091904f12e Reviewed-on: https://gerrit.libreoffice.org/70052 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-01tdf#124413 Crash on undo / redo in Basic IDENoel Grandin
regression from commit 3a9d3f271c445641bebd057c4c91279f9b3cd7d5 Date: Mon Apr 23 09:38:41 2018 +0200 loplugin:useuniqueptr in TextDoc Change-Id: I51ab5de7571e4ec358442e54d590adf88fbeb12d Reviewed-on: https://gerrit.libreoffice.org/70061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-01tdf#120865: preserve cursor shape on repositioning the cursorKatarina Behrens
i.e. don't recreate cursor with new (default) arrow shape in SalFrame::SetPointerPos, but simply move the existing one Change-Id: I3406ceff25a53de6f2afa318114370c318e6a500 Reviewed-on: https://gerrit.libreoffice.org/70049 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-01Qt5 convert broken clippingJan-Marek Glogowski
localClipRegion was just set but never used, when KDE4 xlib blitting was replaced by Cairo / QPainter blitting. So this converts all the occurences to apply these clippings to the drawing QPainter instance. Change-Id: Ibfd60049ce604ac1415dc5c602ed5c952f972891 Reviewed-on: https://gerrit.libreoffice.org/70006 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-04-01tdf#124150 increase size of color valueset widgetTomaž Vajngerl
Size of the color value set can be set through settings, but there was no setter. Added a setter and set it to a bigger value so it is better suited for touch. Change-Id: I8c9b17f7379c4702b0faf7847f1e6292cd89b0d0 Reviewed-on: https://gerrit.libreoffice.org/70031 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-30tdf#122056: Catch DisposedExceptions everywhereKatarina Behrens
Change-Id: I6bdb9aa89a8a5181b096f47f90ab6fb5711e7447 Reviewed-on: https://gerrit.libreoffice.org/69541 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-30ios theme definition: file rename svgx -> svgTomaž Vajngerl
Change-Id: I9bebc4405185496b8243e6f7951a2a9f0b6559fb Reviewed-on: https://gerrit.libreoffice.org/69932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-30tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scalingJan-Marek Glogowski
LO does its own layouting and also all the scaling, so disable the automatic HiDPI scaling explicitly. Otherwise fonts will be rendered in LoDPI and just scaled as an image, if UI scaling is enabled in KDE, resulting in really blocky / ugly fonts. Change-Id: I38503ce27c1671e80d0749d21c6c6dcff1a808a6 Reviewed-on: https://gerrit.libreoffice.org/69941 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-29prefer help strings to a11y strings when availableCaolán McNamara
Change-Id: I50b36f697b8dd9ff8108392d48a7050702edbfbe Reviewed-on: https://gerrit.libreoffice.org/69934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29fix testConvert for OpenGLTomaž Vajngerl
Change-Id: Id78ef9fd05bc158b52aa465c932869c0ef1c55d7 Reviewed-on: https://gerrit.libreoffice.org/69921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-02-21 09:11:00 +0000