summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2014-11-03vcl: Allow SalGraphics to draw gradients nativelyChris Sherlock
The aim of this patch is to allow for native gradient rendering in SalGraphics (i.e. let OpenGL do this natively). It is a two step process: 1. I need to allow gradient draw into SalGraphics, however the current completely intertwined with the metafile code in OutputDevice. I am seperating the gradient metafile code from the gradient drawing code. 2. After splitting the metafile stuff from the actual gradient drawing, I am now able to call on SalGraphics::DrawGradient(). This just calls on SalGraphics::drawGradient() which returns false if there is no way of drawing native gradients, and true if there is. If false, then we use OutputDevice's DrawGradient() functionality. Change-Id: Ibaaabe13b76a8e7a037d9f751b5f662653a50566 Reviewed-on: https://gerrit.libreoffice.org/12119 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-03coverity#1242811 untrusted pointer readDavid Tardon
Change-Id: I74c29a39367e7781e5e6cf9795c7176ef599f97e
2014-11-03coverity#1242806 untrusted pointer readDavid Tardon
Change-Id: Ib92e1a22d7d25f4498272731af12c485937f38ef
2014-11-03coverity#1209010 Unchecked return valueCaolán McNamara
Change-Id: I92c2472a34aca9f7f1a617666607040cadb0b643
2014-11-03coverity#1250699 Dereference null return valueCaolán McNamara
Change-Id: Iaddc47087d796d96fa0ed054c254b3cf83c90b5e
2014-11-03be a little more consistent stylewiseCaolán McNamara
Change-Id: If1d822e0e6c87e792ff4a769a525e161505325c9
2014-11-03coverity#1209395 Dereference after null checkCaolán McNamara
since commit 808d273db098e2269e53813595a6bfc7b160e28e Date: Fri Apr 25 11:56:54 2014 +1000 Remove ImpInitOutDevData and ImplDeInitOutDevData in OutputDevice All these do is some very, very basic initialization. There is no need to lazy load the structure, it should be initialized when OutputDevice is created in the constructor and deinitialized in the destructor. mpOutDevData is never NULL Change-Id: Ie08f7520e8c09b57e056c086bba3089abe2486fa
2014-11-03fdo#84795 Menu, DropDown-List don't disappear with right mouse clickJuergen Funk
this includes a fix to leave disabled menu entries disabled. This reverts commit 454f5c3018c6d61d5872f7c23c7590c2157444e4. Change-Id: Ifb66b0b241378437f040af19ec163da3cb8d815d Reviewed-on: https://gerrit.libreoffice.org/12061 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-03Detect KDE5 and fallback to KDE4UI thereTomáš Chvátal
Change-Id: I8da53d7b81d28b0051be96c0c4ee0a29d8ed8360 Reviewed-on: https://gerrit.libreoffice.org/12209 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-11-03vcl: typo in variable name in PaintLineGeometryWithEvtlExpandChris Sherlock
Change-Id: I87084cbc4d6a8b6f5edbf8b90791c2b1e75b4afb Reviewed-on: https://gerrit.libreoffice.org/12211 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-03vcl: merge DrawPolyLineDirect() and drawPolyLineDirectNoAACheck()Chris Sherlock
I've merged these two functions, I just added a new function parameter to switch on and off the AA check, this function parameter defaults to false so DrawPolyLineDirect needs to do the AA check each time. If bBypassAACheck is set to true, then we automatically enable AA. Change-Id: Id2d9b2036a41716590f7b87f658f5bb210964392 Reviewed-on: https://gerrit.libreoffice.org/12191 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-02coverity#1242508: swapped argumentsThorsten Behrens
Change-Id: If86cc3cd9ea40dc826c93d6adb6e11fab20a15eb
2014-11-02vcl: Refactor OutputDevice::TryDrawPolyLineDirect()Chris Sherlock
I've renamed TryDrawPolyLineDirect() to DrawPolyLineDirect() and also renamed TryDrawPolyLineDirectNoAACheck() to drawPolyLineDirectNoAACheck(). However, at the same time I feel that there is no need to call on drawPolyLineDirectNoAACheck in most instances, because DrawPolyLineDirect does an AA check before it can continue anyway. There is one instance where constantly checking the AA check is inefficient because it's in a loop, in that case then we call directly on drawPolyLineDirectNoAACheck, but this is the only case it is necessary. Change-Id: Ie0320bfc45b5c0e1ac6ce35912da3e2897af9429 Reviewed-on: https://gerrit.libreoffice.org/12190 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-02vcl: rename OutputDevice::DrawPolyLineWithLineInfo() to drawPolyLine()Chris Sherlock
Change-Id: I145ebcfb92fc75f4558d3bf090093aef9e848136 Reviewed-on: https://gerrit.libreoffice.org/12188 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-01tools & vcl: move OutputDevice::ImplRotatePos() to Point::RotateAbout()Chris Sherlock
OutputDevice has a private function that rotates a point around another point. However, there is no real reason why OutputDevice should be responsible for this - it's really the responsibility of the Point class in the tools module. Therefore, I've moved this functionality out of OutputDevice and into Point, but I've renamed it from the rather confusing name "ImplRotatePos" to "RotateAround", which is what it actually does. Change-Id: If12fb40a7b476653224d4edfc01887bc91a80c7d Reviewed-on: https://gerrit.libreoffice.org/12171 Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Tested-by: Chris Sherlock <chris.sherlock79@gmail.com>
2014-11-01coverity#735654 Division or modulo by zeroCaolán McNamara
Change-Id: I9ab09d65ba7587230de320e22a79e9c7224f4ade
2014-11-01coverity#1250405 Division or modulo by float zeroCaolán McNamara
Change-Id: Ifbb7ab559d161fdc8b6838ea34a4519286423997
2014-11-01coverity#1250439 Structurally dead codeCaolán McNamara
Change-Id: Ib0e8fefb154417dde95bc70765ad675a1824db44
2014-11-01coverity#735338 Unchecked return valueCaolán McNamara
Change-Id: If19a61c82f1cf723c8e78e8d27461a543ddbfd40
2014-11-01fdo#84938: replace MIB_ constants with enumNoel Grandin
Change-Id: I58c1b4c9e4c4b3751b233d2fe10b9c953b945c4a Reviewed-on: https://gerrit.libreoffice.org/12179 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-11-01vcl/source: get rid of redundant svsys.h includesDouglas Mencken
+ adapted for WNT (it does really need it for app/settings.cxx) Change-Id: I33a65d24f7c6c46a36718e4421ae88de180a9739 Reviewed-on: https://gerrit.libreoffice.org/11814 Reviewed-by: Douglas Mencken <dougmencken@gmail.com> Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-31Removed duplicated includesAndrea Gelmini
Change-Id: I5362d997bfa086c9fb1726efcb15132a966684f6 Reviewed-on: https://gerrit.libreoffice.org/12160 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2014-10-31callcatcher: a titchy bit more ww1 filter falloutCaolán McNamara
Change-Id: I38517bb7fbf4ab1e9314a28973b707223d7120e7
2014-10-31coverity#1202803 Explicit null dereferencedCaolán McNamara
Change-Id: Ia914c4842e69b3ea57692f1f8ac52c321240b7c4
2014-10-31coverity#735346 Unchecked return valueCaolán McNamara
Change-Id: Ic9aab232667a9b0a3a995d7b033b7ba508fd42dc
2014-10-31quieten warningCaolán McNamara
Change-Id: I91bf3bce86d6b7fb01a26a6785d5bcfd7677878c
2014-10-31drop KeyCode::IsDefinedKeyCodeEqualNoel Grandin
because it's implementation is the same as operator== Change-Id: If9b63abcd13f899735d59d85be3da54406a6e324
2014-10-31convert COMMAND_WHEEL constants to an enumNoel Grandin
Change-Id: I413d821a984ab556bd19c52704c04de6d828f699
2014-10-31KEY_ALLMOD is the same as KEY_MODNoel Grandin
so just dump it Change-Id: I006045aea345e84ff1944fc1ed1daa94bd7bca61
2014-10-30address LTR issue with coretext renderingNorbert Thiebaud
There was a snaffu with the handling of DXArray concerning the special case of the 'first' character and how that translate when the glyph order is not the same than the character order Change-Id: Ie9273ff22fa2d22ca0df2b583768ffb2b2a59930
2014-10-30add SAL_INFO to CTRundataNorbert Thiebaud
Change-Id: I577f7582b4938dc5dcd75460dd889c5675ee3c17
2014-10-30Fixed typos. No automatic tools (sed, and so on).Andrea Gelmini
Change-Id: Ia43976d84eede6f699381bc4f3daf89b95e4cb4f Reviewed-on: https://gerrit.libreoffice.org/12150 Reviewed-by: Bryan Quigley <gquigs@gmail.com> Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2014-10-30coverity#704095 Unchecked return valueCaolán McNamara
Change-Id: I31bfb0b6cdcac78592759824cb74ab62d98fcc7b
2014-10-30document array_vs_singleton dismissalsCaolán McNamara
Change-Id: I8d7eb4c01197e885abca717c7814c61a7641ac9d
2014-10-30vcl button: Avoid a potential crash.Jan Holesovsky
Change-Id: I09d0777ef51045054b8e3bc88aba9fb025e6f9ff
2014-10-29Resolves fdo#85524: OSX Crash Impress with videoclipJulien Nabet
Change-Id: If222be9574af1078ffba15c07f048503dd8d7e8e
2014-10-29Resolves: rhbz#1146169 a11y frames label dies before frameCaolán McNamara
Change-Id: Ie5650c3a5593dcf68196802169c47270a0c3b0e6
2014-10-29need to initialize mnRefCntCaolán McNamara
all sorts of things crash, e.g. format->properties Change-Id: Ida4fb97dcdddd7adde4b98fa67b107a514eef615
2014-10-29remove unnecessary 'using namespace rtl' declarationsNoel Grandin
It turns out that almost none of them were necessary. Change-Id: I1311ed28409c682b57ea8d149bcbaf2c49133e83 Reviewed-on: https://gerrit.libreoffice.org/12133 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-29ref-counting vcl::Window subclassesNoel Grandin
Points of discussion -------------------- (*) where in the Window destructor should dispose() be called? It's a seriously large method. (*) we're going to need similar typedefs and declarations for every single sub-class of vcl::Window, I assume that I will need to create a macro to make it less verbose. TODO ---- Update clang plugin to verify that: (a) dispose() methods always call their superclass dispose() (b) dispose() methods don't forget to clear any references owned by that class. Change-Id: I873d5d5166f811e2f65e49327cc98862559fcf30
2014-10-28Fix -fsanitize=signed-integer-overflow (when long int is 32-bit)Stephan Bergmann
Change-Id: Ia6f1b60108784660c4a2dfd311592207e6bf5d88
2014-10-28coverity#982593 experiment with silencing Infinite loopCaolán McNamara
etc. Change-Id: I1548d60280ab4f74fe023d026435a05f7865b516
2014-10-28coverity#704090 Unchecked return valueCaolán McNamara
going to assume that this is correct Change-Id: I47072dc668f200eacf0f6a6d7ccdad0c9d6bfa68
2014-10-28coverity#704089 Unchecked return valueCaolán McNamara
rework code a little to help coverity out Change-Id: I4aa253a579153ad389d4667a9676fff04aa00a34
2014-10-28coverity#735350 silence Unchecked return value from libraryCaolán McNamara
Change-Id: I8b84466f8bb277c30df4340849b17506eddd4f21
2014-10-28fdo#84938: replace TIMEF_ constants with enumNoel Grandin
Change-Id: Ia6aa4e21fef46b20d1d8996d2f15855b8ba1776e Reviewed-on: https://gerrit.libreoffice.org/12114 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-27coverity#735348 silence Unchecked return value from libraryCaolán McNamara
Change-Id: I6da2fccb0c709f08dc4ed321d7b16683e939cac9
2014-10-27coverity#735342 silence Unchecked return value from libraryCaolán McNamara
Change-Id: Id440d30e44aaf986532d4c6debf3876578c53b29
2014-10-27cid#735557 Logically dead codeNoel Grandin
Change-Id: I0f6851a4ce5c02ea48110bdb8ed47cdb15853917
2014-10-27cid#705053 Dereference after null checkNoel Grandin
re-arrange the code to help coverity out Change-Id: Iddc9284cbdcbaae7a0dc17e62d0e8f4b4832297c
generated by cgit (git 2.34.1) at 2025-01-08 03:48:41 +0000