summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2015-11-12WaE: loplugin:redundantcastTor Lillqvist
Change-Id: I1a111ba1be3083555b47af8cc272f93b367accae
2015-11-12vcl: boost::ptr_vector->std::vectorNoel Grandin
Change-Id: Ib75e4dffb35032f273b9482341a438ccb9b00397
2015-11-12vcl: boost::ptr_vector->std::vectorNoel Grandin
Change-Id: I21f90c8d4b3d52b7119d664cb7af471b33f27649
2015-11-12vcl: boost::ptr_vector->std::vector<std::unique_ptr>Noel Grandin
Change-Id: I91d833a541f1d21be66789bba6c983aa741731d8
2015-11-12Bin mesa_headers completelyTor Lillqvist
We don't need them in a MSVC or OS X compilation either. Change-Id: I00181fe0a047df09bbdfcce34c07eb2ebc45a2da
2015-11-12Avoid mesa_headers on X11, also link with -lGL only where necesssaryTor Lillqvist
The GLEW headers are enough, and what we actually use in these places. In addition to handling GL extension things in its dynamic fashion, GLEW headers also have declarations for standard, non-extension, OpenGL API, including xgl and wgl ones. Most likely we don't need mesa_headers on Windows or OS X either, and can drop them completely. Change-Id: Ic0d8d6238c862f8fe4a74e99e95344dcbf540980
2015-11-11It seems we don't need to include OpenGL (Mesa) headers for X11Tor Lillqvist
GLEW handles all that, that is why we use GLEW, isn't it? Change-Id: I83d272f89f7e6dbb0c6c4502cc1ec4d697a6b0a2
2015-11-11Move checkExtension() to a more private locationTor Lillqvist
Change-Id: I9f8a4ca0991b59bb9b6af4d40e3136ce5c986731
2015-11-115th step to remove tools/rtti.hxxOliver Specht
tools/rtti.hxx removed completed the interface of some Sdr.* Items and removed pseudo items Change-Id: I0cdcd01494be35b97a27d5985aa908affa96048a Reviewed-on: https://gerrit.libreoffice.org/19837 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-11tdf#93243 replace boost::bind with c++11 lambdas in vcl/source treeFabio Buso
Change-Id: Id12333cce50e14698e32195c49863d2e0cb448e4 Reviewed-on: https://gerrit.libreoffice.org/19893 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2015-11-11new loplugin: memoryvarNoel Grandin
detect when we can convert a new/delete sequence on a local variable to use std::unique_ptr Change-Id: Iecae4e4197eccdfacfce2eed39aa4a69e4a660bc Reviewed-on: https://gerrit.libreoffice.org/19884 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-10Missing includesAshod Nakashian
Restored some missing includes and refactored sot/formats.hxx. Change-Id: I11b7102b06889f426f5e0f3efa3a835c6e774d88 Reviewed-on: https://gerrit.libreoffice.org/19891 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2015-11-10Revert "vcl: Assert that a non-negative nXPos is always found"Stephan Bergmann
This reverts commit e3bd0951e6b8e8889aabc8640c5641ab32300517, the newly added assert fires during JunitTest_forms_unoapi_2.
2015-11-10loplugin:nullptr (automatic rewrite; Mac-specific code)Stephan Bergmann
Change-Id: I90a955eb3e485723bb81e7164edcf60f7b0e94c7
2015-11-10vcl: Assert that a non-negative nXPos is always foundTakeshi Abe
Change-Id: Ifb85cac1289af94102947b9064a8c12ca65ad43b Reviewed-on: https://gerrit.libreoffice.org/19404 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10vcl: We see what you meant by DBG_ASSERT(true, ...)Takeshi Abe
This also makes SalColormap::GetColor() return an RGB color if m_hColormap is valid. Change-Id: I154dc43a2be54f7da473263f9f2a29db0cf2fd4b Reviewed-on: https://gerrit.libreoffice.org/19836 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2015-11-10loplugin:stringconstantStephan Bergmann
Change-Id: I32b1263c00e2b2e4d3d43ca3e96e4492e09e9c17
2015-11-10tdf#95650: Replace wrong assertion with conditionMike Kaganski
When UniscribeLayout::LayoutText(ImplLayoutArgs & rArgs) is run with BiDiRtl flag, and some skipped VisualItems was reversed in lines 908-927, it's possible that they will arrive in reverse order to the code adjusting mnSubStringMin, so this assertion may fire. This situation is not erroneous, so simply replacing the assert with "if". Change-Id: Icb244502dd00b4c08a2c5192369ee66d743b0dcc Reviewed-on: https://gerrit.libreoffice.org/19835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-11-10loplugin:nullptr (automatic rewrite)Stephan Bergmann
Change-Id: I05e89f9896170d4df3d1377549ea074f06b884a0
2015-11-10Use a depth buffer on OS X, tooTor Lillqvist
Change-Id: I35fa7c2dcec0731aed1f5effefa131ce3007d010
2015-11-10Surely a 24-bit depth buffer is enoughTor Lillqvist
We asked for a 64-bit one, which is rather preposterous. And the comment claimed we asked for a 32-bit one. Funnily, this same odd code and comment is found in half a dozen code samples on the Internet... Copy pasta rules. Change-Id: Ie54a7b75e07cfe0ffd98ec330ce63158d2d15415
2015-11-10Add some assertions and improve commentsTor Lillqvist
Make sure the hardcoded indexes into the iAttributes array that we use mean what they are supposed to. Add comments about that, and fix one misleading comment. Change-Id: Ibb748b00782db4fcaf34f6c717075f6aff50651e
2015-11-10tdf#95481 catch out-of-range access in vcl bitmapArmin Le Grand
blendBitmap24 assumes bitmap is 2 lines high for doing interpolation. For bitmaps of height 1, really nothing to interpolate there. Fix cornercase by 'blending' between the very same line instead. Change-Id: I9b94000aa563e525d0bb2418346ad2c86af26df8 Reviewed-on: https://gerrit.libreoffice.org/19863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-09translated German warningsAndras Timar
Change-Id: Ibb42bfbbf8c7a1796998c5390e7d933009b3ab89
2015-11-09new loplugin: oncevarNoel Grandin
Change-Id: If57390510dde4d166be3141b9f658a7453755d3f Reviewed-on: https://gerrit.libreoffice.org/19815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-11-08Leftover debug code? (causes -Werror,-Wformat)Stephan Bergmann
Change-Id: I8629481a454a668b3044eb6f56dbe43d4720e52a
2015-11-08update README.varsTomaž Vajngerl
Change-Id: Ie2d0cc90ecc3e585a8fbfc9517e48170cf07c0d2
2015-11-08support to load SVG images when loading from Image resourceTomaž Vajngerl
Change-Id: Ieda1c334d8d995c774381c52fa1d9aa11751c5ef
2015-11-07loplugin:stringconstantStephan Bergmann
Change-Id: I9e505814f206c35b465633c45bab6f989ad18074
2015-11-06vcl: WinMtfOutput: replace the other mutable static with a member tooMichael Stahl
Change-Id: Ied1e1c12f2fe19734f27c005e60db07e674e3639
2015-11-06compilerplugins: enhance "badstatics" plugin to find membersMichael Stahl
Finds static variables of types that have bad non-static members. Change-Id: I81ee940580c0f043feb543840ea4d3dd27734202
2015-11-06unused warning in DISABLE_DYNLOADING fixedOliver Specht
Change-Id: Ic5ae9d2c2c9a7ef95604d80134b0ff4de005db38 Reviewed-on: https://gerrit.libreoffice.org/19825 Reviewed-by: Oliver Specht <oliver.specht@cib.de> Tested-by: Oliver Specht <oliver.specht@cib.de>
2015-11-06vcl: [loplugin:stringconstant]Michael Stahl
Change-Id: I973b6b68a225cc872aff2c0fe0e8a2e9108b3140
2015-11-06merged graphic import/export into a single libraryOliver Specht
instead of egi, eme, epb, epg, epp, eps, ept, era, eti, exp, icd, idx, ime, ipb, ipd, ips, ipt, ipx, ira, itg, iti, there is now one graphic import export lib (gie) Change-Id: I20c0dd94e5857bb6e2e8cc8ac175ff500c6bbdfc Reviewed-on: https://gerrit.libreoffice.org/19756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-11-06coverity#1338231 Unchecked return valueCaolán McNamara
Change-Id: I76161e87adc70fb8ae94c5c4cc7157b95f76b6f7
2015-11-06loplugin:stringconstant: elide explicit ctor usage (automatic rewrite)Stephan Bergmann
Change-Id: I7ac150458a72963f3336d30ef9d99d7c0d81c024
2015-11-06vcl: The keymap table is constantTakeshi Abe
Change-Id: Ia563e1c58a61eaa9f2316be280711fafe6702c9d
2015-11-05afl-eventesting: deref of null mpTextObjCaolán McNamara
Change-Id: Icdb7d1cc250640f428984b96b0a51ac950013cb2
2015-11-05Reduce scope of #include <tools/poly.hxx>Matteo Casalin
Change-Id: I0d64393c029d27c8e6f3b6d360d2509dad16d860
2015-11-05Comment the quartz off-screen buffering code.Michael Meeks
Change-Id: Ie9a52745a83ca6e4281faa4f1dc8b8ea7411badf Reviewed-on: https://gerrit.libreoffice.org/19805 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-05use uno::Reference::set method instead of assignmentNoel Grandin
Change-Id: I31a69a997098eb1807361b8049c3312a4f287d75
2015-11-05OpenGL options: clarify setting descriptions, and provide a live status.Michael Meeks
Hopefully this will un-confuse users about whether GL is enabled; the settings only take effect on re-start, so show a current status line too. Change-Id: I82832fd8d35bc76ab2cf1f394f11a881fde80774 Reviewed-on: https://gerrit.libreoffice.org/19790 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2015-11-05fix compiling of this java classNoel Grandin
(even though it's not being built right now) Change-Id: I237cce48ea50b1184b166a8a8132ae425597bffe
2015-11-05vcl: This is constantTakeshi Abe
Change-Id: Ib01701c4e89f665cb65cdfa8612b02a70633181e
2015-11-05vcl: fix typo in the Android stub of sgvsplnMiklos Vajna
The intention is to call the real function, not the stub itself. Change-Id: I4bfd3020871c68951b19a3c63ea9a2dc4d736be7
2015-11-04vcl: fix Android buildMiklos Vajna
See <https://code.google.com/p/android/issues/detail?id=74835>, Android's <cmath> currently does not provide std::copysign(), add a forwarding stub till it gets fixed. Change-Id: I49cc74ad1b61fed0460588150f21471d63e9069f
2015-11-04yyyyyNoel Grandin
Change-Id: I9a947beefd2dfe21da8239e841ea3fb416bd1548
2015-11-04-Werror,-Wabsolute-valueStephan Bergmann
("using integer absolute value function 'abs' when argument is of floating point type; use function 'std::abs' instead") Change-Id: I3634186a10607f3b3fc6fc7c0aef968b32892156
2015-11-04vcl: What we want here is exactly std::copysignTakeshi Abe
Change-Id: I888ca84342a6c34b99a1f03d44d686e1f50622f4 Reviewed-on: https://gerrit.libreoffice.org/19778 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com>
2015-11-03loplugin:simplifyboolStephan Bergmann
Change-Id: I7fdcc939154ca6804707039c3311728a0249dec7