summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-07-29Revert "cid#1486241 'Constant' variable guards dead code"Samuel Mehrbrodt
This led to an exception when activating a page via UNO (seen in WollMux): warn:svtools.uno:211417:211417:svtools/source/uno/wizard/wizardshell.cxx:120: DBG_UNHANDLED_EXCEPTION in enterState exception: com.sun.star.uno.RuntimeException message: [jni_uno bridge error] UNO calling Java method onActivatePage: non-UNO exception occurred: java.lang.ArrayIndexOutOfBoundsException: Index 2 out of bounds for length 1 java stack trace: java.lang.ArrayIndexOutOfBoundsException: Index 2 out of bounds for length 1 at de.muenchen.allg.itd51.wollmux.dialog.mailmerge.MailmergeWizardController.onActivatePage(MailmergeWizardController.java:170) at com.sun.star.bridges.jni_uno.JNI_proxy.dispatch_call(Native Method) at com.sun.star.bridges.jni_uno.JNI_proxy.invoke(JNI_proxy.java:185) at com.sun.proxy.$Proxy118.execute(Unknown Source) at de.muenchen.allg.itd51.wollmux.dialog.mailmerge.MailmergeWizardController.startWizard(MailmergeWizardController.java:199) at de.muenchen.allg.itd51.wollmux.sidebar.SeriendruckSidebarContent.lambda$new$5(SeriendruckSidebarContent.java:468) This reverts commit 23c2c3433dc6bbfff2e1b590b1a89ee7f9c155c0. Change-Id: I6344a83eaa37b58c46a8b576c65bb15b11855c9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119655 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-29sidebar: unify LineWidthPopup with other WeldToolbarPopupsSzymon Kłos
Change-Id: I9dd0d2b223972683a9066f0069e055175349526f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118023 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119654 Tested-by: Jenkins
2021-07-29jsdialog: enable line end style popupSzymon Kłos
Change-Id: I6c9bc4bf651ba130ec87348ac0e12cbe0265b3e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118006 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119653 Tested-by: Jenkins
2021-07-29jsdialog: handle toolbox menus togglingSzymon Kłos
Change-Id: I85881531f041cbd5402ac8de2a96b2c7150cbba8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117839 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119609 Tested-by: Jenkins
2021-07-29jsdialog: toolbox popupsSzymon Kłos
unify menubutton popups and toolbox dropdowns Change-Id: I61c0c33a17d96f03d6513507bda6d5c8edbc55dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117786 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119608 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-29Avoid some division by zeroStephan Bergmann
The first of which was seen when running under UBSan `instdir/program/soffice --headless --convert-to pdf` of caolan/id:002485,src:002216,op:havoc,rep:8.jpg from the crash-testing corpus. The second one (when computing nGrfDPIy) was not observed, but lets assume that it could happen just as well, and keep the code symmetric. Change-Id: Idf9f9a84f3b05c7cfe3c66db753c73d2cbf812be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119650 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-07-28qt5 a11y: Implement Qt5AccessibleWidget::minimumStepSizeMichael Weghorn
This makes use of the newly introduced XAccessibleValue::getMinimumIncrement method, s. Change-Id: Ie148a4e1cedbdbb5964f8565c81611d3480465cb, "Add XAccessibleValue::getMinimumIncrement method". With this in place, Accerciser now shows the correct "Minimum increment" and the exact decimal value instead of a rounded integer value for FormattedFields, s. note in commit message for Change-Id: I8af326c2d24c1801147a56ea2e2a886ab42ac634 "a11y: Expose FormattedField as spinbox" for more details. Change-Id: Ia9d07552197357c81ae8ea3b62e2de07e82148bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119597 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-28jsdialog: handle popover closeSzymon Kłos
Change-Id: I8b5afe7438c57cfe0553475131bed1e3c4921f46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117373 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119598 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-28jsdialog: dump and activate popup windowsSzymon Kłos
Change-Id: I4eb49a81d12ac37f50c6595eeec6d472fdbe6d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117251 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119581 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-28Move SalInstancePopover decl to header fileSzymon Kłos
Change-Id: I58d021d3e4a3f5d4b8b805380526c1d32b782674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117345 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119563 Tested-by: Jenkins
2021-07-28jsdialog: dump internal image for buttonsSzymon Kłos
Change-Id: I53687f67042490c19d1056c74619d43566bf1289 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117132 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119562 Tested-by: Jenkins
2021-07-28jsdialog: sidebar: fix closingSzymon Kłos
revert change done by mistake in: 64bd4dd2f80b247cb5df3f3e6c54bf2d47bc41a7 Change-Id: I740d5970c713053c7f8a4c880776a1056d132e12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119553 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-28jsdialog: weld MenuButtonSzymon Kłos
Change-Id: I79b753e070183daa809b23dbb7d3052000ebecd4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116995 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119552 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-27MetaTextArrayAction version 2 string discardedCaolán McNamara
since... commit 58a064595e43428f7d74341aff38df40fec0c8b3 Date: Thu Jul 8 12:51:11 2021 +0300 Add Handler for MetaTextArray Read Change-Id: I0c35bb92d3e61d8d2158e3a51e3661373e5cb6aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-27Move SalInstanceMenuButton decl to headerSzymon Kłos
Change-Id: I5f5f0ceb58925874c6878760a99179a4936198fa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116991 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119543 Tested-by: Jenkins
2021-07-27jsdialog: sidebar: remove code for tunneled oneSzymon Kłos
Change-Id: Idb60fdfc03729dd3755d5ef1ba61b2f9376e9556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116965 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119542 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-27Added the feature to store VCL test results as a zip filehomeboy445
The results can now be downloaded as a zip file, which would consist of the test log and all the resultant bitmap images produced by the tests compressed as png stored in the user directory folder. Change-Id: I8a6098a7454a621bbb9cafa7b6f2cafaa5503522 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117937 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for MetaAction Readpanoskorovesis
The handler separates MetaAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx In this case the handler doesn't read anything. It creates and returns a MetaAction Change-Id: I01b23bd836c88f07dc9adde90a7e2da322b832f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119539 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for TextLanguage Readpanoskorovesis
The handler separates MetaTextLanguageAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: I9862c21ab2f75a1365bdbc609e4c399694d0a9a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119538 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for LayoutMode Readpanoskorovesis
The handler separates MetaLayoutAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: Idd9e8f2db42b0fc6028c192f3fcba11c59917e17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119537 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27jsdialog: weld frameSzymon Kłos
Change-Id: I863022b0b1efc741626b0ba4a8a6183c169eaa85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116891 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119523 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-27Move SalInstanceFrame decl to header fileSzymon Kłos
Change-Id: I43b10e2314b81dc490714ad9fb809c1324fe17c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116890 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119512 Tested-by: Jenkins
2021-07-27jsdialog: sidebar: send sidebar PanelsSzymon Kłos
Change-Id: Ia5a936c44e5d83fd4626098bcc027b0382523231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116098 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119511 Tested-by: Jenkins
2021-07-27Add Handler for Comment Readpanoskorovesis
The handler separates MetaCommentAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: Ic37db0ecb30482b3503ede88cd9d72de2ed0efde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119194 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for RefPoint Readpanoskorovesis
The handler separates MetaRefPointAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: I0de2cbefbb91a89e24b8c6e43fea80a7595baa5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119193 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for EPS Readpanoskorovesis
The handler separates MetaEPSAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: I9a56e447865643bbd6e02f9b9da3be715172fe35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119192 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-27Add Handler for FloatTransparent Readpanoskorovesis
The handler separates MetaFloatTransparentAction::Read from metaact.hxx Read implementation is now in SvmReader.hxx Change-Id: Ie19d33570daec5a5ec34ba015cf83bffb18d250b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119171 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-26cid#1489523 silence bogus Out-of-bounds accessCaolán McNamara
drop comment referring to no longer used return value Change-Id: I3eca1294edc09fc626a8d62ff031547c2a1a5a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-26jsdialog: weld ContainerSzymon Kłos
Change-Id: I9516538cac8d2e42e0d029feaf84c3bc3a80151a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119499 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-07-26vcl: bitmap::CreateFromData add option to reverse alpha (0xff - a)Tomaž Vajngerl
Change-Id: If69225f86afb315ad432789178188a66264ab3ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118669 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-23no need to allocate these static vars on demandNoel Grandin
the constructor can be laid out at compile/link time Change-Id: I377a537e15199ae81394d76ac662576280a25c25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119362 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-23do not use "using namespace std" in headersCollabora
It's a bad style, doing that in headers can affect many source files (especially with PCH used). Change-Id: Ic9091a1d018e74606c9fa95df71a55faaa93d4ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119011 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-07-22tdf#95394 - ui fill dialog from (bitmap -> image)haru-02
Change-Id: Ib30eb0489e8cad2d417bc8638204b95f4acee936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119115 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-07-22tdf#143493 Qt5 key modifier events don't have textJan-Marek Glogowski
Regression from commit 862fdb98ca271b60a831cd5420fd16d5f9c1c747 ("tdf#143298 Qt5 send SalEvent::KeyModChange events"). Change-Id: I6981af06e3a73dee45ed10416f5d3b17b860a73b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119375 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-07-22qt5 a11y: Always query the XAccessibleContext for a11y interfacesMichael Weghorn
The accessibility interfaces are implemented by the object implementing 'XAccessibilityContext' which is often the same as the 'XAccessible' (in which case the corresponding 'XAccessible::getAccessibleContext()' call just returns a reference to self), but it doesn't have to be that way. From offapi/com/sun/star/modules.idl: > /** UNO Accessibility API > > <p>This modules contains the basic interfaces of the UAA (UNO > Accessibility API). Services that describe how these interfaces are > implemented can be found in other modules. The services in this module > describe only what every accessible object has to support.</p> > > <p>Making a class accessible starts by supporting the > ::com::sun::star::accessibility::XAccessible interface. > This interface's only method returns the actual accessibility object, an > instance of ::com::sun::star::accessibility::XAccessibleContext. > These two interfaces may be implemented by the same class in which case > a call to ::com::sun::star::accessibility::XAccessible getAccessible() > returns the same object that is > called. Alternatively the implementation of the > ::com::sun::star::accessibility::XAccessibleContext > interface can be done by another class. This makes it possible to put > all accessibility implementations into their own library which has only > to be loaded when necessary.</p> > > <p>Note that all other interfaces have to be implemented by the same > class that implements the > ::com::sun::star::accessibility::XAccessibleContext > interface. Note also that there is no way back from an accessibility > object to the object from which it has been obtained by means of the > UAA. If you need such a back-link you have to provide one on your > own.</p> > */ > module accessibility {}; This e.g. makes Accerciser show the correct values of the "URL" and "Text" controls in Writer's "Insert" -> "Hyperlink" dialog. Change-Id: I909b1fdf5e1e7ca50db5d5191ae69cb558a49dc8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119364 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-22qt5 a11y: Improve Qt5AccessibleWidget::attributesMichael Weghorn
* handle case where out params are nullptr * set fallback values for out params at the beginning This e.g. makes Accerciser show '-1' for both, startIndex and endIndex for the text interface of the "URL" and "Text" controls in Writer's "Insert" -> "Hyperlink" dialog along with no text. Making the actual text show up if there is any will be handled in an upcoming commit. Change-Id: Ie864f729ad06e28684bd426e4ba37b8a9d4d4634 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119363 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-22tdf#143148: Use pragma once instead of include guardsSabyasachi Bhoi
Replace include guards with pragma once in header file Change-Id: I8f845a3eb563ab3e6d5ce57b3b411a46bce54889 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119368 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-07-22no need to allocate the error separately in GraphicFilterNoel Grandin
Change-Id: I26c43cb72580d9cc384b3c4b70e43f47d3db0198 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119367 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22osl::Mutex->std::mutex in GraphicFilterNoel Grandin
Change-Id: Ia7d81ad0eaeab4f6ecf89b555da26e42a27bf80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119361 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22flatten vcl::LazyDeleteNoel Grandin
we can allocate the stored value in-line and avoid some pointer-chasing Change-Id: I828814b127923cdcec1bf57b3b64dffab4cffaaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119298 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22flatten GraphicObjectImplNoel Grandin
no need to allocate the GraphicObject separately Change-Id: I71f13792dfd45e47d835ad1e3627a559044346a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119337 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-22osl::Mutex->std::mutex in GraphicObjectImplNoel Grandin
Change-Id: I4c62d4b105425d4fb39eefdb7117299488af47dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21flatten vector in ImplMultiTextLineInfoNoel Grandin
Change-Id: I30f40c3906c38d29bab7aeef0a9562bd96934a72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119329 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21flatten ImplListBoxWindowNoel Grandin
no need to allocate ImplEntryList separately Change-Id: I276e92895a00ebccff60f5067567a0ed066d4e66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119328 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21flatten ImplToolBoxPrivateDataNoel Grandin
Change-Id: Ia3c0d6624ccf2d3c6189064ab7c8b07dc0734c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-21qt5 a11y: Implement Qt5AccessibleWidget::cursorPositionMichael Weghorn
Use 'XAccessibleText::getCaretPosition', similar to how 'Qt5AccessibleWidget::setCursorPosition' calls 'XAccessibleText::setCaretPosition'. Change-Id: Ic9e4533d6a39de90fee7ec2e8e0bd3fc6a69bba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119320 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-21qt5 a11y: Implement Qt5AccessibleWidget::textAtOffsetMichael Weghorn
The Orca screen reader uses 'IAccessibleText::textAtOffset' e.g. in order to retrieve the text of the current Writer paragraph on cursor movement. With this and various other WIP changes to qt5 a11y on top which are required to make Orca speak at all (well, at least sometimes...), Orca now also speaks the text of paragraphs that contain more than just a single character. The single-character case was working because Orca has a special handling for this; a comment in the source code says: "We do this because Gecko's implementation of getTextAtOffset is broken if there is just one character in the string.") This implementation is inspired by the corresponding winaccessibility one, see 'CAccTextBase::get_textAtOffset' in winaccessibility/source/UAccCOM/AccTextBase.cxx. Change-Id: I67775a03c6e4384f410e1e9d727d7a412ba4112e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119310 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-21jsdialog: don't send unnecessary show/hide messagesSzymon Kłos
Change-Id: Ie37503b5964606a2b3e5b305c949f570616dc1cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117070 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119243 Tested-by: Jenkins
2021-07-21qt5 a11y: Handle AccessibleStateType::MULTI_LINEMichael Weghorn
This addresses warnings like warn:vcl.qt5:53343:53343:vcl/qt5/Qt5AccessibleWidget.cxx:639: Unmapped state: 17 seen e.g. when navigating to a Writer paragraph in Accerciser when using LO with the kf5 VCL plugin. With this in place, the "multi line" state is correctly shown in Accerciser. Change-Id: Ib38a7374d9c81f2d5c361809583f711f4eadccba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119295 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-07-21qt5 a11y: Handle AccessibleStateType::MOVEABLEMichael Weghorn
This addresses warnings like warn:vcl.qt5:151782:151782:vcl/qt5/Qt5AccessibleWidget.cxx:636: Unmapped state: 31 which I started seeing when running LO with kf5 VCL plugin and Orca enabled after commit ddbc111555607e62b94b74aacadd6a964b9fe4a5 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Mon Jul 19 17:13:04 2021 +0200 qt5 a11y: Set proper a11y states had fixed handling of a11y states. Change-Id: I00b8f2f75954fbd7d9e5f0807b51e5632d1a8035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119248 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
generated by cgit (git 2.34.1) at 2025-01-09 19:53:37 +0000