summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2023-12-10cid#1545975 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1545955 COPY_INSTEAD_OF_MOVE cid#1545954 COPY_INSTEAD_OF_MOVE cid#1545952 COPY_INSTEAD_OF_MOVE cid#1545948 COPY_INSTEAD_OF_MOVE cid#1545943 COPY_INSTEAD_OF_MOVE cid#1545935 COPY_INSTEAD_OF_MOVE cid#1545930 COPY_INSTEAD_OF_MOVE cid#1545928 COPY_INSTEAD_OF_MOVE cid#1545925 COPY_INSTEAD_OF_MOVE cid#1545922 COPY_INSTEAD_OF_MOVE Change-Id: I28d830504337f417829c675b1eb9c763b83b30c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160522 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10cid#1546281 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546278 COPY_INSTEAD_OF_MOVE cid#1546276 COPY_INSTEAD_OF_MOVE cid#1546247 COPY_INSTEAD_OF_MOVE cid#1546244 COPY_INSTEAD_OF_MOVE cid#1546243 COPY_INSTEAD_OF_MOVE cid#1546220 COPY_INSTEAD_OF_MOVE cid#1546209 COPY_INSTEAD_OF_MOVE cid#1546207 COPY_INSTEAD_OF_MOVE cid#1546206 COPY_INSTEAD_OF_MOVE cid#1546205 COPY_INSTEAD_OF_MOVE cid#1546197 COPY_INSTEAD_OF_MOVE cid#1546180 COPY_INSTEAD_OF_MOVE cid#1546172 COPY_INSTEAD_OF_MOVE cid#1546165 COPY_INSTEAD_OF_MOVE cid#1546164 COPY_INSTEAD_OF_MOVE cid#1546158 COPY_INSTEAD_OF_MOVE cid#1546151 COPY_INSTEAD_OF_MOVE cid#1546135 COPY_INSTEAD_OF_MOVE cid#1546132 COPY_INSTEAD_OF_MOVE cid#1546129 COPY_INSTEAD_OF_MOVE cid#1546128 COPY_INSTEAD_OF_MOVE cid#1546122 COPY_INSTEAD_OF_MOVE cid#1546117 COPY_INSTEAD_OF_MOVE cid#1546113 COPY_INSTEAD_OF_MOVE cid#1546106 COPY_INSTEAD_OF_MOVE cid#1546099 COPY_INSTEAD_OF_MOVE cid#1546091 COPY_INSTEAD_OF_MOVE cid#1546085 COPY_INSTEAD_OF_MOVE cid#1546069 COPY_INSTEAD_OF_MOVE cid#1546063 COPY_INSTEAD_OF_MOVE cid#1546062 COPY_INSTEAD_OF_MOVE cid#1546058 COPY_INSTEAD_OF_MOVE cid#1546056 COPY_INSTEAD_OF_MOVE cid#1546051 COPY_INSTEAD_OF_MOVE cid#1546040 COPY_INSTEAD_OF_MOVE cid#1546030 COPY_INSTEAD_OF_MOVE cid#1546028 COPY_INSTEAD_OF_MOVE cid#1546015 COPY_INSTEAD_OF_MOVE cid#1546001 COPY_INSTEAD_OF_MOVE Change-Id: Ib954c92a300fc323b29f27880fdf8bc46ed98862 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160520 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-10add missing #if MORE_FONTSRene Engelhard
since it nededs Source Han Sans since 9b5964cf5931d7c09e4fd624d68595891c2afb58 Change-Id: I35bd30048b298e8cbdaf6de22ae2022d51415aa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160512 Tested-by: Jenkins Reviewed-by: Chris Sherlock <chris.sherlock79@gmail.com> Reviewed-by: René Engelhard <rene@debian.org>
2023-12-09tdf#158461 eliminate flicker during live resizingPatrick Luby
When using Skia/Metal, the window content will flicker while live resizing a window if we don't send a paint event. Change-Id: Ib3edc497e26e6abfdfd17a34f9269a3eae090805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160519 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-09cid#1556778 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546474 COPY_INSTEAD_OF_MOVE cid#1546473 COPY_INSTEAD_OF_MOVE cid#1546469 COPY_INSTEAD_OF_MOVE cid#1546467 COPY_INSTEAD_OF_MOVE cid#1546458 COPY_INSTEAD_OF_MOVE cid#1546448 COPY_INSTEAD_OF_MOVE cid#1546446 COPY_INSTEAD_OF_MOVE cid#1546441 COPY_INSTEAD_OF_MOVE cid#1546424 COPY_INSTEAD_OF_MOVE cid#1546377 COPY_INSTEAD_OF_MOVE cid#1546374 COPY_INSTEAD_OF_MOVE cid#1546352 COPY_INSTEAD_OF_MOVE cid#1546334 COPY_INSTEAD_OF_MOVE cid#1546328 COPY_INSTEAD_OF_MOVE cid#1546310 COPY_INSTEAD_OF_MOVE cid#1546303 COPY_INSTEAD_OF_MOVE Change-Id: I8a43fdd574857ba1d3ec416f23c8269a9a08e12f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160515 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08Revert "Related: tdf#155266 force flush after drawing native scrollbars"libreoffice-24-2-branch-pointPatrick Luby
This reverts commit 5ff701226b00963312cb2a78e77966d012b79c82. Reason for revert: Tester reports no change in behavior after the commit. Change-Id: Ic6d9f4834c7c6e3fae34d132298b335f433df280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160470 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-08tdf#43157 vcl: remove DBG_ASSERT() from DrawDeviceAlphaBitmapSlowPath()Chris Sherlock
Change-Id: I6c120eb2bb8999276103f50bf3679366b6ee86ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157189 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-08cid#1546472 COPY_INSTEAD_OF_MOVECaolán McNamara
and cid#1546459 COPY_INSTEAD_OF_MOVE cid#1546452 COPY_INSTEAD_OF_MOVE cid#1546403 COPY_INSTEAD_OF_MOVE cid#1546396 COPY_INSTEAD_OF_MOVE cid#1546394 COPY_INSTEAD_OF_MOVE cid#1546338 COPY_INSTEAD_OF_MOVE cid#1546324 COPY_INSTEAD_OF_MOVE Change-Id: If61457cfaf1d7ce4a069bcecdc0cc657aeb43c68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-08tdf#143148 Use pragma once instead of include guardsKira Tubo
Replace include guards with #pragma once Change-Id: Id7378d6cf43817a8501a314dd8614467fb10e33a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160417 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-12-07Related: tdf#155266 force flush after drawing native scrollbarsPatrick Luby
When scrolling on some Intel Macs either via dragging the scrollbar thumb or via swiping the trackpad with two fingers, final repaint of scrollbars doesn't appear to get flushed to the screen. It appears that scrollbars aren't updated and repainted until after a batch of native scroll events have been dispatched. On slower machines, this lag is long enough that any pending forced flushes have already been done so when the timer that repaints scrollbars finally fires, the repainted scrollbars won't get flushed to the native window until the next normal flush which may not occur until seconds later. Change-Id: Iadef6812cd2495a28347560caae81f604c908b51 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160440 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-07cid#1546503 Using invalid iteratorCaolán McNamara
and cid#1546284 Using invalid iterator cid#1546275 Using invalid iterator cid#1546049 Using invalid iterator cid#1545929 Using invalid iterator cid#1545870 Using invalid iterator cid#1545668 Using invalid iterator cid#1545420 Using invalid iterator Change-Id: I3ad3000631b4be5917b9c5f49f21b8cc003a309c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159056 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07cid#1558798 Unchecked return valueCaolán McNamara
Change-Id: Iddb702f40ced018c104a8a42847bc396ba258ff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160420 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-07simplify and modernise ScopedBitmapAccessNoel Grandin
(*) Make all of it use a "Scoped" paradigm (*) pass by value, no need to allocate on heap (*) make all of the construction go via the *Access constructors, instead of it being some via the constructors and some via the Acquire*Access methods. (*) take the Bitmap& by const& in the constructor, so we can avoid doing const_cast in random places. Change-Id: Ie03a9145c0965980ee8df9a89b8714a425e18f74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160293 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-07tdf#157432 Expert config: Allow filtering by changed valuesSamuel Mehrbrodt
Change-Id: Ib8bbb7fc9e8014a9367278f3fa640f53af46dd2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159986 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-12-06Related: tdf#155266 skip redisplay of the view when forcing flushPatrick Luby
It appears that calling -[NSView display] overwhelms some Intel Macs so only flush the graphics and skip immediate redisplay of the view. Change-Id: I7a94a1ada35526c5eda1b793f872e206b4c833ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160399 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-12-06tdf#148986 Support XF86Forward / XF86Back key eventsGabor Kelemen
Multimedia keys found on certain presentation clicker devices. Not added to the Customize dialog, as that was not yet asked for. As I have no access to a MAC, did not add support for that in vcl. Inspiration for code taken from commit ca74511985981444dbd72ade7244484c131e36a7 Change-Id: I417e6ba7e79c5f6e774a56ba747803a156d5f50f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160255 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06Drop use of Win98-era multimon.hGabor Kelemen
last mention of it was removed in 2014 by: commit cb40b7d2f9902b5fbe89333c4107d72c156b9a15 Change-Id: Ib60d84624b681d103bc654075a759fc92f8f3300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160289 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-12-06make AlphaMask separate from BitmapNoel Grandin
Having it subclass Bitmap encourages confusion in passing it around, and I need the extra type-safety for my work on merged-alpha Change-Id: I35819f9b8ee609cbdaf865563c78531e397b529b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160235 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-06Remove the special-casing in Bitmap::Invert (and fix)Noel Grandin
and rather rely on the backends doing the right thing, which is considerably faster. Which uncovers a bug in the existing code - it is not legal to simply invert the value when dealing with palette-based images. Fix this by sharing some code with Bitmap::ReplaceMask. Change-Id: I2ef340a9f251c8c7e27b68ab451ce85df07c1035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-05Related: tdf#158534 set fallback help page for optional print contentCaolán McNamara
Change-Id: I79d843cbf2591ab5a8625087e2ec5897b26a8056 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160371 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05Resolves: tdf#158534 two help pages from print help buttonCaolán McNamara
its either use the default "help" response, or have an explicit handler for the help button. Its more consistent to just use the default "help" response for the print dialog as done everywhere else. Change-Id: I0bb173e67a3bea1c10cc315cfcf212376f2710c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-05vcl: add unit test for cached glyphs based on tdf#103492Chris Sherlock
Change-Id: Id66be996053435c92b667eb142ae1e271ff33b90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159386 Tested-by: Jenkins Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-05Drop own mutex to prevent lock order problemMike Kaganski
When running UITests on Windows with parallelism, I often see deadlocks in clipboard threads, where one thread holds own mutex and tries to lock solar mutex, and the other holds it and waits for own mutex. The problem is in TransferableDataHelper::GetAny, where solar mutex is released temporarily. Avoid it by dropping own mutex, and only using solar mutex. Change-Id: Idbfa2e1399fe94d092b4090e7aa4956be4103744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160296 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-05vcl: add unit tests for a mixture of CJK and latin charactersChris Sherlock
To influence the fallback fonts chosen, I have introduced a new OutputDevice function ForceFallbackFont() which injects ("forces") a font as the first one in the font fallback chain. Change-Id: I05856cbe829fde0eb140bb48a37795a84d780900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159221 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-12-04Avoid clipboard messages after Scheduler::ImplDeInitSchedulerMike Kaganski
When running UITests on Windows with parallelism, often there are clipboard "content changed" messages that fail the assertion in Scheduler::ImplDeInitScheduler. This is because the clipboard is only uninitialized after the scheduler de-init; and even then, the respective threads are not stopped yet. Make sure that clipboard listeners are stopped before calling the Scheduler::ImplDeInitScheduler in DeInitVCL. Change-Id: I37918cdc565c7f1b3bd4f46e71c55bb5a807db6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160308 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-04cid#1545810 Using invalid iteratorJulien Nabet
and : cid#1545802 Using invalid iterator cid#1545745 Using invalid iterator cid#1545717 Using invalid iterator cid#1545675 Using invalid iterator cid#1545668 Using invalid iterator cid#1545639 Using invalid iterator cid#1545634 Using invalid iterator cid#1545629 Using invalid iterator cid#1545620 Using invalid iterator cid#1545608 Using invalid iterator cid#1545607 Using invalid iterator cid#1545601 Using invalid iterator Change-Id: I403842175f64a570d7e52fba7c3e03bf21b7d05b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160320 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04cid#1546021 Using invalid iteratorJulien Nabet
and : cid#1545983 Using invalid iterator cid#1545969 Using invalid iterator cid#1545949 Using invalid iterator cid#1545929 Using invalid iterator cid#1545911 Using invalid iterator cid#1545910 Using invalid iterator cid#1545886 Using invalid iterator cid#1545870 Using invalid iterator cid#1545813 Using invalid iterator Change-Id: I2ad10c2a9affd348050a4abe0917a90927a52547 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160317 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04cid#1546275 Using invalid iteratorJulien Nabet
and : cid#1546219 Using invalid iterator cid#1546088 Using invalid iterator cid#1546070 Using invalid iterator cid#1546061 Using invalid iterator cid#1546055 Using invalid iterator cid#1546049 Using invalid iterator Change-Id: I6f3a786852b5c262d60c3195e446a37967ed9b59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160311 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-12-04Relax assertion a bitMike Kaganski
When running UITests on Windows with parallelism, I often see this assertion failing. I don't know why; but every time I attach the debugger to the failed process, I see mpSchedulerStack's mpTask and mpNext are both nullptr. The only place where this can happen is Task::~Task, which seems to suggest that this situation is basically the same as no mpSchedulerStack. Change-Id: I2485333944b6d56a365820bc4ca781098e508f48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160304 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-12-04ofz#64582 Out-of-memoryCaolán McNamara
Change-Id: I862d558ffcf7d0347bf6b9e960b6f00c08c9e8fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160310 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-04ofz#64680 Integer-overflowCaolán McNamara
Change-Id: Ic125ef6faf136a9821efc717214dd49ae24d6059 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-04cid#1545582 COPY_INSTEAD_OF_MOVECaolán McNamara
Change-Id: I9d88d11889cef3f761b86c967ba1f3da7a8de891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160287 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03cid#1546503 Using invalid iteratorCaolán McNamara
and: cid#1546480 Using invalid iterator cid#1546479 Using invalid iterator cid#1546454 Using invalid iterator cid#1546419 Using invalid iterator cid#1546410 Using invalid iterator cid#1546150 Using invalid iterator cid#1546039 Using invalid iterator cid#1545831 Using invalid iterator cid#1545736 Using invalid iterator cid#1545701 Using invalid iterator cid#1545630 Using invalid iterator cid#1545381 Using invalid iterator Change-Id: I9e151b623f751ee1e982b5da0011ff08ab0ad5e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160270 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-12-03Split the *Bitmap::CopyPixel functionsNoel Grandin
into the two entire separate cases they want to handle, there is no reason to mix the two different cases like this. Change-Id: I38e99e7ad6168a84e7a744f61407887825158902 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02Simplify some AlphaMask codeNoel Grandin
AlphaMask has an operator=, no need for extra complication Change-Id: Ib0f4aba4e1c9a4a594cc1cbc92f3a335dc9295a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02AlphaMask::ReleaseAccess is unnecessaryNoel Grandin
There is no way the format can change via the Bitmap*Access mechanisms, and we already perform these asserts in the constructor and operator=. The code has been there since commit 8ab086b6cc054501bfbf7ef6fa509c393691e860 Author: Jens-Heiner Rechtien <hr@openoffice.org> Date: Mon Sep 18 16:07:07 2000 +0000 initial import Change-Id: I75195f6fd4e29d7133e787131b6c8479a9188d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-12-02pass BitmapBuffer around by std::optionalNoel Grandin
instead of allocating on the heap, it is small Change-Id: I79eec6605a04c09d9a984cd1a719affb5b06dff3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160195 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-30vcl: Fix commentKhaled Hosny
The comment is saying the opposite of what the code is doing. Change-Id: I16cc44b56f90f622cedb87b9107d17b940665896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160144 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-11-30Related: tdf#155092 translate Y coordinate for height differencesPatrick Luby
When in live resize, the NSView's height may have changed before the CGLayer has been resized. This causes the CGLayer's content to be drawn just above or below the top left corner of the view so translate the Y coordinate by any difference between the NSView's height and the CGLayer's height. Change-Id: Iac13fa8374977e098f8311c55e182ef5a5ebec30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160131 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-11-29Online: Put the image width height info into json.Gülşah Köse
When online's image render is delayed we don't have any image size info so getting 0x0. To show better result we need that info into message. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: I28f345cdd64de5fa47b3b1054330e606e7b32f03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160106 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-11-29Extended loplugin:ostr: vclStephan Bergmann
Change-Id: Ia9e958deec9716e38381a027451d5ee821efe23d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160095 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
2023-11-29remove fallback codeNoel Grandin
we have had this assert for long enough now to flush out any problems. Change-Id: Ib732ca8d9156feb3c5d071cdbd44ea97875f6d9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-28simplify some BitmapEx constructionsNoel Grandin
using the color bitmap __and__ the alpha from another BitmapEx is equivalent to just doing a straight copy/assign Change-Id: I134ab8a1197ed538823afc4a8cd28b3d5986c6b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-27tdf#155092 don't dispatch left mouse up events during live resizingPatrick Luby
Round 2 of trying to fix macOS live resizing. If this is a left mouse up event, dispatching this event will trigger tdf#155092 to occur in the next mouse down event. So do not dispatch this event and push it back onto the front of the event queue so no more events will be dispatched until live resizing ends. Surprisingly, live resizing appears to end in the next mouse down event. Also, reverted parts of commit 54da842381ccb554d3cadc876f23cf183d21bf1a and cleaned up the setting of ImplGetSVData()->mpWinData->mbIsLiveResize. Change-Id: Ie93ed496e1f0e2a1711284ab205c6b245f71647c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159960 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@libreoffice.org>
2023-11-25tdf#158317 fix cleanup of SfxPoolItems in editengArmin Le Grand (allotropia)
It is not possible to use implCreateItemEntry/implCleanupItemEntry, that is tooling limited *by purpose* to svl/Item/ItemSet stuff. But what I can do is to do that SfxPoolItemHolder I already talked/thought about. It is a helper that can safely hold a SfxPoolItem in cases where an SfxItemSet is too expensive. Think about it as a SfxItemSet for a single item. That solves the problem why DirectPutItemInPool/DirectRemoveItemFromPool is used in general (each usage is a 'compromize'). Did that now, works well. Editengine is now free of DirectPutItemInPool/DirectRemoveItemFromPool. Replaced ::CursorMoved with checkAndDeleteEmptyAttribs since all these got static with no longer need to DirectRemoveItemFromPool. Corrected create/delete counters. Change-Id: Ia6e53f48ac2e479b461546515e68697039b5b628 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159931 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2023-11-24tdf#157551 Calc-Validity-CellRange, dropdown tinyNoel Grandin
regression from commit b6b26421a1029b18b48b69dbdac4bb70fb622604 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Jul 20 08:19:52 2023 +0200 split Point/Size/Rectangle into AbsoluteScreenPixel* types Change-Id: I92c25041520ec5a8f03b5318c00f49bda398b051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159915 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-11-24enable using medium/full font hinting even with subpixel positioningFrank Steiner
Change-Id: I1be0670d59163070dccf035ec9c7b0cd4f818c69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159766 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-11-23Update vcl README wrt VCL pluginsMichael Weghorn
Change-Id: I0b778b3d33367239e4cb12e5f1eba2224a0ed55e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159861 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-11-23tdf#155092 use tracking areas instead of tracking rectanglesPatrick Luby
Apparently, the older, tracking rectangles selectors cause unexpected window resizing upon the first mouse down after the window has been manually resized so switch to the newer, tracking areas selectors. Also, the NSTrackingInVisibleRect option allows us to create one single tracking area that resizes itself automatically over the lifetime of the view. Note: for some unknown reason, both NSTrackingMouseMoved and NSTrackingAssumeInside are necessary options for this fix to work. Change-Id: I1f771628d872166ff63a52990f671df053d144ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159845 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-11-22Online: Fix Wizard Help buttonGülşah Köse
Wizard dialog help button's response is not initialized if we don't run any other dialogs. It should be initialized in RoadmapWizard itself. response_help function can not detect wizard dialog's Help button. So we should handle this case in function too. Signed-off-by: Gülşah Köse <gulsah.kose@collabora.com> Change-Id: If80a2e54dcbf5eaa3d0e07347d12296ace5c9569 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/159282 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-01 21:50:43 +0000