summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-07-03Rearrange and annotate funcs by XInterfaceKatarina Behrens
Change-Id: Ie429074fdbe8fb4e28b1af47486bc70c5f8070e8
2018-07-03Implement getDirectory, signal+slotKatarina Behrens
also factor some shared code out into separate func Change-Id: I49d25eeb4eb647b72dae78c42301091d198eeff4
2018-07-03Folder picker is now really a folder pickerKatarina Behrens
and not a regular file picker with wrong title Change-Id: I849e7bb3d0cad197880fadd865f4d39f13245e97
2018-07-03Fix initial switch to folder in fileopen dlgKatarina Behrens
the argument passed is an URL, so using setDirectory wouldn't do the trick, setDirectoryUrl would Change-Id: I312f6e2a06b46777dc126f95f63ec0dbcb1f5799
2018-07-02loplugin:unusedfields improve checking for write-only fieldsNoel Grandin
we trade off a little accuracy for finding more possible write-only fields. Change-Id: I9f7edba99481fe4ded0a9d8e45e911b0ee99d269 Reviewed-on: https://gerrit.libreoffice.org/56715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-30cppcheck: variableScopeJochen Nitschke
and use unique_ptr for vector elements Change-Id: I5421a53e96928699fd451d4ff3e2eef0bf847f42 Reviewed-on: https://gerrit.libreoffice.org/56772 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-30cppcheck: variableScopeJochen Nitschke
Change-Id: Icd99a9e6791840f7701745b93a0f414bf61e2955 Reviewed-on: https://gerrit.libreoffice.org/56773 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-06-29Improved loplugin:redundantcast (const-qualified typedefs): vclStephan Bergmann
Change-Id: Iac5978ee41f76a2b34c7dae12509212ba1c9d7e7 Reviewed-on: https://gerrit.libreoffice.org/56706 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-29This cast seems completely unnecessary to me?Tor Lillqvist
Change-Id: I93a135afc1402d9095828c4d41d669471a37f565 Reviewed-on: https://gerrit.libreoffice.org/56661 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-06-29tdf#117335 Fix displaying GIF imagesBartosz Kosiorek
To fix regression the sal_uInt16 was used instead of sal_uInt8. Verified on macOS High Sierra 10.13.5. I also checked if with this fix, there is no issue with displaying EMF (tdf#113197) Sample document from tdf#113197 is displaying correctly. Change-Id: I6504717d831a193b0a878ced2f335d34a993aed6 Reviewed-on: https://gerrit.libreoffice.org/56578 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-06-29Fix typosAndrea Gelmini
Change-Id: If6fafa1ef192411a9d59ef9a4ef4d7f522c67f66 Reviewed-on: https://gerrit.libreoffice.org/55964 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-06-28tdf#86612: statusbar: hide some elements if width is not sufficientVasily Melenchuk
new statusbar element property mandatory=true/false to determine if this element can be hidden if total statusbar width is not enough to fit all elements. marked some calc and draw statusbar elements as not mandatory. Change-Id: I20e26d3c4bd865e94ea48632a1e97d55f3fa712f Reviewed-on: https://gerrit.libreoffice.org/56443 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-28Clean up ownership tracking of SalVisual's visual (in X11 Visual base class)Stephan Bergmann
GCC trunk towards GCC 9 emits -Wdeprecated-copy because SalVisual has implicit copy functions but a user-declared dtor. The implicitly-defined copy functions are actually used (so cannot be deleted), but in fragile interaction with the semantics of the user-provided dtor in the SalColormap(sal_uInt16) ctor. Changing SalVisual into a move-only class (moving the "this instance must delete its visual member" information) doesn't work well, as SalDisplay::ScreenData is used as a supply of SalVisual instances (but which will never be of the "this instance must delete its visual member" variety) that are then copied into SalColormap::m_aVisual. As only SalColormap creates SalVisual instances of the "this instance must delete its visual member" variety, what actually works is to track that information in SalColormap instead of directly in SalVisual, and make SalColormap a move-only class. Change-Id: Ib968a38c40b660ce91981b3c7b281f4add6ece6b Reviewed-on: https://gerrit.libreoffice.org/56579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-06-27This assert() seems superfluousTor Lillqvist
The assertion fails when one reproduces tdf#69460 but removing the assert() does not cause any problems. Change-Id: Idaa5d41a0cf76073e406d7152fc3b4e9ebd3e876 Reviewed-on: https://gerrit.libreoffice.org/56538 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-06-27tdf#102960 vcl opengl: fix missing support for polygon track framesMiklos Vajna
Which is used in e.g. the Calc cell border dialog. The approach is similar to commit 60790935cc143de49b732e93b6fb923b7669530b (tdf#96657 - vcl opengl: implement invert: Track Frame., 2016-01-09) but that one was for rectangles, this one is for polygons. Change-Id: Ib1feebab2d14f4450fee0afe96afcea906965fdb Reviewed-on: https://gerrit.libreoffice.org/56534 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-27This should be a const NSString* so that we can pass such variables to itTor Lillqvist
Change-Id: I017c100f83faac64ad3a8430010c226b438e6a07 Reviewed-on: https://gerrit.libreoffice.org/56529 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-27vcl: prefer OpenType font feature description over GraphiteTomaž Vajngerl
If the fon supports Graphite features we can get the feature descriptions from the font, but this descriptions are mostly limited (available in a limited number of languages), so it is better to only use this descriptions only if the feature does not have an OpenType description available. Change-Id: Ic0b81cb8cc22e1e73f30e6a960167cfa982fbfc7 Reviewed-on: https://gerrit.libreoffice.org/56318 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-27tdf#53282: Leave (our own) full-screen mode when the AquaSalFrame is dyingTor Lillqvist
Change-Id: I85243dff96b9090de0fd55564b44abb6142d9ac2 Reviewed-on: https://gerrit.libreoffice.org/56524 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-06-26forcepoint#50 fix end detectionCaolán McNamara
rBuffer.size() of 26, nBytes of 25, rBuffer[25] is the first zero so aLine.getLength() of 25, nBytes reduced by aLine.getLength()+1 and nRun increased by same, so nBytes wraps and nRun is 26. Change-Id: Ia9f4789e081e6b77a21321f37d71cabfc7c84550 Reviewed-on: https://gerrit.libreoffice.org/56478 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26support gtk < 3.20.0Caolán McNamara
Change-Id: Ib21c787a5ff9253e54d620f5bb0142a57d04987d Reviewed-on: https://gerrit.libreoffice.org/56448 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-26Resolves: tdf#118356 freeze/thaw mass language additionsCaolán McNamara
Change-Id: Ifdc2247594d3ddeea0ca7b3b97eb6e392c54f95b Reviewed-on: https://gerrit.libreoffice.org/56409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-25weld SwWatermarkDialogCaolán McNamara
Change-Id: Iff3ddfb4dd75088e39ea7675b085f1bbde2c2045 Reviewed-on: https://gerrit.libreoffice.org/56247 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-24uitest logger: some changes in log statementsSaurav Chirania
These changes will allow the interpreter introduced in gerrit change number 56120 to understand these log statements. Change-Id: I68a406cd19bbe1cfe5b6563025348263d564d5af Reviewed-on: https://gerrit.libreoffice.org/56305 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-24uitest logger: print parent when logging keysSaurav Chirania
Change-Id: I130f266016dc51dab5e4d1395fe579ca21a1b835 Reviewed-on: https://gerrit.libreoffice.org/55675 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-24vcl: treat description of cv** & ss** font features speciallyTomaž Vajngerl
To avoid adding descriptions for each of font features cv** and ss**, where ** is a number between 00-99, process them separately and just use one description for each. This simplifies translation as we don't need to add 99 copy-paste translations but add a bit more complexity when looking up the descriptions. Change-Id: Ia6e9554af20355c90c73afeec33fd18c694865b9 Reviewed-on: https://gerrit.libreoffice.org/56317 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-22Fix typoAndrea Gelmini
Change-Id: I3b85fad7fa8962daf5926740cc1ebdb8ff3d6c5c Reviewed-on: https://gerrit.libreoffice.org/56294 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-06-22tdf#116208 vcl opengl: fix lack of updates in status barMiklos Vajna
Commit f0821f9a347c7752a3c741c3451a2f1630173720 (Cache text layout of statusbar items, 2017-06-08) was a performance improvement of not laying out the text of status bar text during each & every paint. One of these places didn't work correctly with Chinese text, so commit a4ed3d9a1ffa1b51ba4352a955c950235f099fdc (tdf#115353 Status bar: no cache in settext, 2018-03-01) attempted to disable the caching at that particular place by removing the update of the cache. This resulted in lack of updates, e.g. during typing into Writer and checking the word count part of the status bar. Fix this (and at the same time keep the original problem fixed) by still not using the layout cache and that problematic place, but instead of just not updating the cache actually invalidate it -- probably that was the intention in the force place already. Change-Id: Ib7b91e5f24bc68d2f8cae2efea64340585ad9bd5 Reviewed-on: https://gerrit.libreoffice.org/56304 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-06-22Resolves: tdf#115816 simpler fix for masterCaolán McNamara
Change-Id: Ibafd041728624e781b5da44a0b484206f760d4d0 Reviewed-on: https://gerrit.libreoffice.org/56248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21Allow building KDE5 backend on HaikuKacper Kasper
Change-Id: I3138d26596af4c615fe2caaa2b160a76d8d2a352 Reviewed-on: https://gerrit.libreoffice.org/55548 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-06-21Fix lists position in dialogsMaxim Monastirsky
Regression of 2bfc4cefc21ab18e9ff7cc5fdc743bcc856d103c ("Correctly mirror autofilter in rtl ui, tdf#117175 related") If a window has a parent, it doesn't necessarily mean it's not a top level. Change-Id: I75a27d19284be6c29de7705af20ddccfcf69491d Reviewed-on: https://gerrit.libreoffice.org/56250 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-06-21Resolves: tdf#115816 second 'Insert' menu is pasteCaolán McNamara
reuse existing translation to be backportable wrt no new translations Change-Id: I1fb94f66d696f836e8f6a10ba2d6933f69cfac95 Reviewed-on: https://gerrit.libreoffice.org/56225 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21FontFeatureTest - adding the dependency for "Libertine G" fontTomaž Vajngerl
Change-Id: I2b74c7b074f59df41a20b7c58b3719cb6724c5ef Reviewed-on: https://gerrit.libreoffice.org/56227 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-06-21Missing include (-Werror,-Wundef)Stephan Bergmann
Change-Id: Ic74b443768deb833d6b92d8a99512492e7f84572
2018-06-21disable testGetFontFeatures if bundled fonts aren't availableTomaž Vajngerl
Change-Id: Ie644e605f749a486ba4590d1ec2a9536a06c9847
2018-06-21take the surface directly from the SvpSalVirtualDeviceCaolán McNamara
Change-Id: I5e0d46fa863a9a74063063cc3d22ea15d2544d8b Reviewed-on: https://gerrit.libreoffice.org/56208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-21merge GenericSolarMutex and SolarMutexNoel Grandin
Since nothing else is implementing the SolarMutex abstract class. Change-Id: I2a41254af3e9c7534033cdd0bece9dd8e0258b9d Reviewed-on: https://gerrit.libreoffice.org/56153 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-21use more OutputDevice::GetBitmapExNoel Grandin
instead of GetBitmap Change-Id: Ib43cfaf3c91968d623e5a24f44539368da28d36f Reviewed-on: https://gerrit.libreoffice.org/55190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-06-20show down arrow in GtkMenuButtonsCaolán McNamara
Change-Id: I6468474110adfc477927f6d89b44e92d29384484 Reviewed-on: https://gerrit.libreoffice.org/56164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20Add UI test for the Customize dialogMuhammet Kara
Change-Id: I00109ef54ec7cfc1f4976794daa92ded3cd6ce4b Reviewed-on: https://gerrit.libreoffice.org/53119 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-06-20weld SvxColorTabPageCaolán McNamara
Change-Id: I5dc6f949edcb34aa110dfa9415e2ac886d0dfa4c Reviewed-on: https://gerrit.libreoffice.org/56111 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-20forcepoint: rework to explore loopCaolán McNamara
Change-Id: I14f6a3269fc3347a9976d899519e74f58d5975c8 Reviewed-on: https://gerrit.libreoffice.org/56125 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-19tdf#103913 keep ".emf" file extension and mime typeLászló Németh
in documents, don't change them to wmf and image/x-wmf silently, resulting for example, dropping or rejecting modified documents by firewall packet filtering. Change-Id: I3b8634ae022c7c026b0ed4ebc345c1c3b3f96337 Reviewed-on: https://gerrit.libreoffice.org/56045 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-06-18loplugin:{implicitboolconversion,salbool}Stephan Bergmann
Change-Id: I795a50241b9d77127b5ee5558e0cd706e0fdb76b
2018-06-18weld SfxSecurityPageCaolán McNamara
and drop the sole use of WB_EARLYTOGGLE Change-Id: I01e7d085eb3f9daf5a62a048178ab90defb4c5b1 Reviewed-on: https://gerrit.libreoffice.org/55983 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-06-18VCLKDE5Application is now unused as wellKatarina Behrens
Change-Id: Ib11274b6039596246aa232b83fa4d85095a93e08
2018-06-18Drop cargo-cult FPServiceInfoKatarina Behrens
FILE_PICKER_SERVICE_NAME wasn't even used anywhere Change-Id: Ie99de85175b8321948612c680c4e4d956a4c7efc
2018-06-18Fold all the rest into KDE5FilePicker2Katarina Behrens
Change-Id: Icbaa56057776ffcb981207ec30e5d94d6901e43c
2018-06-18Drop winId and KWindowSystem::setMainWindowKatarina Behrens
as fpicker isn't a separate binary anymore Change-Id: I9c9c57a21f5dc79714f37f8bc65b998887c29e78
2018-06-18Fold enableFolderMode into ctorKatarina Behrens
Change-Id: I8674395271b83d9c50477bdf0242cd9f46af7a30
2018-06-18Fix suggesting file name (for new documents)Katarina Behrens
Change-Id: I39eb672f7dd097e12ddb323ce702c6c28235b5d9
generated by cgit (git 2.34.1) at 2025-01-29 00:00:23 +0000