summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-07-15coverity#1437953 Unchecked dynamic_castCaolán McNamara
Change-Id: I7f9e000cb47206444c4bda0896f56d220d86f04b Reviewed-on: https://gerrit.libreoffice.org/57456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-15tdf#118377 Do not use disposed OutputDeviceArmin Le Grand
Change-Id: I7e085f69ce18e8e3c47fde690a939948454d4d15 Reviewed-on: https://gerrit.libreoffice.org/57319 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-07-13Inaccurate symbol signs fixed (tdf#118381)Thorsten Wagner
Change-Id: I2af1d3e4c924acd2ae601f0b40fcf1b2be17c397 Reviewed-on: https://gerrit.libreoffice.org/56426 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-07-13merge IUndoManager into SfxUndoManagerNoel Grandin
SfxUndoManager is the only implementation of the IUnderManager "interface", and it lives in the same header. Plus this way we can get rid of some covariant parameters, which will make using std::unique_ptr easier. Change-Id: I6661b9876b18da830bead78794d237886cd3c5c9 Reviewed-on: https://gerrit.libreoffice.org/57317 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-12uitest logger: log key according to DSL inside dialogs tooSaurav Chirania
Change-Id: I30cfbf7ba87dda43ecb75ffd5f69253d77b6a00b Reviewed-on: https://gerrit.libreoffice.org/57233 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-11font feat: prioritize Graphite descriptions, use UI lang., fixesTomaž Vajngerl
When collecting font feature description do prioritize Graphite collected descriptions over OT. This is important for descriptions for ssxx and cvxx only contain general description and not what exactly they do. When collecting for Graphite use the UI language for descriptions. Fix gathering the descriptions with graphite to include all of the descriptions available. Change-Id: I6b3b92eb160fc3fd70214edf0d37095865f9c563 Reviewed-on: https://gerrit.libreoffice.org/57250 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-10Bitmap cursors contain XBM data, read them accordinglyKatarina Behrens
Change-Id: I8d5cf48fb37db8e6e5c8058f92b69659838f3471 Reviewed-on: https://gerrit.libreoffice.org/57229 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-07-10tdf#118661 LibreOffice remains in background after closing itNoel Grandin
regression from commit d0f44d8ba7e87aa263008d3cfc4e68294d783162 tdf#84323 - sal - add sane sleep interface: cleanup osl_waitThread Change-Id: I55c2fa6c8993cc6268b1c5d9331c665c401e8efe Reviewed-on: https://gerrit.libreoffice.org/57228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-10Revert "tdf#117517: Fix OpenGL text rendering on Windows"Jan-Marek Glogowski
This actually breaks the OpenGL glyph cache, which forced a full redraw all the time working around the original problem, which is now fixed with commit fad862e290d727fc9fefe206f6e4b807482c4175. This reverts commit c5f8a296fcfc08f8ac441cb8300a7565caa50b53. Change-Id: Ibfc5a24dfc157c42b4cf796b35101191e88a6d15 Reviewed-on: https://gerrit.libreoffice.org/57221 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-07-10pass SvStream around by std::unique_ptrNoel Grandin
and give utl::OStreamWrapper a new constructor so that it knows it is taking ownership of the SvStream, which appears to fix several leaks Change-Id: Idcbcca9b81a4f0345fd8b8c8a2f4e84213686a6b Reviewed-on: https://gerrit.libreoffice.org/57187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09WIN GetFontMetric doesn't matter for GetEmbedFontDataJan-Marek Glogowski
so there should always be a valid mpWinFontEntry[nFallbackLevel]. Change-Id: I27f7a5a72c50d10a88538d02f1510f583ae6df35 Reviewed-on: https://gerrit.libreoffice.org/57192 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-07-09tdf#118555 fix HFONT fallback handing / lifecycleJan-Marek Glogowski
Instead of storing the never changing DC in the WinFontInstance store the HFONT, which is Windows logical font instance. Then set the correct HFONT instance from the layout when rendering its text. This also changes the HFONT ownership and lifecycle. The HFONT is moved from the mhFonts to the WinFontInstance, if available, so it has a proper referenced lifecycle. The mhFonts is still needed, as embedded font just supply an HFONT and no WinFontInstance. Change-Id: Iba62281c710290276f004f0c0177e6d37c849d2c Reviewed-on: https://gerrit.libreoffice.org/57101 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-07-09tdf#112690: make page size of exported PDF closer to what is setAron Budea
regression from 3a2ccb419c5face6fbf56b1a4877e675d4cd5fe8 Change-Id: Ia0fddeb112fa0867ec367c085e3682eac078d5f8 Reviewed-on: https://gerrit.libreoffice.org/57166 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-07-09Implement reading screen count and screen geometryKatarina Behrens
this improves restoring window location should it be within the secondary screen Change-Id: Iaac6bcead6bfcb7ae9eda579e5a4ad6b2482cc39
2018-07-09Basic Qt5 system display dataKatarina Behrens
copied from dummy headless implementation Change-Id: I1b184745627acd065b4c0cc54f044c47ec980c93
2018-07-09Don't draw focus around checkboxes and radiobuttonsKatarina Behrens
it is drawn separately around cb/rb's text Change-Id: I22737944048c4d501ba4dc5416fa79d4d081e91c
2018-07-09Try to move adjusting focus rect down to gtk3 codeKatarina Behrens
as it makes the focus rect look oddly shifted for kde5 widgets Change-Id: Ia42ccf30207a8c804d23ba45870d839f94c3f858
2018-07-09Conserved the alphabetical order in contexts.Kshitij Pathania
ThreeDObject is remained on top as its entry begin with 3. All others are sorted now except the generalised ones in last. Change-Id: Id56550da450f0d2a0dd770a78360d20ada90f048 Reviewed-on: https://gerrit.libreoffice.org/56984 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-09Don't unload VclBuilder modules on shutdownJan-Marek Glogowski
Prevents crashing the CppunitTest_smoketest on Ubuntu Trusty. Probably this should be a subclass in osl:: with a proper virtual destructor. The release() function is actually called for a lot of osl::Module handling all over the code. The alternative would have been a custom allocator for the map. Change-Id: I10b86587556056b7080d0d04a27f07dbb8ca4d48 Reviewed-on: https://gerrit.libreoffice.org/57067 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins
2018-07-09loplugin:oncevarNoel Grandin
Change-Id: Id295dc0db174a448ef73db9de34f2de07d47f09a Reviewed-on: https://gerrit.libreoffice.org/57108 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-09uitest: test for ui elements children firstMarkus Mohrhard
Change-Id: I837721533bc40cea55cbccaa14e1f14686aa3e3a Reviewed-on: https://gerrit.libreoffice.org/57165 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-08cppcheck: useInitializationList in settings.cxxJochen Nitschke
and remove some default-able constructors Change-Id: I3ff5cb9d68143bb13a362383255da98f7bf6bd86 Reviewed-on: https://gerrit.libreoffice.org/57135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08tdf#84323 - sal - add sane sleep interface: cleanup osl_waitThreadKevin Dubrulle
Replace osl_waitThread by osl::Thread::wait. Use std::chrono instead of TimeValue. Change-Id: I71691d014feeeb0c5d0ba29d048bda8e25e6e7dd Reviewed-on: https://gerrit.libreoffice.org/57130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-08Fix typoAndrea Gelmini
Change-Id: I1cc4544e807d7c04aa171358ccd1c204040dff55 Reviewed-on: https://gerrit.libreoffice.org/57078 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-07Drop TEST_FONTS_MISSING for HAVE_MORE_FONTSKhaled Hosny
TEST_FONTS_MISSING is just adding confusion since it tests for hardcoded font names, while what we really want (most of time) is to check whether bundled fonts are enabled or not, and HAVE_MORE_FONTS just does that. Change-Id: I1b00d359c37fa49584ca27c319d6d0e937c3b20b Reviewed-on: https://gerrit.libreoffice.org/57136 Tested-by: Jenkins Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-07-07uitest: complete wrapper for SpinField and SpinButtonSaurav Chirania
Change-Id: Ibd28b656792018087478a3c6fb5f5f7ac6686131 Reviewed-on: https://gerrit.libreoffice.org/56813 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06WaE: -Wunused-variableThorsten Behrens
Change-Id: I58f012ddc2c5030b0e3e215b9cab4e89abf06c2b Reviewed-on: https://gerrit.libreoffice.org/57066 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-06uitest logger: log the events calling CallEventListeners()Saurav Chirania
Some events directly call CallEventListeners() instead of calling ImplCallEventListenersAndHandler. This patch thus moves logAction to CallEventListeners() Further, this patch adds logging for EditSelectionChanged which is broadcasted using CallEventListeners(). Change-Id: Ib15367688cdbcdb542f6139d270d8d463f214fde Reviewed-on: https://gerrit.libreoffice.org/56952 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-06loplugin:externandnotdefined + loplugin:unreffunJan-Marek Glogowski
Change-Id: I364cfdb3b26096d986b651bd3e0673fa3dbf5f83 Reviewed-on: https://gerrit.libreoffice.org/57039 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-07-06various loplugin in qt5Noel Grandin
loplugin:includeform loplugin:staticaccess loplugin:loopvartoosmall loplugin:redundantcast Change-Id: Ibd4848f0c6076d5ae95fff2853e1f6e0ba1c083b
2018-07-06Qt5 use fontconfig for font substitutionJan-Marek Glogowski
This just shoves all known fonts from the PrintFontManager into the QFontDatabase. Can be disabled using SAL_VCL_QT5_NO_FONTCONFIG. It already feels slow - don't know. Running "./bin/run vcldemo --show text" you can see it has some pro and cons, regarding the output. Qts' diacrits look definitly nicer then the "substitutions". This brings the font support kind of on par with the other backends. And since sensible font substitition is not at all implemented in Qt, we have to rely on some platform ssolution anyway. And this needs a sensible, platform agnostic interface, so we can reuse the code easier. Change-Id: I4e9d8ee98fc479a7c4bbe4c968116e0a102ebb7a
2018-07-06Qt5 multiple small fixesJan-Marek Glogowski
* just assert palettes, which are larger then the bitmap support; smaller then maximum palettes are ok * 1bit images are encoded by the most significant bit (N1BitMsbPal) => adapt the alpha mask decoding * drawLine update height and width need an additional pixel * drawn objects can be filled *and* have an outline * show cairo usage in about dialog Change-Id: I301708386feb3cc1c86b27f47f0e76594a1e7357
2018-07-06Qt5 implement invert for blinking cursorJan-Marek Glogowski
The different modes are quite probably not correctly implemented, as multiple backends disagree here. Change-Id: I08fc3096487ca95f4905ae9f0e4b5d3897fca483
2018-07-06Qt5 implement scaled image drawsJan-Marek Glogowski
If the source and target rects don't match, LO expect the image to be scaled. Change-Id: I337acfa56600eba92c10aed7a70749ad08c03e90
2018-07-06Qt5 implement 4bit => 32bit bitmap conversionJan-Marek Glogowski
Some of the PNG icons are 4bit palette based PNG images. This implements the conversation function for the most common 4bit case, so we don't rely on some generic handling. All other non-4bit conversions can be handled by Qt. Change-Id: I4ddd744fb7166fc3a6992b6be6c250c2adb99ca5
2018-07-06Qt5 flesh out font handlingJan-Marek Glogowski
Fills some more FontAttributes based on the QFont. Also implements initial font rotation support. Something is still strage with the vertical font in Writers vertical ruler. Text looks correct in vertical text boxes FWIW. The toRectangle bug is embarrassing; I was wondering for quite some time, which glyphs had strange size rects :-) While at it, move the Qt5Font header to vcl/inc/qt5. Change-Id: I67fa400486981035be6f98c5ab56e82d69c42065
2018-07-06Some cleanup and commentsJan-Marek Glogowski
Change-Id: Ic1dda9b0e5d7896703b65d0d43be340196bcb871
2018-07-05FontFeatureTest set weight/italcs explicitlyTomaž Vajngerl
Font featrues can depend on the state. To make the state more stable we need to set the the font properties explicitly. This sets the weight, italics, width type to "NORMAL", which changes the number of available features. Change-Id: Ida6be4191762c3acfeb7b95182b80717e9774c62 Reviewed-on: https://gerrit.libreoffice.org/57011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-05Honor border width in a welded color picker for gtk3/x11Maxim Monastirsky
Change-Id: I1b59e85edb8e9df5be453dc0be1d7d1ffd100ceb Reviewed-on: https://gerrit.libreoffice.org/56996 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-07-05vcl: experiment for font related test fails on WNTMichael Stahl
Change-Id: I7471299c1f0d4c0431e9b896cd2fbf5a056f31f8 Reviewed-on: https://gerrit.libreoffice.org/56892 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-04Notebookbar:Context for printpreview is now workingKshitij Pathania
Also the context stuff is now working well even after print preview is set Change-Id: Ia43f512394cf4d162b4019257c039aecb664df22 Reviewed-on: https://gerrit.libreoffice.org/56740 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-07-04Make ThreadPool::pushTask take param by std::unique_ptrNoel Grandin
And fix leak in XclExpRowBuffer::Finalize, was not freeing the synchronous task it creates Change-Id: Id1e9ddb5d968e6b95d9d2b5ca0c9e50774580182 Reviewed-on: https://gerrit.libreoffice.org/56874 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-04tdf#115718 Fix Watch Window EditBoxAlex McMurchy1917
For KDE4 only: this change reintroduces QStyle::PE_PanelLineEdit for the EditBox/LineEdit widget. This allows the contents of the Watch Window EditBox to be amended as one would expect. Change-Id: Iffd7498d5f553ac0c9c612bf36b9f23d9eb8f86d Reviewed-on: https://gerrit.libreoffice.org/56447 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-03vcl: fontfeature test, decalre fonts the same was as in sw testsTomaž Vajngerl
Change-Id: If1b3e658c30d1ae0e254ed7d8035d107bd2892f7 Reviewed-on: https://gerrit.libreoffice.org/56900 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-03tdf#115671 vcl opengl: fix drawing of polylines with duplicate pointsMiklos Vajna
The bugdoc had a custom shape, the interesting part of it was a triangle with miter line join, where the last segment was missing. In that case RenderList::addDrawPolyLine() mishandled the polyline, as it does not expect duplicate points in it. Change-Id: I06d5c2d191bb6269a87da1f006f27a94205f5145 Reviewed-on: https://gerrit.libreoffice.org/56879 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-03Draw button focus so that it doesn't obscure the actual buttonKatarina Behrens
Change-Id: I0df51b8dfd75dd966639d0893c379f2038c949ff
2018-07-03Use cairo's OVER operator to preserve transparencyKatarina Behrens
Change-Id: I1afae266a5308fa0dbf2488777ddb963e99199c7
2018-07-03Implement native modality for modal dialogsKatarina Behrens
instead of hack with hiding the window and showing it again (otherwise modality change has no effect and worse yet, weird things happen) it would be much easier to use QDialog Change-Id: Ie7029ca66380495c4aad246d02f4b96cb55eb01e
2018-07-03Traversing dialog controls backwards (Shift-Tab) works nowKatarina Behrens
Change-Id: If0e8d7307dd37436751e524d7ed24e89d5b72db3
2018-07-03Ignore closeEvent if user has vetoed closing the frameKatarina Behrens
Change-Id: Ib86ec0d297e23c02ad50ce1044859e029eae2ba9
generated by cgit (git 2.34.1) at 2025-01-27 14:36:49 +0000