summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-07-30Related: rhbz#1602589 rework to avoid bogus cppcheck double free warningCaolán McNamara
Change-Id: Ie673de68f39b903536c2287b8989fe6afcc9fd66 Reviewed-on: https://gerrit.libreoffice.org/58307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-30fix OT font feature description ssxx and cvxx mixupTomaž Vajngerl
Change-Id: I20e169fede237e4760f8be905e70a3ed964c402f Reviewed-on: https://gerrit.libreoffice.org/58305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-30make DBG_TESTSOLARMUTEX available in assert buildsNoel Grandin
where our QA people are more likely to trigger it Change-Id: I4ce7c8c72e7e21f2296c0f9cc9f019aaef32ed0b Reviewed-on: https://gerrit.libreoffice.org/58170 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-29more windows tinderbox fixNoel Grandin
Change-Id: Ie17b27f89c3c6d2fb43b869985febd18921a99f0 Reviewed-on: https://gerrit.libreoffice.org/58259 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-28uitest: support parameters when sending UNO commandsSaurav Chirania
This patch introduces a new function to send parameters with UNO commands in UI Tests and adds a test which uses the function to change the color of text in writer. Change-Id: Ic687872ab826b50360e1bd042d9668a9f6ddbf63 Reviewed-on: https://gerrit.libreoffice.org/57857 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-07-27tdf#118966 vcl: add a flag to determine if AA of fonts is used from the systemMiklos Vajna
This is on by default (as there are loads of vcl users who expect font AA working even if the default is off and they don't enable it), but the svx UnoGraphicExporter disables it to make everyone happy. The reason in practice AA was on by default is that the gtk backend uses the system settings in GtkInstance::GetCairoFontOptions() (and not the AA setting from the UI), and lclGetSystemTextAntiAliasMode() does the same on Windows (at least in the direct write case). So now these defaults again have higher priority than leaving the vcl-level default unchanged. Change-Id: I81267c0b036211525ac02d3282fa89d75510f4a8 Reviewed-on: https://gerrit.libreoffice.org/58199 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-27loplugin:returnconstant in vclNoel Grandin
Change-Id: I597ef6d75d1c21cdc15a91bf7f549bc14c851506 Reviewed-on: https://gerrit.libreoffice.org/58086 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27loplugin:stringloop in vclNoel Grandin
Change-Id: I086a809b6541041b627daa93f9a08be2a9218550 Reviewed-on: https://gerrit.libreoffice.org/58117 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-27Related: rhbz#1602589 silence coverity copy_paste_errorCaolán McNamara
Change-Id: Idca4bfaaa9f127eae87ae879e2131aed747ce4b3 Reviewed-on: https://gerrit.libreoffice.org/58089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-27vcl: avoid -Werror=deprecated-copy (GCC trunk towards GCC 9)Stephan Bergmann
...by explicitly defaulting the copy/move functions (and, where needed in turn, also a default ctor) for classes that have a user-declared dtor that does nothing other than an implicitly-defined one would do, but needs to be user- declared because it is virtual and potentially serves as a key function to emit the vtable, or is non-public, etc.; and by removing explicitly user- provided functions that do the same as their implicitly-defined counterparts, but may prevent implicitly declared copy functions from being defined as non- deleted in the future. (Even if such a user-provided function was declared non-inline in an include file, the apparently-used implicitly-defined copy functions are already include, so why bother with non-inline functions.) Change-Id: Ife5d8eb699b8b6c84b9229ae275dc386fa189bce Reviewed-on: https://gerrit.libreoffice.org/58105 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-26Related: rhbz#1602589 silence coverity leaked_storageCaolán McNamara
Change-Id: Iae694be40b32cc3821d326bb362e6091dba19a35 Reviewed-on: https://gerrit.libreoffice.org/58079 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26skip checking png block crcs when fuzzingCaolán McNamara
Change-Id: If4671f7db2afb46dc68aa7a8a92c509e1735ab9f Reviewed-on: https://gerrit.libreoffice.org/58051 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26vcl cairo text renderer: support non-AA textMiklos Vajna
Non-AA lines were already working, but text was always anti-aliased. (Use-case is reference bitmaps in a testsuite, where AA just makes it harder to determine if the expected and actual rendering output match.) Change-Id: I7c5ab4c80675e1a523d67b71f3cd3cbc9c6416c3 Reviewed-on: https://gerrit.libreoffice.org/58035 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-26weld SwTextGridPageCaolán McNamara
Change-Id: I4f8e5f643126bea5deef7636b6d20f8080cb6662 Reviewed-on: https://gerrit.libreoffice.org/56309 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-26tdf#118860 svx opengl: avoid SalBitmap creation without solar mutexMiklos Vajna
The bugdoc has 2 slides. When switching to the second slide, the graphic is loaded in the background, but OpenGLSalBitmap::Create() can't work correctly if the caller doesn't own the solar mutex. This already asserts in OpenGLContext::prepareForYield() in a less obvious way. Focus on the correctness, so just hold the solar mutex during the whole ImportGrpahic() call. If it turns out that the purpose of running this on a thread is to avoid synchronous network traffic, then the data could be first copied to a memory stream, and only then take the lock + import the graphic. Change-Id: I88203c12b4e7a5f2b689928c01e2ba953c5b13c5 Reviewed-on: https://gerrit.libreoffice.org/57970 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2018-07-26Missing includes (Windows --disable-pch)Stephan Bergmann
Change-Id: Iea067e3529de9208bd0a00c276eb03858816bd00 Reviewed-on: https://gerrit.libreoffice.org/57996 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-25-Wc++11-narrowing (clang-cl)Stephan Bergmann
...from 'int' to 'FLOAT' (aka 'float') Change-Id: I999fc322d0ace0d32c675a22337077d7a95eed3c Reviewed-on: https://gerrit.libreoffice.org/58006 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-25loplugin:sallogareas (clang-cl)Stephan Bergmann
Change-Id: Id3f41fe72487a1e38ead75c8df6307edd1c3ccab Reviewed-on: https://gerrit.libreoffice.org/58005 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-24GetCharWidths always returns trueCaolán McNamara
Change-Id: I4a58b203a7c18484c3405f918e77297ac764725d Reviewed-on: https://gerrit.libreoffice.org/57925 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24split buffers to clarify what it doesCaolán McNamara
Change-Id: Id7888d2e2ef1cdf21af4247207c2b0dda0aa3823 Reviewed-on: https://gerrit.libreoffice.org/57926 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24forcepoint#53 restrict to expected index rangeCaolán McNamara
Change-Id: I22f01e5a3e3cf51b014ac841cd14071dce5baf0f Reviewed-on: https://gerrit.libreoffice.org/57920 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-24Fix typosAndrea Gelmini
Change-Id: I07cf04cd2acc5b50d64224edb9f2c2de2c61e356 Reviewed-on: https://gerrit.libreoffice.org/57884 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-24Fix typoAndrea Gelmini
Change-Id: I2f9f532890bedf4aa3d86bf2aa4b6961846a915a Reviewed-on: https://gerrit.libreoffice.org/57886 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Fix typosAndrea Gelmini
Change-Id: If0d8f4033d9bc20f521d33d732fb349f0df5eeef Reviewed-on: https://gerrit.libreoffice.org/57822 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-23Qt5 just release the SolarMutex for Qt eventsJan-Marek Glogowski
Just like the other backends, just release the SolarMutex when processing Qt events and keep it for user events. Change-Id: I0c4a7149f1541607b546a99e51e790836bc9b2f9 Reviewed-on: https://gerrit.libreoffice.org/57844 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-07-23loplugin:unnecessaryparenStephan Bergmann
Change-Id: Ie28001cf1eb5259f479caecdfb50355f98b80b7f
2018-07-23Avoid deadlock in case of events not driven by the userKatarina Behrens
e.g. progress bar updates. Release and re-acquire SolarMutex Change-Id: Ie4e12fed7b2b8ee9bcb163334d82e466025cb7fa Reviewed-on: https://gerrit.libreoffice.org/57780 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-23tdf#118453 Reactivate navitagor submenu drag mode and displaySalimHabchi
I add a function to get the data from the submenu Change-Id: If8aedc72abfc7ca967377f0e588167f9f62fe137 Reviewed-on: https://gerrit.libreoffice.org/57269 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-20Fix typosAndrea Gelmini
Change-Id: Ia3e6f17217b837517faa588ea7f2e72dc5aff6aa Reviewed-on: https://gerrit.libreoffice.org/57767 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-07-20implement pdf export of underline for outlined fontCaolán McNamara
just the simplest case of a straight solid line which is outlined, i.e. border in font color and filled with white Change-Id: I7d670a543475b6457cb2827e74a05bba6c4a91ea Reviewed-on: https://gerrit.libreoffice.org/57778 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-20undef more vcl_font_feature test on windowsNoel Grandin
Change-Id: If8697d13b8fa87fd07e8fef9cb6fdcb0f444fa71 Reviewed-on: https://gerrit.libreoffice.org/57775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-20Fix typosAndrea Gelmini
Change-Id: I1048bea42c66b81244021aa2188e5dfe2ce6e83d Reviewed-on: https://gerrit.libreoffice.org/57768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-19Fix typosAndrea Gelmini
Change-Id: Id31aa22a98f7520a37e624cbb1dc4d949246c0fb Reviewed-on: https://gerrit.libreoffice.org/57622 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-19Fix typosAndrea Gelmini
Change-Id: I2aa5448869bf60e9c8d9b1ebabd0d0932d28f3a1 Reviewed-on: https://gerrit.libreoffice.org/57606 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-19tdf#108012 - Clicking in the font field should select the contentsNickson Thanda
Change-Id: I1276976e031b419ca5cc3cc8e848f2af58ce4cfb Reviewed-on: https://gerrit.libreoffice.org/56865 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-07-19loplugin:constantparamNoel Grandin
Change-Id: I8e2e9009f0a70d2fa390e03688a988ac935d5f36 Reviewed-on: https://gerrit.libreoffice.org/57643 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-19loplugin:unusedmethodsNoel Grandin
Change-Id: I2b7a055a44c63bfc072b82580811898e177fbb8e Reviewed-on: https://gerrit.libreoffice.org/57628 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-18Resolves: tdf#118802 map GTK_RESPONSE_DELETE_EVENT to RET_CANCELCaolán McNamara
Change-Id: I8285f329e4672c90f47d96ccffe60c21c565dde7 Reviewed-on: https://gerrit.libreoffice.org/57655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18lokdialog: no invalidation when in init showPranav Kant
This improves LOK dialog opening time considerably. libreofficekit/tilebench results: Before: profile run: initialization - 346.5185(ms) load document - 2162.5881(ms) open dialog - 7077.8980(ms) wait for dialog - 52.7742(ms) render dialog - 256.9597(ms) post close dialog - 523.7811(ms) destroy document - 58.3723(ms) Total: 10.4789(s) After: profile run: initialization - 336.5867(ms) load document - 2155.5481(ms) open dialog - 1151.4130(ms) wait for dialog - 51.5332(ms) render dialog - 260.3197(ms) post close dialog - 519.8729(ms) destroy document - 56.7322(ms) Total: 4.5320(s) Change-Id: I6345aca33c5881aba33c8a5f74765b99fe098711 Reviewed-on: https://gerrit.libreoffice.org/57561 Tested-by: Jenkins Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-07-18Fix typosAndrea Gelmini
Change-Id: I5195d13b351c0eebad1eae901f7ce8408a9e5c92 Reviewed-on: https://gerrit.libreoffice.org/57028 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-07-18only ellipize menubutton label when requesting narrower sizeCaolán McNamara
Change-Id: I32f4856756910ec1db8d37854b6e57dbec5aae76 Reviewed-on: https://gerrit.libreoffice.org/57617 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18Resolves: tdf#118604 only use popover workaround for popovers, not menusCaolán McNamara
Change-Id: I7982a3836fbf699979beaa70e34bfa38aea80462 Reviewed-on: https://gerrit.libreoffice.org/57615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-18No parent-child relationship between Qt5WidgetsKatarina Behrens
QWidget destructor always deletes all its children, which is fatal in case not-yet-deleted frame (e.g. because it's in lazy delete queue) points to one of those children There's parent-child relationships between the frames though, so perhaps no need to have it double. For native modality this seems enough Change-Id: I556ace8d7949bcdfb208170cc08181ac1f2622e8 Reviewed-on: https://gerrit.libreoffice.org/57560 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-07-18Resolves: tdf#118302 drag n drop to same tab should cancel dndCaolán McNamara
dropComplete is used to do this, follow the mac pattern here to propogate this in the drag and drop from self to self case. Maybe this also affects tdf#105320 ? Change-Id: I2b8f8b0e0486f6ee45a65918fae2537750a75f2d Reviewed-on: https://gerrit.libreoffice.org/57589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17Resolves: tdf#118801 icons go missing on text-less buttonsCaolán McNamara
Change-Id: I003a59643518e60948d71b335dfcd7e20ba8fee5 Reviewed-on: https://gerrit.libreoffice.org/57572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-17loplugin:useuniqueptr in PrintFontManagerNoel Grandin
Change-Id: I539e167b0b9d3523d50cbebc13227867c5f05bd5 Reviewed-on: https://gerrit.libreoffice.org/57515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-17loplugin:useuniqueptr in PPDParserNoel Grandin
Change-Id: Id7ffe7967d2b6a7f394a4e096c04218c10aeda37 Reviewed-on: https://gerrit.libreoffice.org/57514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16try to make the windows tinderboxes happierNoel Grandin
at the moment about 1 in 10 builds fail Change-Id: I29ada5555170bf7c3f603b684ab4dc7b1932c44c Reviewed-on: https://gerrit.libreoffice.org/57491 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-16move freeze/thaw to WidgetCaolán McNamara
Change-Id: I3944092c26ca81028912f6fb206b148b49e4f172 Reviewed-on: https://gerrit.libreoffice.org/57489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-07-16cppcheck: useInitializationList in vclJochen Nitschke
reorder members of GIFLZWDecompressor to ease initialization. use rtl_allocateZeroMemory in ImplVectMap to avoid memset in ctor. Change-Id: Icfcfe73ec7e52988036995d8dbc604361aee893b Reviewed-on: https://gerrit.libreoffice.org/57481 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
generated by cgit (git 2.34.1) at 2025-01-27 00:59:25 +0000