summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-08-04loplugin:simplifypointertobool (clang-cl)Stephan Bergmann
Change-Id: I6512e6e4217ef9084c74e46e3b4f1e8defbd1bec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100108 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:elidestringvar (clang-cl)Stephan Bergmann
...plus ensuing loplugin:unnecessaryparen in vcl/source/treelist/transfer.cxx Change-Id: I1abf2e0c589c2c124399c1337f5dd703ee7d04a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100094 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04Improved loplugin:staticanonymous -> redundantstatic redux, clang-clStephan Bergmann
Change-Id: Ie6dc22edbcfdf05ab8d7d668cb7cc33b5b747995 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-04loplugin:unusedmethodsNoel Grandin
Change-Id: I5fa2bbeff17a9933ff55afb0c3544d025d096a63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vclNoel Grandin
Change-Id: I271cc67ecf34acbf0edbda960e33315fb6a1f9dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vcl/gdiNoel Grandin
Change-Id: Ief1736264e62acfac3a9a83c54dc564c03d6fba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100034 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vcl/windowNoel Grandin
Change-Id: I94e69e988f038e85b1fb78985211d478bb5ed9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100033 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-04loplugin:flatten in vcl/unxNoel Grandin
Change-Id: Ib9df009a51db1ed96c6eea7bda68e288755e7a56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100032 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-03ofz#24648 fix slkfuzzerCaolán McNamara
Change-Id: I3dce445038a29a622ceea2415e7736768a95206d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100029 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-03tdf#42949 Fix IWYU warnings in include/[t-x]*/*hxxGabor Kelemen
Recheck after 7-0 branchoff Also drop the now unused file include/vcl/field.hxx Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9e54c82f50d1e02a0f99858939cac999fc66f7de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-02Fix typoAndrea Gelmini
Change-Id: I298d8c5aac6e340fb4d5c753abbd8fa80ffc9408 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99962 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-02Make gtk's get_sort_order return the same as the vcl's oneMaxim Monastirsky
Change-Id: Ia6584b268cb7b53423c7ac3d353e07409e9a5dac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99952 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02tdf#135368 change the mnemonic to point to our combobox replacementCaolán McNamara
Change-Id: Ib53b787399954e5be7e4b4080366fe64cc937de3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99958 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-02Revert "android: avoid expensive load of un-used sidebar icons on mobile."Jan Holesovsky
Unfortunately we need this on Android for the tablets, otherwise the sidebar lacks the icons. Also it is not easily possible to use the isLOKMobilePhone() check here, because that is per-view in general, and handled in sfx in particular, making it hard to use here in vcl. This reverts commit 9a38b194eec5bcf6cb8d073e5d35173c5856f28f. Change-Id: I2b599e884ad4d00b7c246743c180a5324c9a143d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99300 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-08-02tdf#133564: Text coloring of buttons within non key windows on macOS amendedThorsten Wagner
Change-Id: I815fcf82440a7e5d14ae457cc659a5fe6a9f8c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99946 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-01tidy up language a bitCaolán McNamara
Change-Id: I3bc840da190e50f03bbd1cc57f49fbdb809e4be5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-01tdf#135325 previews missing content drawn via DrawTransformedBitmapExCaolán McNamara
Typically in these OutputDevice methods, the record-to-metafile case the MetaFile is already written to before the test against mbOutputClipped to determine that output to the current device would result in no visual output (due to the output being outside the bounds of the device). In this case the metafile is written after the test, so we must continue past mbOutputClipped if recording to a metafile. It's typical to record with a device of nominal size and play back later against something of a totally different size. Change-Id: Id1249b10f919165582f7de65b4cdc4d48074abaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99900 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31drop unused SvTreeList::LastSelectedCaolán McNamara
Change-Id: I3c51030b8b7a03d944bdaa5e8bc4fb0f443061f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99892 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31drop some stuff the pptfuzzer doesn't needCaolán McNamara
Change-Id: I647c23bd08bba831759c931a64cdef39b7e9867e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99891 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31transfer any expander or expander toggles when using custom renderersCaolán McNamara
Change-Id: I10857c236c5915ef7dcb08dd42ad1bd499063b89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99872 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31ofz#24521 fix qpwfuzzerCaolán McNamara
Change-Id: Ia9490a07f4567df62cb5a08cb1859390d2a1ca1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99873 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31ofz#24527 fix pptfuzzerCaolán McNamara
Change-Id: I661bfc42b0e05d9dddd35b21c4074727562e5a0a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99877 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31tdf#135212 Don't crash when unable to create clipboardMichael Weghorn
Gracefully handle the case where the SalInstance returns an empty Reference when trying to create clipboard. Primary selection support on Wayland has only recently been added to the relevant KDE components ([1], [2]), and an empty Reference would be returned for the qt5/kf5 VCL plugin when trying to create create a clipboard for primary selection in a Plasma Wayland session with that functionality not yet being available. Regression from commit 05d286e0065ff1c10e75827ac4726b5a74747128 ("vcl/clipboard: create instances with uno constructors", 2020-07-07). [1] https://invent.kde.org/plasma/kwayland-server/-/merge_requests/15 [2] https://invent.kde.org/plasma/kwin/-/merge_requests/27 Change-Id: Ia9016f56b775003b2ffe81a6f3bf44f411ad39a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99871 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-07-31if the default renderer was editable, make the custom one editable tooCaolán McNamara
Change-Id: Ib4c80560943cff7c65d9eed342e3d5bb9d838e5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99866 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31tdf#135317 avoid reenterenceCaolán McNamara
Change-Id: I79b6c1c2a2503c49a94f6c7ed74286f53ccebd44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99821 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-31add queue_draw to force redraw with custom renderingCaolán McNamara
Change-Id: I19251835ff4d49e6240b322a37df5653db7d1b70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-30make some classes privateNoel Grandin
Change-Id: Icfce56436aafa14fe923b4d35835ed6dee52afba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-29ignore invalid dates like the vcl Calendar doesCaolán McNamara
Change-Id: I6a607936849923bfb7e7db3550ebca3c9083aa8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29tdf#135264: draw to mpAlphaVDev after DrawTransparentNativelyMike Kaganski
Otherwise the transparency is lost for the cases where mpAlphaVDev is used. Change-Id: Ic7b92cb69727dbe8901695ba496878f0ea381826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99694 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-29replace and drop MiscCfgCaolán McNamara
Change-Id: I5ea9e3663fc5d30d725cf18757badb9b9802da18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29drop lines that don't do anythingCaolán McNamara
since... commit 9a4d0581c72653e60562d1b8e2121772d21f8a9e Date: Mon Oct 12 11:49:13 2009 +0200 #i103496#: move SysLocale stuff to unotools Change-Id: I6a7c3d71af7e91f873a2cab3393e8cefdcdff28d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99693 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29allocate bitmap data buffer on demand in SkiaSalBitmapLuboš Luňák
And also make sure mScanlineSize is always correct, which it seems like it possibly might not have been the case (the delayed scaling makes it a bit complicated, as the internal scanline size is based on the internal bitmap size mPixelsSize, not the externally reported bitmap size mSize). Change-Id: I0d6cc2fca27ffa1c3accc13b38c8c01b5ffc8ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99680 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-29sd_component_getFactory no longer existsCaolán McNamara
Change-Id: I78405fc5ddbafa9760644bebaeee4ce4622a6c3b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99679 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-29optimize a bit more conversions to/from Skia bitmap formatsLuboš Luňák
It turns out this doesn't really matter in practice, since if converting between pixel formats is where time is spent, something higher must be already wrong. But since I've already written this... Change-Id: I25451664d529a9226d2d81b2c424a4f4e5422ad5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99577 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-28Resolves tdf#132066 - Localization of special text in about windowHeiko Tietze
Copy all version infos in English Change-Id: I6719e27f721b0ff9f06efb4ea63e286e6d58ebf4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98498 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-27detect small-button class and minimize padding and size in that caseCaolán McNamara
Change-Id: I7db9d765549112e292f60d1cd47002e45f0136b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99517 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27map gtk-new symbol to SymbolType::PLUSCaolán McNamara
Change-Id: Id2fdbc9873377871c929b10e8152151bec02812c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99516 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27make margin-start/margin-left and margin-end/margin-right synonymsCaolán McNamara
Change-Id: I15dc9a87ca0a25d34b1280eb5e776e933a080a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99486 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27tweak not caching images in Skia drawing when upscaling (tdf#132438)Luboš Luňák
The change done for tdf#134237 was meant to avoid caching of very large images when zooming in. But it turns out that it happens quite often that we get asked to draw something larger than the drawing area, such as when scrolling a document with a larger image. So tweak the check to hopefully avoid only huge images or when upscaling a lot. Change-Id: Ifa76e0ef2df78085afc21fd064b77d5b1c9513b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99482 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-27don't duplicate large memory usage in SkiaSalBitmap (tdf#134342)Luboš Luňák
Since SkiaSalBitmap is required to support bitmap formats that Skia itself doesn't support (1bpp, 4bpp, 24bpp,etc.), it needs to store its own copy of the bitmap data and convert to SkImage for use. With huge images this can lead to large duplicated memory usage. Since the code can actually drop the buffer and create it if needed (which it normally is not), just drop large buffers after converting to SkImage. Ideally SalBitmap should be able to say which bitmap formats it supports and VCL code should oblige, which would allow reusing the same data. Change-Id: I98af62a51dde5d738cc8afcdd2fcdc25ff89952f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99476 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-07-27A GtkButton is already sufficient to get mouse eventsCaolán McNamara
Change-Id: Ia61a7906198bf6b6a4ce188d7de9a627c8540af4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99450 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-27tdf#135077 Qt5 revert broken fix for tdf#132172Jan-Marek Glogowski
So I tested a lot of stuff, but missed the missing focus for new dialog windows :-( This is IMHO a far worse problem, then the popup, so just revert the fix. This reverts commit 06fb3e7b7f1079c276ad2f048cd94299b4bd7006. Change-Id: I391ad91ded90e4518ab024572d3f182769b0bcda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99451 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-07-26rename ensureEventWidget to ensureMouseEventWidgetCaolán McNamara
Change-Id: Ibe2d8722dc61c56e762cabb1cecccac8706fb4cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99449 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25move getUIRootDir to AllSettingsCaolán McNamara
Change-Id: I3b7774a043a2c99531e1c76b531df4358699bba7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25cid#1465512 Wrong operator usedCaolán McNamara
Change-Id: Ieda705abc6d49bfa4c611445f0df92a649b77117 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-25inline some use-once constantsNoel Grandin
Change-Id: I1be21b14b550d5ff586b2306f990882e2e649468 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99418 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-25loplugin:unusedfieldsNoel Grandin
Change-Id: Ia2fb09dcd6f266e7eab04fceb893839531ab3e00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99412 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-24block mouse down on GtkTextView getting to toplevel parentCaolán McNamara
making it similar to GtkEntry Change-Id: Ic3621dc308222b2464f0daf919a10b81bc887f6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-24use HasChildPathFocus for composite MultiLineEditCaolán McNamara
Change-Id: I7b7ca3abbc68d6ba1f63245b1aa6925ae70a0dd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99380 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-24add Idle layout timer to InterimItemWindowCaolán McNamara
and queue_resize trigger so if its size doesn't change, but its children's size change that they get re-layed out Change-Id: Ia118547d1eb6e7a87b91f80b54917cd43e3bd8e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99367 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-20 11:51:10 +0000