summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-08-18Fix typosAndrea Gelmini
Change-Id: I85a91d24943430b42217ac91611f182059d8ec69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100919 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-18new loplugin:unusedvarsglobalNoel Grandin
I copied and modified the unusedfields plugin to find unused variables. Change-Id: I18ed6daa202da70a2e564e4fe4760aed7ce070ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-18ofz#24942 missing constructorCaolán McNamara
Change-Id: I481845a3d64cb2ec0749c9a113db09234dc99143 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100912 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-18Dereference of nullptrMike Kaganski
... opening attachment 164348 from tdf#135799 Change-Id: I7d9b38bf34c7120fee39707ed99a0e6e2c2c84e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100878 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17Add test for preserving page number when suappingTomaž Vajngerl
Change-Id: I1a7028d1768d0098aabbbc519d1b7936ddfc4a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100838 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17loplugin:unusedmethodsNoel Grandin
Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17vcl: save and load the page number when swapping the graphicTomaž Vajngerl
PDF vector graphic includes a page number, of the page that the graphic is rendering. This however isn't remembered when swapping out and back in the graphic, because the serialization format doesn't include it. This adds a version 2 of the serialization format, with an additional page number (page index) attribute. Also changes the GraphicTest to account for an additional 4 bytes written and the change of the checksum. Change-Id: Ic0fbfc4ad983f7880e06956da3b4664bd4b610d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100836 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17Related: tdf#135743 position combobox dropdowns correctly for RTLCaolán McNamara
Change-Id: I4f8e70e128fd8506e7f95291226fc52599f15896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17tdf#135743 only overwrite our geometry with the valid entriesCaolán McNamara
Change-Id: I228ebfed17d922704d72529c714fde220b9d20cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17[API CHANGE] remove OSL_SIGNAL_USER_RESOURCEFAILURENoel Grandin
which is unused since commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Date: Sun Jun 11 20:56:30 2017 +0100 migrate to boost::gettext Change-Id: Ia66a3a729dc4999c95b96ae1754b07c372121370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17tdf#135743 ignore size-allocations triggered by an embedded SalObjectCaolán McNamara
getting configured, we already ignored them for painting, do the same for the size-requests it output from our internal configuring Change-Id: I4c0153535459b089ba6c31e3d9f09bfae2545806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17"loplugin:stringstatic also look for local statics" macOS reduxStephan Bergmann
...plus addressing follow-up loplugin:stringconstant when inlining the literals at their sole call sites Change-Id: I727e2d3fe53e85af328afc5fba92e52fb63c49b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100839 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17Use transparent buffer to correctly process transparency in metafilesMike Kaganski
Otherwise the transparency gets converted into b&w mask here before applying the gradient. Required for tdf#134052. Change-Id: Ife00f75024f7d776fdb11e16fcafbd237f07eb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-16loplugin:unusedmethodsNoel Grandin
Change-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:singlevalfieldsNoel Grandin
Change-Id: Ia5d4de61ecf77477e86032b86d67d6ffd011913e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Iafad1df533d5fefd335066427a0fb9e2d8bfa91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:virtualdeadNoel Grandin
Change-Id: Ic002692801113de5778826db5e3faf9869a48307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-15remove constructor with plain Bitmap from Graphic, use BitmapExTomaž Vajngerl
Change-Id: Ie429a10a8f54c6779d437ee4bc75a5ea0c427848 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100727 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-15tdf#125234 Qt5 implement CreateFontSubsetJan-Marek Glogowski
This abstracts the just refactored vcl::TrueTypeFont class, so the Qt5 backend can provide it's own QRawFont based font table access. Change-Id: Ic71bc95bc8fe39bc7a32086d4adc78cfa00d15be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100718 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-08-15Refactor vcl::TrueTypeFont class member accessJan-Marek Glogowski
This hides all members, which are needed to create a new TTF font by calling vcl::CreateTTFromTTGlyphs, and adds an abstraction to access individual font tables. This is needed, because Qt5 just allows access to the raw font based on font tables. Change-Id: I74e34cf1aa2529a06ec5ec53aa2be751e58982ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100717 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-08-14loplugin:simplifybool moreNoel Grandin
look for expressions like !(a && !b) which can be expanded out Change-Id: I72515a9638762b050f9a258c08da39ebfa2ef8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14inline some use-once typedefsNoel Grandin
Change-Id: Ifefdb1ad20d09e257064171e458b2eb33065f5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100733 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-14tdf#135526 ranges overflowing to become negativeCaolán McNamara
the properties panel uses huge min/maxes which can overflow when the number of digits changes Change-Id: Idbb998a065ce8f2b918fceea2076b794cbde3368 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-14tdf#134968: don't forget to draw on mpAlphaVDev in fallback caseMike Kaganski
Change-Id: I6ab8cc8907943c3bb7fd717624ea4ac7c9d4fd5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100711 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-14tdf#135500: always use transparent and clear content vdev in impBufferDeviceMike Kaganski
This removes the only place that hadn't used transparent impBufferDevice yet - in VclProcessor2D::RenderMaskPrimitive2DPixel. Not clearing the vdev made it draw on whatever garbage was left there from previous paints when the buffer was taken from maFreeBuffers in VDevBuffer::alloc, so since this was also the only place left that didn't clear the buffer explicitly, this makes the clear unconditional in impBufferDevice ctor. Also this makes sure to clear proper rectangle in VDevBuffer::alloc, and to clear mpAlphaVDev in OutputDevice::Erase. Change-Id: I7c1c0cc510a92628f19020b3faf0c0cd81f5a599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100674 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-13improve comments around blocks which abort on UI thread event exceptionsNoel Grandin
Change-Id: If3336b8a39e41d958de2e998e3d9467888f2df6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-13loplugin:stringstatic also look for local staticsNoel Grandin
Add some API to O*StringLiteral, to make it easier to use in some places that were using O*String Change-Id: I1fb93bd47ac2065c9220d509aad3f4320326d99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100270 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-12ucb_component_getFactory no longer existsCaolán McNamara
Change-Id: I9c937d5fa0e235de114d8f3962eba0ba3bcb33ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100626 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12tdf#135640 ensure parent rows are expanded on scolling to make a row visibleCaolán McNamara
Change-Id: I37e55ed8d0d3d5916950228ba78982b90356fbc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100606 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12SvTreeListBox can move into toolkit headers nowCaolán McNamara
Change-Id: I6b3b6ef1530a192f4b6bf87aa9688687063683ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100591 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12svlbitm.hxx can be toolkit only nowCaolán McNamara
Change-Id: Ie5ad0febca0747fa66c2caede619d14e468da032 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100498 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-12expand out DELETEZ in vclNoel Grandin
Change-Id: Ibcaef8c5dd057cb9b1711440e5f9da43817078f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-11tdf#135442 min supported version of gtk3 is 3.18 not 3.20Caolán McNamara
Change-Id: Iaa2eefbe08fad3a7dd6eff98bf5fb513053a263d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100532 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11unset CustomCellRenderer instances in dtorCaolán McNamara
Change-Id: I60a5f91df65d1d511ba863ba9a0286c1483314d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100508 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-11tdf#135567 for async case need an alternative check for dialog in executionCaolán McNamara
Change-Id: I326b891b61f8a9848b56b2f26a80af80ab045dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-10tdf#135495 builder file format has annoyingly escaped into user configCaolán McNamara
Change-Id: I38882e2c6e1815ac5fd747642c8934e3e4ca3ffb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100438 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-09block gen's focus in/out callbacks from grab_focus like gtk'sCaolán McNamara
Change-Id: I6102022495f5ffe644b4aa2b71df2fcf4e0a7b6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08loplugin:unusedmethodsNoel Grandin
Change-Id: I58819edd0965ff52c3fc6c20d84bc5951a79bbe2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100381 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-08don't make InterItemWindow a WB_DIALOGCONTROLCaolán McNamara
which means pressing tab searches it children, let it be the target, and it will delegate focus Change-Id: I353ae6b5a6b62c91b844fcd10508f8689db77038 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100298 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-08loplugin:virtualdeadNoel Grandin
Change-Id: Ib2a4ebad50e9c6f0d71a9ac3a1bc8ac11e775496 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100378 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-07cid#1465674 silence Copy-paste errorCaolán McNamara
Change-Id: I5b90774ffae5ee0ce32de1d557bd50f2d6b775cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100293 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07Fix typosAndrea Gelmini
Change-Id: Iedaac490a577d3582ea9ef5a105836eff8c2eaf5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100078 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-07IMnemonicEntryList interface of SvTreeListBox is unusedCaolán McNamara
Change-Id: I56a97d0ef82353aaf3c2ab482c1d782b5dfc8000 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100263 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-07nothing calls EnableEntryMnemonics anymoreCaolán McNamara
Change-Id: I8ef10b4d2f350b4025e46a153766d60510d1b7d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100262 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-06for hover-select require mouse to be really over the rowCaolán McNamara
Change-Id: I67f7e30f87555df8094625e0de3679b0215feb50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100254 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-06uitest : Add support for Menu Button objectsAhmed ElShreif
This will help us test MenuButton like "gear button menu in Tools->Customize" You can test this type of button by excuting this actions: >>var_name.executeAction("OPENLIST", mkPropertyValues({})) >>var_name.executeAction("CLOSELIST", mkPropertyValues({})) >>var_name.executeAction("OPENFROMLIST", mkPropertyValues({"POS": "0" })) Then you can check on it using this lines: >>get_state_as_dict(var_name)["Label"] Change-Id: I189759d9c32237a9a34ee82cfde9611eedff4f3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98996 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-08-05tdf#135330: avoid replacing all settings when enabling IA2Mike Kaganski
Call to ImplHandleGetObject may happen in the middle of any UI operation, including those that make use of references to parts of global settings, like this: const LocaleDataWrapper& rLocaleData = Application::GetSettings().GetUILocaleDataWrapper(); setValue(*m_xCurrentWordFT, rCurrent.nWord, rLocaleData); // < here ImplHandleGetObject may be called setValue(*m_xCurrentCharacterFT, rCurrent.nChar, rLocaleData); If all settings get replaced, then LocaleDataWrapper gets destroyed, and the reference becomes invalid, and crashes in the next line. So first, the change makes the call only modify settings when it's needed; and second, it makes use of the implementation detail that aMisc modifies the shared data. The check after the change will catch if implementation changes so that this is no more true. Yet, the problem stays that using any references to global settings objects is unsafe, since any call to Application::SetSettings will invalidate them. Change-Id: I96d237ee57e80465fe52bc6bb6c149b087c89af9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-05Silence loplugin:staticmethods when the definition involves preprocessingStephan Bergmann
...to help avoid false positives. (Another option to silence such warnings is to add (void) this; to false-positive function bodies, but this new approach may be more natural in certain cases.) Change-Id: Ie6ea908730c596dbfb62ff42ae60dbd0a00a8fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100152 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05loplugin:indentation (--disable-assert-always-abort)Stephan Bergmann
Change-Id: I9f5f60771e7d658e0806428eb1c515ebb6fad6dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100146 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-05document the abort in ProcessTaskSchedulingNoel Grandin
Change-Id: I8a30e9abbf437cdf4f91a14755e5cc639dd172b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99937 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>