summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2019-11-18widget theme: correct sizes of combobox/listboxTomaž Vajngerl
Combobox/listbox was clipped on the right side. Fixed this by increasing the size of the widget by one and moving the button to the right by one pixel. Change-Id: If73e93d0c99c1daff9c0bab095169dba3c619450 Reviewed-on: https://gerrit.libreoffice.org/83043 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-17cid#1430089 Copy-paste errorCaolán McNamara
add an annotation here Change-Id: Ib8a924271e557f7eb8ee4b5a7353206485b1f10a Reviewed-on: https://gerrit.libreoffice.org/83028 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-17tdf#128847 - vcl: fix colorspace names for MacOSChris Sherlock
kCGColorSpaceGenericGray is deprecated and should be kCGColorSpaceGenericGrayGamma2_2, and kCGColorSpaceGenericRGB is similary deprecated and now should be kCGColorSpaceSRGB. This fixes the "color skew" issue found in a variety of tests. Change-Id: I8088b2377e03cde3f8e03e9d3778a40fc3081c4a Reviewed-on: https://gerrit.libreoffice.org/82809 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-17loplugin:unusedmethodsNoel Grandin
Change-Id: I04deb5a1dee5b8a9a4508d28552ffe0b67288993 Reviewed-on: https://gerrit.libreoffice.org/82977 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-17Extend loplugin:external to warn about enumsStephan Bergmann
To mitigate the dangers of silently breaking ADL when moving enums into unnamed namespaces (see the commit message of 206b5b2661be37efdff3c6aedb6f248c4636be79 "New loplugin:external"), note all functions that are affected. (The plan is to extend loplugin:external further to also warn about classes and class templates, and the code to identify affected functions already takes that into account, so some parts of that code are not actually relevant for enums.) But it appears that none of the functions that are actually affected by the changes in this commit relied on being found through ADL, so no adaptions were necessary for them. (clang::DeclContext::collectAllContexts is non-const, which recursively means that External's Visit... functions must take non-const Decl*. Which required compilerplugins/clang/sharedvisitor/analyzer.cxx to be generalized to support such Visit... functions with non-const Decl* parameters.) Change-Id: Ia215291402bf850d43defdab3cff4db5b270d1bd Reviewed-on: https://gerrit.libreoffice.org/83001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-16widget theme: allow for default "stacked" spinbuttonsTomaž Vajngerl
Change-Id: I2943616a641de72a615f57784e8a9927c12edcf7 Reviewed-on: https://gerrit.libreoffice.org/82979 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-16loplugin:singlevalfieldsNoel Grandin
Change-Id: I31fd6b251dee9d1ee1a9ac59964034d0136e1f3e Reviewed-on: https://gerrit.libreoffice.org/82978 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-15tdf#128495 measure preferred size of print preview relative to UI fontCaolán McNamara
Change-Id: If04f50818fc94dd62263daaebc1c386b2d85c987 Reviewed-on: https://gerrit.libreoffice.org/82790 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-15loplugin:fakebool and loplugin:consttobool (macOS)Stephan Bergmann
Change-Id: I42d6546a9a400d8edb9ecef82614c6c88d4e6e83 Reviewed-on: https://gerrit.libreoffice.org/82806 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15tdf#128710 Qt5 don't force immediate paint on showJan-Marek Glogowski
I tried to build a minimal reproducer with QMainWindow and a QDialog and miserably failed. All variants of show, hide, modal change, move, resize, processEvents(QEventLoop::AllEvents) just worked. I was able to produce "qt.qpa.xcb: QXcbConnection: XCB error: 3 (BadWindow) ... major code: 18 (ChangeProperty)" entries in my ~/.xsession-errors, but that didn't matter for my program. Then I started to comment code blocks in Qt5Frame and after that continued in Qt5Widget, found that ShowEvent produced a modal window, albeit with an obviously missing paint event. But that is fixable by just queuing one in LO. I tried to debug that broken behaviour to find the real cause of the bug, but as I already knew from commit e770bacc85a0 ("Qt5 workaround modal change after show bug"), this bug has some timing related component, so that sadly didn't result in any conclusion. Change-Id: Iaec45997179365fae5430120f86e435aa5e88447 Reviewed-on: https://gerrit.libreoffice.org/82745 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-15loplugin:indentationStephan Bergmann
Change-Id: Iea0f624e0f46c6555dace701a543787c48ab9549 Reviewed-on: https://gerrit.libreoffice.org/82754 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-15make some classes module-privateNoel Grandin
Change-Id: I95845d7217fc5e77e3f8e205030e9cd761ad0cc5 Reviewed-on: https://gerrit.libreoffice.org/82116 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-15tdf#123734 Prepend "Custom." for values of custom PPD optionsMichael Weghorn
CUPS supports using custom options in PPDs, which go beyond what is specified in the PPD specification, s. doc at at [1]. [2] mentions that the "Custom." prefix is needed when specifying custom page sizes: > When Custom is listed for the PageSize option, you can specify custom > media sizes using one of the following forms: > > lp -o media=Custom.WIDTHxLENGTH filename > lp -o media=Custom.WIDTHxLENGTHin filename > lp -o media=Custom.WIDTHxLENGTHcm filename > lp -o media=Custom.WIDTHxLENGTHmm filename While I did not find any explicit documentation that the same is true for CUPS-specific custom options, this is apparently the case. (The "CustomPageSize" keyword is expclicitly specified in the PPD specification [3], section 5.16 "Custom Page Sizes" and thus not a CUPS-specific custom option.) This can be seen e.g. by the fact that after setting the default value for a PPD option to such a custom value, the corresponding entry in the PPD does get the "Custom." prefix, e.g. *DefaultPassword: Custom.12345 for the sample PPD from tdf#123734. For more details, s.a. the discussion on the similar bug report for Gtk+ at [4], where e.g. comment 0 says: > According to the cups people, the value should have been > "Custom.ThisIsAtest" in this case. Without the "Custom." part, > this is not used by the cups filters. Therefore, add the "Custom." prefix for custom options, but don't show them in the UI. [1] https://www.cups.org/doc/spec-ppd.html#OPTIONS [2] https://www.cups.org/doc/options.html [3] https://web.archive.org/web/20161017222612/http://partners.adobe.com/public/developer/en/ps/5003.PPD_Spec_v4.3.pdf [4] https://bugzilla.gnome.org/show_bug.cgi?id=543520 Change-Id: I570d8b55212c6fc33405460f11d152e86cedb0f9 Reviewed-on: https://gerrit.libreoffice.org/82722 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-14New loplugin:consttoboolStephan Bergmann
...to: "Find implicit conversions from non-'bool' constants (e.g., 'sal_False') to 'bool'". Due to how FALSE is defined as just #define FALSE (0) (i.e., a literal of type 'int') but TRUE is defined as #define TRUE (!FALSE) (i.e., an implicit conversion from 'int' to 'bool') in GLib (see the comment in ConstToBool::VisitImplicitCastExpr), we get more warnings about uses of 'TRUE' than of 'FALSE'. For example, in libreofficekit/source/gtk/lokdocview.cxx there is a warning about the 'TRUE' in g_main_context_iteration(nullptr, TRUE); but not about the 'FALSE' in g_main_context_iteration(nullptr, FALSE); (where the parameter of 'g_main_context_iteration' is of type 'gboolean'). Lets live with that asymmetry for now... (Besides the issues addressed directly in this commit, it also found the two bogus asserts at 7e09d08807b5ba2fd8b9831557752a415bdad562 "Fix useless assert(true) (which would never fire)" and 122a0be8ae480473bd1d7f35e197a2529f4621e3 "Fix useless assert(true) (which would never fire)", plus 5f0d6df7f57ae281fe161e61c7f25d67453fddd2 "Use two-argument form of static_assert".) Change-Id: Id77322de9f94b85a7b65608a03e0e9865d14467b Reviewed-on: https://gerrit.libreoffice.org/82667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-14Revert "tdf#108687 vcl: always enable tabstop on radio buttons"Justin Luth
This reverts LO 6.2 commit f2cd1c3c7cce2699d1341f726fc90cf30b52612c because it most recently caused regressions tdf#128749 and tdf#128625. There are places where radio-groups are not properly defined, and things are a big mess. -about 4 levels of radio buttons are created. -the last level does not do grouping properly. -the tab order is defined too early, before all the controls are fully made. -this code is repeated for EVERY control added. Already reverted in 6.2 and 6.3, this also reverts 6.5 because after looking again I don't see any way out of this, short of rewriting all of the old code. Reviewed-on: https://gerrit.libreoffice.org/75157 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4109dfff009f017e8994ea0a57119e79291ca2c8) Change-Id: Ic62fd7bb50e67647703cba3796f6d11ffb797eb5 Reviewed-on: https://gerrit.libreoffice.org/82523 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-11-14tdf#128434 really free the VclPtr<PDFWriterImpl>Jan-Marek Glogowski
This fixes the major reference cycle introduced by my commit b85ff98383942360901b8242cf77366782400426 ("Change PDFWriterImpl into an OutputDevice"), and adds the missing disposeAndClear() call. Maybe it would be better to add a ScopedVclPtr in the PDFWriter class and revert all the other VclPtr<PDFWriterImpl> users back to the original PDFWriterImpl*. The PDFWriter code really doesn't need any of the special VclPtr handling. Change-Id: Ia64fb207ad274d9323e350022f6b8af35c44e9f5 Reviewed-on: https://gerrit.libreoffice.org/82562 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-11-14Fix useless assert(true) (which would never fire)Stephan Bergmann
526387b96e9bc2c04b0dc26744bf6b88ea7c0521 "loplugin:unnecessaryvirtual" had added the assert (which was presumably meant to be an assert(false) instead, but had somewhat oddly been added as part of that commit for no apparent reason), after 68ec95b3f80408ae50897b043eed69a07d084df9 "made ListBox handle more than 64k elements, fdo#61520 related" had added the check+return. But check+assert+return doesn't make sense. Either the checked condition cannot happen (assert) or it can (return), but not both. A `make check screenshot` didn't cause the (now active) assert to fire in my local build, so lets assume that the condition cannot happen and the assert is legitimate (and thus drop the return and simplify the code accordingly). An alternative fix would be to show that the condition can happen, and to thus drop the assert. Change-Id: Id0059790d4f34c6645eadda9bca3184483e46bdf Reviewed-on: https://gerrit.libreoffice.org/82642 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-14remove user-added page in remove_pageCaolán McNamara
Change-Id: I22e2449fb8c15790f7396af6f94d03d48bf334f6 Reviewed-on: https://gerrit.libreoffice.org/82640 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13ensure we connect just onceCaolán McNamara
Change-Id: Icd403eac948f0ead1f08a5a2e3a46e9b6bf33792 Reviewed-on: https://gerrit.libreoffice.org/82612 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13tdf#123851 Qt5 handle broken ScrollBar valueslibreoffice-6-4-branch-pointJan-Marek Glogowski
If the scrollbar has a mnMin == 0 and mnMax == 0 then nVisibleSize is set to -1?! I don't know if a negative nVisibleSize makes any sense, so this just handles this case without crashing LO with a SIGFPE in the Qt library. If min == max then the visible size is just zero. It's actually not clear, that this crash is the same then the bug report, but it fixes at least the later reproducer crash. Change-Id: Ib2dd51ddecfd24ddf2d89f746cbc8975269e13da Reviewed-on: https://gerrit.libreoffice.org/82600 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2019-11-13Resolves: tdf#128758 scrollbars added during scrolledwindow layoutCaolán McNamara
Change-Id: I1eee32278f6b46ff4f0447eb39543836c3d687f0 Reviewed-on: https://gerrit.libreoffice.org/82589 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-13Extend loplugin:salbool to loplugin:fakeboolStephan Bergmann
...checking for unnecessary uses of more "fake bool" types. In the past, some of the checks involving the types of variables or data members, or the return types of functions, issued warnings that required surrounding code to be changed too (e.g., when changing the signature of a function whose address was taken). These checks have been tightened now to not warn in such cases (which avoids warnings that require changes to additional code, or changes that might even be impossible to make, at the cost of being less aggressive about removing all unnecessary uses of those "fake bool" types). Change-Id: I70eb75039817cda34ed611387ee27dc5f36a3e2e Reviewed-on: https://gerrit.libreoffice.org/82554 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-13tdf#128465: Enable pasting also JPEG images in presentation documentsTor Lillqvist
Change-Id: I0f3254ad536c26c975452f800a464f5498e66a78 Reviewed-on: https://gerrit.libreoffice.org/82507 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82587 Tested-by: Jenkins
2019-11-13tdf#128717 Sync duplex value from "Properties" dialogMichael Weghorn
The value for duplex can be set in two places, the main print dialog and the "Properties" dialog. Therefore, update the value for duplex combobox in the main print dialog with the value set in the PrinterController, to take into account potential changes carried out in the "Properties" dialog. (Other options, like orientation already worked fine before, as did synchronisation the other way around.) Change-Id: Ie68f1cfbba6def82c85745e1c361e28a1513e647 Reviewed-on: https://gerrit.libreoffice.org/82528 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-13Related tdf#128717: Drop "<ignore>" value for duplex and paper trayMichael Weghorn
Drop the artificial extra value "<ignore>" for the duplex and paper tray options in the "Properties..." dialog used in the print dialog on Linux. Those extra values were introduced in commit a9f8d75e6c54b40845fc198019788ff6b568aaf5 ("Administration utility for Unix PS-Print Environment") in 2001. The two corresponding comboboxes are greyed out if there are no PPD options "Duplex" and/or "InputSlot". And if there are valid values for these options, one of those is preselected. I see no use in allowing to explicitly setting the value to "<ignore>". Not passing any value explicitly to CUPS will cause the default option to be used anyway. Having an additional option for Duplex is also inconsistent with the (revamped) main print dialog, where that additional value is not offered for the duplex option, i.e. the "Properties" dialog offers more choices than the main print dialog. Change-Id: Id9d20a061e51921e601d53d74aa8079fe3c59aca Reviewed-on: https://gerrit.libreoffice.org/82527 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-12Resolves: tdf#128716 make gtk assistant steps clickableCaolán McNamara
Change-Id: I28d7cfd2192f22410eee08c6f4e5ab056789fcfd Reviewed-on: https://gerrit.libreoffice.org/82503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12factor out inserting an intermediate GtkEventBoxCaolán McNamara
Change-Id: I52b8e09deb474f665ad32baebf5648a7c54c6040 Reviewed-on: https://gerrit.libreoffice.org/82502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12Revert "Drawing calc grid misses pixels on bottom and right."Michael Meeks
This reverts commit 4a3dab5a4cd5c7a7039b2cef9d5bb14c1fff49c9. Change-Id: I1ac1edca00e4d1d62f93de48561a3b6ce4a315aa Reviewed-on: https://gerrit.libreoffice.org/82221 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-12tdf#128630 vcl PDF export: fix aspect ratio when scaling rotated imageMiklos Vajna
Regression from commit 68549e00d5e23aa22bc974a8151d93cd948444b3 (vcl, BitmapEx transformed draw: special-case simple rotations, 2019-10-10), the intention there was to fix an error on the last col/row of a bitmap, but that was only tested with input where the aspect ratio doesn't change on scaling. Fix the problem by going back to the original way in the "aspect ratio changes" case. Change-Id: I52bed503ddaadbbbdf64ac6fec2fe268153866f1 Reviewed-on: https://gerrit.libreoffice.org/82467 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-11Fix copy/paste error that probably has had no ill effectTor Lillqvist
Change-Id: I062fef5f2316a3aa7560ecb42799496cd38362e9
2019-11-11unnecessary includeCaolán McNamara
Change-Id: Ia8db302de488cfa89311a258a57f8c595528088a Reviewed-on: https://gerrit.libreoffice.org/82443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11GtkSalFrame toplevel might not be a GtkWindowCaolán McNamara
in the rare embedded case, e.g. ASPO extensions option window Change-Id: Iedacdbc6b795ee5fbe7471b9f19f8f7f6c746204 Reviewed-on: https://gerrit.libreoffice.org/82458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11widget theme: add missing actionButtonTextColor style to iOS themeTomaž Vajngerl
Forgot to add "actionButtonTextColor" to the iOS theme definition. Change-Id: I29207512a04068759021d4ae6a30824b56498de6 Reviewed-on: https://gerrit.libreoffice.org/82394 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-10widget theme: add new action button stylesettings to xml def.Tomaž Vajngerl
This adds new action button stylesettings to the xml def. parser and adds the defeinitions to iOS theme. Change-Id: If500d0a7a4633b3c7b90b14b6f62c320ef4b1c12 Reviewed-on: https://gerrit.libreoffice.org/82381 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-10Set action button colors in QT5 backend tooTomaž Vajngerl
Change-Id: I8aacadbef404cdad474a58d92b947fea2aa22604 Reviewed-on: https://gerrit.libreoffice.org/82384 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-10replace define by constexpr in vcl/roadmapJulien Nabet
+ move LABELBASEMAPHEIGHT in vcl/source/control/roadmap.cxx (only file where it's used) Change-Id: I22498bc7f6fa3f09a86f15844836a0b9bb3d7eb2 Reviewed-on: https://gerrit.libreoffice.org/82389 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-11-09custom widgets: support custom action button text colorsAshod Nakashian
Change-Id: I314183a1d6434c043183a600740c786e22a67503 Reviewed-on: https://gerrit.libreoffice.org/82276 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-09disable static_assert on AtomicCounter::is_always_lock_free on armel ...Rene Engelhard
... since AtomicCounter::is_always_lock_free seems to be always false on armel Change-Id: I89c15fd41337ac5b29f781722423427825e6ff45 Reviewed-on: https://gerrit.libreoffice.org/82165 Tested-by: Rene Engelhard <rene@debian.org> Reviewed-by: Rene Engelhard <rene@debian.org>
2019-11-09tdf#41205 Auto-focus range edit in print dialogMichael Weghorn
Auto-select the page range edit when the "Pages" radio button is selected in the print dialog, to allow for easy insertion of the pages to print. S.a. commit 6087dc9cddde7052258996389d561f415ebee13c ("filter: PDF Export UI "page range" autofocus") which did basically the same for the PDF export dialog. Change-Id: Iff7a9292c4874952e67218d83aafc4bc76b1e5b7 Reviewed-on: https://gerrit.libreoffice.org/82310 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-08Resolves: tdf128672 nup missing erase of old contentCaolán McNamara
Change-Id: Ib00d7aeb5911e071cd8f1c8cd79574e194b87d98 Reviewed-on: https://gerrit.libreoffice.org/82299 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-08Mention that SAL_FORCEDPI is used by qt5/kf5 as wellMichael Weghorn
And "gtk" (i.e. gtk2) is no more, so remove that one. Change-Id: Idc68553ff6f396a6dbc7226145cb070560c2cb93 Reviewed-on: https://gerrit.libreoffice.org/82288 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-08tdf#121740 speed up font loadingNoel Grandin
by caching whether the font is a graphite font. Takes load time from 27s to 23s for me. Change-Id: I7b14a8bd305b27a088f363d19ebfb6fe774d3b02 Reviewed-on: https://gerrit.libreoffice.org/82267 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-08tdf#127993 remove default WB_HIDESELECTIONCaolán McNamara
so the highlighted entries in a TreeView doesn't appear different when it has focus vs not having focus. Change-Id: I823fc0cc503161ee93845eb0fb7458a41344d608 Reviewed-on: https://gerrit.libreoffice.org/81995 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-11-08widget theme: Gradient support when drawing widgetsTomaž Vajngerl
Change-Id: I29239348e36e4963d9708a22ac649b2b1d68bf02 Reviewed-on: https://gerrit.libreoffice.org/82207 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-08loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: Icf2894f77c90aa4620910d621249947bad4be8b7 Reviewed-on: https://gerrit.libreoffice.org/82269 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-07make size group defaults match and document what the default isCaolán McNamara
Change-Id: Ic9a90d50d19b82ffd2ad599a106c2bc58d138f17 Reviewed-on: https://gerrit.libreoffice.org/82237 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07remove some unused gettersCaolán McNamara
Change-Id: Iaa556491add4a7674f90ecfbf8e44f0b1d6583ee Reviewed-on: https://gerrit.libreoffice.org/82198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07drop unused TreeView::set_top_entryCaolán McNamara
Change-Id: I70171b95baf29486c253e7d388ba59385da1d929 Reviewed-on: https://gerrit.libreoffice.org/82196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07rename FloatingWindow::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I55babcf716292fa9fac3e9cb4ba66a2038a1d80b Reviewed-on: https://gerrit.libreoffice.org/82203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-07rename Dialog::ImplInit so no need for using directiveCaolán McNamara
Change-Id: I01a8591def7a559d3152e9c4875c6785940331f7 Reviewed-on: https://gerrit.libreoffice.org/82202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-12-28 02:37:02 +0000