Age | Commit message (Collapse) | Author |
|
Change-Id: I88c1bed647bf6f77953ccd9921e515c1246fa96f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150273
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
When an `AccessibleEventId::CHILD` event with
its s `NewValue` set is received, that means that
this a11y child object has been created, so the
`QAccessible::ObjectCreated` event needs to be
sent for the newly created object, not the accessible
interface of the listener (which is the parent).
This makes announcement of (part of) the font color popup
button in Writer's toolbar generally work with Orca and the
qt6 VCL plugin e.g. the buttons in the popup are now announced
(but the colors are not yet).
Adapting this for the case where a child has
been removed (bridged to Qt as `QAccessible::ObjectDestroyed`
event) would currently results in crashes when closing the
application e.g. after using the character font color popup in
the Writer toolbar. This needs further investigation, so don't
send the event for now, but add a `SAL_WARN`.
Also warn when receiving a `CHILD` event with neither `OldValue`
nore `NewValue` set, since that shouldn't happen,
s.a. documentation in
`offapi/com/sun/star/accessibility/AccessibleEventId.idl`.
Change-Id: I183e71de061489fdc9751620820268f280f1949f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150417
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I85c6eb0db6ad7123df1c8596951be5bb8ed5ef3a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149171
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
(cherry picked from commit 451939ac9a8cf182ab563412d561562957a60499)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150089
Tested-by: Jenkins
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
|
|
Change-Id: Ie0d4e0c3cd5d19cf6337ec79d30ae7c877cffd82
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150394
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I915414c55c0b008c018bc2376760eaa85f653384
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150282
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150388
|
|
Hide the SvMemoryStream implementation detail better - this
could be served from a file in future. Also couple lifecycle
of the SvMemoryStream to the vector backing it.
Change-Id: Ia9b28b57b8df4ce57286effd4d1753bf345fc10e
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149917
Tested-by: Jenkins
|
|
Change-Id: Ic8dbf0afdb96a0f1be210eedfbd12ef6467dd29f
Signed-off-by: Michael Meeks <michael.meeks@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149916
Tested-by: Jenkins
|
|
Change-Id: I4d303f7f60bb0f086fad8f3883dee1393a5d6eb3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150345
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ib0173b1a33be7156c27c81b0804ac7c4d3373857
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150336
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Icc24e0aaf1762e5b318b8364dd9fdb496edfb77c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150279
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Unused ever since the two variables got introduced in
919a4ef592b6026a7533a93682f39118fef29ce8 "tdf#105461 PDF export of editeng fill
color: restrict to logic map modes" and fddd956c0cf3b2c22a152bbb30554def1336b466
"tdf#96892 vcl: add unit test for misplaced soft-hyphen ...", respectively.
(Found with an experimental Clang build supporting __attribute__((warn_unused))
on individual ctors rather than just whole class types, and the corresponding
css::uno::Reference ctor marked accordingly.)
Change-Id: I538a8cf410355ca4b5230f89947587b58d67e205
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150304
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Also, return an autoreleased empty array instead of a retained array.
Change-Id: I5f494b301dbae859486d6bc4874112b714022b60
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150307
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
|
|
Take the visibility of the menu item
(that e.g. gets set in `QtMenu::ShowItem`)
into account when updating the menu in
`QtMenu::DoFullMenuUpdate`.
With this in place, only the relevant entry is shown
in the context menu for items in the character table
in the special characters dialog (Writer: "Insert" -> "Special
Character") while previously, the "Add to favorites"
and "Remove from favorites" entries would both be shown
at the same time regardless of whether the character
was present in the favorites or not.
(Both entries would actually do the same: add the character
if it was not present in the favorites, remove it if it
was already there...).
Change-Id: Ica5f07d6009d97db2df0540293b096565bf1dd52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150285
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
ever since it was added in
commit 8229967979d96bd01e63e2954b7af35a57d9e08c
Date: Thu Sep 20 15:23:39 2007 +0000
INTEGRATION: CWS os2port01 (1.2.2); FILE ADDED
2006/11/29 14:34:20 ydario 1.2.2.1: Initial OS/2 import.
Change-Id: Ic1bbf9f9167f9a7146f3c7d18b6fdb69c1f44e0b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150275
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ib6e5131bff38b55b2dbf0805b63ca3554c5ee349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150278
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Id1d42e2de480e8ec248e5716ababc8bddfc905ed
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150276
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I38f3410c0b25ff579879b9de1f266af4d8fd51e6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150256
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Skip the posting of SalEvent::ExtTextInput and SalEvent::EndExtTextInput
events for private use area characters.
Change-Id: I6fa5dedacefc5d9dd671f607786deb999f5e4c6a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150248
Tested-by: Jenkins
Reviewed-by: Patrick Luby <plubius@neooffice.org>
|
|
entry for that font->OpenSymbol conversion. It might make sense to drop
the conditionals and just use the result of ConvertChar::GetRecodeData
if there are any, but keep close to what has worked historically.
Change-Id: Idf9ee0f8068f1ff8e7f179ba5087763e44ade268
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150241
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This suite is large enough so that avoiding the
declaration/registration/definition of each test manually saves a lot of
space.
Change-Id: Icfbfede5663d93eca10d7585313b51c3e19303bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150223
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
... and use SvStream::WriteNumberAsString, replacing Write[U]Int32AsString
Change-Id: I10e56c532494239ed40ec01b6184dd06db463a0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150193
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
WriteOString is a better replacement
Change-Id: Ic431b9aeb98d19fe61cff71360eee555105cc2bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150192
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
As noel indicated in https://bugs.documentfoundation.org/show_bug.cgi?id=154631#c6
"GIF does not (as far as I can tell) support partial transparency, it only has full or none transparency.
See specs linked from https://en.wikipedia.org/wiki/GIF"
Change-Id: Ib110f344a6b8f0fdfd1355e6521d979b33548709
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150184
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
after commit d7910847fba1694c83dc57a1f27b8eaabb2a7d85.
Thanks to mike kaganski for spotting this.
Change-Id: Ie7272b6f97e3b292439aedb3a163bf00ca26f852
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
which prevents constructing unnecessary temporaries via getStr()
Change-Id: I9ca70893a10e954b5ee0e6ad6098660ee24c2bef
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150170
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
both because it is more obvious to read, and it takes a string_view,
which is handy
Change-Id: Ic201cfa0434446f51436d23c33d3f1a919ed65be
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150167
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I32fc2570e8553be356e5c5c059b92791f5e9106a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150164
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
eventtesting with input of fuzzed keystroke was a fairly nifty idea, but
I never did anything with it beyond an initial experimental run and its
cluttering up things so drop it now
Change-Id: I44571e3e33124f522374d7c6772b7a7e7721aa1d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150125
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I785120bdad1a3c3311aeca0c8ec5b8b014999872
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150108
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
For similar code sequences that can be improved.
Also move containsComment from collapseif plugin code to
plugin.cxx so we can use it from stringadd.
Change-Id: Ie07d9aedf2c31cb0b2080e1b8584294d7046a8e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149217
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ieab3d9fdbcee90ccd125e84f74c06cd1d6711a9f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149953
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150057
Tested-by: Jenkins
|
|
Change-Id: Ia2865346e966cdd4b64ed588a29cc1e760d36c73
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149969
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Specifically in sd/source/core/annotations/Annotation.cxx
We seem to end up fixing leaks here often.
The current tools::JsonWriter API is just very hard to use correctly.
So rather return an OString, which is cheap to copy,
and push that down into the LOK code.
AFAIK that seems to end up requiring less code and less adhoc copying
of data (specifically the queueing code in init.cxx was creating
copies when converting to std::string).
Ideally, we could have some special API to avoid the new strdup()
calls in init.cxx, but not sure how to prevent other people
from accidentally using that.
Change-Id: Ia33437c1bfd9cc2d54dfb99914d1b72db20335f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149963
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I449ae3f8cf294e2ab81a5b47862278e325f2cb1b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148937
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150041
Tested-by: Jenkins
|
|
7.18.6.2 Media clip data
In the media clip data dictionary, the optional CT and Alt keys
(ISO 32000-1:2008, 13.2.4.2, Table 274) are required.
Presumably writing a potentially wrong hard-coded mime type here isn't
intended.
Change-Id: Ifa8ee199a4cf9ce83f410860d59b6c30475f80e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150050
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I1cf23442667a8ac6e9f8da2ea72bf60f5126236e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150047
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
which propogates to cairo and once a cairo surface is in an error state,
that cannot be cleared and all subsequent drawing fails, so bodge that
with a high degree of stretch we draw the brace without stretch to a
temp surface and stretch that to give a far poorer visual result, but
one that can at least be rendered.
Change-Id: I6b8bb079e82c3cf03a908de750c5c445ad230750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150031
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I89fbaca1fa7303904681f75ee4a7fc90aeb9ef8e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150030
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ibcbd175e9b7c04f30acd4c5d23998b00889e7b0d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149714
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150040
|
|
Change-Id: I45c086ce652487017817fcdb2a3c5329a8f2a30f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149689
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150039
|
|
Change-Id: I0577832f57b15621d150da4cb50e134c9c06bae7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150029
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
in the past there was intermediate calls that these affected
Change-Id: I5bb15046ff5869522dfafe72e16f9be4707c1f7e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150027
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
since:
commit 6c9948d80aaa1d4827ccf741d900093abe7a973e
Date: Mon May 3 06:51:50 2021 +0800
vcl: adjust cairo text renderer for vertical writing
Change-Id: I853b5f3b8c8979468d6c72617b7991f4c7d509d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150026
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
i.e if the crossing was triggered ultimately by a key stroke which is
likely from exiting the search box.
This way we can avoid the problem that with hover-selection that after
"enter" is used in the search box, selecting a matching row, then during
teardown of the widget the box is hidden, and the generated crossing
notification triggers unwanted selection of a different row under the
mouse.
If needs be this could be refined further to only happen for a specific
key or other details of the triggering event
Change-Id: I7e64fb5fa31a446b85016d86ecd314d13130d7b9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150016
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I1849e40508a8754ec567da5913d3454571da5bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149063
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150015
Tested-by: Jenkins
|
|
Change-Id: I21817b21fe6d2ce0a6f6bd784c0e24fe35b17fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149502
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150014
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
|
|
veraPDF complains:
Specification: ISO 14289-1:2014, Clause: 7.18.4, Test number: 2
If the Form element omits a Role attribute (Table 348), it shall have
only one child: an object reference (14.7.4.3) identifying the widget
annotation per ISO 32000-1:2008, 14.8.4.5, Table 340.
LO forms produce both page content in an MCID and an /Annot, so Role is
needed.
Change-Id: Ic231931a7c35d8da37ca76e02d97501edb43347c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149626
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
PDFWriterImpl::beginStructureElementMCSeq() emits a spurious MCID
definition outside of any stream, before the 1st page:
/Document<</MCID 1>>BDC
% PDFPage::emit
1 0 obj
<</Type/Page/Parent...
This is because SwPageFrame is translated to a Document StructElem in
EnhancedPDFExportHelper, but PDFPage::emit is called at a later time
than when the page content stream is produced, so this is just wrong; an
MCID inside the page content stream is pointless because that's an
object already anyway, so just suppress this.
Looks like other applications don't produce Document currently.
Change-Id: Ic2e30e4125c0e97c8e47330c7a247f74efc18f98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150017
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
Change-Id: I02cb63b57960c1d7425fe97c341eaf24f216c3a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149496
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150013
Tested-by: Jenkins
|
|
Change-Id: I625346049b866d9f231bba461f40b671f4959e4d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/149717
Tested-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150012
|