summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-02-18uitest: fix small race condition when launching modeless dialogsMarkus Mohrhard
Change-Id: I44f7af1b44badce6ed09eeca0bb19760b5f22aa9 Reviewed-on: https://gerrit.libreoffice.org/49942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-02-18tdf#115602 keyboard navigation: Skip disabled toolbox itemsJim Raykowski
Change-Id: I793dd301a04435c79a97819497b9d34fa49e298b Reviewed-on: https://gerrit.libreoffice.org/49697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-16convert any canonical negative gtk responses to our ownCaolán McNamara
Change-Id: Ie51d843061157190003ccbc91b4392409249c6e3 Reviewed-on: https://gerrit.libreoffice.org/49865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-16tdf#115315 Cursor not in focus with new documentTelesto
Partial revert of 7aae8772aa18744cb1bbd8348272be99cc882c47 ("Clear VclPtr instance reference on removed UserEvents.") Disposing of child controls should not affect focus events of the parent frame. Change-Id: I583311050560a2851cfcc372741b675b52375d06 Reviewed-on: https://gerrit.libreoffice.org/49855 Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-16gtk3_kde5: Checkboxes on the left, texts on the rightKatarina Behrens
QFormLayout does it the other way round (text left, checkbox right) and it looks odd, so use QGridLayout Change-Id: Iff4255f695ce17561bac44e496a3567e1b438581 Reviewed-on: https://gerrit.libreoffice.org/49815 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-16native dialog initial basisCaolán McNamara
Change-Id: I392be563e38257390f748c70bb71c67a66778ddd Reviewed-on: https://gerrit.libreoffice.org/49677 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15for fuzzing, reduce allowed warnings againCaolán McNamara
Change-Id: I60c388db280f8178a5a17354b1f68e7bea9560f6 Reviewed-on: https://gerrit.libreoffice.org/49828 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15ofz#6372 fix bitmap decoding of pattern in LwpBackgroundStuffNoel Grandin
after commit b90e098a354323b635bab3ee8f9c79deb1e734fe use BitmapEx in LwpBackgroundStuff <caolan> maybe the lotuswordpro original stride is really 4 after all (as a common stride), with the first byte on each line containing the 8bits for each row The original code in GetPattern() looked pretty dodgy since it was copying 32-bytes into an 8 byte buffer. Assume that the reversing part is right, and that the format is really a 1bit packed 8x8 image. Also fix the decoding of such a image in CreateFromData to assume packed format, which is more predictable. Also fix the bug in createDefaultCross_3x3 which changing the assert revealed. Change-Id: I7196ae601429bbe0f842399df61c8b858e022d3e Reviewed-on: https://gerrit.libreoffice.org/49808 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15tdf#96892 3 to 5 digit precisionCaolán McNamara
Change-Id: Iaecfff78a3e17548dbd097a30c2a6b061806a974 Reviewed-on: https://gerrit.libreoffice.org/49643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-15gtk3_kde5: advertise vcl plugin correctly in about dialogThorsten Behrens
Change-Id: Icfe977f7f9750003d992d795cad8cd86d7055e59 Reviewed-on: https://gerrit.libreoffice.org/49813 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-02-15move ToolboxButtonColorUpdater bitmap update to VirtualDeviceNoel Grandin
to avoid doing a read-modify-write cycle on the item images on the toolbar, add an overlay image member to Toolbox items. part of the process of making Bitmap an internal detail of vcl/ Change-Id: Ie4a886c48484a06694fc4c066ee0845b39d27f0b Reviewed-on: https://gerrit.libreoffice.org/49649 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-15move cairo surface code from canvas to BitmapToolsNoel Grandin
part of making Bitmap an implementation detail of vcl/ Change-Id: Ic4b8d114a8091041374a083b3b7ca2fa68757ab1 Reviewed-on: https://gerrit.libreoffice.org/49719 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14lok IME: support dialogs as wellPranav Kant
Change-Id: Ic78da45dadaa5a4e1ca78e20d04974108581121e Reviewed-on: https://gerrit.libreoffice.org/49714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-02-14use BitmapEx in LwpBackgroundStuffNoel Grandin
part of making Bitmap an implementation detail of vcl/ Change-Id: I847a2371cd630637b11aed0fad7263809143c706 Reviewed-on: https://gerrit.libreoffice.org/49705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14Fix typosAndrea Gelmini
Change-Id: I76d50754a660e006e5913b89caa491cc21d6f9dc Reviewed-on: https://gerrit.libreoffice.org/49588 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-14move transparency adjust code to BitmapExNoel Grandin
part of making Bitmap an internal implementation detail of vcl/ Change-Id: I6978d84c86c3d55b3ebbeacda60fd94b160daa29 Reviewed-on: https://gerrit.libreoffice.org/49667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-14use BitmapTools in TIFFReaderNoel Grandin
part of making Bitmap an internal detail of vcl. This one is a little trickier because it constructs the palette after it reads the pixel data, so I couldn't use RawBitmap Change-Id: I2f501260beebb541ee451e78d551e13f182a01b1 Reviewed-on: https://gerrit.libreoffice.org/49665 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-13graphic: Remember the origin URL after swap out - swap inTomaž Vajngerl
Change-Id: I3874fb43d1b545b334cb7e69fe119945d127f380 Reviewed-on: https://gerrit.libreoffice.org/49646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-13use a11y description if offline help doesn't have an entryCaolán McNamara
Change-Id: I0090e10f6fa7b5e86be7ace8f1bd61f3f790fa11
2018-02-13ofz#5428 TimeoutCaolán McNamara
Change-Id: I8fe05cbaaf2f39723e76100bcdb928c859d712d8 Reviewed-on: https://gerrit.libreoffice.org/49639 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-13tdf#94341: Set child transparent mode for ToolBoxMike Kaganski
Push buttons don't rely on their parent's child transparent mode since i#38498. This allows buttons to have proper transparency mode, despite toolboxes don't set their children transparency mode at all (even being transparent themselves). However, when other controls are placed to toolboxes, as FixedText, they check parent's child transparent mode, and then use parent's background for them. For transparent toolboxes this makes the background to be NONE, and thus on invalidation of such FixedText, neither parent's area, nor FixedText's is filled to remove previous text before outputting new text. This patch sets ToolBox child transparent mode depending on its own transparency. Also, FixedText now checks if background applied in ApplySettings is empty, and if it is, sets transparency mode despite parent's setting. Change-Id: Id424cbad894bb42a88a4b027f2a964d6e542f115 Reviewed-on: https://gerrit.libreoffice.org/49621 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-13Add missing SVLIBRARY include.Michael Meeks
Change-Id: I10a1d9430f38499d77ad528ef98cff260873d4de
2018-02-13Blind fix for MERGELIBS buildEike Rathke
It's g_aMergedLib instead of g_aMergedLibs, and osl::Module is not a unique_ptr or somesuch.. commit 707f787cd991f9c59712cd3020d127d09605c792 AuthorDate: Sun Feb 11 00:01:44 2018 +0100 CommitDate: Mon Feb 12 22:27:55 2018 +0100 Change-Id: I1f0266d189546dfe3b0d9eb449c878daebbf0da6
2018-02-12lok: enable pre-loading with Vcl's builderMichael Meeks
Cache vclbuilder's loaded modules globally & simplify logic. Pre-populate that cache on preload for LOK vs. a somewhat inelegant pre-canned list of dialog libraries. Change-Id: I86d936862a41495fd37908f3ee7eb2e0c363d651 Reviewed-on: https://gerrit.libreoffice.org/49550 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-12give up on recoverable errors earlier when fuzzingCaolán McNamara
Change-Id: I10b06a977f77c0802cbf5a1db33671ba1db69ba9 Reviewed-on: https://gerrit.libreoffice.org/49601 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12for ~perfect compression link fuzzer input limit to an output limitCaolán McNamara
Change-Id: I30c3a0b75c818b55f6e73fdb68bf59fdac249d0e Reviewed-on: https://gerrit.libreoffice.org/49606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-12fix pixel address calculation in RawBitmapNoel Grandin
Change-Id: I42476a8049330ff02c555ecba49b49f3cf012086 Reviewed-on: https://gerrit.libreoffice.org/49599 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-12Fix typosAndrea Gelmini
Change-Id: Ia01f85e87706b02ffb816b3385765e2729dafa02 Reviewed-on: https://gerrit.libreoffice.org/49585 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-12crashtesting: tdf111681-6.pptxNoel Grandin
regression from commit e5012e53b919ae4921d6d35660bde323a6f28417 use scanline when reading pixel data Change-Id: Ic9382426191d5cbbffc6c3fd6f7038ed93715b8e Reviewed-on: https://gerrit.libreoffice.org/49598 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-12One less ctor/dtorMike Kaganski
Change-Id: I73cab951942f16b937e95a6617ed60ee24b6c3b3 Reviewed-on: https://gerrit.libreoffice.org/49583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-11tdf#115353 tdf#114743 Use first valid glyphTamas Bunth
in AdjustLayout. Change-Id: Iaa9a0cde2bd35fed5cbc9ebf0690341812679b6f Reviewed-on: https://gerrit.libreoffice.org/49541 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-02-11Add origin URL to Graphic to remember where the image came fromTomaž Vajngerl
Change-Id: I73e7377c2049211de0b464efff03058dc5de33a6 Reviewed-on: https://gerrit.libreoffice.org/49554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-10lokdialog: Render non-pixel based preview windowsTamás Zolnai
PaintToDevice() method was designed for pixel based windows, now I added some scaling to handle different units. Change-Id: Id242c44101c1e842409ba3a9b13291e48bdd44ca Reviewed-on: https://gerrit.libreoffice.org/49543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-10use RawBitmap and BitmapEx in icgm filterNoel Grandin
Change-Id: Icaffda666c27f733c0d490905e91a68b72073bcb Reviewed-on: https://gerrit.libreoffice.org/49502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-10speed up jpg fuzzingCaolán McNamara
Change-Id: Iad65200d132f8fdd0e598ff5a4ee4943a9f7ac26 Reviewed-on: https://gerrit.libreoffice.org/49508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10lokdialog: Handle dialog items' invalidation in generalTamás Zolnai
Change-Id: Ib7b178fe97964bc5fd6ac173a143ba8ba089e237 Reviewed-on: https://gerrit.libreoffice.org/49240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-09Fix conditionSamuel Mehrbrodt
OSL_DEBUG_LEVEL is always set as it seems Change-Id: Ie555f705fd13de778463c8073e86d30b3ce09073 Reviewed-on: https://gerrit.libreoffice.org/49476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-09add sft fuzzerCaolán McNamara
Change-Id: I0ee43e78b5366f2c23fb0bac9a103af987138411 Reviewed-on: https://gerrit.libreoffice.org/49372 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09promote to unsigned intCaolán McNamara
Change-Id: I84fa219708199cd8293e6887860ba44dd897a2e8
2018-02-09move largest bounds check to startCaolán McNamara
Change-Id: I03fe80f9568759b829fac4e9bcfd496efebe6a26
2018-02-09bounds checkCaolán McNamara
Change-Id: I6d32a6b6f1dd91db42a3f154700ea55603f0e4dd
2018-02-09extend to cover the last byte neededCaolán McNamara
Change-Id: I5177d42b47a4bca614878dce4a69ab16b5cfe163
2018-02-09simplify returnsCaolán McNamara
Change-Id: I1a67cb2f1c686032438852fec1267a59fbd04d7f
2018-02-09use safeint on calculationsCaolán McNamara
Change-Id: Ic063786ba41aa9a985f505e62b43d3d543a0d48f
2018-02-09check ntables offsetCaolán McNamara
Change-Id: Id75f5f4b578fd176c17e5763569f1403260c6594
2018-02-09check tableoffset against sizeCaolán McNamara
Change-Id: Ia79be052dd3f6b6ed38fb326558924c853af5fff
2018-02-09check cmap offsetCaolán McNamara
Change-Id: I5aae26c38f3645020f0e1d6d7b6877c2727af1b4
2018-02-09check more table sizesCaolán McNamara
Change-Id: I004a6d322f60d916cc4635b362ce948e8a10d7c7
2018-02-09fix mem leakCaolán McNamara
Change-Id: I0d329357ac282d4652b0f7ebc401cbd51963461b
2018-02-09use ptr diff rather than intCaolán McNamara
Change-Id: Ia174fd94c57cc3c899c10e1c0dc5968965a50427