summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-08-31tdf#119390 Don't focus the toolbar when closing a floating windowMaxim Monastirsky
Toolbar popup windows have the toolbar as their direct parent. This causes problems when such window is teared-off and later closed, as Window::dispose will attempt to move the focus to its parent which is the toolbar, instead of what users expect to have the focus back in the document area, or in whatever was the last focused control. As a solution reparent the window before dispose, similar to what happens with floating toolbars. Also return the focus to the main window when popup mode ends, so we can keep track of the last focused control. This is also a good thing by itself, as WB_OWNERDRAWDECORATION windows don't get the focus by default, which results in neither the floating window nor the document have focus after tear-off. Change-Id: I060b8c45a64db9c612da58b7c35478bab41a4558 Reviewed-on: https://gerrit.libreoffice.org/59811 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-08-30Support buffering SystemDependent GraphicDataArmin Le Grand
This is a first step to allow buffering of system dependent data, especially (but not only) for the system-dependent implementations of graphic output. For example, for B2DPolygon and Win output, it allows buffering the Gdiplus::GraphicsPath instead of re- creating it all the time. To support that, the change includes forwarding the current transformation to the renderers in SalGraphics. The current state in VCL is to transform all and everything to device coordinates at every single paint. I have currently started to do this for ::drawPolyLine implementations. The fallbacks for all systems will at the start of that method just transform the data to device coordinates, so all works as before. This may also be done for FilledPolygon paint in a later step, but most urgent is FatLine painting. An arrangement of shared_ptr/weak_ptr is used so that either the instance buffering (in the example B2DPolygon) or the instance managing it can delete it. The instance managing it currently uses a 1s Timer and a cycle-lifetime management, but that can be extended in the future to e.g. include size hints, too. The mechanism it designed to support multiple Data per buffering element, e.g. for B2DPolygon at the same time system-dependent instances of Gdiplus and Cairo can be buffered, but also PDF-data. This is achieved semi-automatic by using typeid(class).hash_code() as key for organization. The mechanism will be used for now at B2DPolygon, but is not limited to. There is already a similar but less general buffer (see GdiPlusBuffer) that can and will be converted to use this new mechanism. Added vcl/headless Cairo renderer to support given ObjectToDevice transformation (not to transform given B2DPolygon) Added support for CairoPath buffered at B2DPolygon, seems to work well. Need to do more tests Moved usage to templates suggested by Noel Grandin (Noel Grandin <noelgrandin@gmail.com>), thanks for these suggestions. Adapted Win usage to that, too. Converted Win-specific GdiPlus BitmapBuffer to new mechanism, works well. Checked, the manager holds now a mix of bitmap and path data under Win Added a cleanup mechanism to flush all buffered data at DeInitVCL() using flushAll() at SystemDependentDataBuffer Adapted Linux-versions of ::drawPolyLine to support PixelSnapHairline, for now in a simplified version that still allows buffering. This will also be used (and use buffering) for the Cairo-fallback in X11SalGraphics Change-Id: I88d7e438a20b96ddab7707050893bdd590c098c7 Reviewed-on: https://gerrit.libreoffice.org/59555 Tested-by: Armin Le Grand <Armin.Le.Grand@cib.de> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-08-30loplugin:useuniqueptr in InverseColorMapNoel Grandin
Change-Id: I04801a912397ca0081201f52b756c37f83538be5 Reviewed-on: https://gerrit.libreoffice.org/59776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-30use realloc instead of malloc+memcpyNoel Grandin
Change-Id: Ia69be8db2b735c28cc69f478efcff3b6a2cdbbf2 Reviewed-on: https://gerrit.libreoffice.org/59775 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29Replace find_if with proper quantifier algorithmsArkadiy Illarionov
Change-Id: Icc820a47ac891c358883f9c01224f676c58fdd11 Reviewed-on: https://gerrit.libreoffice.org/59744 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29Various Haiku improvementsKacper Kasper
* Fix make distro-pack-install. * Remove Xorg dependency. * Remove stack protector workaround. * Update distro-config and enabled features. Change-Id: I273dc8343ad84bd77b86453cc01ff427b50ea0b5 Reviewed-on: https://gerrit.libreoffice.org/58634 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-08-29loplugin:constantparam (3)Noel Grandin
Change-Id: Ifc47bb8e096c9a8563021b2fcb44199577740746 Reviewed-on: https://gerrit.libreoffice.org/59747 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29tdf#119458 just wakeup Scheduler on active IdleJan-Marek Glogowski
So this almost returns the code to the original state, before I started fixing tdf#116370... a long way. This introduces the new Scheduler::Wakeup() function, which will just queue a Scheduler event in the System event queue unconditionally. This should prevent fdo#73165, which I couldn't reproduce, but just to be sure. More importantly this patch resets the m_bStartOnUnblock when the Idle job actually runs. This run should already determinates if more Idle work needs to be done, and others can still call BeginIdling() to ensure further processing. This also drops the IsBusyDoc() test from UnblockIdling(). We can't really know, if the document is still busy when the Scheduler is finally running, be it by the system timer or Application::Reschedule(). Change-Id: I6cc4a3c48dcaf62b6985c7bc1c95c96697443f3b Reviewed-on: https://gerrit.libreoffice.org/59730 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-29replace rtl_allocateMemory with std::mallocNoel Grandin
where used directly, since rtl_allocateMemory now just calls into std::malloc Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad Reviewed-on: https://gerrit.libreoffice.org/59685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28create toggles with WB_TOGGLE setCaolán McNamara
Change-Id: Ic4142b6f80f2b47e745c4d2bd898c6aef865ca36 Reviewed-on: https://gerrit.libreoffice.org/59703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf119556 Sync "Use only paper size from printer preferences"Michael Weghorn
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-28We do want to initialise m_MainThread on iOS, tooTor Lillqvist
This doesn't make the LibreOfficeLight app work much better, though. But at least it doesn't hang its event loop completely, some 10 s timer keeps firing. (But nothing sane shows up in the app UI, even if some welcome.odt document apparently does get loaded. Clearly something is waiting for something else that never happens...) Change-Id: Ieba22a5e1418d48a7dd6cacda526aca69cced4c3
2018-08-28tdf#119451 vcl layout cache: fix glyph fallback handlingMiklos Vajna
Type ":dog:" into Writer with e.g. the Liberation Serif font, glyph layout doesn't execute, a literal 0 glyph id is rendered. Fix the problem by returning the glyph items (to be inserted into a cache) after handling glyph fallback. Change-Id: I928b0087de309dbe04936c6e7732d79bec541596 Reviewed-on: https://gerrit.libreoffice.org/59665 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-27Fix iOS build after f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044Tor Lillqvist
Change-Id: I7b0c737b84f4528a8fba01e2998f525046834b1c
2018-08-27WIN use the SetTimer timer as one-shotJan-Marek Glogowski
SetTimer is a continuous timer, but we want to use it as a one-shot, so make sure we actually kill it when not needed. Change-Id: If6f5374346dc530eb664545ade2c2955885941b5 Reviewed-on: https://gerrit.libreoffice.org/59589 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27WIN ignore the timer resultsJan-Marek Glogowski
Nobody else will handle our scheduler or WM_TIMER event, so there is really no point to return any error value from the handlers to some lower level function. Change-Id: I33eac11076a30220cfa11cec8f352bd5c8b69209 Reviewed-on: https://gerrit.libreoffice.org/59588 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27rename ENABLE_HEADLESS option to DISABLE_GUINoel Grandin
since it has nothing to do with the headless command line option, so use the name it has in the configure.ac file Change-Id: Ibf0615ed02695d6e48a797f5632e4f417c010c70 Reviewed-on: https://gerrit.libreoffice.org/59611 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-27tdf#90376 revert the dock windows' Idles to TimersJan-Marek Glogowski
The dock windows' Timers were converted to Idles in commit eef25e0e7c03 ("changed timers to idles"). Since the Idles poll the mouse buttons, they starve all lower priority events. From the comment in ImplDockFloatWin2::Move, this is a hack to get the mouse release event from the window decorations in X11. Change-Id: Ibba3c58dd8b3d95dbd9296cc111ab32968bee230 Reviewed-on: https://gerrit.libreoffice.org/59590 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-27Add task count to Scheduler debug infoJan-Marek Glogowski
Change-Id: I60c00a40f119260ea34fb48efab72f1da8ae4e53 Reviewed-on: https://gerrit.libreoffice.org/59587 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-24Resolves: tdf#118572 ensure basic error dialog blocks any other dialogCaolán McNamara
if a dialog is already running, disable input to it until this error dialog is acknowledged. The other dialog might be running from the script which has the error. Change-Id: I10c437a25bd7c91d37eeb8241bef10709767e499 Reviewed-on: https://gerrit.libreoffice.org/59567 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24tdf#118786 WIN just assert in YieldJan-Marek Glogowski
This reminds me - again - that Jenkins doesn't run make check. It turns out InSendMessage() also returns true, if you process a nested SendMessage in the same thread. Therefore we have to remove the SalComWndProc assert and just keep the one in the Yield call. Why? Because there seem to be no way to get the information ReplyMessage has access to, so we could detect the caller / origin of the send message and implement proper nested call checks. The alternative would be to change all call sites of SendMessage to: if ( !pSalData->mpInstance->IsMainThread() ) SendMessage(...) else SalComWndProc(...) which is the same SendMessage already does. Change-Id: I991d68a64952dc5d47ba51edd8635c9e8c46614c Reviewed-on: https://gerrit.libreoffice.org/59538 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-24Just set highlight color for focus rect list boxJan-Marek Glogowski
Hopefully fixes the regression from commit 9897fd1c4715 ("Fix list box focused text color"), so it won't re-introduce tdf#109353. Change-Id: I7107deb33b959a250da9051b527099d723914223 Reviewed-on: https://gerrit.libreoffice.org/59549 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-24iRelated rhbz#1618703: Properly handle failure en-/decoding PDF fileStephan Bergmann
...when e.g. FIPS mode makes the various calls to rtl_cipher_initARCFOUR fail. Change-Id: Id1b2222249c151470e233ab814b21228f3a8b561 Reviewed-on: https://gerrit.libreoffice.org/59543 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-24Fix int vs sal_GlyphIdDon Lewis
(cherry picked from commit 7b63e739fc22b8ade19cbd6fd5a343d0b457f751) Change-Id: Ic3606609bbdcaa07340b6a5d1cd7210ddd627ed7 Reviewed-on: https://gerrit.libreoffice.org/59546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-24loplugin:useuniqueptr in BitmapScaleConvolutionFilterNoel Grandin
Change-Id: If83aecb555b3b73b2e4fd19ecfa782236bc546e6 Reviewed-on: https://gerrit.libreoffice.org/59507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-24Fix list box focused text colorJan-Marek Glogowski
This ignores the rollover state for text colors if the list box has the focus and just uses the highlight text color. This is visible in the "gen" VCL plugin and on Windows, e.g. when the focus is in the Math symbol list box. Change-Id: I00602e2a2601060f8588e474380dfa9af64a9094 Reviewed-on: https://gerrit.libreoffice.org/59488 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-23tdf#119454 don't advance PS glyphsJan-Marek Glogowski
The glyphs from SalLayout already have the correct position, so one doesn't have to advance them. This is why PS glyphs were positioned "off-by-one", which is especially visible, if your test document has words with spaces. "dm d" was almost rendered / printed as "d md". This is a regression from commit 2325f9ac789c ("fix bug in GlyphSet::DrawGlyph"), which assumed the dead / unused code was a bug, introduced by commit b157b82a6d92 ("Use GlyphItem in more places"), which out of luck, seem to have been correct. Since nobody uses the advance anywhere, just drop the parameter. Change-Id: I40e8f99a98f84d48446a9190566af8cfe441cd88 Reviewed-on: https://gerrit.libreoffice.org/59510 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-23Resolves: tdf#118659 eps not shownCaolán McNamara
since... commit 7b355669c6ddeab2e6cec692d6afdff41c61d0fb Date: Sat Apr 14 15:13:05 2018 +0900 Function to load graphic swapped out (loaded on demand) new function doesn't load the eps, so supposed to fall back to the old function, but the new function didn't leave the stream at its original position on failing to attempt the load Change-Id: I960574722687cf5ad8c78be7339d2ce6b74397a9 Reviewed-on: https://gerrit.libreoffice.org/59503 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-23loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: If33fb9d046ea7d54af16a14a77c76c2e173c0a63 Reviewed-on: https://gerrit.libreoffice.org/59499 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-23tdf#119357 add the glyph, if the lookup failedJan-Marek Glogowski
Regression from commit de8f6b25de6f ("loplugin:unused-returns in vcl") changing the logic in hunk: - return LookupGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID) - || AddGlyphID (nGlyph, nOutGlyphID, nOutGlyphSetID); + if (LookupGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID)) + AddGlyphID(nGlyph, nOutGlyphID, nOutGlyphSetID); Change-Id: Id643120e1cf5e26b3ffda933d07893048493f089 Reviewed-on: https://gerrit.libreoffice.org/59493 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-23Qt5 initialize unx glyph cacheJan-Marek Glogowski
Until we implement a Qt based glyph cache, this prevents the crash for print preview. Change-Id: I37dd3f90cc0bcac28ef4ce9fe70fd566a781d903 Reviewed-on: https://gerrit.libreoffice.org/59489 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-23ofz: various use after free and related crashes in glyph cacheCaolán McNamara
in a long lived fuzzer it eventually gets to garbage collect and the trouble begins, this can be reproduced locally and faster by setting mnMaxSize to 1 I think since... commit 0b6f2f3ff47b6f1455d213bee4b257542e527976 Date: Mon Aug 13 14:50:13 2018 +0200 loplugin:useuniqueptr in GlyphCache oss-fuzz stats show no instances of this until approx August 17th Change-Id: I1809f3d50e339ccf51a10fa2d3098752d12bc248 Reviewed-on: https://gerrit.libreoffice.org/59496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22fix oss-fuzz buildCaolán McNamara
Change-Id: Idec87abc7c7ec030e299a5dd582d6c1c44ae1a32 Reviewed-on: https://gerrit.libreoffice.org/59440 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22vcl: README claims VCL expands like Borland's VCL, not StarOffice'sMichael Stahl
Change-Id: I41b013dc3666dc990b63f1de34fe80fcc129ecc8 Reviewed-on: https://gerrit.libreoffice.org/59455 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-08-22arg is never nullCaolán McNamara
Change-Id: Ifde85786e9e0b0d9c1bdb1163b7c4a0889005323 Reviewed-on: https://gerrit.libreoffice.org/59386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22pass X11SalGraphics around by std::unique_ptrNoel Grandin
Change-Id: Id2fcf829e3ca0edcfcdd3d4daf31188ae5317b27 Reviewed-on: https://gerrit.libreoffice.org/59427 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-22Adapt Library_vclplug_kde5 to f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044Stephan Bergmann
..."loplugin:useuniqueptr in SvpSalInstance" Change-Id: I6f3f7c102fcf07f552d3256553dd39e9cd54005f
2018-08-22fix android buildNoel Grandin
after commit f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044 Date: Sun Aug 19 08:53:29 2018 +0200 loplugin:useuniqueptr in SvpSalInstance Change-Id: I0479139c28b88c049a4584c825a28217fa20b7c0
2018-08-22rename FontSelectPatternAttributes to FontSelectPatternCaolán McNamara
Change-Id: I2c018e2e61707c0d89178b0cb38a0918906e23cb Reviewed-on: https://gerrit.libreoffice.org/59390 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22drop now unused FontSelectPatternCaolán McNamara
Change-Id: Ie236f1dd88f21cf85130ab324787d7b9bd2ff81e Reviewed-on: https://gerrit.libreoffice.org/59389 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-22turn the cache around to work on LogicalFontInstanceCaolán McNamara
instead of a FontSelectPattern with an associated LogicalFontInstance use a LogicalFontInstance with owned FontSelectPatternAttributes Change-Id: I939f84731fcb8db5ff6484dcfbd2f9199bb50d23 Reviewed-on: https://gerrit.libreoffice.org/59388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21split into FontSelectPatternAttributes and LogicalFontInstance argsCaolán McNamara
Change-Id: I099d9de60e6ca85f6cf048fe935cdfe5a804e78b Reviewed-on: https://gerrit.libreoffice.org/59374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21change FindFontSubstitute to operate on FontSelectPatternAttributesCaolán McNamara
it remains to be seen if we need the the returned mpFontInstance of the coretext impl Change-Id: I48f73188250c3eb014f16ffe0a735191da5cb25b Reviewed-on: https://gerrit.libreoffice.org/59322 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21CreateFont from LogicalFontInstance instead of FontSelectPatternCaolán McNamara
Change-Id: I75e5dc2934a208c30be18b3ce3b033059fdf1164 Reviewed-on: https://gerrit.libreoffice.org/59373 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21can now use just FontSelectPatternAttributesCaolán McNamara
Change-Id: I1857afa0a9aff39118ba3c242134985f865e37c1 Reviewed-on: https://gerrit.libreoffice.org/59387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21pass GetFontFace at call siteCaolán McNamara
Change-Id: Id2677cdc386e51ae1549c548c06d095ad0f43b40 Reviewed-on: https://gerrit.libreoffice.org/59385 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21Resolves: rhbz#115937 virtual device leakCaolán McNamara
windows runs out much sooner than the other platforms Change-Id: I8ffbe32babf8854580150edfe741b03fd43e4326 Reviewed-on: https://gerrit.libreoffice.org/59404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21use LogicalFontInstance with SalGraphicsCaolán McNamara
Change-Id: I66fb1ff4b2fdcc211e0a9d5831f6dcc5e564e789 Reviewed-on: https://gerrit.libreoffice.org/59372 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-21use ImplDoSetFont instead of SetFontCaolán McNamara
i.e. the same pattern as CreateFontSubset and GetGlyphWidths Change-Id: Ie90d7279c4debe47b4d2739e12cdae86f4e70517 Reviewed-on: https://gerrit.libreoffice.org/59403 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>