summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-05-31connect up accessibility locationCaolán McNamara
Change-Id: I226e42cf6bd7aa455514439f7303b490aa6d192d Reviewed-on: https://gerrit.libreoffice.org/55137 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31focus rect for value setCaolán McNamara
Change-Id: I208cf42db4256bb7286222781cf2bf29f843c673 Reviewed-on: https://gerrit.libreoffice.org/55101 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31drop Graphic::GetBitmapNoel Grandin
so that we flush out various code using Bitmap, in favour of using BitmapEx. This is part of the process of making Bitmap largely an internal detail of vcl Change-Id: Iaf2ead5e3d9960838723fb55b812b97108093d74 Reviewed-on: https://gerrit.libreoffice.org/55062 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-31RTL support for custom widgetsCaolán McNamara
Change-Id: I34038f047c002a1ec1276f8c523db0e1c4d29065 Reviewed-on: https://gerrit.libreoffice.org/55100 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-31move some CanvasHelper::implDrawBitmap inside vclNoel Grandin
part of making mask and alpha internal details of Bitmap/BitmapEx Change-Id: I87ca24af18a29f5eb8a5761c5d95ae2806d97e77 Reviewed-on: https://gerrit.libreoffice.org/55078 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-30tdf#117859 crash in Tab Color a11yCaolán McNamara
Change-Id: I935f0b1a28b483fad70caf7af96742dee74916ad Reviewed-on: https://gerrit.libreoffice.org/55087 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-30tdf#112034 , tdf#107266 label color on basis of persona and personaKshitij Pathania
flipping is fixed. Labelcolor not gets updated immediately but when statechanged function triggers via executemethod things workwell.(like it triggers on changing mode of notebookbar) Change-Id: I755fb4ff434d7971112d2f0beb44ca09f4a7e0f1 Reviewed-on: https://gerrit.libreoffice.org/54301 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2018-05-30Log error codeStephan Bergmann
Change-Id: I6550af7949e4838d9f23310fe5ab49fb6b466eaf Reviewed-on: https://gerrit.libreoffice.org/55053 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-30tdf#117872: Revert "tdf#115284: Unify LibreOffice and system full-screen..."Tor Lillqvist
Instead, never participate in the macOS system full-screen mode. There is just too much complexity involved, and the way LibreOffice works really isn't prepared for the concept of windows having the option from a system point of view to being full-screenable or not. This means that the green bubble in window title bars changes from being a (system) full-screen toggle to being a maximize/restore toggle. Sure, the "maximize" concept also probably can be confused with LibreOffice's own full-screen concept. For instance, the Start Centre window is not expecting to be made full-screen. Still, when you from the Start Centre open a Writer document, it is the *same* window that is re-used as the Writer window, and then suddenly should be prepared to handle going full-screen. Also, it is up to each separate kind of document window whether it can be made full-screen (from the LibreOffice point of view) or not. Writer windows can, but Impress windows can't, for example. The View>Full Screen menu entry is added separately each case. Maybe I will come back to this mess later, or not. Anybody else is welcome to have a go, too, of course. This reverts commit 4b42fd7e9516fbbd8a92d97680524f32dd260fb2. Change-Id: I6983481cbd30c0e5190c450483b1246006c80632 Reviewed-on: https://gerrit.libreoffice.org/55049 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-30ImplSplitSet::mpBitmap is unusedNoel Grandin
Change-Id: Iadbeb462a34b9bdabe5bf71249eeef798fe6372a Reviewed-on: https://gerrit.libreoffice.org/55044 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30Remove AddTable unused return typeStephan Bergmann
Change-Id: Ied2dfddab780cac1a5edc21519240537d2054b1c Reviewed-on: https://gerrit.libreoffice.org/55042 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-30tdf#116498 Use win metrics for 'DIN Light' fontSamuel Mehrbrodt
This adds a special treatment for fonts which rely on the win metrics for correct line spacing calculation. At the moment, only 'DIN Light' is known to need that treatment. Change-Id: Idd9fd6f63083ab7a706e0cbcd33a947d4949d4e9 Reviewed-on: https://gerrit.libreoffice.org/53962 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-05-30use BitmapEx in the screenshot stuffNoel Grandin
part of the process of moving Bitmap usage to BitmapEx Change-Id: I4f02f8aa60d19a3639d623a998491447adf79e15 Reviewed-on: https://gerrit.libreoffice.org/55031 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-30Bitmap->BitmapEx in FixedBitmapNoel Grandin
Change-Id: I0e409beb0d046d927b6a0c1987abec42df76727d Reviewed-on: https://gerrit.libreoffice.org/55032 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-29Remove unused SFErrCodes::TableFormatStephan Bergmann
...which was apparently unused (under its original name SF_TABLEFORMAT) ever since its introduction in 571f15004533c1e7a5472e033139d5765862fb73 "Unix PS- Print Environment". (Not sure what its appearance in the comment to AddTable, also there since that introductory commit, was ever supposed to mean.) Change-Id: I363e21e2e2d23aaf17c6f10b3936ba700203b9eb Reviewed-on: https://gerrit.libreoffice.org/55020 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29disable inconsistent when setting true/falseCaolán McNamara
Change-Id: Ib612e7f38c7a1a638d69af2a6d26f1293fe0c8da Reviewed-on: https://gerrit.libreoffice.org/55011 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29remember button pressed to reuse for moveCaolán McNamara
Change-Id: I4a7f5bb8e46e190f33150f666a653bfc04957a0f Reviewed-on: https://gerrit.libreoffice.org/55010 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29only get notified for user events, not api onesCaolán McNamara
Change-Id: I4cbede587ed4de7950fd7ca435902baa26c8faf5 Reviewed-on: https://gerrit.libreoffice.org/55009 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29Change SFErrCodes to scoped enumStephan Bergmann
Change-Id: Ib2f267397e419e8164bb2d732f7cbcca7acad1a6 Reviewed-on: https://gerrit.libreoffice.org/54996 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-05-29weld SvxSwPosSizeTabPageCaolán McNamara
Change-Id: I51c83ec801884a07f7920309535a58b55171b0be Reviewed-on: https://gerrit.libreoffice.org/54934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-29weld SvxAngleTabPageCaolán McNamara
Change-Id: I03bd0a6a0805d549570ce44030a0f58ca2b98d05 Reviewed-on: https://gerrit.libreoffice.org/54818 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28fix up position of anchor widgetCaolán McNamara
Change-Id: I35823a4c84f6134bf9b005fb1ab6df12d716d14e Reviewed-on: https://gerrit.libreoffice.org/54816 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28toggle should trigger only through uiCaolán McNamara
Change-Id: I15619dad2189f81a074f8b9649c4e8b756120f2c Reviewed-on: https://gerrit.libreoffice.org/54944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28tdf#117850: Just call _Exit() in our applicationWillTerminate:Tor Lillqvist
Sure, it is just a workaround, but a very effective workaround. Change-Id: Id0daff048a27dae5cf8fb5e0e949c5b21e03fc86 Reviewed-on: https://gerrit.libreoffice.org/54924 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-28Bin ten year old temporary hackTor Lillqvist
Cmd-W works just fine without any special handling at this low level, as far as I can see. Change-Id: Ib00964553984b7aeec89d9fab9fc425c08de910a Reviewed-on: https://gerrit.libreoffice.org/54917 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-28tdf#117628 crash after closing media player with X11 backendCaolán McNamara
Change-Id: I812da5ddf7343573f93ea64e592442edb31cad2d Reviewed-on: https://gerrit.libreoffice.org/54910 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28disable part of VclComplexTextTest::testArabicNoel Grandin
fails sporadically on one of the windows buildboxes, Khaled might be able to get to it in a few weeks Change-Id: I65ebb8ad1e2ae08308d2ac150b88a393c134f715 Reviewed-on: https://gerrit.libreoffice.org/54906 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28weld ScTabBgColorDlgCaolán McNamara
Change-Id: I864382bc55dead850c13faae9958fb660fd4f156 Reviewed-on: https://gerrit.libreoffice.org/54809 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-28loplugin:unusedfieldsNoel Grandin
Change-Id: I625b73152c0c277c6e0ce3e24e4704094fc4e8ff Reviewed-on: https://gerrit.libreoffice.org/54822 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-28loplugin:unusedmethodsNoel Grandin
Change-Id: I64df1f467986b3d70c058adff289a6dd8f00fb20 Reviewed-on: https://gerrit.libreoffice.org/54821 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-27Some LibreOffice Fuzzers Can't Use AFL's Deferred ForkserverCaolán McNamara
https://github.com/google/oss-fuzz/issues/1449 Change-Id: I495f269b66f8232dce260031c4f74e574bec6aa9
2018-05-27Fix typosAndrea Gelmini
Change-Id: I4924e62af79ba225a4cc9ed2f1221111854318b9 Reviewed-on: https://gerrit.libreoffice.org/54883 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-05-26Bin crack presumably related to the removed debug dialog thingTor Lillqvist
Change-Id: Ic0cdfc837ac8503968c5226ec309e75ff7172a75 Reviewed-on: https://gerrit.libreoffice.org/54801 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-05-25loplugin:passstuffbyrefNoel Grandin
Change-Id: I785e96599bbda029adf4698d11d7f981750dec07 Reviewed-on: https://gerrit.libreoffice.org/54802 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-25vcl: Run gla11y on demo.uiSamuel Thibault
Change-Id: I63d67709ab50e86b138fecd814b4dee7e2f2a755 Reviewed-on: https://gerrit.libreoffice.org/53925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-25Remove unnecessary code from ae37972cd25117d467d34ee8591c21dcbb5a0fecKeith Curtis
Git commit: ae37972cd25117d467d34ee8591c21dcbb5a0fec added some logic at the bottom to call Toolbox::SetItemImage to trigger the bitmap doubling code. This is no longer needed and is faster without. Change-Id: I0fb0538000d5616cb8d8a0ae35e15fb09cdf2c59 Reviewed-on: https://gerrit.libreoffice.org/54654 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-05-25tdf#113143 PDF export: fix mis-scaled JPGs on Impress note pagesMiklos Vajna
This is really similar to commit 4c2172a3e973bc6351107a3a1b554c77b40b75dd (tdf#106702 PDF export: fix missing images from Writer headers/footers, 2018-05-22) just this one is about the size of the output rectangle for JPG content, while the previous problem was about the position of them. Also extract PdfExportTest::exportAndParse() from the last two tests to avoid duplication. Change-Id: I9812924d505e9fdaca2a95b4990e7aaa5e44fd7f Reviewed-on: https://gerrit.libreoffice.org/54773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-05-24Bin ancient AQUA_NATIVE_MENUS=FALSE crackTor Lillqvist
Using the system ("native") menubar works fine since a long time surely. No reason to keep a fallback possibility. Change-Id: I0d9ed86c28b0d832c8123b18980740dbf895ec1c Reviewed-on: https://gerrit.libreoffice.org/54775 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-24tdf#77444: Follow-up fix: Guard against GetSalData()->mpInstance being nullTor Lillqvist
Can happen at least when LibreOffice is started from the command line using the 'open' command line and passed a file name. Change-Id: I93145974a56e124550579cae8fd69ccb4a7d3bda Reviewed-on: https://gerrit.libreoffice.org/54758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-24tdf#115284: Unify LibreOffice and system full-screen concepts on macOSTor Lillqvist
Also tdf#76476, and probably more. Make it so that when a window is in full-screen mode from LibreOffice's point of view, it is also full-screen from the system's point of view, and vice versa. All three ways to enter and leave full-screen mode can now be used with the same end result: The Ctrl-Cmd-F shortcut, the "View > Full Screen" menu entry, and the green bubble on the title bar. Don't disable/deactivate/etc menus while in full-screen mode. The menu auto-hides so there is no harm in having it function normally. Don't display the floating toolbar with a single "Full Screen" button in it as the way to leave full-screen mode. Instead, the same three ways that can be used to enter full-screen mode work to leave it, too. Sadly I could not figure out a way to set a window properly to full-screen at the point where a document window is created and set to be the same size as that kind of document window was the previous time it was open in LibreOffice. Thus don't save state for full-screen windows as we can't properly restore them. At least not for macOS. It is not good to just restore them as non-full-screened but still at the size they had when full-screen. One irritating glitch remains, and I was unable to fix that properly: I now prevent closing the document window that is in full-screen mode. Otherwise, if it is closed, the full-screen mode remains even if no window is open there; the desktop is completely black. Moving the cursor to the top edge, the LibreOffice menu is there, though. I tried to fix that but with no fully satisfying result. (Some attempts even lead to crashes, so just disabling closing is better than crashing at least.) Change-Id: Id909077ef9de9f19d48c8b9ad10d748a65b2417f Reviewed-on: https://gerrit.libreoffice.org/54760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-24rework custom widget welding to enable inheritenceCaolán McNamara
Change-Id: I0d391b3fe9d2d610ae41e2a03cd2e195a866e103 Reviewed-on: https://gerrit.libreoffice.org/54681 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-24Resolves: tdf#117737 combobox menu misplaced if wrap-width setCaolán McNamara
so use ellipsize instead and set the height to one single line Change-Id: Icb124669410c041880ce468f3cf56fdb4bc1c9f1 Reviewed-on: https://gerrit.libreoffice.org/54751 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-23forward more a11y stuff for native drawing area widgetCaolán McNamara
Change-Id: Ic5529a73e317fb652944155fabc889b693447355 Reviewed-on: https://gerrit.libreoffice.org/54704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-05-23Add debug output operator<< for SalFrameGeometryTor Lillqvist
Change-Id: Ifb855eb3fa6d58c06cf145523dbb0735b2ca5a0b Reviewed-on: https://gerrit.libreoffice.org/54702 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-05-23Revert "vcl: StartPresentationMode should be using a sal_uInt32.."Noel Grandin
This reverts commit 9321c560943330fbc76dacfebff67bd740fbc95b. This is just plain wrong. Both the call sites and the function that this method in turn calls want to use sal_Int32. It doesn't seem to cause any actual problems, but that's probably just lucky. Change-Id: Id77867094b9c7c209edd8b575c9203aee6515ff3 Reviewed-on: https://gerrit.libreoffice.org/54691 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-05-22tdf#106702 PDF export: fix missing images from Writer headers/footersMiklos Vajna
Position of an image is determined by the relevant bitmap scale metafile action when recompressing images. The same position was determined by PDFExtOutDevData "meta" info when not recompressing images. This second rectangle was never correct for images repeated in Writer headers/footers on non-first pages: the position was relative to the page, while PDF export sets the map mode (origin) of the output device during export, so such positions are expected to be absolute ones. The root of the problem seems to be that header images in Writer are both repeated (as the user sees it) and unrepeated (as the doc model sees it), and by the time we want to get its position, we only see the unrepeated SdrObject. Fix the problem by using the correct position from the scale action and not from PDFExtOutDevData if possible. (Also give up on running CppunitTest_vcl_pdfexport in the non-pdfium case, most of the tests there do require pdfium anyway, and the growing ifdef forest in that file just made it hard to read the code.) Change-Id: I31c14d4bd223b2804859982542ebd6d5f9abd312 Reviewed-on: https://gerrit.libreoffice.org/54674 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22Fix typosAndrea Gelmini
Change-Id: Idbe136fbfd222e8baad588dc36a2f9b7ce6996ec Reviewed-on: https://gerrit.libreoffice.org/54590 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org>
2018-05-22lok: charts context menu was misplaced + wrong LogicToLogic conversionMarco Cecchetti
Chart context menu was misplaced since the context menu expects a position related to the document window not to the chart window. Moreover map mode is not enabled for chart window, that leads to use the LogicToLogic routine which unfortunately provides a wrong pixel to twips conversion. In fact we gets a 20 twips per pixel conversion since LogicToLogic uses a fixed 72 dpi value, instead of a correctly computed output device real dpi or at least the most commonly used 96 dpi value. Change-Id: Idb4220d03fddd4b6d643c1c0fb52754bafed7e36 Reviewed-on: https://gerrit.libreoffice.org/53118 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/54649 Reviewed-on: https://gerrit.libreoffice.org/54655 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Marco Cecchetti <mrcekets@gmail.com>
2018-05-22tdf#117342 - Add Karasa Jaga to LibreOffice coreRizal Muttaqin
Change-Id: Id121df0ddc763a299c5714cadd0d61740876e3d6 Reviewed-on: https://gerrit.libreoffice.org/54512 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-05-22Revert "lokdialog: Give non-programmatic name to autofilter"Jan Holesovsky
In the meantime, we are able to treat the title-less pop-ups just fine. This reverts commit a895f6356159f4267c0ac24781814ae0cbcba0b9. Change-Id: I1e2913190e9a1141eddf9aba0732e57bd5407987 Reviewed-on: https://gerrit.libreoffice.org/54629 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-09 23:32:36 +0000