summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-01-12loplugin:stringview (clang-cl)Stephan Bergmann
Change-Id: I64177842c3f77a5ae43574a18f389b64f61bc868 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109176 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-12transparency->alpha in tools::ColorNoel
this just changes the Get/Set methods, the constructor and internal representation of Color is not changed. Change-Id: Idb6e07cc08bbaa5bd55b6bd4b585e648aef507b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109074 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12jsdialog: make Data field dialog workingSzymon Kłos
Change-Id: Iae4ec2b585272fb09253b6e05ac2a59da2219fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107777 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109098 Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-12jsdialog: enable Data field dialogsSzymon Kłos
Change-Id: I87a1446737f7d73b4d8b5b03590a0fcd3236c97c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107776 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109097 Tested-by: Jenkins
2021-01-12cid#1470786 Uncaught exceptionCaolán McNamara
Change-Id: I85e75e40c9280b16b12ea268b5070f0ce450208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-12Revert "WIN replace clipboard update thread with Idle" et alStephan Bergmann
This reverts commit 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle" plus follow-up commits f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de "WIN don't notify clipboard change with SolarMutex" and c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object". The Gerrit Jenkins Windows builds had started to abort after timeout for almost all builds now. Going back to before the youngest of the above three commits, c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object" did not improve things (see the <https://gerrit.libreoffice.org/c/core/+/109100> "Test build #1, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds timed out). But going back to before the oldest of the above three commits, 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle", does look promising (see the <https://gerrit.libreoffice.org/c/core/+/109155> "Test build #7, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds succeeded). So the hope is that reverting all three commits brings back a green master, allowing us to understand and fix the actual issue later. Change-Id: Ie83ba742f216396b49f561d19c2cda7758740502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-11Bin two unused macrosTor Lillqvist
Change-Id: I3e84b2183401e82b7b66c7a191b38d45ee935854 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109109 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-11Avoid assertion failure related to cursor sizes on macOSTor Lillqvist
No idea why this assertion failure started to show up now (at least when viewing a presentation slide show). Anyway, apparently the code needs to handle 256x256 cursors, too, and not just 128x128 and 32x32 ones. Apparently the assertion failure is caused by icon-themes/colibre/vcl/res/null.png. Sadly I don't really understand the code around here, but this commit gets rid of the assertion failure, and that is good enough for me for now. This problem was reported in a comment in the otherwise unrelated tdf#138122, and the assertion failure caused a hang, which is not good, reported as tdf#139535. That general problem is not fixed by this commit. Change-Id: I1390f00e03e0766d54969d9d62311a55da8e8945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109083 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-10vcl: implement BinaryDataContainer copy, move + testTomaž Vajngerl
Also remove constructor that takes size only - BinaryDataContainer should always be constructed with data, that is copied into the container and should be immutable. Change-Id: Ic61b393b7729b948843bd20e6676c9290c68936f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108439 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-10fix coverity parse errorsCaolán McNamara
Change-Id: I4884bfb67a061b865e8cf38b2fea6de0cb1bc3d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109057 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-10jsdialog: updates in similar fashion like other messagesSzymon Kłos
to unify all jsdialog interactions Change-Id: I22e14282f5a2c52ef44e68cb39338600004c4e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108435 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-10jsdialog: export correct children for toolboxSzymon Kłos
if toolbox has children it means we have embedded widgets so don't export notmal 'toolitem' entries Change-Id: Ia1bd3323cf3606b923a4b30e1147633dcac24a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109036 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-09lok: fix initialization variableHenry Castro
It should initialize false Change-Id: I67249bc8040688ee82bf12532178eb133f80b8e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109021 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09fix coverity parse errorsCaolán McNamara
Change-Id: I3a1179947704452e3ffec02be59d0f7bf0b75ab0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09cid#1470783 Logically dead codeCaolán McNamara
Change-Id: I0bf96d28904b84bb970c53d0cb732dc45aa2deb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-09Fix typoAndrea Gelmini
Change-Id: I44b6b006ca74a60cd00af7ee765b0e21be1afa48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109024 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-01-09vcl: remove "path" attribute from VectorGraphicDataTomaž Vajngerl
This isn't used for anything important for the vector graphic and is mostly empty string anyways. Change-Id: I1c5b52b5b407bd320cb5053141f1699971607399 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108438 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-08Introduce Color::IsFullyTransparentNoel
Change-Id: I94875b9fb7ee18edf63ed28902da4ae77eb14bb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108973 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08Remove BitmapColor::GetAlphaNoel
since its implementation is completely wrong - alpha and transparency are not the same thing, they are inverses of each other. Change-Id: Id9e00b8296391befd471345b6c86e0493a9e3f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108964 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08replace deprecated gtk-go-up, gtk-go-down, gtk-save and gtk-open labelsCaolán McNamara
Change-Id: Iaced32a6810b1a510dc300458a8860b7994226f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108951 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-08vcl: move ImplPrintTransparent() from OutputDevice to PrinterChris Sherlock
Change-Id: I6950bdca72b93b34621e0b108c2c8060c59d98d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08vcl: followup fix to c8d564094eChris Sherlock
Change-Id: I9dcff185eb3df4c79dcedd27bef488762ea19c3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108959 Tested-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-08use more IsTransparentNoel Grandin
Change-Id: I3ef18a2601a51d56614b5da9b56e871bd33ec79e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108942 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-08pdfium: add wrapper for FPDF_TEXTRENDERMODE_* definesMiklos Vajna
Change-Id: I85fe128f0b86d1e308727f7cc0f803d62c6ba48d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108952 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-08vcl: migrate OutputDevice::DrawShadowBitmapEx() to BitmapShadowFilterChris Sherlock
Change-Id: I5d8b92d91530feed92dcdf2e384448b05eebdb0f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-07replace deprecated stock labels used <= twiceCaolán McNamara
replace single use of deprecated gtk-paste replace single use of deprecated gtk-play replace single use of deprecated gtk-stop replace only two uses of deprecated gtk-clear replace only two uses of deprecated gtk-find replace only two uses of deprecated gtk-media-next replace only two uses of deprecated gtk-media-previous Change-Id: Ia749c03ad5887f7919b1d0dc2facf8ae7e5fb7a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07handle also !mbPrepared Graphic correctly when parallel loadingLuboš Luňák
GraphicFilter::MakeGraphicsAvailableThreaded() can cause loading of swapped out Graphic objects too (since def31e135e5e2c0adb1502?). So make sure those are processed the same way as they would be when swapped in. Change-Id: Ibc8eb34b2167e2e21ea2c0c5ce9da14b75f3b6f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108814 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07do not process ImpGraphic twiceLuboš Luňák
Graphic objects share those, and it's ImpGraphic that actually does all the work, so it's enough to process each one once. Change-Id: I771a68e04bf5e1d866ae32973a3096e8d4a82445 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108813 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07faster debug dumping for SkiaLuboš Luňák
Write out the png images as quickly as possible, with still at least minimal compression. Without compression the debug images are way too big, but otherwise it's preferred that this is fast (especially when possibly dumping thousands of images). Skia's PNG code ignores the quality and hardcodes the libpng defaults, so patch Skia to explicitly handle the quality we want. It'd be also possible to use SkPngEncoder directly, but SkImage makes it non-trivial to get at the pixel data if it's on the GPU, and the internal getROPixels() invoked by encodeToData() also caches the content, so be lazy and patch Skia. Change-Id: I09cc61115246de4fc9d076953eb7fec8140c32cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108668 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07set fill color when filling alphavdev area for gradients (tdf#138959)Luboš Luňák
When drawing a gradient to an alpha-enabled output device, make the area also opaque (=black in the alphavdev). Change-Id: I2ba1a598e0bf6291e5422253352a201e224af2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108806 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-01-07fix oss-fuzz build and fftesterCaolán McNamara
since... commit 94d34e53ac9eb41cba96a56bf715d4b02794a12a Date: Tue Dec 29 22:32:01 2020 +0900 Move TIFF reader and writer from filter module into VCL Change-Id: I2dc5da100071f51eaceaf1f8be4a191f6827668c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108891 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-07pdfium: rework to eliminate FPDF_ANNOTATION from the public interfaceMiklos Vajna
Change-Id: Ib11213f0307cd215b71e3da08468be6e82e2eb55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108914 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-07improve JpegWriterTest - detect type is correct during roundtripTomaž Vajngerl
Change-Id: I4560be2dd1627caf8126142930c3479668689273 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108823 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-06remove support for deprecated GtkAlignmentCaolán McNamara
Change-Id: I29e21e9e4d9b80b8c8e331ed9cce76b2e7fe0f68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108689 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06replace only use of deprecated gtk-connectCaolán McNamara
Change-Id: I09cdb5c109b67f3686e701468c5a814c6c184832 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-01-06Drop comphelper::string::equals; compare OUString to OUStringCharMike Kaganski
In cui/source/tabpages/autocdlg.cxx, use code point-based methods for comparison with sal_UCS4 values in SvxSwAutoFormatFlags. Change-Id: If34c981393774d1b8db649f0c29870e1ca6bdfe8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-06Release solar mutex before using an apartment-threaded COM objectMike Kaganski
See https://lists.freedesktop.org/archives/libreoffice/2020-December/086448.html for motivation This partially reverts f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de. Although this change is questionable, it's intended to avoid crashes (tdf#139074); a better fix should replace this eventually. Optionally releasing a lock isn't a good API and might hide other bugs, but the better solution to handle all requests in the main thread would need an even larger rewrite of the Windows clipboard code. It's simply too late for that in this LO release cycle. Change-Id: I60e847599fe873025c9903b9d6290ed4cdf4a961 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107669 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-01-06pdfium: add wrapper for FPDF_OBJECT_* definesMiklos Vajna
So that client code doesn't have to include fpdfview.h manually. Change-Id: I0cb9569f84e85953a308519ea89bed39fe4a1390 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108817 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-01-06Move TIFF reader and writer from filter module into VCLTomaž Vajngerl
Moving graphicfilter one by one into VCL to get rid of filter_gio module and all the nonsense of dynamic/static library loading in "GraphicFilter". Change-Id: I21ebc0334ee07d36553a88557d33e01d9caec9ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-01-05jsdialog: use the "WindowShow/WindowHide" to notifyHenry Castro
If the "Macro Security Warning" message dialog is disabled the idle notifier, then it is used, the "WindowShow/Window Hide" events to notify client side. Change-Id: I48281cf5b76285a86f951eb057454610e266b85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108290 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05lok: add missing global notifierHenry Castro
Occurs when server shows the "Macro Security Warning" before load the document if enable/disable macros, but there are no instances for document/view/controller yet. So it is required to use the global notifier so it can be sent messages to the client side using the JSDialog framework. Change-Id: I67f15b21cbaf21906b88145f3c5835cf0e1ff79d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108288 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-05Simplify a Unicode string constructionStephan Bergmann
Change-Id: Iba8ecae2397a5de200e959f05f3f68ab0a7b4fd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108738 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-05jsdialog: direct updates for treeviewSzymon Kłos
We should use only weld:: interfaces methods to detect moment of control's updates as all the modifications goes through weld:: API. Let's use higher abstraction layer and not use vcl implementation details. this reverts partially: 32bfa0e1c7e859aedc3988d5bfdf86f5d7bab98a Change-Id: I2dd25c08dae3f5a95d077e2715788d636be47fe4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108433 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-01-05CGLayerHolder::getScale() can be constTor Lillqvist
Change-Id: I727b2b5f1035ae70d62d3c5339a814161e3ec92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108663 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-04Don't use m prefix for a local variableTor Lillqvist
Change-Id: I73e106923d463215078a465f9ff933ea3c89255f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108665 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-04Fix comment: Division, not multiplicationTor Lillqvist
Change-Id: I901721f18f5e536bcf7c59e08b0a0f66ccfc6190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108672 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-01-04loplugin:stringviewparam: operator +=Stephan Bergmann
Change-Id: I30ce1b5bd8fb168da7067c1967c5af2569df2653 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-01-04jsdialog: override weld_message_dialogHenry Castro
It is required to create the "Macro Security Warning" message dialog Change-Id: Ic802b6e4f1a2f8c5c294aa5432f3ad5274b5e105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108289 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2021-01-04tdf#88205 Adapt uses of css::uno::Sequence to use initializer_list ctorhalfhiddencode
Change-Id: I3973c223e0f26b1ab042752d5f212c77ed2acec9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108411 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2021-01-04jsdialog: support for freeze/thawSzymon Kłos
Change-Id: Ia3ca2c3c06a95e295e400780540c176cd9606ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108498 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
generated by cgit (git 2.34.1) at 2025-01-07 20:22:17 +0000