summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2020-02-18fix uninitialized memoryLuboš Luňák
Change-Id: I1cae656d2059779774643de93c698281b55b86fd
2020-02-18jsdialog: don't report hidden toolbox items as present.Michael Meeks
Change-Id: I965d41b15c437965b605e70b228f4da6ccbeb857 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88766 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-02-17cid#1458429 silence some CHECKED_RETURNsCaolán McNamara
Change-Id: I4499ba6a1c74f809901c20a05958ca13ecdf0382 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88880 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17default to not selecting all on explicitly grabbing focusCaolán McNamara
like vcl does, cause there are assumptions built into the writer InputEdit that this is the case Change-Id: I39358e2c82f602fe2e9a62d54d075888fe80265f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88864 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17tdf#127167 Do not reset Draw/Impress page sizeKelemen Gábor
to default A4 when modifying the Size settings in Print dialog - LO Draw/Impress page Change-Id: I28321d29408964d97b2b347c0b9f16cb1fb63183 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88530 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-17disconnect damage when target window is destroyedCaolán McNamara
Change-Id: I4b14ec12112e54bc913fe960808f0bbf8ba4bada Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17improve changed_by_direct_pickCaolán McNamara
Change-Id: I5007c428b30a2827f5ba1a85eefdb8deed826b5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88855 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-17tdf#126785 qt5: Ignore external QEvent::ShortcutOverrideMichael Weghorn
For some reason, an extra external QEvent::ShortcutOverride event is triggered when a key is pressed and e.g. the Orca screen reader is enabled, which would result in duplicated input when handled as key input event as well. Therefore, ignore those ShortcutOverride events that are "spontaneous", i.e. "the event originated outside the application (a system event)". [1] [1] https://doc.qt.io/qt-5/qevent.html#spontaneous Change-Id: Ibccacb69c31d4d7ebd512c704f0e4df978c5281f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88852 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-17Related: tdf#130414 implement queue_resize for ChildFrameCaolán McNamara
so it can respond to changes to its childrens layout request state Change-Id: I32235c1df9f315954b9d91b500388abe663fa16d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-16cid#1458437: useless call in vcl/sftJulien Nabet
Change-Id: If67a7c21b04f7195e8cbab6d90d1dd24426b5dea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88752 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-16GBUILD_TRACE, support for finding out where the build time is spentLuboš Luňák
See instructions in solenv/gbuild/Trace.mk . This generates a file than can be viewed e.g. in the Chromium tracing view. Change-Id: I5f90647c58ca729375525b6daed2d4918adc8188 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88754 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-15weld NavElementBox_Impl Item WindowCaolán McNamara
Change-Id: I72a7cc6d60cb4149838933c3c57982ebefea458d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't use gtk_window_group_remove_window if widgets are not GtkWindowsCaolán McNamara
Change-Id: I80d01f29091d7cc06e82295e781ef7a53fb7776b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88739 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Resolves: tdf#130414 don't crash attempting gtk_fixed_move if parent changedCaolán McNamara
Change-Id: I5b51f1fb0eccbdb1b3ad14ff7b36077a0016a838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88738 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move dialog.hxx to vcl/include/toolkitCaolán McNamara
Change-Id: Ia3877f58b6e5ccc4fb1621e6b928638e0c850e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#130573 labels exchanged in export to BMPNoel Grandin
In the commit below, I removed the 1-bit dithered output, so restore it. regression from commit b5699cd01b6a52906880c107bac6f3802ea7353d Date: Wed Feb 8 16:18:32 2017 +0200 convert BmpConversion to scoped enum Note that this bug has been around since LO5.4 which means that anyone who has adjusted their setting in officecfg/registry/schema/org/openoffice/Office/Common.xcs with key BMP runs the risk of having that setting now revert to its prior (documented) meaning. Change-Id: Ibbda8aefbac261ff37ffab7223714f5d0343c692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13weld FindTextFieldControlCaolán McNamara
Change-Id: Ib5861855d37c72d2be2b11b77173a141db90444e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13extract NaturalSortCompare from ListBoxCaolán McNamara
Change-Id: I260c83778aea06eba9ae774739c6dc31fe5366d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13improve debugger/valgrind handling in watchdogLuboš Luňák
This way it'll avoid incorrect lock-up detection also if the debugger is attached later when LO is already running. Change-Id: I9b762ee439a62631036ad2f09f4396cca0b5ba6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88609 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13factor out dialog hacksCaolán McNamara
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13drop workben outdevgrindCaolán McNamara
Change-Id: I94978f84b45daec9ba7e782087e45182def234d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13use TopLevelWindowLocker for the lock other windows problemCaolán McNamara
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13make sure SAL_SKIA=vulkan also overrides settingsLuboš Luňák
Change-Id: I2933fec07b594c47520087664f50d48184122818
2020-02-13remove 'ATI' from the driver listLuboš Luňák
The ATI brand has not been in use for a decade, and it's confusing to have both AMD and ATI there. All AMD gfx cards use the 0x1002 formerly-ATI PCI vendor ID, so just use AMD and that vendor ID. Change-Id: I9d60f1e86fe12a2e0fe9548c7c912d2d1ecec240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88534 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13make OpenGL blacklist file code generic and use it for Skia/VulkanLuboš Luňák
Change-Id: Icc150b853f5d2d06afedcb7878f6a031aff57c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13use what gtk reports as the held buttons for mouse moveCaolán McNamara
Change-Id: I52242eb652802913382551527763737d92127129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88597 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13toplevel might not be a GtkWindow, no need to cast to GtkWindowCaolán McNamara
Change-Id: I3347bcff6f32e8eb61186216373a950b45ab1765 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88596 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13set-focus doesn't exist in GtkEventBox, only GtkWindowCaolán McNamara
Change-Id: I7e8ba4891a34fa585831e11fd4e2fcbbfe7b859d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88595 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13set up properly Vulkan context creation also for WindowsLuboš Luňák
This was somehow missing in aafe540f5a4c3593d8e56bbdbeb5f508994fe6d9. Change-Id: I5bdcc490b10c73ac4bc55aa6af29d08815cd18d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88532 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12vcl: avoid accessing null member on unloading viewsAshod Nakashian
Change-Id: If4e416c7257c861b9e13352b3329d9719b159e61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87830 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88538 Tested-by: Jenkins
2020-02-12cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
a) for vcl version, listen to modify and select, instead of just modify so we can get the artificial select via uiobject that the mobile makes use of. (and disregard the modify which we know will lead to select so we get just one event in that case) b) default to assuming something has been picked "directly" unless we know otherwise. ideally the result is that https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: Ibbf33eab88dabd55d0c329aa00c8adaf001a4f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88476 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-12clang-analyzer-deadcode.DeadStoresNoel Grandin
Change-Id: Ifa384933569b27d0d08eb479bb95b799163ae386 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88450 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-12tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenusMichael Weghorn
This implements native PopupMenus for the qt5 VCL plugin, which not only gives them the native look and feel, but also makes context menus faster (tdf#128921), accessible (e.g. to the Orca screen reader, tdf#122053), and makes them work for a case in Base's relationship dialog where entries in the non-native context menu were not selectable/clickable (tdf#130341). For now, this always shows the popup menu at cursor position, which can be changed by taking the Rectangle passed to 'Qt5Menu::ShowNativePopupMenu' into account if there should be any need. Change-Id: Ie52cbc682acacb92716ff51e8bf7f1ab07d34cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88512 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-12vcl: fix UB in Window::ImplGetFirstOverlapWindow()Miklos Vajna
mpWindowImpl can be nullptr here, see online.git's unit-load-torture test: vcl/source/window/window2.cxx:882:24: runtime error: member access within null pointer of type 'WindowImpl' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior vcl/source/window/window2.cxx:882:24 in Surrouding code already checks for nullptr mpWindowImpl, so fix it directly where the problem is reported, not a caller. (Also fix a similar case in Window::ImplCallFocusChangeActivate().) Change-Id: I34dee0fd49483c428a78fd48b54c00b2f0a26417 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88474 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-12nModCode assigned but not usedMaxim Monastirsky
aModEvt.mnCode used to get the currently pressed keys before commit fe0451259d2fb93c809c1bfa3baf5abd90019c58 ("tdf#103158 ctrl+shift should work on key up"). Now it gets the previously pressed ones, by ignoring the last nModCode assignment. My intention in the mentioned commit was to only change aModEvt.mnModKeyCode to also include the released key, and nothing else. So let's revert the unintentional change to aModEvt.mnCode. Change-Id: Ic182119e732b79bc494c73f9bd72959f75cc38b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88484 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11tdf#130478 add direct dash paint in GDIPlus (win)Armin Le Grand (Collabora)
Not as easy as hoped, see more info in the adapted file vcl\win\gdi\gdiimpl.cxx itself. Change-Id: I265888c65658d5e8a2a04b6f064d2baf3e1d9bad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88463 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-11move GraphicReader class out of graph.hxxTomaž Vajngerl
Change-Id: Id78995bfb8e8308a388ed542690ad85e4d19ce12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88425 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-11tdf#130555: Prevent negative aSelection.Min()Stephan Bergmann
...which would violate the the preconditions of the later call to maText.remove. When BreakIteratorImpl::previousWord (i18npool/source/breakiterator/breakiteratorImpl.cxx) is called to e.g. move back over a single space at the start of the text, at least for an en-US locale it will fall through to the call to BreakIterator_Unicode::previousWord (i18npool/source/breakiterator/breakiterator_unicode.cxx) at the bottom of the function. That in turn calls icu::BreakIterator::preceding, which is documented (workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) to return icu::BreakIterator::DONE (i.e., -1, see workdir/UnpackedTarball/icu/source/common/unicode/brkiter.h) in that case, which causes BreakIterator_Unicode::previousWord to return a Boundary with startPos == endPos == -1. The documentation of UNO method css.i18n.XBreakIterator::previousWord (offapi/com/sun/star/i18n/XBreakIterator.idl) is silent about the expected return value in such a case. But lets assume that returning such a [-1..-1] Boundary is as intended, and locally address this case in Edit::ImplDelete, making aSelection start at the start of the text. Change-Id: I40e17ba602088e72aa6962cb41dd8e1cdf6e2561 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88431 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-11tdf#57879 - Expand word boundaries to include connector punctuationsAndreas Heinisch
In the IDE expand word boundaries for strings in order to fully select names for double clicks and Ctrl+Shft+Left/Right. Change-Id: I4662b2170fdd5891dc020c08b9a9d8db8d477541 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86597 Tested-by: Jenkins Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-11tdf#126744 Transfer paper size and orientation to new printerKelemen Gábor
when selected from the Printer dropdown list Change-Id: Iedd53575c2e9146b663cf21b42b495473abe5165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88373 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-11cypress: mobile: Font size combobox is broken on core/master.Caolán McNamara
so https://cgit.freedesktop.org/libreoffice/online/commit/?id=08d6c3fdf9bac4ad8318151ab1402690eb950f52 isn't needed Change-Id: I8836969ae064342835287a63065e591f083f2220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88433 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-11Drop some static_cast from long to sal_Int32Stephan Bergmann
...that would just silently hide overflow in the unexpected case that the given long values do not fit into sal_Int32. (These casts had been carried over in 3270fc628b2e6a8f73ff0d1e4389d9c7595e0a50 "use OUString(Buffer) in class Edit" from the casts to xub_StrLen, aka sal_uInt16, that were present ever since 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import".) Change-Id: I1775f44d386389f00051f11cc9d1911b10feb427 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88432 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-11SplitWindow::ImplDrawBack is effectively unusedNoel Grandin
ever since commit facc94bb0aef58353d54e14f948790643ccbec32 Date: Thu Jan 30 14:36:57 2020 +0200 loplugin:unusedfields Change-Id: Idb09424a09074abe77d6d5b63ea4a526a3bb7ed2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88423 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-10operate on the text renderer cell, not the first cellCaolán McNamara
Change-Id: Id208150e45a4a5724f1e001522ee8fd94a64a91a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88375 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-04 18:19:30 +0000