summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2017-03-14return early on clearly broken xbmsCaolán McNamara
Change-Id: Ic94a75aacb6bcd47d594a12e0df999a58b04b061
2017-03-14add a separate fuzzer for OLE2David Tardon
Change-Id: I518bd8dc6fd50e96746d6d415190551c6cbfdea5 Reviewed-on: https://gerrit.libreoffice.org/35178 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-14Clean up uses of integer types in vcl/textengStephan Bergmann
Change-Id: Ic70f57784e69cd82910d834c43a65bce4c00caea
2017-03-14Use int to count to threeStephan Bergmann
Change-Id: Ic44c13fb32f4563a776c18a49c408d2a021e55af
2017-03-14tdf#105454: Stop ignoring font kerning settingKhaled Hosny
Make sure the default is for kerning to be enable, and honor the setting to disable it. This also updates the expectations for chart2_xshape tests for file that had kerning disabled and was previously ignored. Change-Id: Icf6bb75e71cae43868fba323ca3c61e4a3e81523 Reviewed-on: https://gerrit.libreoffice.org/34169 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-03-14Remove excess non-const gettersStephan Bergmann
Change-Id: Ia66394560cda5c4d517f2a9fd047bed30c2c8975
2017-03-14ToolBox: Remove dead drag'n'drop "customization" supportStephan Bergmann
There was support for an MOD2+drag operation in ToolBox, apparently intended to allow customization by re-arranging items. However, in ImplTBDragMgr::EndDragging that operation would always have ended in doing nothing: Ever since at least 8ab086b6cc054501bfbf7ef6fa509c393691e860 "initial import", what happened was a call to virtual ToolBox::Customize, but which had an empty body and wasn't overridden anywhere (and has since been cleaned away over a series of commits). Change-Id: I8c5962d7b29506dc7dc8d803f49847f30fb93ea1
2017-03-14loplugin:subtlezeroinit (clang-cl)Stephan Bergmann
Change-Id: I34367cad2d07b9fc6c8f4607ee5e74625f12e78f
2017-03-14loplugin:unoany (clang-cl)Stephan Bergmann
Change-Id: I82f69e1fda3a63c7f1a521acbb2df6412d270455
2017-03-14ToolBox::mbCommandDrag is always false nowStephan Bergmann
...after 5ac443e180c54dee69a65a1569c99afe151f2f97 "ToolBox::mbCustomizeMode is always false" Change-Id: I39bd9d07dfd8dee8e935aa612db35e11022f4ed3
2017-03-14ofz: reject broken rle bmpsCaolán McNamara
Change-Id: I1354d4aa4d7e46cd3bf463e3350071aad3ff5674
2017-03-14ToolBox::mbCustomizeMode is always falseStephan Bergmann
...after b2262e8be35d51cc18afeb60486f19576a81adc0 "callcatcher: remove some unused methods" (and other clean-up of unused functionality that came before) identified ToolBox::ImplStartCusomizeMode as unused. Change-Id: Ic2c6720ca5519842796c7e993064aed637503aa2
2017-03-14ofz: reject invalid mapmodes earlyCaolán McNamara
Change-Id: I7fae0eb980b6dc655254da8b401fc1e71a4e65cf
2017-03-14remove noise UUUU tags in commentsNoel Grandin
Change-Id: Id8a2940ae7348bf75ca967f31adf8489dc678d00 Reviewed-on: https://gerrit.libreoffice.org/35161 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-13More ToolBox sal_uInt16 -> ImplToolItems::size_type clean-upStephan Bergmann
Change-Id: I6ec50033a452493852729dc8efe78da2708cbd96
2017-03-13Simplify and sanitize some OSL_DEBUG_LEVEL > 2 (!) SAL_INFO codeTor Lillqvist
No point in outputting the enum class name when we know it is a value from that enum that we are outputting. Fix some random whitespace craziness. No point in putting that symbolic representation of an enumeration in double-quotes. It is not a string in any sense. We can pass an OUString directly in SAL_INFO. Be consistent, put a double-quote on both sides of the string (font family name), if at all. This is a way too verbose commit message for such a trivial change. Change-Id: I9e3f96856a634dc16f0e24f789c1898d7ec75fd9
2017-03-13WaE: Operator precedence is difficult to get rightTor Lillqvist
Fix C4806: '&': unsafe operation: no value of type 'bool' promoted to type 'int' can equal the given constant Change-Id: Iedd54379a67373fb3499a0a780f2cbfc83f08e84
2017-03-13Fix bit-rot in OSL_DEBUG_LEVEL>2 (!) codeTor Lillqvist
Change-Id: I376933a033a2dc2b5b7b59006b93d14a65463aed
2017-03-13Bin leftover debugging fprintf with reference to some mysterious 'grLog()'Tor Lillqvist
Change-Id: I6b9423db247583ff1dcbd469db5dfab7f89e7457
2017-03-13Clean up odd non-static member functions with pThis paramterStephan Bergmann
...and get member function const'ness right overall Change-Id: Idb422039108d1dde9f6a8b881f6dff742030f6f0
2017-03-13loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ide32700aab3427a8bf18c806968822cdf3f91bf2
2017-03-13Bin some noise commentsTor Lillqvist
Change-Id: Ia315f446c374ac08d8a4b7247c571b70cbbab5ae
2017-03-13ofz#846 timeout in wmf, can defer clip region if we don't do anythingCaolán McNamara
Change-Id: I8711bb5c676194d9b34df2584a31851dfcc901e6 Reviewed-on: https://gerrit.libreoffice.org/35143 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-13Clean up integer types representing positions in ToolBox's item vectorStephan Bergmann
(vs. uses of sal_uInt16 representing such items' IDs). APPEND and ITEM_NOTFOUND are members of ToolBox now (and have been bumped to the corresponding type's max). The payload of VclEventIds ToolboxButtonStateChanged ToolboxClick ToolboxHighlightOff ToolboxItemAdded ToolboxItemDisabled ToolboxItemEnabled ToolboxItemRemoved ToolboxItemTextChanged ToolboxItemUpdated ToolboxItemWindowChanged ToolboxSelect has been changed too (note that reading/writing of those payloads isn't very consistent, though: for some of these, values are written that are never read, while for some others no values are ever written but the reading code would like to receive some value if the payload wasn't a nullptr). Change-Id: I4856ffb3637404b8d866621a3503d7922b1b8141
2017-03-13rhbz#1431476 dnd has started copying instead of moving slidesCaolán McNamara
Is suspect something has changed in gtk3, and I think we're not supposed to use gdk_drag_drop_succeeded at this point, but instead we'd get a dragFailed signal on the failure case Change-Id: I6b305db56a29255b468ca9182d1f7e57cb4c10f4
2017-03-13improve readabilityJochen Nitschke
and make it easier to debug. top crasher in 5.3.0.3 is around this area: https://cgit.freedesktop.org/libreoffice/core/tree/vcl/source/gdi/ bmpacc2.cxx?h=libreoffice-5.3.0.3#n235 http://crashreport.libreoffice.org/stats/signature/ BitmapReadAccess::GetPixelForN32BitTcRgba( unsigned%20char%20const%20*,long,ColorMask%20const%20&)#summary in case someone wonders suffix increment '++' precedes dereference '*' Change-Id: I15876711db569d55739da3514f61ef1b981269ab Reviewed-on: https://gerrit.libreoffice.org/35099 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-03-12ofz#827 avoid oom in xpmsCaolán McNamara
Change-Id: I323be5e042e0ccb21956def70a8c481833f43998
2017-03-12Better use 0 instead of TOOLBOX_ITEM_NOTFOUND for "no ID available"Stephan Bergmann
...return value from ToolBox::GetItemId, as is done in all other places where such is returned from one of the ToolBox::GetItemId overloads. And TOOLBOX_ITEM_NOTFOUND is otherwise only used for item positions, not item IDs. (This lone odd use of TOOLBOX_ITEM_NOTFOUND was introduced with ae5f75ab0515f8ee63813ec9284fbfb2124f0a5d "Allow a common op. on a disposed toolbox", probably by accident.) Change-Id: Id767b1d8d0b3cdfdc0ec525f165d75ae0cef7301
2017-03-12ToolBox::mnFocusPos is unusedStephan Bergmann
...ever since b8f7708176f56d6093405faf6f112004db359be9 "#96972# improved key and focus handling" Change-Id: I236143997f6e90eaa8cc28e10c17ff5a647da48c
2017-03-11ofz: test if comment data is available before allocCaolán McNamara
Change-Id: I0d2cdae6a825fc74d08c55353f48f64021542be4
2017-03-11ofz#817 nStrLen-1 changed to nStrLen-3Caolán McNamara
regression from... commit ff8f6629287d0d1bdbcf4f8ed16cb8d077d08c7a Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Jan 19 16:56:34 2017 +0000 Resolves: ofz#424 guard against broken dxary length but this weird typo doesn't appears in the 5-2 and 5-3 backports, odd how I managed that Change-Id: I5fb1db2284d48ee78e717d41274a3d37ab0255cf
2017-03-11Fix typosAndrea Gelmini
Change-Id: I2be7113bfe86476acfd6550f1eed53eed83c9747 Reviewed-on: https://gerrit.libreoffice.org/35063 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-03-10tdf#106466: Use graphite2 shaper firstKhaled Hosny
We want to always prefer Graphite shaping when supported by the font, which is also what HarfBuzz does by default. Change-Id: I6670fc03b8e6b3d7e07e1b8e0062880524da1655 Reviewed-on: https://gerrit.libreoffice.org/35046 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-03-10ofz: min action has to be >= 4Caolán McNamara
Change-Id: If03837dff5d7db6907f13c32ce05a74e4a0b7b55
2017-03-10mnFormerPos is unusedCaolán McNamara
Change-Id: I147b68882d99b8712625178e5206ea7c0f5f7401
2017-03-10Propagate integer type mismatch out of ToolBox::ImplFindItemPosStephan Bergmann
Change-Id: I6f0c06491cf3c09d97b637d7456debd1e3decbcd
2017-03-10min valid jpeg len is less than 512Caolán McNamara
our qa tests already include such, so this isn't right Change-Id: I86fb02bf353fb5b228db915f04db6e36cfb40c51
2017-03-10The previous commit wasn't really thought throughStephan Bergmann
Change-Id: I88e44e637e2ac93b4deed42a2d0f94b0a973c995
2017-03-10improve scopingCaolán McNamara
Change-Id: I2c7f607f05b07b7ec5453758910fdcb7f27ae697
2017-03-10loplugin:loopvartoosmallStephan Bergmann
Change-Id: I07c13c354df1d7f523b08a39f2ed3f008051f7aa
2017-03-10ofz#799 stop decompressing if the file is truncatedCaolán McNamara
Change-Id: I4040ebbf7b21905b950f4af36012bc83aebaa320
2017-03-10ofz#797 truncate broken polygon to amount readCaolán McNamara
to avoid super slow polygon math Change-Id: I30ef0afe96d9863df27ef7a4e7f7e8e7af36f8c1
2017-03-10ofz#787 avoid bmp oomCaolán McNamara
Change-Id: Id5d1a1b8dd6d4e78bef9d09ab68d1e7daf7e1bd5
2017-03-10ofz#786 avoid svm oomCaolán McNamara
Change-Id: Ib4920d6537437fe060c453f249fa7f8da230bfc7
2017-03-10ofz#782 oom in xbmCaolán McNamara
Change-Id: I72e187203843803e7a4e76346d484f22a5cc8823
2017-03-09ofz#502 negative indexCaolán McNamara
Change-Id: I2eb3da9d378cd8fdace5ccd644f501f5119f6698
2017-03-09ofz#574 sanitize png palette indexesCaolán McNamara
Change-Id: I006ffdf5c8c751e7e07b133716022e2a9b154478 Reviewed-on: https://gerrit.libreoffice.org/34034 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-09just calculate the scanline positionsCaolán McNamara
rather than generating a big offset table to dramatically reduce the amount of memory loading graphics takes Change-Id: I8a4b1dc5cbcb686d6b8570f2eeef61ee0fe25515 Reviewed-on: https://gerrit.libreoffice.org/35005 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-09Resolves: ofz#424 guard against broken dxary lengthCaolán McNamara
Change-Id: Ia2569e963edd75cd6c27399d33e73bafe8b3f073 Reviewed-on: https://gerrit.libreoffice.org/33319 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-03-09ofz#439 protect against 0 len textCaolán McNamara
Change-Id: Ib67284636235b0d43df626a4aeed67f2bc64b491 Reviewed-on: https://gerrit.libreoffice.org/33374 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-15 07:44:02 +0000