summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2023-03-08tdf#153538: blacklist GeForce GTX 1070 Ti for Skia hardware renderingJulien Nabet
Change-Id: I4ec53d9bcde229f3df3f19e952536ba64e1dc3d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148447 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-08Simplify usage of BinaryDataContainerMike Kaganski
It is always used to store data read from streams Change-Id: I613bc446eaadf98d2b1c012002d38f23d79a40ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148450 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-07lok: form controls: rendering and mouse event forwardingMarco Cecchetti
What we got - Most controls rendered on Writer and Impress (on Calc already implemented by Tomaž Vajngerl) - Text labels rendered correctly - Mouse events forwarded to controls - Control state changed on click for Writer and Calc - Control invalidation for all apps - Fixed broken LOK_CALLBACK_MOUSE_POINTER msg - Correct pointer style when mouse is hovering over a control Need to be improved - in impress click method for a control is not executed even if the mouse event is forwarded correctly - avoid not needed control invalidations (as the one occurring on document autosaving) Change-Id: I4d5012af7f90a2c726b6b6b5b068e2be1ed5568a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146569 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147320 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2023-03-07tdf#152278 a YoavKtav Black font reported as claiming its name is in 0x4800 ↵Caolán McNamara
encoding Change-Id: Ie1f190cd4e550a21b5614d565b03422332594ede Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148417 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07tdf#153699 workaround cairo 1.17.8 problemCaolán McNamara
Change-Id: I5290dd93d06a6812acf97fe0eeec581a233a898c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148356 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-07jsdialog: don't close dialog on tab page destroySzymon Kłos
was closing the whole dialog on tab switch in Format -> Characters -> Highlight when switching to "None" also avoid sending multiple "full updates" by using the same builder for sending message Change-Id: I4540c9c857acf2b9f40482678a30335edc24e7cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148314 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-07jsdialog: enabled format Character dialog (calc)Pranam Lashkari
can be found from: Tabbed view > Format > Character Compact view > Format > Character Change-Id: I80c15237a29ef19303c71101965df9a18791cb4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148243 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-07Fix a bug parsing pdf arraysJaume Pujantell
The parser ignored number elements in some situations, like before a reference element. This manifested in creating an invalid pdf file when exporting as pdf a document that contains a pdf. Change-Id: I98625c8da8631056079814f7e824f36177cf41c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148198 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2023-03-07Drop VectorGraphicDataArrayMike Kaganski
Change-Id: If444317edf35d0627c6bc3a8c36ba973a8a0af8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148371 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins
2023-03-07Resolves tdf#153933 - Minor adjustments to EntryMessageTypeHeiko Tietze
Red adjusted to follow the standard palette and yellow to have the same saturation Change-Id: Ic40a37c77862471066a8575d4b22cc18dc6edac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148348 Reviewed-by: Vernon, Stuart Foote <vsfoote@libreoffice.org> Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-03-07tdf#153396 - Bibliography marks improvementsVojtěch Doležal
Adds option to separate function of "URL" into (listed) "URL" and "Target URL" to allow for more flexibility (in that case if target URL is empty, bibliography mark hyperlink leads to bibliography table row if possible) When writing tests also found and fixed bug where exporting new file with anchor link bibliography mark crashes LO. Change-Id: Ic1b5c8c9590c0338dcfc4fa3a981142bddae0113 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147868 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-03-07eFormat modified inside GetDateArea, but change not propogated to the callerCaolán McNamara
regression from: commit 6e7e19d9c300dbdd279789b09f94781e946fad52 Date: Wed Jul 15 12:10:32 2020 +0100 weld DateControl Change-Id: I74bc01383f04fd4e54a45058fbbc3bc082eef0e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148359 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07remove dead code in X11SalFrame::SetIconNoel Grandin
ever since commit a11cabb47249257d8b6510fe91063ade03d0c636 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jan 11 12:22:17 2023 +0000 rely on support for NET_WM_ICON found by clang-tidy dead-code Change-Id: I4b762361a7937d087dab8c5cb0f57131ce3650d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148346 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07clang-tidy dead-storeNoel Grandin
Change-Id: Id7c48e995b4f92f081fbd4d1af257e1b81e6a421 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148347 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-07clang-tidy dead-storeNoel Grandin
Change-Id: I40574713beaf1799cbc177a679e3485b4dc4eb1b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148349 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-06ofz#56734 AbrtCaolán McNamara
Change-Id: I0426c0d3a56789b2f2d24fc87ed9e88653700ca5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148358 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-06qt a11y: Handle all QAccessible::Relation flagsMichael Weghorn
The bits/flags in `QAccessible::Relation` can be set in any combination, while the previous code would only properly handle the case that `QAccessible::AllRelations` is set. This would e.g. mean that QtAccessibleWidget::relations(QAccessible::FlowsTo | QAccessible::FlowsFrom) would not return both relations as it should. The previous handling of the case that just a single flag is set also looks odd, since it would use the sal_Int16 value of the UNO relation as an index into the set of relations... Fix this by always iterating over all relations and applying the filter in `lcl_appendRelation` (only append those that match the filter). (At least for AT-SPI, the previous handling should not have caused any issues in practice, since Qt's AT-SPI bridge always passes `QAccessible::AllRelations` from what I can see.) Change-Id: Icc21ac252db026f607fe8d6041252916b1d9e3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148352 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-06clang-tidy dead-storeNoel Grandin
Change-Id: I842114880c43dfcc342b6255b7d17befb905bccb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-06no need to allocate these separatelyNoel Grandin
they are all one or two words in size Change-Id: Iec508d917d05b3ca762723bdc99be8c68b974aaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148336 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-06qt a11y: Add mapping for relations added in Qt 6.6Michael Weghorn
Map `AccessibleRelationType::CONTENT_FLOWS_FROM`, `AccessibleRelationType::CONTENT_FLOWS_TO` and `AccessibleRelationType::DESCRIBED_BY` to the Qt equivalents added in Qt 6.6 and vice versa. As described in more detail in commit e55713dffbe8d8eba18068f6c2af14c10b787220 Date: Fri Feb 17 15:25:37 2023 +0100 qt a11y: Invert relation type to match Qt's semantic , the "inverse" relation needs to be used when mapping to/from the Qt relation. For example the Orca screen reader on Linux makes use of the FlOWS_FROM and FLOWS_TO relations. So far, when using the qt6 VCL plugin with Orca running, moving focus to a Writer paragraph resulted in these warnings being emitted: warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 1 warn:vcl.qt:220606:220606:vcl/qt6/../qt5/QtAccessibleWidget.cxx:218: Unmatched relation: 2 and thus Orca not being able to make use of those relations. Sample use in Accerciser's Python console, with a Writer document having three paragraphs with texts "First", "second", and "third" and the a11y object of the second paragraph's a11y object selected in Accerciser's a11y tree view: In [1]: acc.queryText().getStringAtOffset(0, pyatspi.TEXT_GRANULARITY_PARAGRAPH) Out[1]: ('second', 0, 6) In [2]: acc.get_relation_set() Out[2]: [<Atspi.Relation object at 0x7fccc36862c0 (AtspiRelation at 0x421e100)>, <Atspi.Relation object at 0x7fccc358c280 (AtspiRelation at 0x4493c60)>] In [3]: first_relation = acc.get_relation_set()[0] In [4]: first_relation.get_n_targets() Out[4]: 1 In [5]: first_relation.get_relation_type() Out[5]: <enum ATSPI_RELATION_FLOWS_FROM of type Atspi.RelationType> In [6]: first_relation.get_target(0) Out[6]: <Atspi.Accessible object at 0x7fccc35aa4c0 (AtspiAccessible at 0x4479820)> In [7]: first_relation.get_target(0).queryText().getStringAtOffset(0, 1) Out[7]: ('First', 0, 5) In [8]: second_relation = acc.get_relation_set()[1] In [9]: second_relation.get_n_targets() Out[9]: 1 In [10]: second_relation.get_relation_type() Out[10]: <enum ATSPI_RELATION_FLOWS_TO of type Atspi.RelationType> In [11]: second_relation.get_target(0).queryText().getStringAtOffset(0,1) Out[11]: ('third', 0, 5) (QTBUG-105864 [1] also has a sample doc and pyatspi script that can be used for testing.) Qt commit adding the relations [2]: commit f5358e5932bc8701621389c265c4ea86c92c536c Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Feb 17 13:48:38 2023 +0100 a11y: Add new relations DescriptionFor, Described, Flows{From,To} This is equivalent to the corresponding relation types defined in the IAccessible2 spec [1] (IA2_RELATION_DESCRIPTION_FOR, IA2_RELATION_DESCRIBED_BY, IA2_RELATION_FLOWS_FROM, IA2_RELATION_FLOWS_TO) and for AT-SPI on Linux [2] (relation types ATSPI_RELATION_DESCRIPTION_FOR, ATSPI_RELATION_DESCRIBED_BY, ATSPI_RELATION_FLOWS_FROM, ATSPI_RELATION_FLOWS_TO). User Interface Automation (UIA) on Windows also has corresponding properties for 3 of them [3]: UIA_DescribedByPropertyId, UIA_FlowsFromPropertyId, UIA_FlowsToPropertyId. This commit adds the new flags and implements the mapping for the AT-SPI case. Note that the relation type is conceptually always "inverted" when comparing Qt and AT-SPI (or Qt and UIA) as clarified in afbfe30093d49eff0ec4c28c220d33c233b9f807. "QAccessible::Description" instead of "QAccessible::DescriptionFor" would align better with the naming scheme of the other relations, but that is already used in the Text enum. [1] https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/group__grp_relations.html [2] https://lazka.github.io/pgi-docs/Atspi-2.0/enums.html#Atspi.RelationType [3] https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-automation-element-propids [ChangeLog][QtGui][QAccessible::RelationFlag] Added new relation flags DescriptionFor, Described, FlowsFrom and FlowsTo. Fixes: QTBUG-105864 Change-Id: If2d46099eeea75e177358c821d1ae833a553bd0e Reviewed-by: Jan Arve Sæther <jan-arve.saether@qt.io> [1] https://bugreports.qt.io/browse/QTBUG-105864 [2] https://code.qt.io/cgit/qt/qtbase.git/commit/?id=f5358e5932bc8701621389c265c4ea86c92c536c Change-Id: I6e5d78fb26f62a6f1745d4f94647e8dc0fe2abfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138687 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-06jsdialog: enabled format Character dialog (writer)Pranam Lashkari
can be found from: Tabbed view > Format > Character Sidebar > Character Compact view > Format > Character Change-Id: I43f9dc63a1941345a7ef55bfecd8bb38f652208e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148242 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-06jsdialog: send full update when showing BuilderPageSzymon Kłos
BuilderPage when created welds only container. Detect that case when full update wasn't sent in weld_dialog or weld_assistant so we show new tab pages. Fixes problem in Characters -> Higlight -> Color Change-Id: Iab38493a12feb4fc5e8b258125987856485275a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148221 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-06BaseMutex->std::mutex in DNDListenerContainerNoel Grandin
Change-Id: I0e7bb629eb4d52ddd43774a2c1a5133d6f265d23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148278 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-05ofz#56551 TimeoutCaolán McNamara
Change-Id: I491ef30362a56bf954233c3bc1e58549f9d2d5f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148286 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-05tdf#153180: PngImageWriter add support for gray alpha colortypeSarper Akdemir
8 bit grayscale images can have alpha accompanying it, and PNG supports 2 channel gray-alpha images. libpng supports this with the use of colortype PNG_COLOR_TYPE_GRAY_ALPHA. This patch adds support for writing GRAY_ALPHA colorType PNG images. This is done by expanding what was in place for ScanlineFormat::N24BitTcRgb with alpha PNG_COLOR_TYPE_RGBA. Change-Id: I80d462d784f91529eb9371c6bdb029c78f32f81e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146138 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-03-04jsdialog: sort enabled UI files by namePranam Lashkari
this helps avoid repeating them Change-Id: Iaa1d73ca1e396c18a0486ca89cb3b0a26571569d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148241 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04JSDialog: implemented jsdialog support for the toggle buttonsPranam Lashkari
Change-Id: I21408f7344f7e100373c368036f81503302b93ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148240 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04tdf#153803 qt: Let Qt style draw combobox popup bordersMichael Weghorn
... and listbox popup borders as well. Declare suppport for native drawing of focus for pushbuttons, since the Qt-based VCL plugins take care of drawing focus for controls. As far as I can see, there is no need to actually implement drawing of focus separately for the Qt-based VCL plugins, though, since that is already handled by the `ControlState::FOCUSED` state when drawing the entire control. Support for this is what `ComboBox::ImplInit` and `ListBox::ImplInit` check and if it's not supported, they enable double buffering for the window (which would have the result that the `pWin` in `ImplDrawFrame` in vcl/source/window/decoview.cxx would be nullptr and thus no native drawing of the frame would happen), s.a. commit d4714b0fdb81e6e561ae526cc517ecc9a40a603e Date: Mon Jun 17 17:02:54 2019 +0200 tdf#101978 vcl combobox/listbox floating window: avoid flicker With this in place, the border in the popup windows for listboxes and comboboxes are drawn by the Qt style. Yet another way to achieve this would be to support drawing `ControlPart::ListboxWindow` for `ControlType::Listbox`, so that the other rendering path in `ImplSmallBorderWindowView::DrawWindow` is taken, but that is currently complicated by the fact that bounding and content rect are not really used consequently there, so that would have to be cleaned up first, s.a. the commit message in commit 5c96e813bed3293605f8d746f188cc051d1e5949 Date: Thu Feb 2 15:27:37 2023 +0000 tdf#150451 Fix borders in Editbox controls (kf5) for more details. Change-Id: I8cd2396e7075a475e53e016acbb16d6fb54bad2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148160 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2023-03-04jsdialog: enable chart wizardSzymon Kłos
Change-Id: I7d6f4b4e6022507a57224ad40785f5f4f4537ea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148215 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04jsdialog: handle weld_widget_for_responseSzymon Kłos
Change-Id: I3b8d3911ff93bd26f8bdfb498b547fd335c3db8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148113 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-04jsdialog: correct structure for RoadmapWizardSzymon Kłos
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: Id9837c208653311608bf39d6066cbf1345efc565 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148214 Tested-by: Jenkins
2023-03-03jsdialog: add wrapper for weld:AssistantSzymon Kłos
Signed-off-by: Szymon Kłos <szymon.klos@collabora.com> Change-Id: I82d045cbcc7fc4682c251ac51b19b3bd33f813f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148190 Tested-by: Jenkins
2023-03-03lok: macro: VBA message dialogs was causing assertion failureMarco Cecchetti
Get VBA MsgBox and VBA Runtime Script Error dialogs to be displayed correctly without causing an assertion failure. Provided a solution that allows VBA MsgBox to be executed in a not-async way so that the VBA script is paused until the message box is closed. Change-Id: Ica7d0d343a0ea4b6a163c1c43572f18a5779a0ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147243 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147321 Tested-by: Jenkins
2023-03-03jsdialog: hide not-used tabpage in the wizardSzymon Kłos
In the wizard initially we show only the first page. Change-Id: I18ff5362f9ceb9989bfba2d9fddebf95230331e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148108 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-03Move SalInstanceLinkButton declaration to header fileSzymon Kłos
Change-Id: Icd5b79f31e1839303e81c1914c9e30e078661d9e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148111 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-03Move SalInstanceAssistant declaration to header fileSzymon Kłos
Change-Id: I3407893c878fd37fe0968c2990c92d5d16213ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148107 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-03-03Fix typoAndrea Gelmini
Change-Id: Ic3b7dc043e13717e13ec19184f8771acdae0e5f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148141 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-03-03Fix SAL_INFO dereferencing optionalsMike Kaganski
Change-Id: I6d8ec4cd481284a42db33bf85ec7770fbb89cf83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148168 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-03-02drop TooLargeScaleForMapMode import checkCaolán McNamara
revert this part of: commit 32dc2d14287a4210589c33dbd62c6e36e095aa6e Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Mar 18 19:50:12 2022 +0000 ofz#45583 detect some invalid scale cases at import time Change-Id: Ib80eda465d5b9d975a5b30974241d9f824c6741d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148130 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-02tdf#152073 tdf#153895 basicide: Set bg color for border winMichael Weghorn
As described in the original commit to address tdf#152073 ("Glitch rendering line numbers in Basic IDE editor (kf5 only)"), the fact that the KDE Breeze style's frame border is partly transparent was causing artifacts in the Basic IDE: commit 6f4b8b7cfe2907b7da46eec6951a0e09b836a6de Author: Michael Weghorn <m.weghorn@posteo.de> Date: Tue Jan 31 16:08:53 2023 +0100 tdf#152073 qt: Draw background when drawing frame For native drawing of a frame (border), use the window background color as default color. As mentioned in commit f39f21d92ec83c3a5062f29dd26214fc83012c06 ("tdf#138010 (IV) VclScrolledWindow: Use actual border width"), the Qt/KDE Breeze style uses a frame width of 2, with the actual 1 pixel border being surrounded by a 1 pixel padding/margin. Transparent background did not ensure that the 1 pixel padding/margin is repainted and could thus result in artifacts from what was painted to that location previously (s. the Basic IDE editor example from tdf#152073). [...] However, there are cases when a transparent background is actually wanted, like in the print dialog (tdf#153895). Therefore, revert the original commit mentioned above and explicitly set a background color for the border windows of the involved windows in the Basic IDE instead, which is in line with the alternative already mentioned in the above commit ("An alternative might be to explicitly draw the background further up the call stack, [...]."), but enables transparency in the qt5/qt6/kf5-specific drawing for the frame again. Change-Id: Ifb4deb80c6ae245ec630a4fdc23f675e5587836c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148117 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-03-02Resolves: tdf#153885 keep popovers with application window parent inside thatCaolán McNamara
for wayland. If the popover window is the application window, contrain it within the application window so it won't be cut off off screen, because gtk under wayland just puts it when it wants to be regardless of screen bounds. Leave dialog hosted ones alone, like format, watermark, which are likely presented in the middle of the screen and are too small to constrain the popover inside. Change-Id: Ibdc0749613a3b587414e88be7d0aea81c637f31a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148091 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-03-02no need to allocate mpPortName separatelyNoel Grandin
it is only one pointer big Change-Id: I7c8c99c4dad4289e2f073d73e8b3703ee5c8e64e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148090 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-03-01tdf#153869 qt: Unminimize window when requestedMichael Weghorn
Remove the `Qt::WindowMinimized` state from the widget's window states if the `SalFrameToTop::RestoreWhenMin` flag is set to request restoring the minimized window. Change-Id: I0cb67f28c1e9c3f48a9a234702a4aaa7e3ffec8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/148036 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-02-28move sanitizing of Size inside GenericTypeSerializerNoel Grandin
I cannot see a useful application of a Size that is negative (at least not in a file format). Change-Id: I0c5bd8c7d3987a5c7803af2a6ae0543c4a6d7754 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147884 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-27Related: tdf#153784 margin_bottom is a cnp nonsense, should be margin_endCaolán McNamara
Change-Id: Id14f63a8bfb64622e505903820b7f081c368389c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147924 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-27ofz#56293 TimeoutCaolán McNamara
Change-Id: I8c6385b879d517b3f40a33d139295aeafb1c6354 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147874 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-27UITest does not need to be a classNoel Grandin
Change-Id: I0d9b67076abe0acc20406f594b1724a909504a1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-02-26cid#1521198 Untrusted loop boundCaolán McNamara
move sanity check inside CountTTCFonts so it applies to the fd smuggle in via filename mechanism Change-Id: Id2fee5801d71720747a8736859681e7c9a324bc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147740 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2023-02-25tdf#143148 Use pragma once in vclNirnayK
Change-Id: I99317552a32f0cb70333f542d54c86dbdd9d1746 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147676 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2023-02-24use comphelper::WeakComponentImplHelper for UIObjectUnoObjNoel Grandin
Change-Id: I5aa340e9bc8abc498f37636f191c47c738fa1c63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/147585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-11 20:55:14 +0000