summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2018-11-29band-aid: deprecated-declarations related to cupsJulien Nabet
Change-Id: I07438840fc1c3cc8e70559d44954be0c49531525 Reviewed-on: https://gerrit.libreoffice.org/64191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-29loplugin:stringconstant look for unnecessary OString constructor useNoel Grandin
and tweak the methods in check.hxx to make them more flexible when called with dc.Class(xxx ? "foo" : "bar") Change-Id: I881fe628f22121ced4d8849715d6b1c92b092da1 Reviewed-on: https://gerrit.libreoffice.org/64207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-29remove unnecessary "if (!empty()" checks before loopsNoel Grandin
found with git grep -n -A4 'if.*!.*empty' | grep -B3 -P '(\bfor)|(\bwhile)|(\bdo)' Change-Id: I582235b7cf977a0f9fb4099eb306fdb4a07b5334 Reviewed-on: https://gerrit.libreoffice.org/64169 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-28drop WB_SIMPLEMODE for TreeViewCaolán McNamara
multi selections are weird with this set Change-Id: I765c46294803d06911a6ac3fc37d68dd001aacdc Reviewed-on: https://gerrit.libreoffice.org/64187 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Check against concrete expected values in PdfExportTest::testTdf115262Stephan Bergmann
With d464d505fbf6e53a38afdd3661d320fac8c760d6 "Refactor calc non-linear ViewToDevice transform", the problems with my macOS build that I described in the commit message of (abandoned) <https://gerrit.libreoffice.org/#/c/61651/> "Omit 'Calc adjust to grid hack' when not rendering for the screen" are apparently solved: `make CppunitTest_vcl_pdfexport test` succeeds, and opening vcl/qa/cppunit/pdfexport/data/tdf115262.ods and exporting it to PDF while the on-screen Calc document is displayed at varying zoom levels leads to effectively identical files now. Assuming that 232 is the universally correct value for nFirstImageTop now (nRowTop appears to have always evaluated to 199), it looks cleaner to me to have the expected values spelled out explicitly in the test code. Change-Id: Idb9f30f4ab9641b5b5325ddd90084e4112e1b572 Reviewed-on: https://gerrit.libreoffice.org/64171 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-28Fix typo deactiveAndrea Gelmini
Change-Id: I68a87a9435784f949f1e7b730270641bd8e05b43 Reviewed-on: https://gerrit.libreoffice.org/63149 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-11-28Resolves: tdf#112215 null deref on missing optional ppd valueCaolán McNamara
Change-Id: Iba45437332df963e1aa213c587071ab293f36390 Reviewed-on: https://gerrit.libreoffice.org/64163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28Resolves: tdf#121752 let scroll wheel change active notebook tabCaolán McNamara
Change-Id: If8437346a58ea14266f11293b94082740303e5a9 Reviewed-on: https://gerrit.libreoffice.org/64158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-28loplugin:unusedfieldsNoel Grandin
Change-Id: Iffbb4e7107a0b1ae35c879c193a9ec209addf453 Reviewed-on: https://gerrit.libreoffice.org/64144 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27Use HiDPI scaling to load scaled images.Michael Meeks
We render these at apparently the same pixel size as normal images, but the underlying canvas is larger so these then end up pixel-matching the true underlying grid. Change-Id: Ic4b749127e9c81da78d06b34d9f88c5635dc64b9 Reviewed-on: https://gerrit.libreoffice.org/64044 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27weld DataSourceDialogCaolán McNamara
Change-Id: I4d3eb8aa354043d3ff57b4996db7b28ad25e0262 Reviewed-on: https://gerrit.libreoffice.org/64072 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27enable hiding gtk dialogs without ending their dialog loopCaolán McNamara
we need this to support reshowing dialog after an intermediate range selection dialog executes Change-Id: Ib6575e5d852bd1d29cc1a791a5dc2c19949b67a0 Reviewed-on: https://gerrit.libreoffice.org/64100 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-27missing declarations/includesStephan Bergmann
Change-Id: I3a9b99011467bdfe34825da24ffdf9179a3bb194
2018-11-27remove unused BorderWindowStyle enum valueNoel Grandin
Change-Id: I05ae398b75bbafe9b144a90e6735cf7d5e532ce4 Reviewed-on: https://gerrit.libreoffice.org/64097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused GraphicsStateUpdateFlags enum valuesNoel Grandin
Change-Id: I1a83c897d93a29d38aebccdba33be7b70592922e Reviewed-on: https://gerrit.libreoffice.org/64096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27Add explicit API scaling via ImageTree API.Michael Meeks
Also add image scale to in-memory cache lookup. Change-Id: I1e84b922d4a9ab2f1723c5cb8a72f295c6940504 Reviewed-on: https://gerrit.libreoffice.org/64043 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27Preserve stock images until render time.Michael Meeks
This allows us to choose to render HiDPI images at the right time, when we have the DPI of the device to render to. The first step in a better, and more industry standard way of improving our UI for HiDPI via rendering level scaling that should retain a consistent look across the app with many fewer changes. Change-Id: I36681f3242cb650de4f0b2d0fcdffbe5618e30fc Reviewed-on: https://gerrit.libreoffice.org/64040 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-27vcl: fix gtk debug codeThorsten Behrens
Change-Id: I940e1ae01ec384069cf2704fdc81b7561e9f8d63 Reviewed-on: https://gerrit.libreoffice.org/64094 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-27tdf#42949 Fix IWYU warnings in include/vcl/[f-h]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ice2eb8c5994bf2ccb88972332ca4a1d3ed41752a Reviewed-on: https://gerrit.libreoffice.org/63826 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2018-11-27remove unused BmpDitherFlags enum valuesNoel Grandin
Change-Id: I09a0eb661b66da78d8b3809124930bc761960712 Reviewed-on: https://gerrit.libreoffice.org/64064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused DrawButtonFlags enum valueNoel Grandin
Change-Id: I5e1a92d94e5b7963c8162b74f1b67dbbf3eeccc9 Reviewed-on: https://gerrit.libreoffice.org/64063 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused HelpEventMode enum valueNoel Grandin
Change-Id: I0fffa7b02ac61ef009e566d04b903cc02e9b4b3d Reviewed-on: https://gerrit.libreoffice.org/64062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27remove unused GraphicManagerDrawFlags enum valueNoel Grandin
Change-Id: I9e832da8f6b7a90d72c07ab712cbe00774496b76 Reviewed-on: https://gerrit.libreoffice.org/64060 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27tdf#114839: Drop ancient AquaBlinker crackTor Lillqvist
Most probably that was related to "pulsating" buttons that haven't been used since 10.9. Whether the code even worked (made buttons pulsate) on 10.9 anyway is unclear. Much of the code in this file uses various HITheme (Carbon?) API that as far as I know is long since deprecated and undocumented. It's weird that it still compiles, and that it doesn't get caught by the private API use checking when submitting to the the Mac App Store, in the LibreOffice Vanilla case. This change reduces the busy looping in Dialog::Execute() even when nothing happens (no user input, no mouse movement) when displaying a dialog. Change-Id: I9c62db608f637aa5d8493176feb2873f6426fd00
2018-11-27remove unused QuickHelpFlags enum valueNoel Grandin
Change-Id: Ia40e882af0df396895a19dd34caa60461cdf6c12 Reviewed-on: https://gerrit.libreoffice.org/64059 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-27tdf#121723 vcl: leave popup mode on focus loss of toplevel windowsMiklos Vajna
This way it can't happen that we open a menu or context menu, the user switches away (loosing focus) and a leftover floating window is still there. Handle this at the same place where we stop blinking the cursor on focus loss. Change-Id: I4321e8e3fa1d3f8976c0a1fa29c6a182972023bf Reviewed-on: https://gerrit.libreoffice.org/64053 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2018-11-26tdf#121647: fix regression from 85b3c799ede62a3d7ad0493fc80b629214956601Xisco Fauli
the pCP = pCodePairs statement was left behind in - std::vector<sal_UCS4>::const_iterator itInt = aSupportedRanges.begin(); - for( pCP = pCodePairs; itInt != aSupportedRanges.end(); ++itInt ) - *(pCP++) = *itInt; + for (auto const& supportedRange : aSupportedRanges) + *(pCP++) = supportedRange; Change-Id: Icedf7a4dae224f6b328f924691ec4c6767495389 Reviewed-on: https://gerrit.libreoffice.org/64038 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-11-26remove unused SalLayoutFlags enum valuesNoel Grandin
Change-Id: I5d1559c2cb201ec69fc6353aaf491fbb5c0534dd Reviewed-on: https://gerrit.libreoffice.org/64047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused DrawModeFlags enum valuesNoel Grandin
Change-Id: I86775a5b7609f5e85c8fcc18a0be7e0ee3c8f84c Reviewed-on: https://gerrit.libreoffice.org/64046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused enum value ConvertDataFormat::PDFNoel Grandin
Change-Id: I61023dc049b914fee1d5d8918b99972d34a82b4a Reviewed-on: https://gerrit.libreoffice.org/64042 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused enum value SplitWindowItemFlags::InvisibleNoel Grandin
Change-Id: I4d63601ca3658b4ffd9eaf1c13d4c17503640aa0 Reviewed-on: https://gerrit.libreoffice.org/64041 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26Anti-alias toolbar button drop-downs.Michael Meeks
Change-Id: Id4eed12f3d4a32b71d00b99e6e82ca7cefb3f8ec Reviewed-on: https://gerrit.libreoffice.org/63961 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-26like keypress does, on mouse press create a cursor if missingCaolán McNamara
Change-Id: I57cd718ed03846dbff164acb5cd3c329d9eee615 Reviewed-on: https://gerrit.libreoffice.org/64036 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26weld DataSourceTabPageCaolán McNamara
Change-Id: I99b7c2ec397829c2f7ceb7ec18ae24195b9781e2 Reviewed-on: https://gerrit.libreoffice.org/61800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26remove unused enum value SvTLEntryFlags::IN_USENoel Grandin
Change-Id: Ieb09d4d28cc2084da4660165a96561ee57d2420d Reviewed-on: https://gerrit.libreoffice.org/64029 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused enum value TrackingEventFlags::DontCallHdlNoel Grandin
Change-Id: I75b28d20e2e0954fbd2fee396b8e06e9bb7d7073 Reviewed-on: https://gerrit.libreoffice.org/64028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused ShowFlags::NoParentUpdateNoel Grandin
Change-Id: Id63e1d73643a18d823dfcb35479f0f8eb3e20b15 Reviewed-on: https://gerrit.libreoffice.org/63972 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26Fix menu insertion to specified positionAleksei Nikiforov
Change-Id: I61f870010003fae98d792f95d7fdac0e59d4305c Reviewed-on: https://gerrit.libreoffice.org/63885 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-26weld SfxVersionDialogCaolán McNamara
Change-Id: I0b69192a6eab9dadac892968a4a2d4fa3d9febde Reviewed-on: https://gerrit.libreoffice.org/64001 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-26remove unused StartTrackingFlags enum valuesNoel Grandin
Change-Id: Ib72e4d5e3e1c65bc4d44756f98392393c79dab0e Reviewed-on: https://gerrit.libreoffice.org/63971 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26remove unused DrawFlags enum valuesNoel Grandin
Change-Id: I3f313dfa085612d805ea54352793a3fb0356b986 Reviewed-on: https://gerrit.libreoffice.org/63970 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-26tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I1ac4c52ea51503373644bc58dcd4395c69f1a675 Reviewed-on: https://gerrit.libreoffice.org/64007 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25Missing test dependencyStephan Bergmann
> warn:vcl.layout:29309:29309:vcl/source/window/builder.cxx:446: DBG_UNHANDLED_EXCEPTION in VclBuilder::VclBuilder(vcl::Window*, const rtl::OUString&, const rtl::OUString&, const rtl::OString&, const com::sun::star::uno::Reference<com::sun::star::frame::XFrame>&, bool) > when: Unable to read .ui file > type: com.sun.star.container.NoSuchElementException > message: file:///.../core/instdir/share/config/soffice.cfg/vcl/ui/printprogressdialog.ui Change-Id: Ie275f5dbee52c5928276c06f65a5401a5fe1ae29 Reviewed-on: https://gerrit.libreoffice.org/63995 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-25remove unused PresentationFlags enum valuesNoel Grandin
Change-Id: I502ff07467bbfa7117131e2a3e56c45b005512d8 Reviewed-on: https://gerrit.libreoffice.org/63949 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: I8d98aa7dd77fbd79611b8a4aba77e8c378fd1cae Reviewed-on: https://gerrit.libreoffice.org/63981 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-25weld SwFrameDlgCaolán McNamara
and now can remove... commit 5d84af7e83404f22d3c9cd0b0bb88fb84d0550e7 Date: Tue Dec 4 22:43:46 2012 +0100 fdo#57553: Picture dialog Macro tab page: lazily init ... because JVM startup is annoying, so delay it until really activating Macro tab. This patch is sort of lame but with the change in bd2c14ec78a7549d4a19738154cdd5ea890f61c4 what can you do... and description is revealed to be a text_view not an entry Change-Id: Ibc92cf11870d4349ddc728ec17c846e4158e82ac Reviewed-on: https://gerrit.libreoffice.org/63916 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-25tdf#120703 PVS: V560 A part of conditional expression is always true/falseMike Kaganski
Change-Id: If173f42302553b164267909a0a3156bb25a6d558 Reviewed-on: https://gerrit.libreoffice.org/63957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-24disable more vcl pdfexport test on winNoel Grandin
Change-Id: I32fe34dc5d3d80dc26a5a2237c56155576789709 Reviewed-on: https://gerrit.libreoffice.org/63940 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-24allow collapsing rowsCaolán McNamara
Change-Id: I6b137e4fbb860a1d40acc961dae413bcdb27575a Reviewed-on: https://gerrit.libreoffice.org/63894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23weld SfxMacroTabPageCaolán McNamara
Change-Id: I167dd233c8af64e31f0e266bac5cf5b9c4658ca6 Reviewed-on: https://gerrit.libreoffice.org/63893 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-13 12:08:34 +0000