summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2022-07-17ofz#48585 Out-of-memoryCaolán McNamara
Change-Id: If6bb603cc78863df88d5630b4bd5b1198b4050de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137148 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-17tdf#149279 related: make gtk treeview scroll_to_row more sal likeJim Raykowski
The SalInstanceTreeView version of scroll_to_row always scrolls a row that is not visible to the top visible row. GtkInstanceTreeView scroll_to_row does the minimum amount of work to scroll the cell onto the screen. This means that the cell will be scrolled to the edge closest to its current position. This patch makes the gtk behavior always scroll the row so it is the top visible row. Change-Id: Ib318d7bede3723de9e84ea2db5fbfa951324facd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-07-16ofz#49157 Object-sizeCaolán McNamara
Change-Id: I3a17d7967512a282b13894ba479aa3507f1be38f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137121 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-07-15tdf#149952 gtk3 a11y: Return pos relative to window when requestedMichael Weghorn
ATK (and AT-SPI) allows to specify 3 different coordinate types [1]: 1) `ATK_XY_SCREEN`: coordinates relative to the screen. 2) `ATK_XY_WINDOW`: coordinates relative to the widget's top-level window. 3) `ATK_XY_PARENT` coordinates relative to the widget's immediate parent. The `XAccessibleComponent` interface provides equivalents for 1) and 3), but not 2), and the gtk3 VCL plugin wasn't really handling 2) so far either. This adds handling for `ATK_XY_WINDOW`. The position in the window is calculated by recursively walking up the a11y hierarchy and summing up the positions relative to the parent, until a window is reached (or there's no parent, or none implementing `AtkComponent`). Also add an explicit check for `ATK_XY_PARENT` if none of the other two constants is used and warn and return if that isn't used either, to cover the case that new constants will be introduced in newer ATK versions. (That check needs to be conditional, because `ATK_XY_PARENT` is only defined from ATK 2.30 on, while our minimum required version is currently 2.28.1.) The coordinates received when testing this with a selected Writer paragraph in Accerciser's IPython console look generally plausible now with this change in place: In [108]: acc.queryComponent().getPosition(pyatspi.component.XY_SCREEN) Out[109]: (1939, 417) In [109]: acc.queryComponent().getPosition(pyatspi.component.XY_WINDOW) Out[110]: (19, 245) In [110]: acc.queryComponent().getPosition(pyatspi.component.XY_PARENT) Out[111]: (19, 113) In [111]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_SCREEN) Out[112]: (2015, 417, 5, 19) In [112]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_WINDOW) Out[113]: (95, 245, 5, 19) In [113]: acc.queryText().getCharacterExtents(0, pyatspi.component.XY_PARENT) Out[114]: (76, 0, 5, 19) (Previously, requesting window-relative coordinates gave the same result as coordinates relative to direct parent.) [1] https://docs.gtk.org/atk/enum.CoordType.html Change-Id: Idf8f7d08f9054a8df28d1ee8fccc791a803de045 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137027 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-14loplugin:moveitNoel Grandin
Change-Id: I2702e716dc669ffbb870d36d060e110288d7a744 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137043 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13move Skia setup code to a shared functionLuboš Luňák
Change-Id: Ifcd434512854b5fedb0baf4ce1251a05f659b006 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137017 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-13loplugin:unusedmethodsNoel Grandin
Change-Id: Ifa9c3fe86e7bad6d3839fd3fdfdb8c1f7b5053c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137016 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-13Related: tdf#149956 Keep in sync after icon theme changeMaxim Monastirsky
We can't just refresh the listener for .uno:ImageOrientation, as that won't work for tdf#149741. Change-Id: Iee584c98f5b81542cd9be4760433b96e97981f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137015 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-07-13tdf#149956 Pass the correct frame to VclStatusListenerMaxim Monastirsky
Starting directly to Writer (i.e. with "--writer") will attempt to create VclStatusListeners for .uno:ImageOrientation before the frame is activated, causing the dispatcher to not be found. Also defer that stuff to after a toolbar is filled, so we get a correct initial state for toolbars which shown when the current paragraph is rtl already. (There is a similar problem with the NB, but it isn't handled in this patch.) Change-Id: Ie482007c10a4014b4a2fd4d53f05d433777ecfb6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137014 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-07-13gtk3 a11y: Activate code that needs AtkRectangleMichael Weghorn
I don't see where `HAS_ATKRECTANGLE` would be defined, not even in what we have as a single git commit that adds the code: commit 9b5df79fbd9e84ef9c2dde845867dbb1f98ac98a Date: Fri May 5 09:55:52 2006 +0000 INTEGRATION: CWS atkbridge (1.1.2); FILE ADDED 2006/03/31 14:09:17 obr 1.1.2.20: #i63580# AtkRectangle already in atk 1.7.0, but ATK_TYPE_RECTANGLE in 1.7.2 2006/03/31 12:19:39 obr 1.1.2.19: #i63583# eliminated warnings 2006/03/30 12:39:35 obr 1.1.2.18: #i63580# AtkRectangle not defined in older atk versions [...] The above extract from the commmit message as well as a quick look into the corresponding OOo ticket [1] suggest that the only concern were old ATK versions that didn't have `AtkRectangle` yet. Since the code looks sane at a quick glance at the corresponding ATK doc [2], just drop the `#ifdev HAS_ATKRECTANGLE` check and enable this unconditionally. (atk >= 2.28.1 is required by now, which definitely has AtkRectangle.) While at it, switch to the new style of using a dash instead of an underscore in the signal name. [1] https://bz.apache.org/ooo/show_bug.cgi?id=63580 [2] https://docs.gtk.org/atk/signal.Component.bounds-changed.html Change-Id: If448c5e79df6f2dd38c3a9acd414cc778f4d1f3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137011 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-13clang-tidy modernize-pass-by-value in vclNoel Grandin
Change-Id: I9ddb786eb88213c53cf53067ced6899ca40ac6e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137000 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-11tools: rename getHeight/Width() to GetOpenHeight/Width()Chris Sherlock
By default Rectangle uses closed interval, if we really want to use half open intervals then we should specifically say as such in the name. Change-Id: Id7a91120ba1a1a4bc330014216b73a692dbf03a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136575 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-11vcl: change drawToPos() to drawToIndex()Chris Sherlock
Change-Id: Iaf102e529cdfd3d758e4e6976f6a99330d8fc64b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76405 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-10tdf#143148 Use pragma once instead of include guardsehsan
Change-Id: I488c8e58620ed89adf67f93f0edb4084765a0ced Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136441 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-10tdf#143148 Use pragma once instead of include guardsehsan
Change-Id: I89f7fb1ec47ee5d7fc3ddb737527bbf2497f9454 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136774 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-08[API CHANGE] Drop css::accessibility::XAccessibleStateSetNoel Grandin
which is internal API, unused (as far as I can tell) by external users. This state is purely a bitset (as implemented by utl::AccessibleStateSetHelper) so we can just return it as a 64-bit value. This shaves significant time off the performance profiles of code that loads very complex shapes, because this state is frequently used, and we no longer need to allocate a return value on the heap for every call. Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05qt a11y: Implement QtAccessibleWidget::tableMichael Weghorn
Implement that `QAccessibleTableCellInterface::table` override by returning the parent, if it is a table. This turned out to be the missing piece when working on an implementation for the Qt library to expose the AT-SPI table cell interface for a11y objects that implement `QAccessibleTableCellInterface`, and testing the "GetTable" method by calling `acc.queryTableCell().get_table()` on a selected LO Calc cell in Accerciser's IPython console. Change-Id: I6144c613f31cafc338ccac739cd7db1bf314d4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136836 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-05lok: vcl: introduce set_cursor_data methodHenry Castro
The ScEditWindow requires to assign a cursor, so the child widget can send cursor invalidation to client side. Change-Id: I429d484a311f217f2419e38d50f8d9a422640221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136829 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-07-04tdf#149804 Set default listbox bg color to whiteMichael Weghorn
This restores white background color for list/combo boxes for the the "gen" VCL plugin after commit 3c6a53b9ce64180b2a03e097c1844f7496f26815 Date: Sat Apr 17 14:49:43 2021 +0200 improve the look of the macOS combobox Other VCL plugins and Windows, which use the system style, are covered in Change-Id I31401af38b991e7e0cdc436b894ee0f491a22752, "tdf#149804 Set newly introduced list box colors from system colors". macOS Should be unaffected by this change of the default color, since it explicitly sets one in `AquaSalFrame::UpdateSettings`. Change-Id: Ia9a660bceade683386a07c84a45a1757af38882f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136738 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-04jsdialog: send grab_focus actionSzymon Kłos
- disable jsdialogs for navigator panel for now because it breaks tests but is not used in online yet Change-Id: Ib91050363add8cda1c386627c312b79e0f62b99e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136603 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-07-02Revert "tdf#137544 std::unordered_set is cheaper here"Julien Nabet
This reverts commit 8e7edc8c3620e4f733c1974a288e5a5abd29f87e. With a brand new LO profile, launch Writer and close LO, I get: 0 0x00007f76f7e752f5 in std::__uniq_ptr_impl<comphelper::SolarMutex, std::default_delete<comphelper::SolarMutex> >::_M_ptr() const (this=0x10) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:173 1 0x00007f76f7e4ade5 in std::unique_ptr<comphelper::SolarMutex, std::default_delete<comphelper::SolarMutex> >::get() const (this=0x10) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unique_ptr.h:422 2 0x00007f76f7e07249 in SalInstance::GetYieldMutex() (this=0x0) at vcl/source/app/salvtables.cxx:145 3 0x00007f76f7ed92ee in Application::GetSolarMutex() () at vcl/source/app/svapp.cxx:576 4 0x00007f76f97f4b29 in SolarMutexGuard::SolarMutexGuard() (this=0x7ffd84f3b080) at include/vcl/svapp.hxx:1368 5 0x00007f76f98161a0 in VCLXDevice::~VCLXDevice() (this=0x724c050) at toolkit/source/awt/vclxdevice.cxx:44 6 0x00007f76f98f19d4 in cppu::ImplInheritanceHelper<VCLXDevice, com::sun::star::awt::XWindow2, com::sun::star::awt::XVclWindowPeer, com::sun::star::awt::XLayoutConstrains, com::sun::star::awt::XView, com::sun::star::awt::XDockableWindow, com::sun::star::accessibility::XAccessible, com::sun::star::lang::XEventListener, com::sun::star::beans::XPropertySetInfo, com::sun::star::awt::XStyleSettingsSupplier>::~ImplInheritanceHelper() (this=0x724c050) at include/cppuhelper/implbase.hxx:155 7 0x00007f76f98cc28f in VCLXWindow::~VCLXWindow() (this=0x724c050) at toolkit/source/awt/vclxwindow.cxx:336 8 0x00007f76f980a6bd in VCLXContainer::~VCLXContainer() (this=0x724c040) at toolkit/source/awt/vclxcontainer.cxx:45 9 0x00007f76f980a719 in VCLXContainer::~VCLXContainer() (this=0x724c040) at toolkit/source/awt/vclxcontainer.cxx:44 10 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x724c050) at cppuhelper/source/weak.cxx:230 11 0x00007f76f980d1e9 in VCLXContainer::release() (this=0x724c040) at toolkit/inc/awt/vclxcontainer.hxx:39 12 0x00007f76e49080ae in com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference() (this=0x8fa9710) at include/com/sun/star/uno/Reference.hxx:114 13 0x00007f76e4921486 in SwAccessibleDocumentBase::~SwAccessibleDocumentBase() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:77 14 0x00007f76e4923d1c in SwAccessibleDocument::~SwAccessibleDocument() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:374 15 0x00007f76e4923d89 in SwAccessibleDocument::~SwAccessibleDocument() (this=0x8fa9620) at sw/source/core/access/accdoc.cxx:370 16 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x8fa9620) at cppuhelper/source/weak.cxx:230 17 0x00007f76e490a325 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleContext3, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::lang::XServiceInfo>::release() (this=0x8fa9620) at include/cppuhelper/implbase.hxx:115 18 0x00007f76e4928495 in SwAccessibleDocument::release() (this=0x8fa9620) at sw/source/core/access/accdoc.hxx:139 19 0x00007f76ee91c11e in com::sun::star::uno::Reference<com::sun::star::uno::XInterface>::~Reference() (this=0x9012828) at include/com/sun/star/uno/Reference.hxx:114 20 0x00007f76ee9391a9 in __gnu_cxx::new_allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> >::destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (this=0x8c9a8f8, __p=0x9012828) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/ext/new_allocator.h:168 21 0x00007f76ee9390ed in std::allocator_traits<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::destroy<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >(std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> >&, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>*) (__a=..., __p=0x9012828) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/alloc_traits.h:535 22 0x00007f76ee9390ba in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::_M_deallocate_node(std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true>*) (this=0x8c9a8f8, __n=0x9012820) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable_policy.h:1894 23 0x00007f76ee939035 in std::__detail::_Hashtable_alloc<std::allocator<std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true> > >::_M_deallocate_nodes(std::__detail::_Hash_node<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, true>*) (this=0x8c9a8f8, __n=0x0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable_policy.h:1916 24 0x00007f76ee938f56 in std::_Hashtable<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Identity, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::clear() (this=0x8c9a8f8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable.h:2320 25 0x00007f76ee938ed9 in std::_Hashtable<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Identity, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, true, true> >::~_Hashtable() (this=0x8c9a8f8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/hashtable.h:1532 26 0x00007f76ee938e95 in std::__cxx1998::unordered_set<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~unordered_set() (this=0x8c9a8f8) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/bits/unordered_set.h:97 27 0x00007f76ee938e6d in std::__debug::unordered_set<com::sun::star::uno::Reference<com::sun::star::uno::XInterface>, std::hash<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::equal_to<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> >, std::allocator<com::sun::star::uno::Reference<com::sun::star::uno::XInterface> > >::~unordered_set() (this=0x8c9a8d0) at /usr/bin/../lib/gcc/x86_64-linux-gnu/11/../../../../include/c++/11/debug/unordered_set:190 28 0x00007f76ee9360fb in DocumentFocusListener::~DocumentFocusListener() (this=0x8c9a8a0) at vcl/inc/unx/gtk/gtkdata.hxx:221 29 0x00007f76ee936129 in DocumentFocusListener::~DocumentFocusListener() (this=0x8c9a8a0) at vcl/inc/unx/gtk/gtkdata.hxx:221 30 0x00007f76ff5842b0 in cppu::OWeakObject::release() (this=0x8c9a8a0) at cppuhelper/source/weak.cxx:230 -Type <RET> for more, q to quit, c to continue without paging-- 31 0x00007f76ee920fb5 in cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release() (this=0x8c9a8a0) at include/cppuhelper/implbase.hxx:115 32 0x00007f76ee9716ba in rtl::Reference<DocumentFocusListener>::~Reference() (this=0x1da9788) at include/rtl/ref.hxx:129 33 0x00007f76ee96f259 in GtkSalData::~GtkSalData() (this=0x1da9730) at vcl/unx/gtk3/gtkdata.cxx:372 34 0x00007f76ee96f309 in GtkSalData::~GtkSalData() (this=0x1da9730) at vcl/unx/gtk3/gtkdata.cxx:356 35 0x00007f76f7efc79c in DeInitVCL() () at vcl/source/app/svmain.cxx:609 36 0x00007f76f7efacaa in ImplSVMain() () at vcl/source/app/svmain.cxx:227 37 0x00007f76f7efc839 in SVMain() () at vcl/source/app/svmain.cxx:234 38 0x00007f7700ece163 in soffice_main() () at desktop/source/app/sofficemain.cxx:94 39 0x00000000004008dd in sal_main () at desktop/source/app/main.c:51 40 0x00000000004008b7 in main (argc=3, argv=0x7ffd84f3ba48) at desktop/source/app/main.c:49 Change-Id: Id4ac45bdab96b5afb7e9c18570ef4da4a81eca1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136666 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-07-02qt a11y: Only return actually supported a11y interfacesMichael Weghorn
Let `QtAccessibleWidget::interface_cast` only return a pointer to self if the underlying accessible (`m_xAccessible`)'s context implements the `XAccessible...` interface needed to have the corresponding `QAccessible...Interface` methods do anything useful (s.a. the checks at the beginning of the implementations of the corresponding `QAccessible...Interface` methods). This way, the other interfaces (or their AT-SPI equivalents) are no longer advertised as supported. (See the corresponding handling of the "GetInterfaces" AT-SPI method inside of the Qt library [1].) While at it, also add/adjust the comments indicating what methods override those from `QAccessibleTable{,Cell}Interface`. I ran into this when clicking through the LO a11y hierarchy in the Accerciser tree view and seeing the following warning in the terminal from which I had started Accerciser, after clicking on an item that was in no way related to any table in the first place: > (accerciser:192270): dbind-WARNING **: 14:05:51.582: atspi_dbus_get_property: expected a variant when fetching Caption from interface org.a11y.atspi.Table; got (so) With this change in place, unsupported interfaces are grayed out in Accerciser's "Interface Viewer" as expected, rather than being shown as active, but not displaying any useful data. [1] https://code.qt.io/cgit/qt/qtbase.git/tree/src/gui/accessible/linux/atspiadaptor.cpp?h=6.3.0#n1408 Change-Id: I1edbd451514253392e6b0a9caa6ffef2f789b55c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136782 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-02tdf#149816 qt a11y: Report position in screen coordinatesMichael Weghorn
`QAccessibleInterface::rect()` is supposed to report the geometry in screen coordinates [1]. `XAccessibleComponent::getLocationOnScreen` returns the position in screen coordinates, so use that instead of `XAccessibleComponent::getLocation`, which returns the position relative to the parent. With this in place, Accerciser correctly highlights the area of the item curently selected in its treeview of the LO a11y hierarchy. [1] https://doc.qt.io/qt-6/qaccessibleinterface.html#rect Change-Id: Iefb1e8792cd3ee720feafc81744e5e6ed6a949c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136781 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-02tdf#149804 Set newly introduced list box colors from system colorsMichael Weghorn
commit 3c6a53b9ce64180b2a03e097c1844f7496f26815 Date: Sat Apr 17 14:49:43 2021 +0200 improve the look of the macOS combobox had introduced separate style colors to be used for list/combo boxes, but since those new colors were not set explicitly for gtk3, qt5/qt6 and Windows, this resulted in style/theme/system colors no longer being used, but only the default colors introduced in above commit. This sets the style/theme/system colors for qt5/qt6, gtk3 and Windows as well, using the same values that were used previously. Change-Id: I31401af38b991e7e0cdc436b894ee0f491a22752 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136735 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-01tdf#149680 qt: Open native popup menu at given positionMichael Weghorn
Calculate the position at which to open the popup menu from the passed window and rectangle, rather than always opening the native popup menu at the cursor position. The commit message in commit 1e0b16f8695498e4eea7c2208aabf7e7664ce749 Date: Wed Feb 12 08:07:42 2020 +0100 tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenus which had implemented native poup menus, already said: > For now, this always shows the popup menu at cursor position, which > can be changed by taking the Rectangle passed to > 'Qt5Menu::ShowNativePopupMenu' into account if there should be any > need. Change-Id: If1a44b6d53f3dcd6fa7ceec0738219f11cfc22c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136356 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-06-30tdf#143148 Use pragma once in vcl partMahdi Tizabi
Change-Id: Idf48a2ee9909abb7817b37a546b5a94b13324068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136437 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2022-06-30vcl: clarify variable in Animation::Animation() loopChris Sherlock
Change-Id: Ia7e211298896c40b92cf13c81302d30ddb661cb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/76404 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-30tdf#137544 std::unordered_set is cheaper hereNoel Grandin
when the number of on screen elements becomes rather large Change-Id: I5185c2d23db733c1587eb78108f69f31e20bd913 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-29Don't link against private CoreUI framework when sandboxedChristian Lohmaier
Actual use of the code was already disabled since 2014 with b8bee05dbf85bc4f5834520aa5d64e9ae18aba4e - but the link flags were not conditionalized. Change-Id: Ia1dd299cb78274850eb6a7b10259991bb4970ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136614 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-06-29jsdialog: toggle toolbox buttons correctlySzymon Kłos
Change-Id: Ic02f9ceab29257ebc4cb6261aae10c4f1a7ef176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135562 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit b6b7b3a5a46790baf2266aaeb10976753dfe0fce) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135539 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136605 Tested-by: Jenkins
2022-06-29jsdialog: formulabar: handle multiline selectionSzymon Kłos
it uses format: "start;end;startPara;endPara" Change-Id: If3d36550f5e4a35fc04c72114c7719119b10da61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135866 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136597 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-06-29Adapt to LLVM 15 trunk libc++ dropping std::unary_/binary_functionStephan Bergmann
...for C++17 and beyond with <https://github.com/llvm/llvm-project/commit/681cde7dd8b5613dbafc9ca54e0288477f946be3> "[libc++] Complete the implementation of N4190". (Unless explicitly opted-in with _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION. This is similar to the MSVC standard library needing _HAS_AUTO_PTR_ETC=1 to enable those zombie functions for quite some time now. Only libstdc++ still supports them unconditionally.) Most uses of those zombie functions across LibreOffice itself and the bundled external/* are indirectly within Boost include files. And many (but not all) of those Boost include files only use those zombie functions conditionally, based on BOOST_NO_CXX98_FUNCTION_BASE. For the (Dinkumware-derived) MSVC standard library, workdir/UnpackedTarball/boost/boost/config/stdlib/dinkumware.hpp already defined BOOST_NO_CXX98_FUNCTION_BASE. So add a patch to define that also in workdir/UnpackedTarball/boost/boost/config/stdlib/libcpp.hpp (for all of C++11 and beyond, even if those functions were still available as deprecated in C++11 and C++14, but which shouldn't make a difference with our C++17 baseline anyway; only make sure that things still work if those Boost include files ever get used by code built with gb_CXX03FLAGS). (Patching our bundled external/boost of course doesn't help when building with such a new libc++ and --with-system-boost against an unpatched Boost, but lets consider that "not my problem". Also, one could always use a sledgehammer like passing CPPFLAGS=-D_LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION into gbuild in such a case.) Then there are two places that include boost/multi_array.hpp, which indirectly includes workdir/UnpackedTarball/boost/boost/functional.hpp, which still uses those zombie functions for non-MSVC builds (at least in the bundled Boost 1.79.0). Lets do a targeted _LIBCPP_ENABLE_CXX17_REMOVED_UNARY_BINARY_FUNCTION in those cases. (Alternatively, we could patch workdir/UnpackedTarball/boost/boost/functional.hpp. Also, I decided to make loplugin:reservedid support the new suppression mechanism, rather than extending its existing ignorelist even further.) And then there is external/clucene using those zombie functions even outside of a Boost include file, so extend the existing hack there that was already needed for MSVC. (And adapt the accompanying comment: For one, we are unconditionally "in C++17 mode" by now. And for another, the exact places where external/clucene uses those functions have apparently changed over time.) Change-Id: Id0eec3bedcfddae86b16d33c02c7b5d3b3f8a16f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136579 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-29jsdialog: be sure we send close popup message when destroyedSzymon Kłos
use different m_sTypeOfJSON for popups so we can later detect popup closing Change-Id: Id0086815317011b142b49f4e1421b76e1e663358 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135497 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136594 Tested-by: Jenkins
2022-06-29jsdialog: correctly parse click position for drawingareaSzymon Kłos
Change-Id: I8f0739cea8d2a3472926682f205bc5f5227bdc4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135241 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Mert Tumer <mert.tumer@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136593 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-06-28crashtesting: crash seen on exporting tdf117501-3.docx to odtCaolán McNamara
where the "font stretch" is sufficient to trigger the FreetypeFont ctor mfStretch limit check to create an invalid font and we end up in this failure case, which might have been missed at commit commit 894b4911ffb96ff667fdeb3aec7922316ab7230a Date: Thu Oct 28 09:27:29 2021 +0200 pass DX array around using o3tl::span instead of pointer so we get bounds checking in debug mode Change-Id: I63d0ccf37ab42954735043c6bf028d3c01616a89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136590 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-28ofz: Out-of-memoryCaolán McNamara
Change-Id: Iac52602b0c5f808b384896963c42c4f9dd31519e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-28ofz: Direct-leakCaolán McNamara
same issue as https://gitlab.freedesktop.org/cairo/cairo/-/issues/179 cairo_get_source returns a leaked pattern when the context passed in is in error, so avoid the infinite stretch which creates the error Change-Id: I239b85694773cfee77754c2f7bc819f68ef448aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136580 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-28tdf#149755 bottom of characters missing in dwrite rendered caseCaolán McNamara
snap bounding box to full pixels Change-Id: Iecd973e99cec49ee129bad422ae00f558f057abd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136577 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-28tdf#134328 only copy the RegionBand if it is actually sharedNoel Grandin
Change-Id: I870ac06dba2f41b5c005b8957049d64ff4a2d4e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136569 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-28tdf#134328 use more make_sharedNoel Grandin
one less allocation this way Change-Id: Id5fbd414837d7521306dd188306c4e60394307e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-27ofz#48407 OOMCaolán McNamara
Change-Id: I4e0ee34cffd17203b88602caecbd547fa5b58d80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136501 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-06-27tdf#149279 SwNavigator enhancement to show at least two headingsJim Raykowski
above tracked heading For gtk3, treeview scroll_to_row to a visible collapsed row makes the row expanded. The sal version does not. To make the behavior consistent, the patch removes the call to gtk_tree_view_expand_to_path which causes a visible collapsed row to expand. Change-Id: I29e67535ab23aa1952b4ff97c1b81276794b8036 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136436 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-06-26tdf#143148 Use pragma once instead of the include guardsAmir H
Change-Id: Ief3c0d01746ea1897b55f4f0994237d28a8a04e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136440 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-06-25WIN flatten and assert some codeJan-Marek Glogowski
Thanks to Mike Kaganski to come up with the correct asserts. Change-Id: I01b2b0026fc4de67a14fa803357a4c28951088ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135810 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2022-06-24tdf#149626 use recursive_mutex to fix hang in macro callback during dndCaolán McNamara
See frame #5 and frame #45 where both the same DNDEventDispatcher object and both functions lock m_aMutex which is a std::mutex since commit 8de81db4e3fca488d50db2d74734109b31541a6f Date: Mon Aug 2 09:21:17 2021 +0200 osl::Mutex->std::mutex in DNDEventDispatcher #0 0x00007ff094530c40 in __lll_lock_wait () at /lib64/libc.so.6 #1 0x00007ff0945371d2 in pthread_mutex_lock@@GLIBC_2.2.5 () at /lib64/libc.so.6 #2 0x00007ff08b901663 in __gthread_mutex_lock(pthread_mutex_t*) (__mutex=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/x86_64-redhat-linux/bits/gthr-default.h:749 #3 0x00007ff08b9024d5 in std::mutex::lock() (this=0x1a32c60) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/bits/std_mutex.h:100 #4 0x00007ff08b9018f3 in std::scoped_lock<std::mutex>::scoped_lock(std::mutex&) (this=0x7ffdd0d79240, __m=...) at /usr/bin/../lib/gcc/x86_64-redhat-linux/12/../../../../include/c++/12/mutex:731 #5 0x00007ff08b9006a8 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...) at vcl/source/window/dndeventdispatcher.cxx:156 #6 0x00007ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...) at vcl/unx/gtk3/gtkinst.cxx:1710 #7 0x00007ff0760a7010 in GtkInstDropTarget::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int) (this=0x199eb40, pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0) at vcl/unx/gtk3/gtkframe.cxx:5026 #8 0x00007ff07609bb77 in GtkSalFrame::signalDragMotion(_GtkWidget*, _GdkDragContext*, int, int, unsigned int, void*) (pWidget=0x1c67e40, context=0x1957450, x=89, y=175, time=0, frame=0x19b7d70) at vcl/unx/gtk3/gtkframe.cxx:4922 #9 0x00007ff075649527 in _gtk_marshal_BOOLEAN__OBJECT_INT_INT_UINTv () at /lib64/libgtk-3.so.0 #10 0x00007ff0865dcd5b in g_signal_emit_valist () at /lib64/libgobject-2.0.so.0 #11 0x00007ff0865ddeb8 in g_signal_emit_by_name () at /lib64/libgobject-2.0.so.0 #12 0x00007ff07595b491 in gtk_drag_dest_motion.lto_priv () at /lib64/libgtk-3.so.0 #13 0x00007ff0757b8f7d in gtk_main_do_event () at /lib64/libgtk-3.so.0 #14 0x00007ff0754e5463 in _gdk_event_emit () at /lib64/libgdk-3.so.0 #15 0x00007ff075518056 in gdk_event_source_dispatch () at /lib64/libgdk-3.so.0 #16 0x00007ff0864c3faf in g_main_context_dispatch () at /lib64/libglib-2.0.so.0 #17 0x00007ff0865192c8 in g_main_context_iterate.constprop () at /lib64/libglib-2.0.so.0 #18 0x00007ff0864c1940 in g_main_context_iteration () at /lib64/libglib-2.0.so.0 #19 0x00007ff075f3e60f in GtkSalData::Yield(bool, bool) (this=0x952930, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkdata.cxx:405 #20 0x00007ff075f43e43 in GtkInstance::DoYield(bool, bool) (this=0x9527e0, bWait=false, bHandleAllCurrentEvents=false) at vcl/unx/gtk3/gtkinst.cxx:428 #21 0x00007ff08c2dc5df in ImplYield(bool, bool) (i_bWait=false, i_bAllEvents=false) at vcl/source/app/svapp.cxx:474 #22 0x00007ff08c2dc24d in Application::Reschedule(bool) (i_bAllEvents=false) at vcl/source/app/svapp.cxx:493 #23 0x00007ff091eeeb55 in SbiRuntime::Step() (this=0xa21eb20) at basic/source/runtime/runtime.cxx:801 #24 0x00007ff091e0e659 in (anonymous namespace)::RunInitGuard::run() (this=0x76a6290) at basic/source/classes/sbxmod.cxx:1015 #25 0x00007ff091e0d135 in SbModule::Run(SbMethod*) (this=0xa0ada00, pMeth=0xa16d7e0) at basic/source/classes/sbxmod.cxx:1176 #26 0x00007ff091e0c503 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0xa0ada00, rBC=..., rHint=...) at basic/source/classes/sbxmod.cxx:775 #27 0x00007ff090b3ee6e in SfxBroadcaster::Broadcast(SfxHint const&) (this=0xa231de0, rHint=...) at svl/source/notify/SfxBroadcaster.cxx:39 #28 0x00007ff091e1372e in SbMethod::Broadcast(SfxHintId) (this=0xa231ca0, nHintId=SfxHintId::BasicDataWanted) at basic/source/classes/sbxmod.cxx:2113 #29 0x00007ff091f6ddfa in SbxObject::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/sbx/sbxobj.cxx:274 #30 0x00007ff091d9dd76 in StarBASIC::Call(rtl::OUString const&, SbxArray*) (this=0xa258670, rName="DTL_dragOver", pParam=0xa1e47d0) at basic/source/classes/sb.cxx:1324 #31 0x00007ff091dd7127 in (anonymous namespace)::BasicAllListener_Impl::firing_impl(com::sun::star::script::AllEventObject const&, com::sun::star::uno::Any*) (this=0xa2344a0, Event=..., pRet=0x0) at basic/source/classes/sbunoobj.cxx:3831 #32 0x00007ff091dd6ba1 in (anonymous namespace)::BasicAllListener_Impl::firing(com::sun::star::script::AllEventObject const&) (this=0xa2344a0, Event=...) at basic/source/classes/sbunoobj.cxx:3855 #33 0x00007ff091dd792f in (anonymous namespace)::InvocationToAllListenerMapper::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) (this=0xa110b70, FunctionName="dragOver", Params=uno::Sequence of length 1 = {...}) at basic/source/classes/sbunoobj.cxx:3983 #34 0x00007ff091dd7be7 in non-virtual thunk to (anonymous namespace)::InvocationToAllListenerMapper::invoke(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) () at /home/caolan/LibreOffice/core/instdir/program/libsblo.so #35 0x00007ff072d19921 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0xa110b98, nVtableIndex=4, pRegisterReturn=0x7ffdd0d7b5c0, pReturnTypeRef=0xa875c0, bSimpleReturn=false, pStack=0x7ffdd0d7b5e0, nStack=0, pGPR=0x7ffdd0d7b900, pFPR=0x7ffdd0d7b8c0) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77 #36 0x00007ff072d184fc in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) (pThis=0xa238bb0, aVtableSlot=..., pReturnTypeRef=0xa875c0, nParams=4, pParams=0x2470e40, pUnoReturn=0x7ffdd0d7bb80, pUnoArgs=0x7ffdd0d7bbb0, ppUnoExc=0x7ffdd0d7bb60) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233 #37 0x00007ff072d17c58 in unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**) (pUnoI=0xa238bb0, pMemberDescr=0x24c98c0, pReturn=0x7ffdd0d7bb80, pArgs=0x7ffdd0d7bbb0, ppException=0x7ffdd0d7bb60) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413 #38 0x00007ff0472645ca in stoc_invadp::(anonymous namespace)::AdapterImpl::invoke(_typelib_TypeDescription const*, void*, void**, _uno_Any**) (this=0xa112060, pMemberType=0xa11be80, pReturn=0x7ffdd0d7c4f0, pArgs=0x7ffdd0d7bca0, ppException=0x7ffdd0d7bde0) at stoc/source/invocation_adapterfactory/iafactory.cxx:457 #39 0x00007ff04726379d in stoc_invadp::adapter_dispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) (pUnoI=0xa118a50, pMemberType=0xa11be80, pReturn=0x7ffdd0d7c4f0, pArgs=0x7ffdd0d7bca0, ppException=0x7ffdd0d7bde0) at stoc/source/invocation_adapterfactory/iafactory.cxx:605 #40 0x00007ff072d04e95 in cpp2uno_call(bridges::cpp_uno::shared::CppInterfaceProxy*, _typelib_TypeDescription const*, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void**, void**, void**, unsigned long*) (pThis=0xa11b350, pMemberTypeDescr=0xa11be80, pReturnTypeRef=0x939280, nParams=1, pParams=0xa112460, gpreg=0x7ffdd0d7c520, fpreg=0x7ffdd0d7c540, ovrflw=0x7ffdd0d7c590, pRegisterReturn=0x7ffdd0d7c4f0) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:191 #41 0x00007ff072d04611 in cpp_vtable_call(sal_Int32, sal_Int32, void**, void**, void**, sal_uInt64*) (nFunctionIndex=7, nVtableOffset=0, gpreg=0x7ffdd0d7c510, fpreg=0x7ffdd0d7c540, ovrflw=0x7ffdd0d7c590, pRegisterReturn=0x7ffdd0d7c4f0) at bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx:389 #42 0x00007ff072d29836 in privateSnippetExecutor () at /home/caolan/LibreOffice/core/instdir/program/libgcc3_uno.so #43 0x00007ff08b903787 in DNDListenerContainer::fireDragOverEvent(com::sun::star::uno::Reference<com::sun::star::datatransfer::dnd::XDropTargetDragContext> const&, signed char, int, int, signed char) (this=0x5a444c0, context=uno::Reference to ((anonymous namespace)::GtkDropTargetDragContext *) 0xa1dda68, dropAction=1 '\001', locationX=89, locationY=33, sourceActions=3 '\003') at vcl/source/window/dndlistenercontainer.cxx:224 #44 0x00007ff08b900b7d in DNDEventDispatcher::fireDragOverEvent(vcl::Window*, com::sun::star::uno::Reference<com::sun::star::datatransfer::dnd::XDropTargetDragContext> const&, signed char, Point const&, signed char) (pWindow=0x5a27060, xContext=uno::Reference to ((anonymous namespace)::GtkDropTargetDragContext *) 0xa1dda68, nDropAction=1 '\001', rLocation=Point = {...}, nSourceActions=3 '\003') at vcl/source/window/dndeventdispatcher.cxx:297 #45 0x00007ff08b9007f5 in DNDEventDispatcher::dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x1a32c10, dtde=...) at vcl/source/window/dndeventdispatcher.cxx:178 #46 0x00007ff075f47658 in GtkInstDropTarget::fire_dragOver(com::sun::star::datatransfer::dnd::DropTargetDragEvent const&) (this=0x199eb40, dtde=...) at vcl/unx/gtk3/gtkinst.cxx:1710 Change-Id: I06f24ac50d6d029803d46974162e1afec898d866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136401 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-06-24tdf#143148 Use pragma once instead of include guardsMahdyar M. M. Sadeghi
Change-Id: I8d42e4873a5cce88f2d8c3a471894c4b990890ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136289 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2022-06-23Silence another unhelpful loplugin:redundantfcastStephan Bergmann
...after 37ec4442d70339dc8ec5fb8e4ec8984420b6e14d "o3tl: ensure that the initializer of enumarray contains enough elements", in Windows-only code Change-Id: I1373a5d777240104d88a892bcf048acf3e7392fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136334 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-23Revert "svp: don't directly yield in main thread"Stephan Bergmann
This reverts commit d2de55c93f94bbccff51fa7715b613341f1f4ae6 for now, because it appears to have caused a massive uptick in hung UITest_impress_tests (sd/qa/uitest/impress_tests/save_readonly_with_password.py, line 95) and UITest_writer_test6 (sw/qa/uitest/writer_tests6/save_readonly_with_password.py, line 54) tests across Jenkins, see the comments starting at <https://gerrit.libreoffice.org/c/core/+/117900/8#message-e439f5f2b9ed7a24d6f47fd640defe14dc392eb5> "svp: don't directly yield in main thread". Change-Id: Id114a0d904580024352e4acf37e2558f9f0ae6f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136250 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-06-22Detect WMF from header instead of extensionofftkp
Change ImpDetectWMF function to detect a WMF file from its header instead of just comparing the extension. Change-Id: I5a31cfd52b5425ab94424c2edce842365db04e8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134876 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-06-22Add support for exporting SVGZ in Writerofftkp
When exporting a graphic through Writer, graphicfilters ExportGraphic is called, which didn't have SVGZ exporting functionality before this commit. With this commit a valid Z compressed SVG file is exported, using the functionality that already exists in ExportGraphic. Change-Id: I6c7476ca78a8cb3719488ac4d8a5942e0557ed36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136094 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2025-01-28 14:40:13 +0000