summaryrefslogtreecommitdiff
path: root/vcl
AgeCommit message (Collapse)Author
2021-10-31tools::Long->sal_Int32 in StretchAndConvertNoel Grandin
Change-Id: Id8ceb7042cf28e9130986393aff52bc29920b51a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124502 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31tools::Long->sal_Int32 in OutputDevice::Blend*Noel Grandin
Change-Id: I26ad2727dbc258a49e7f370167b80e98438a50e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124494 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-31tools::Long->sal_Int32 in ToolboxNoel Grandin
Change-Id: I1f337558e6fcd6ea552814611cd6fb8a4f3b2f42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124493 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-30tools::Long->sal_Int32 in GetCaretPositionsNoel Grandin
Change-Id: Id3f037e132a4d07cb2b68dbb93dd24f7f6b33ab6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124461 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-30tools::Long->sal_Int32 in the DX arraysNoel Grandin
Change-Id: I36ddc11b39763dc77086591fe9bb756195b4294f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124459 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-29tdf#145274: vcl_pdfexport: Add unittestXisco Fauli
Exporting to PDF was the only way I could find to test this issue Change-Id: Id2af0f98b505c49ad912e74477d7bb5246cf850c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124341 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-10-29Use non-deprecated names for bits and constantsTor Lillqvist
Change-Id: I9004aaef7b2d526ad99b316b78733671a785c847 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124328 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-29loplugin:indentation (clang-cl)Stephan Bergmann
Change-Id: If23252e7640a9cfc9dd9feab4416ae832feddaf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124403 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-29pass DX array around using o3tl::span instead of pointerNoel Grandin
so we get bounds checking in debug mode Note that I cannot just pass around the std::vectors involved because there is a place in editeng which calls with a subset of a vector. Change-Id: I5088a139593c27bf9cbe5d843ab4b0048ac6d508 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124330 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-28gtk4: use a GtkPicture for arbitrary size/ratio toolbar imagesCaolán McNamara
so the wide .uno:BackgroundColor Toolbar MenuButton in sidebarparagraph.ui is shown correctly Change-Id: I231145092b5444fa2c70a7b3f0d85ddd6762eac1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124342 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-28gtk3 a11y: Use correct index when deselecting childMichael Weghorn
The AT-SPI selection interface provides two functions to unselect: gboolean atspi_selection_deselect_selected_child (AtspiSelection *obj, gint selected_child_index, GError **error); gboolean atspi_selection_deselect_child (AtspiSelection *obj, gint child_index, GError **error); For the first one, 'atspi_selection_deselect_selected_child', "child_index is the index in the selected-children list, not the index in the parent container." [1] For the second one, 'atspi_selection_deselect_child', "child_index is the index of the child in the parent container". [2] ATKSelection, on the other hand, only has gboolean atk_selection_remove_selection (AtkSelection *selection, gint i); where the index 'i' is "a gint specifying the index in the selection set. (e.g. the ith selection as opposed to the ith child)." [3] That means, the meaning of the index in 'atk_selection_remove_selection' is the same as in 'atspi_selection_deselect_selected_child', while 'XAccessibleSelection::deselectAccessibleChild' expects an index in the parent container, not in the selection set. Therefore, convert the index from an index in the selection to a child index first before passing it into 'XAccessibleSelection::deselectAccessibleChild'. (For ATK, the mapping from the two AT-SPI to the ATK function is done in libatk-bridge.) Example to reproduce wrong behaviour without this change in place: 1) select cells B1 to E5 in Calc 2) start Accerciser 3) select the Calc table in Accerciser 4) get AT-SPI selection interface for the table by typing the following in the IPython Console in Accerciser: sel = acc.querySelection() 5) check whether child 0 (i.e. cell A1) is selected In : sel.isChildSelected(0) Out: False -> OK 6) check whether child 1 (i.e. cell B1) is selected: In : sel.isChildSelected(1) Out: True -> OK 7a) try to unselect cell B1: In : sel.deselectChild(1) Out: True -> NOK: selection remains unchanged, cell B1 is still selected Alternatively, intead of step 7a: 7b) try to unselect cell C1 (2nd item in the selection): In : sel.deselectSelectedChild(1) Out: True -> NOK: cell B1 gets unselected instead of C1 [1] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-selected-child [2] https://developer-old.gnome.org/libatspi/unstable/libatspi-atspi-selection.html#atspi-selection-deselect-child [3] https://gnome.pages.gitlab.gnome.org/atk/AtkSelection.html#atk-selection-remove-selection Change-Id: I3c63c647e61baaa6288ffd545d8d89d8b94231de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124329 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-10-27ofz#40404 try smaller documents to avoid timeoutsCaolán McNamara
Change-Id: I7ac320fe062bc076cfd0e3d1b37e32154db79ad5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124302 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27ignoring transparency for border doesn't seem to make senseCaolán McNamara
If we are filling *and* drawing border then we do the border transparently, but if we're not filling we draw the border without transparency? I can't see that this is intentional. Change-Id: Idf8d84bed7f93b1fc4ee05ea56bc10c5e5c6e875 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124261 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-27Remove lines that have been ifdeffed out since 2008Tor Lillqvist
Change-Id: I56e17e876803a11047904187ae2fd40fbae01487 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124264 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-27Use non-deprecated names for event types and flag bitsTor Lillqvist
The deprecations were introduced in SDK 10.12 and we require at least SDK 10.13 so this should not be controversial in any way. (And seriously, I doubt LO can be built with such an old SDK anyway.) Change-Id: I5e2b18b61fa66a6b06f2c751fc9d6ea87b6cbe47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123990 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-10-26tdf#144513 improve perf when breaking long linesNoel Grandin
use the clip rectangle to stop early when the text exceeds the height of the cell Change-Id: I63dadc5b63c1f6c0852e0ba86a58f18c2b207cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124221 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26Using .md extension for vcl README filesHossein
* Renaming all README files inside 'vcl' to use .md extension * The content was previously converted into Markdown format in dc984e7fed26ed26a2cafecb0c5b27feca56bfe2 Change-Id: If55d363b418ff14864297d02a6986c4fc3625ed7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113531 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-26gtk4: get correct rectangle for custom renderer areaCaolán McNamara
Change-Id: Ic7a1bd818a308f5caff5923ff30a0741ffec7f86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124177 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26gtk4: some fonts have pango_font_description_get_size_is_absoluteCaolán McNamara
and are too large, convert back to points Change-Id: I34aafb0a0678397c1c3c5780d67bdcea405a3866 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124179 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-26flatten ImplGetTextLinesNoel Grandin
Change-Id: Iefbbcb186b2811748abf49546351a2c68e8af462 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124155 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-26ofz#1493240 Unchecked return valueCaolán McNamara
Change-Id: I17ffbd28d56513ed7b39c29f74598c7517f44190 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124160 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-25replace friend access with functionsLuboš Luňák
Change-Id: I11cb916285c72f7cd85ea5d5c943f23d0a4f6bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124148 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-10-24cid#1493240 silence Unchecked return valueCaolán McNamara
Change-Id: I3847647221cf365146c8a5f418e65e3e5798303c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124117 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-22backendtest:Reconfigured Rectangle tests to be Asymmetricalhomeboy445
The tests were previously drawing squares in the middle, however, now the tests draws rectangle taking offset from the middle. Change-Id: I26a4af997feac9ced443d7c9b4e3541ea2ba868a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120076 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-22qt: Adapt log area: "vcl.qt5" -> "vcl.qt"Michael Weghorn
And also: "vcl.opengl.qt5" -> "vcl.opengl.qt" Change-Id: I86f8a34cb8c1303a81ffbf40c801ba628f3fa0d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124065 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-10-22Rename SystemEnvData::Toolkit::{Qt5 -> Qt}Michael Weghorn
It's used for the qt6 VCL plugin as well. Change-Id: I3f57258c2c8e3c12532d79b44f24105a30590675 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124064 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-10-22Revert partly "Simplify vector initialization in vcl"Julien Nabet
since it needs 2 allocations instead of one This reverts commit 43a9bf11203ed92096af34ab828501e0218832c7 . Change-Id: I1d8553d9c31f663dd990146e6d375bbbaf32fb27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124072 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-22vcl: move variable declar's closer to 1st use in DrawComplexGradientToMetaFileChris Sherlock
Change-Id: Id626799d1b077e649f67a8abf335a63efd15d433 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123000 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-22return weld::Builder by unique_ptrNoel Grandin
Change-Id: Ifa4f5951d200eaad6c8aebd3f29eed053c927ff0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-22Optimize assignment from OUStringLiteral to OUStringStephan Bergmann
...by making the OUString's pData point to the OUStringLiteral, instead of copying the contained characters. This is one of the improvements that had not been done as part of e6dfaf9f44f9939abc338c83b3024108431d0f69 "Turn OUStringLiteral into a consteval'ed, static-refcound rtl_uString": "To keep individual commits reasonably manageable, some consumers of OUStringLiteral in rtl/ustrbuf.hxx and rtl/ustring.hxx are left in a somewhat odd state for now, where they don't take advantage of OUStringLiteral's equivalence to rtl_uString, but just keep extracting its contents and copy it elsewhere. In follow-up commits, those consumers should be changed appropriately, making them treat OUStringLiteral like an rtl_uString or dropping the OUStringLiteral overload in favor of an existing (and cheap to use now) OUString overload, etc." (Simply dropping the OUStringLiteral overload was not possible in this case, though, as that would have lead to ambiguities among the various OUString and std::u16string_view overloads.) The now-deleted OUStringLiteral rvalue reference overload means that some existing assignments from ternary-operator OUStringLiteral<N> to OUString no longer compile and had to be replaced with uses of std::u16string_view. Those had not already been replaced in e6dfaf9f44f9939abc338c83b3024108431d0f69 because they happened to use OUStringLiteral instances of identical length N in both arms of the ternary operator, so did not already start to fail to compile back then. Change-Id: I328e25b8324d045774e811d20a639f40d6a9a960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124040 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-10-22Converted VCL documentation to MarkdownHossein
Converted VCL documentation to Markdown format: * README.md Main README file (Added link to other md files) * README.vars Environment Variables in VCL * README.GDIMetaFile GDIMetaFile class * README.lifecycle Understanding Transitional VCL Lifecycle * README.scheduler VCL Scheduler Change-Id: I15d973b14005a4944f7b5104c5c80184e1083203 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123867 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-10-21ofz#40166 fix build failureCaolán McNamara
Change-Id: Ie71b63cbd7e10aff6a9374dcaad24c3153db3bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/124039 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-21loplugin:flattenNoel Grandin
Change-Id: I3b4226a9d089ec9aedab95d96e50a068f57a76c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123991 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-21tdf#144222 fix pdf export with vertical layoutMark Hung
Remove the offset adjustment that is no longer necessary. That was done in every backend before, and has been removed now. We can trust what layout text provides us. Regression from: commit dd0d0b44fd1c6c0292d7b2eb3f5cf2baa21e4481 Author: Mark Hung <marklh9@gmail.com> Date: Sun May 2 15:12:46 2021 +0800 vcl: adjust LayoutText() for vertical writing. Change-Id: I077f5a5f0711444086e56e4469dbcb3010ffe661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123682 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-10-21ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: I7e8a0824ec5dba8d2c97b0963704f228f1956e49 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-21ofz#40166 fix build failureCaolán McNamara
Change-Id: I18d7993e508763edeb428b583783584afc295efb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123953 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-20vcl: test OutputDevice::DrawGradient()Chris Sherlock
Change-Id: Ica59cdc5f9164892e390143e86946a0bebde525c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122997 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-20vcl: move variable declarations closer to first use in DrawBitmapWallpaper()Chris Sherlock
Change-Id: I9ad0711480e9626298e643609eaeb2c9da377405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122978 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-20loplugin:indentation check for indent inside blockNoel Grandin
look for places where the statements inside a block are not indented Change-Id: I0cbfa7e0b6fb194b2aff6fa7e070fb907d70ca2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123885 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-10-20mtfdemo: Dump metaactions, fix problems with repaintHossein
* Now mtfdemo can dump metaactions as metadump.xml in the current folder if the -d option is added in the command line. For example: ./bin/run mtfdemo -d odk/examples/basic/forms_and_controls/burger.wmf * Previously, the demo had problems with display, and when a repaint was requested, the display was stopped. Now, each time a repaint is requeted, the metafile is read again, and the paint works fine. * Now mtfdemo supports relative path. Previously, file name had to be absolute to work. Change-Id: I01bcbd38be682a55021e787a60b4dc86f596083a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123574 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-10-20add suggested-action to some buttonsCaolán McNamara
Change-Id: Iacb477c17f1c8ac68b331705796e56b4c92292cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-19Related: tdf#145169 warn on overwrite from gtk "save as" for remote filesCaolán McNamara
Change-Id: Idb98cd13826b6a4bdcbeee4e91dc8678f148dbdc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123815 Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2021-10-19Resolves: tdf#136498 %PRODUCTNAME shown in tool tipsCaolán McNamara
Change-Id: Id9640f9b5f85a98a510307bc7debf51448c716e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123796 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-19Use MsLangId::getConfiguredSystemUILanguage()Eike Rathke
Change-Id: Ia9344c44a71be656a731ab8735dd8e959e520592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123789 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-10-18ofz: MemorySanitizer: use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic38cce29011d7cce80d84f98792c9f7147cd0dd6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123763 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-10-18vcl: test OutputDevice::DrawPolyPolygon()Chris Sherlock
Change-Id: I166f715489ecff3095ccfb485153629050bfca20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/122977 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-10-18sw: avoid popup window for the EmbeddedObject property of an UNO OLE objectMiklos Vajna
The old behavior was that in case loading the native data of the embedded object failed, then we presented a popup to the user, but we still returned a valid com.sun.star.comp.embed.OCommonEmbeddedObject. Given that the return valid is desired even in the error case, don't turn the error popup into an UNO exception, rather redirect the popup to SAL_WARN(). This is meant to be consistent with other UNO API functions that pass down an "is API" boolean to internal code to control if interactive behavior is allowed or not. One extreme would be to do this only for the EmbeddedObject property of frames, the other one would be to do this for more object types. Go with a middle ground for now, so all properties of Writer frame objects use this, but leave other object types unchanged. Change-Id: I655fcb3780e96cecc7ed3f01ded52948d013172e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123752 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-10-17WIN release SalPrinter's SalGraphics borrowed HDCJan-Marek Glogowski
Regression from commit d27187b158d7e3f92180b1f2ab79b048dc5318a5 ("vcl:use unique_ptr<SalWinGraphics> in WinSalPrinter"). Would need something like Rust's Borrowing semantics to prevent. Ideas on IRC to make this bug more unlikely were some extra HDC + SalGraphics struct to pass around or something like unique_ptr reference passing and moving the value into a local copy. For now just add some additional comments. Change-Id: I472ee9acb4a4c02177c27ecd1c1277dfc812cadf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123440 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-10-17Simplify vector initialization in vclJulien Nabet
Change-Id: I881627313221081f72f8421c91417e4c111cfd97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123708 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-10-16adapt to the change from tools::Long* to std::vector<tools::Long>*Tomoyuki Kubota
since d4dc6b5c Change-Id: Ic2104185aec40e01b81d3559c161d894a473d3a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/123631 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-08 14:25:03 +0000